| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-07-20 | |||
| 20:15:15 | sean-k-mooney | stephenfin: yes | |
| 20:16:17 | sean-k-mooney | you have adressed my nits in https://review.opendev.org/c/openstack/nova/+/784066/2 right | |
| 20:20:04 | sean-k-mooney | stephenfin: so ya the iisue i had are adressed in the followup so im ok with moving forward with the current patch and adressing those issue in the later patch | |
| 23:57:39 | opendevreview | Akihiro Motoki proposed openstack/nova master: DNM: Test tempest-full/slow jobs https://review.opendev.org/c/openstack/nova/+/801550 | |
| #openstack-nova - 2021-07-21 | |||
| 08:30:01 | bauzas | stephenfin: around ? I just discovered a new argument for a Opt definition that allows dynamic grouping https://docs.openstack.org/oslo.config/latest/reference/defining.html#dynamic-groups | |
| 08:30:11 | bauzas | but I lack of understand how this works | |
| 08:31:39 | bauzas | context is, we already dynamically register vgpu opts at startup but I want to add a deprecated group for mdevs | |
| 08:34:18 | bauzas | ah nevermind, saw your internal email about you being sick, hope you recover soon | |
| 09:03:52 | sean-k-mooney | bauzas: i think that just allows you to specify a static config option that holds the names of the dynmic groups | |
| 09:07:03 | sean-k-mooney | bauzas: https://opendev.org/openstack/oslo.config/src/branch/master/oslo_config/cfg.py#L1470 https://opendev.org/openstack/oslo.config/src/branch/master/oslo_config/_list_opts.py#L68 | |
| 09:14:16 | opendevreview | Sylvain Bauza proposed openstack/nova master: Rename vgpu options to mdev https://review.opendev.org/c/openstack/nova/+/801607 | |
| 09:15:46 | bauzas | sean-k-mooney: nevermind, I just found a way to have a deprecated group alias easily ^ | |
| 09:17:29 | opendevreview | Sylvain Bauza proposed openstack/nova master: Rename vgpu options to mdev https://review.opendev.org/c/openstack/nova/+/801607 | |
| 09:19:20 | sean-k-mooney | just using deprecated_name='enabled_vgpu_types', ya | |
| 09:19:30 | sean-k-mooney | at lest for the static part | |
| 09:19:43 | sean-k-mooney | ah | |
| 09:19:48 | sean-k-mooney | you are also adding deprecated_group='vgpu_%s' % mdev_type) | |
| 09:19:56 | sean-k-mooney | in the dynmaic option too | |
| 10:07:42 | gibi | could somebody (other than bauzas) hit https://review.opendev.org/c/openstack/placement/+/796595 to unblock the placement gate? | |
| 10:17:18 | lyarwood | gibi: done | |
| 10:17:25 | gibi | lyarwood: thanks! | |
| 10:17:39 | lyarwood | seems like an odd thing to test | |
| 10:17:53 | gibi | it is an intentional cannary | |
| 10:17:59 | lyarwood | kk | |
| 10:18:18 | gibi | there is no reason to have rc names in os-rc-lib that are not usable via the placement API | |
| 10:24:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump oslo.db to 10.0.0 https://review.opendev.org/c/openstack/nova/+/801610 | |
| 10:31:40 | sean-k-mooney | gibi: did the weekly job catch that | |
| 10:32:09 | sean-k-mooney | yep https://zuul.openstack.org/build/0e135bb912b240c8bc2aa96049727a1a | |
| 10:33:55 | gibi | sean-k-mooney: yes | |
| 10:34:05 | gibi | sean-k-mooney: but the patch was up before it caught :) | |
| 10:38:40 | sean-k-mooney | ya the periodic are just incase we dont have activ patches to placement in flight | |
| 10:39:08 | sean-k-mooney | but im gald that we have at leat one red result on it since it definetly show it will catch this now | |
| 10:40:05 | gibi | yepp, it is useful to have | |
| 11:52:56 | opendevreview | Merged openstack/placement master: Bump os-resource-classes requirements https://review.opendev.org/c/openstack/placement/+/796595 | |
| 14:56:21 | yonglihe | gibi，thanks your time reviewing the smartnic patches set, thats lots of work. | |
| 15:06:49 | gibi | yonglihe: hi! I know I should get back to the those as you responded | |
| 21:07:22 | NobodyCam | Good Afternoon Nova folks, crazy question is it safe to delete a stale record out of nova_api.build_requests, or is there a better safer way to clean records up in build_requests? | |
| 23:18:50 | melwitt | zzzeek: random question but I'm trying to maintain a single db transaction across several different method calls and I'm seeing my context.session drop/disappear when I call a method from a different module than I'm currently in. is that expected? | |
| 23:19:48 | melwitt | that is, inside the method in the different module, my context.session is gone even though context is passed in | |
| 23:55:46 | melwitt | zzzeek: nevermind, ignore me. I made a mistake in the thing I was testing /o\ | |
| #openstack-nova - 2021-07-22 | |||
| 01:34:31 | opendevreview | melanie witt proposed openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170 | |
| 01:34:38 | opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | |
| 01:34:42 | opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | |
| 01:40:41 | melwitt | gibi: finally I have an update for consumer types https://review.opendev.org/c/openstack/placement/+/679441 sorry for the long delay | |
| 07:15:34 | opendevreview | Merged openstack/nova-specs master: Move placement specs to placement repo https://review.opendev.org/c/openstack/nova-specs/+/800775 | |
| 07:20:21 | gibi | melwitt: OK, I've added it to my queue | |
| 07:21:59 | gibi | melwitt: I have the RP re-parenting patch ready too https://review.opendev.org/c/openstack/placement/+/784020 | |
| 07:22:05 | gibi | if you have time | |
| 08:10:57 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | |
| 09:12:57 | stephenfin | lyarwood: Could you review a few outstanding docs changes for me today? https://review.opendev.org/c/openstack/nova/+/782410/1 | |
| 09:13:12 | lyarwood | stephenfin: sure thing | |
| 09:13:29 | stephenfin | Thanks. I addressed your comments in that one specifically too, gibi ^ | |
| 09:13:48 | gibi | stephenfin: ack | |
| 09:19:38 | stephenfin | bauzas: In case you didn't see it, I addressed your issues on https://review.opendev.org/c/openstack/nova/+/798145 with a follow-up https://review.opendev.org/c/openstack/nova/+/801523 | |
| 09:19:50 | bauzas | stephenfin: ok, will look | |
| 09:19:54 | bauzas | and thanks | |
| 09:25:40 | opendevreview | Sylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | |
| 09:26:04 | lyarwood | https://github.com/openstack/nova/blob/3545356ae3a719442833cb8c3c911408d4bd3c15/nova/conductor/manager.py#L166-L184 - This is likely a stupid idea but why aren't we logging anything here as breadcrumbs for RPC timeouts etc? | |
| 09:26:26 | lyarwood | Have an example downstream of a bdm.save() timing out on the compute and I've got no way of seeing what n-cond was doing AFAICT | |
| 09:28:17 | lyarwood | I guess any breadcrumbs need to land in the actual object methods being exercised | |
| 09:29:34 | sean-k-mooney | ya i dont know really | |
| 09:29:45 | sean-k-mooney | i guess one question would be where | |
| 09:30:03 | sean-k-mooney | as in in what log would they end up | |
| 09:30:16 | sean-k-mooney | the api/conductor wont know where it actuly got too | |
| 09:30:59 | lyarwood | it should end up in n-cond right? | |
| 09:31:47 | lyarwood | almost need a TRACE log level below DEBUG for stuff like this | |
| 09:34:37 | gibi | stephenfin: what should I do to enable ':oslo.config:option:' directive in the api-guide doc build? I've added 'oslo_config.sphinxext' extension to the config but it fails with https://paste.opendev.org/show/807644/ | |
| 09:40:43 | lyarwood | nvm another n-cond log is full of `Too many heartbeats missed` errors from oslo.msg | |
| 10:10:51 | lyarwood | really wish gerrit had a `move the unified diff to the middle of your giant ass screen` option | |
| 10:12:50 | stephenfin | gibi: You'd need to render the config options somewhere like we do here https://raw.githubusercontent.com/openstack/nova/master/doc/source/configuration/config.rst | |
| 10:13:02 | stephenfin | (the '.. show-options::' directive) | |
| 10:13:36 | stephenfin | which we probably don't want to do. We could build something that relies on intersphinx to link back to the main docs but that doesn't exist yet | |
| 10:43:33 | opendevreview | Stephen Finucane proposed openstack/nova master: neutron: Remove references to dead 'qos-queue' extension https://review.opendev.org/c/openstack/nova/+/754448 | |
| 10:44:43 | stephenfin | gibi: turns out that extension was used by the VMWare NSX neutron plugin, but they dropped it about two years ago. Have updated the commit message to state as much ^ | |
| 11:35:35 | sean-k-mooney | stephenfin: nice find | |
| 11:36:39 | sean-k-mooney | stephenfin: im kind of surpised we have any third party exstions reference in nova | |
| 11:37:06 | sean-k-mooney | at least on the common code. i would have expect those constance to live in teh vmware dirver | |
| 11:37:43 | sean-k-mooney | do we know if vnic-index is used still | |
| 11:44:37 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Final cleanups https://review.opendev.org/c/openstack/nova/+/800484 | |
| 11:45:03 | stephenfin | sean-k-mooney: vnic-index? | |
| 11:45:22 | stephenfin | oh, wait, yeah | |
| 11:45:28 | stephenfin | hmm, probably not actually | |
| 11:45:33 | gibi | stephenfin: re sphinx: OK, then I stop fighting with sphinx :) | |
| 11:46:13 | stephenfin | sean-k-mooney: actually no, it's still there https://opendev.org/x/vmware-nsx/src/branch/master/vmware_nsx/extensions/vnicindex.py | |
| 11:46:30 | stephenfin | whether it actually works is a different thing of course | |
| 11:47:56 | gibi | stephenfin: I'm +2 on the QoS extension removal | |
| 11:48:06 | stephenfin | hurrah | |
| 11:48:13 | stephenfin | thanks gibi++ | |
| 11:48:57 | gibi | stephenfin: I'm fixing your comments in the pps series I hope I can push it today | |
| 11:49:19 | gibi | moving around the func test was a nice exercise :) | |
| 11:50:19 | stephenfin | yeah, it felt like the right thing to do | |
| 11:51:05 | gibi | yepp, it is much better now. and pycharm is glad not to reparse the whole test_servers.py when I edit something in the func tests | |
| 11:51:29 | stephenfin | fair to say that 5kloc+ files are a thing best avoided where possible. 5kloc+ *test* files are 100% worth avoiding :) | |
| 11:51:32 | stephenfin | \o/ | |
| 11:52:32 | gibi | I hope not just me but jetbrains using the nova codebase to performance test pycharm :D | |
| 11:53:05 | stephenfin | there a few projects that could benefit from using nova as a test bed | |
| 11:53:17 | gibi | :D | |
| 11:53:35 | stephenfin | gitea for one | |
| 11:54:06 | gibi | we should promote that as a goal of nova :D being big and complicated python codebase for "you" to test your python tooling on | |
| 11:54:09 | stephenfin | don't know if you clicked through the links on the nsx-mh removal patch but it basically crashed my browser | |