| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-29 | |||
| 16:49:07 | gibi | #endmeeting | |
| 16:49:11 | elodilles | o/ | |
| 16:49:21 | gibi | feel free to continue the video mode discussion | |
| 16:49:30 | gibi | I will drop now but will read back tomorrow | |
| 16:49:42 | sean-k-mooney | well quickly the live migration issue https://review.opendev.org/c/openstack/nova/+/742180 should have fixed that | |
| 16:50:03 | sean-k-mooney | this is what previously broke live migration without binding-extended | |
| 16:50:32 | sean-k-mooney | but that is still fully supported so droping binding-extended form ml2/ovn shoudl not result in job failures | |
| 16:50:45 | sean-k-mooney | unless we are talking about cross-cell migration | |
| 16:50:51 | kashyap | Thanks for running it, gibi. | |
| 16:50:54 | sean-k-mooney | *cross-cell resize | |
| 16:51:57 | dansmith | sean-k-mooney: so, looking at the build process, it surely seems like the libvirt driver could just look at vm_state==BUILDING in spawn and annotate the desired default going forward | |
| 16:52:05 | dansmith | doesn't seem overly complicated to me | |
| 16:52:16 | dansmith | unless I'm missing elsewhere that we might be building but not want to do that | |
| 16:52:24 | sean-k-mooney | dansmith: ya i was thinking about that later in the meeting | |
| 16:52:40 | sean-k-mooney | i think your right we can detech inital spwan | |
| 16:53:14 | dansmith | yeah, so IMHO that'd be the way to go | |
| 16:53:54 | sean-k-mooney | dansmith: the quistion that i have is wether we can detect it in a place that is within the virt driver that also has the required info | |
| 16:54:15 | opendevreview | Rodrigo Barbieri proposed openstack/nova stable/train: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/798717 | |
| 16:54:17 | sean-k-mooney | i dont belive it will still be in building when we are generating the xml | |
| 16:54:23 | dansmith | well, it's set to building right before we get our spawn called | |
| 16:54:55 | sean-k-mooney | yes but we might need to pass down a flag internally in the driver | |
| 16:54:59 | dansmith | sean-k-mooney: we don't need to detect it while building the xml do we? we can go ahead and annotate the instance right in spawn() so it's there later for the xml building no? | |
| 16:55:22 | sean-k-mooney | dansmith: the default depens on the image and flavor and config values | |
| 16:55:23 | dansmith | if instance.vm_state == building: instance.system_metadata['image_hw_whatever'] = $default; instance.save() | |
| 16:55:35 | dansmith | sean-k-mooney: it does? | |
| 16:55:35 | sean-k-mooney | dansmith: e.g. if different based on architrues and a few other things | |
| 16:55:42 | dansmith | oh sure, okay | |
| 16:55:53 | dansmith | but still, I think you have all that in spawn I would guess | |
| 16:56:16 | sean-k-mooney | yes proably let me check quickly | |
| 16:56:30 | dansmith | yeah we actually build the xml right in spawn, | |
| 16:56:53 | dansmith | so I think we should be fine, even if you want to pass a flag to get_guest_xml() from there instead of having it look or something | |
| 16:57:05 | sean-k-mooney | its basically decided here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5912-L5951 | |
| 16:57:14 | sean-k-mooney | in _add_video_driver | |
| 16:57:55 | dansmith | sure, so we could break out the "which video" part from the actual xml bit and just call it to get the model name we need to use separate from the xml part | |
| 16:58:20 | sean-k-mooney | yep or just call that directly | |
| 16:58:38 | dansmith | it returns an xml node or something doesn't it? | |
| 16:58:39 | sean-k-mooney | but ok | |
| 16:58:51 | dansmith | anyway, regardless.. I think it's not hard | |
| 16:58:54 | sean-k-mooney | yes well it returns one of our config objects | |
| 16:59:37 | sean-k-mooney | LibvirtConfigGuestVideo i think https://github.com/openstack/nova/blob/25e218484990b41485973fab86adf5afc21dd476/nova/virt/libvirt/config.py#L2052 | |
| 17:00:05 | dansmith | yeah | |
| 17:00:09 | sean-k-mooney | so we can jsut get the type filed value if we need too | |
| 17:00:20 | sean-k-mooney | so as a general pattern you would advise | |
| 17:00:43 | sean-k-mooney | update the default on new instance creation and recored in instance_system_metadata | |
| 17:00:53 | sean-k-mooney | and then just use that value in all other spawn cases | |
| 17:01:20 | dansmith | yup | |
| 17:01:50 | sean-k-mooney | in this case though virtio will work in all configuration i belive | |
| 17:02:02 | sean-k-mooney | so we really just need to check if tis build and if tis set in the image | |
| 17:02:10 | sean-k-mooney | if not set it in the image metada copy we have | |
| 17:03:59 | dansmith | well, I'd really say we should avoid breaking sensitive windows vms by changing anything much | |
| 17:04:03 | sean-k-mooney | so basiclly image_meta.properties.set('hw_video_model', image_meta.properties.get('hw_video_model')) | |
| 17:04:26 | sean-k-mooney | * image_meta.properties.set('hw_video_model', image_meta.properties.get('hw_video_model', 'virtio')) | |
| 17:04:53 | dansmith | https://www.howson.pro/content/images/2016/07/sound-popped-up-after-fi.png | |
| 17:04:57 | dansmith | don't want that on your cloud instance :P | |
| 17:05:23 | sean-k-mooney | hehe no that would be awkward | |
| 17:06:00 | sean-k-mooney | i mean you can attach a cinder volume as a driver disk but it sucks | |
| 17:06:56 | dansmith | let us not go there :) | |
| 17:08:03 | sean-k-mooney | you can kind of do that today actully but its really inovlved and convulted | |
| 17:09:11 | dansmith | lol | |
| 17:10:16 | sean-k-mooney | dansmith: so 1.) set new default in image metata copy on new spawn. 2.) keep current logic in driver which will use the image vaule preferencally if set. 3.) recored value if not in image after its calulated for exising instance? | |
| 17:10:38 | sean-k-mooney | 3.) would only run once per instance the first time they hard reboot | |
| 17:11:12 | sean-k-mooney | and after that it just uses what in the insance_system_metadata | |
| 17:11:45 | sean-k-mooney | then rise and repeat taht for any default we want to change like this in the future | |
| 17:12:11 | sean-k-mooney | is that about right ^ if so it would be nice to add to the contibutors docs | |
| 17:12:41 | sean-k-mooney | i can proably submit a patch for that | |
| 17:13:11 | dansmith | well, I was going to say just always assume cirrus if it's not set | |
| 17:13:31 | dansmith | instead of "fixing" all the existing instances, but either works, as long as we assume cirrus if not set there | |
| 17:13:48 | sean-k-mooney | well assume exsiting behavior | |
| 17:13:55 | sean-k-mooney | which will be cirrus on x86 | |
| 17:14:04 | opendevreview | Merged openstack/nova master: Add test coverage for API version headers in CORS https://review.opendev.org/c/openstack/nova/+/796580 | |
| 17:14:17 | sean-k-mooney | its vga on power and virtio on arm | |
| 17:14:25 | dansmith | yeah | |
| 17:14:57 | opendevreview | Merged openstack/nova master: Fix typos in minimum version policy docs https://review.opendev.org/c/openstack/nova/+/795575 | |
| 17:15:30 | sean-k-mooney | kashyap: does ^ work/make sense to you | |
| 17:15:49 | opendevreview | Merged openstack/nova master: Make test_refresh_associations_* deterministic https://review.opendev.org/c/openstack/nova/+/794396 | |
| 17:16:49 | sean-k-mooney | dansmith: we may have other default like this we want to change but i cant rememebr them at present which is why i want to document the workflow for this type of change | |
| 17:16:58 | dansmith | ack | |
| 17:49:40 | opendevreview | Merged openstack/nova master: Remove PROJECT_ADMIN limitation from zero-disk and external-network policy https://review.opendev.org/c/openstack/nova/+/794360 | |
| 17:50:23 | opendevreview | Merged openstack/nova master: Improve policy doc for supported scope info https://review.opendev.org/c/openstack/nova/+/762013 | |
| 20:57:23 | slaweq | Hi nova-stable-cores, can You check https://review.opendev.org/c/openstack/nova/+/787253? Thx in advance | |
| #openstack-nova - 2021-06-30 | |||
| 01:32:02 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 01:32:02 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 01:32:03 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - create arqs https://review.opendev.org/c/openstack/nova/+/758944 | |
| 01:32:04 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | |
| 01:32:04 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | |
| 01:32:06 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 01:32:06 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 07:37:38 | ralonsoh | sean-k-mooney, hi good morning! Just a heads-up: the idea for OVN (and OVS because is the same VIF type) has been approved. Well, at least the RFE. Now I need to push a spec. | |
| 07:37:47 | ralonsoh | but the idea was understood and accepted | |
| 07:38:32 | ralonsoh | context (for anyone else): https://bugs.launchpad.net/neutron/+bug/1933517 | |
| 07:54:33 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 07:54:34 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 07:54:36 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - create arqs https://review.opendev.org/c/openstack/nova/+/758944 | |
| 07:54:37 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | |
| 07:54:37 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - build instance with smartnic arqs https://review.opendev.org/c/openstack/nova/+/798249 | |
| 07:54:38 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 07:54:39 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 08:43:48 | yonglihe | Hi gibi, alex had finished the core logic review and +2 already. I split original 3rd patch to 3 one, that make review easier. Seems lots of review work, thanks. | |
| 10:56:05 | kashyap | sean-k-mooney: I'll read back the discussion and respond. | |
| 10:58:26 | sean-k-mooney | kashyap: tl;dr dansmith proposed a way that shoudl allow you to do the change of default this cycle by not changing the default in the code that currently sets it and instead populating the image metadata copy we have with the new default if its an intial boot | |