| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-15 | |||
| 16:14:48 | gibi | other branches should be OK | |
| 16:14:52 | gibi | stable/ocata will be EOL'd -- nova patch: https://review.opendev.org/c/openstack/releases/+/795664 | |
| 16:14:55 | gibi | EOM | |
| 16:14:59 | gibi | thanks elodilles for the summary | |
| 16:15:09 | elodilles | np | |
| 16:15:20 | gibi | anything else on stable? | |
| 16:15:23 | tosky | gibi: about that first patch, I think it's a bit more complicated, melwitt created a squashed patch with more changes | |
| 16:15:29 | tosky | but it's failing too | |
| 16:15:55 | melwitt | yeah elodilles has added a comment wrt the fail | |
| 16:16:08 | elodilles | yes, I've just commented on it as it is failing on the post tasks | |
| 16:16:22 | elodilles | :] | |
| 16:16:36 | melwitt | and yes it's a megasquash. I defer to elodilles as to how the commit message should be bc I don't know :) | |
| 16:17:04 | tosky | this one: https://review.opendev.org/c/openstack/nova/+/795432/2 (which should probably get a better combined subject) | |
| 16:17:35 | lyarwood | I missed our reasoning for doing this but as it's mostly my work I'll try to take a look before I leave today | |
| 16:17:43 | tosky | or you can preserve https://review.opendev.org/c/openstack/nova/+/794675 as it is, but set nova-live-migration as non-voting, and re-enable it in a subsequent commit | |
| 16:18:08 | tosky | which would reduce the diff and avoid a supermegasquash | |
| 16:18:23 | gibi | lyarwood: thanks | |
| 16:18:27 | melwitt | lyarwood: tl;dr is tosky recommended we backport the native zuul v3 patches instead of fixing legacy versions | |
| 16:19:05 | melwitt | so I tried to do it. it worked ok until ussuri | |
| 16:19:17 | lyarwood | ack understood | |
| 16:19:37 | tosky | it's mostly working in fact: https://review.opendev.org/c/openstack/nova/+/795432/ shows that the backported change works, but something else fails | |
| 16:19:55 | melwitt | so feel free to take another approach if it's too messy | |
| 16:20:24 | elodilles | maybe just that post task should be fixed (to avoid the supermegasquash :)) | |
| 16:20:40 | elodilles | I mean... if that is possible... | |
| 16:20:50 | elodilles | without the supermegasquash | |
| 16:21:11 | lyarwood | yeah it's possible | |
| 16:21:26 | elodilles | \o/ | |
| 16:21:27 | lyarwood | it's just because this was written against focal but the nodes here are bionic AFAICT | |
| 16:21:44 | sean-k-mooney | on ussuri? | |
| 16:21:45 | elodilles | yes, it's bionic | |
| 16:21:46 | gmann | yeah ussuri is on bionic | |
| 16:21:55 | sean-k-mooney | really ok i thought that was focal | |
| 16:22:04 | gmann | from victoria we moved to focal | |
| 16:22:07 | sean-k-mooney | hopefully that wont be hard to fix then | |
| 16:22:35 | sean-k-mooney | Could not find the requested service libvirtd-ro.socket: host | |
| 16:22:43 | sean-k-mooney | ok so likely hte service names are different | |
| 16:22:59 | sean-k-mooney | both that should be a quick fix | |
| 16:23:14 | gibi | OK I think we generated ideas about the way forwards | |
| 16:23:23 | gibi | anything else about stable? | |
| 16:23:38 | elodilles | nothing from me | |
| 16:24:29 | gibi | OK moving on | |
| 16:24:44 | gibi | skipping the libvirt subteam topic as bauzas is absent, but he said nothing to report | |
| 16:24:50 | gibi | #topic Open discussion | |
| 16:24:57 | gibi | there is one item on the agenda | |
| 16:25:04 | gibi | (yonglihe)smartnic support need one extra core reviewer , we have alex now, anyone else could help? thanks : https://review.opendev.org/c/openstack/nova/+/779913 (yongli could not attending due to time slot...) | |
| 16:25:58 | gibi | looking at the patches I think alex_xu haven't reviewed them | |
| 16:26:18 | gibi | or at least not recently | |
| 16:26:50 | gibi | as I reviewed these in the past I can be the second core | |
| 16:27:05 | gibi | but I will wait for Alex to to the first rounds | |
| 16:27:50 | gibi | any comment? | |
| 16:28:38 | sean-k-mooney | i can proably take another look at that although i kind of wanted | |
| 16:28:48 | sean-k-mooney | someone else who can review the code to be on board with it | |
| 16:28:58 | sean-k-mooney | oh that the implemtion not the spec | |
| 16:29:06 | gibi | yep the spec is approved | |
| 16:30:24 | sean-k-mooney | well i can try and review the code i guess but maybe stephenfin or bauzas could take a look? | |
| 16:30:59 | stephenfin | I can give it a shot | |
| 16:31:18 | gibi | OK thanks I think this is more than enough :) | |
| 16:31:25 | gibi | any other topic for today? | |
| 16:32:23 | stephenfin | oh, one | |
| 16:32:28 | stephenfin | specless BP approval | |
| 16:32:31 | stephenfin | for https://blueprints.launchpad.net/nova/+spec/remove-sqlalchemy-migrate | |
| 16:32:40 | stephenfin | I thought I had done this before, but clearly not | |
| 16:32:53 | stephenfin | that's the spec to track replacing sqlalchemy-migrate with alembic | |
| 16:33:18 | sean-k-mooney | you mean blueprint | |
| 16:33:22 | sean-k-mooney | or is there actully a spec | |
| 16:33:53 | stephenfin | sorry, blueprint, yeah | |
| 16:33:57 | sean-k-mooney | i assume you want to track it as a specless blueprint | |
| 16:34:00 | sean-k-mooney | ok | |
| 16:34:23 | opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795432 | |
| 16:34:49 | gibi | stephenfin: do you forsee any complication that might warrant a spec? | |
| 16:35:09 | stephenfin | not at the moment, no. It's very simple if tedious so far | |
| 16:35:28 | sean-k-mooney | in the ptg we said """create a contributor doc showing how a migration will look like after the change. Document how to backport a migration to stable""" and """figure out if alembic collapsing migrations can this cause timeouts for big migrations""" | |
| 16:35:34 | stephenfin | if I encounter something that I think warrants discussion, I'll happily write one then | |
| 16:35:44 | sean-k-mooney | did we we figure out the latter | |
| 16:36:06 | stephenfin | I haven't managed to rewrite all the migrations yet, so no | |
| 16:36:19 | sean-k-mooney | i think that was the only concern we had e.g. how does it scale | |
| 16:36:25 | sean-k-mooney | ok | |
| 16:36:43 | opendevreview | Lee Yarwood proposed openstack/nova master: gate: Remove test_evacuate.sh https://review.opendev.org/c/openstack/nova/+/796523 | |
| 16:36:46 | stephenfin | though neutron's use of this suggests we'll be fine (famous last words :)) | |
| 16:36:47 | sean-k-mooney | i suspect as well as what we currently use or at least well enough for neutron | |
| 16:36:53 | stephenfin | yup | |
| 16:37:18 | sean-k-mooney | i dont really have any open quetsion that woudl warrent a spec | |
| 16:37:31 | sean-k-mooney | provided you provide the contib doc as part of the series | |
| 16:38:12 | gibi | any objection against approving it as specless bp? | |
| 16:39:12 | gibi | then it is approved | |
| 16:39:19 | gibi | any other topic for today? | |
| 16:39:27 | stephenfin | hurrah | |
| 16:39:29 | stephenfin | not from me | |
| 16:40:15 | sean-k-mooney | am one | |
| 16:40:19 | gibi | any feedback on having the meeting on this channel? | |
| 16:40:29 | sean-k-mooney | gibi: when did you want to do the next spec review day | |
| 16:40:38 | dansmith | ++ on meeting in channel :) | |
| 16:40:39 | sean-k-mooney | gibi: and i think it worked ok | |
| 16:40:51 | gmann | ++ | |
| 16:40:57 | gibi | sean-k-mooney: 6th of July maybe? | |
| 16:41:24 | stephenfin | meeting in the channel seems sensible so far, yup | |
| 16:41:26 | sean-k-mooney | ya that gives a few days befor m2 on the 12th | |
| 16:41:27 | gibi | that is a bit more than a week before the freeze | |
| 16:41:29 | sean-k-mooney | so works for me | |
| 16:41:36 | stephenfin | as does that date | |