| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-08 | |||
| 15:15:10 | sean-k-mooney | we would be overloading on the number of keyword arguments | |
| 15:15:21 | sean-k-mooney | i cant remember if python allows that now or not | |
| 15:16:00 | kashyap | gibi: Afraid, I might not be able to stay for the full meeting - if it lasts longer than 15 min, as I need to run an errand around 18:30 CET... | |
| 15:16:33 | gibi | kashyap: then we will start with your topic | |
| 15:17:01 | kashyap | gibi: Thank you! :) | |
| 15:17:16 | kashyap | gibi: And BTW, I agree on moving the meeting to -nova | |
| 15:17:24 | gibi | kashyap: thanks for the input | |
| 15:31:20 | bauzas | gibi: others: for what it's worth, I'll be on PTO tomorrow | |
| 15:31:36 | gibi | bauzas: ack. | |
| 15:31:40 | gibi | bauzas: enjoy | |
| 15:31:56 | bauzas | thanks | |
| 15:46:36 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: testing https://review.opendev.org/c/openstack/nova/+/794863 | |
| 15:50:35 | gibi | nova meeting starts in 10 minutes in #openstack-meeting-3 | |
| 16:33:43 | opendevreview | Luigi Toscano proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | |
| 20:40:14 | opendevreview | Luigi Toscano proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | |
| 22:22:09 | opendevreview | Merged openstack/nova master: Remove references to 'instance_type' https://review.opendev.org/c/openstack/nova/+/778546 | |
| 23:21:37 | opendevreview | Merged openstack/nova stable/victoria: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794674 | |
| 23:32:24 | opendevreview | melanie witt proposed openstack/nova stable/victoria: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787252 | |
| 23:34:14 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Initialize global data separately and run_once in WSGI app init https://review.opendev.org/c/openstack/nova/+/785059 | |
| #openstack-nova - 2021-06-09 | |||
| 00:23:58 | opendevreview | Merged openstack/nova master: Remove unnecessary mocks from unit test https://review.opendev.org/c/openstack/nova/+/794637 | |
| 00:24:37 | opendevreview | Merged openstack/nova master: docs: Address TODO https://review.opendev.org/c/openstack/nova/+/792363 | |
| 00:54:37 | opendevreview | Merged openstack/nova master: Create a fixture around fake_notifier https://review.opendev.org/c/openstack/nova/+/758446 | |
| 00:55:10 | opendevreview | Merged openstack/nova master: Use NotificationFixture for legacy notifications too https://review.opendev.org/c/openstack/nova/+/758448 | |
| 01:20:20 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794675 | |
| 01:20:21 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795432 | |
| 01:20:22 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/795433 | |
| 01:22:12 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | |
| 01:35:24 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794686 | |
| 01:35:25 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795435 | |
| 01:35:26 | opendevreview | melanie witt proposed openstack/nova stable/train: zuul: Replace nova-live-migration with zuulv3 jobs https://review.opendev.org/c/openstack/nova/+/795436 | |
| 06:06:14 | opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 06:06:15 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 06:06:16 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | |
| 06:06:16 | opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 06:06:17 | opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | |
| 07:02:20 | gibi | lyarwood: hi! Please file a bp for https://review.opendev.org/c/openstack/nova-specs/+/794799 then I will +2 | |
| 07:17:43 | opendevreview | Merged openstack/nova-specs master: Re-propose Unified Limits in Nova https://review.opendev.org/c/openstack/nova-specs/+/789585 | |
| 07:19:30 | opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | |
| 07:35:27 | lyarwood | gibi: yup will do shortly | |
| 07:40:47 | gibi | thanks | |
| 07:45:09 | lyarwood | I shouldn't say shortly, I'm currently stuck in standing traffic after the school run. \o/ | |
| 07:49:05 | gibi | lyarwood: ohh. no worries. | |
| 07:49:30 | gibi | bauzas: I left a suggestion in the mdev spec https://review.opendev.org/c/openstack/nova-specs/+/792796 about trait support. | |
| 07:49:38 | gibi | (I know bauzas is on PTO) | |
| 08:00:42 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: Fix the bp link in the cyborg admin token spec https://review.opendev.org/c/openstack/nova-specs/+/795493 | |
| 08:21:10 | opendevreview | Wenping Song proposed openstack/nova stable/train: Change get console auth token policy to RULE_ADMIN_OR_OWNER https://review.opendev.org/c/openstack/nova/+/795496 | |
| 09:24:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: [DNM]Test with sqla 1.4 and try to tease out slow tests https://review.opendev.org/c/openstack/nova/+/795506 | |
| 09:45:41 | stephenfin | gibi++ Thanks for the review on the RPC 6.0 cleanup series. Delighted to not have to rebase that again :-D | |
| 09:49:47 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API https://review.opendev.org/c/openstack/nova-specs/+/794799 | |
| 09:54:51 | lyarwood | gibi: would you mind hitting https://review.opendev.org/c/openstack/nova/+/794639 and https://review.opendev.org/c/openstack/nova/+/793463 if you have time today please? | |
| 09:54:59 | lyarwood | happy to help with any reviews in return | |
| 09:55:42 | gibi | lyarwood: queued them up | |
| 09:55:59 | lyarwood | many thanks | |
| 10:02:46 | opendevreview | Luigi Toscano proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | |
| 10:08:46 | sean-k-mooney | this is not something we can do right https://review.opendev.org/c/openstack/nova/+/795496 | |
| 10:10:05 | sean-k-mooney | am is gerrit broken? | |
| 10:12:55 | gibi | sean-k-mooney: I agree that patch seems strange | |
| 10:13:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: [DNM]Test with sqla 1.4 and try to tease out slow tests https://review.opendev.org/c/openstack/nova/+/795506 | |
| 10:13:19 | gibi | at least is needs a lot of arguing in the commit message why the author wants this | |
| 10:14:15 | sean-k-mooney | gibi: well ideally if they did want this it would be done on master first not on stable/train | |
| 10:14:24 | gibi | sean-k-mooney: yes. | |
| 10:14:26 | sean-k-mooney | with either a bug or blueprint | |
| 10:14:35 | gibi | sean-k-mooney: and zuul will also vote -1 as it is not a backport | |
| 10:14:53 | gibi | so we have automatic rejection for such cahnges | |
| 10:14:55 | sean-k-mooney | what this is doing is allowing you to look up the connection details if you happen to fined a token | |
| 10:14:55 | gibi | changes | |
| 10:15:44 | sean-k-mooney | gibi: beacuase of the pep8 cherry-pick check or something else | |
| 10:15:56 | sean-k-mooney | i was not aware of sometrhing that did that automatically | |
| 10:16:04 | gibi | sean-k-mooney: yepp | |
| 10:16:14 | gibi | sean-k-mooney: we have our own script | |
| 10:16:18 | gibi | sean-k-mooney: as part of pep8 | |
| 10:16:38 | gibi | https://github.com/openstack/nova/blob/master/tools/check-cherry-picks.sh | |
| 10:16:41 | sean-k-mooney | i tought the cherry pick script would only detect this if you had cherry-pick lines | |
| 10:16:48 | sean-k-mooney | i did not think it would run on this patch | |
| 10:17:04 | gibi | sean-k-mooney: it reject things that does not have cherry-pick lines and does not have [stable only] heading | |
| 10:17:51 | sean-k-mooney | ah echo 'Stable branch requires either cherry-pick -x headers or [stable-only] tag!' | |
| 10:17:58 | sean-k-mooney | ya | |
| 10:18:11 | sean-k-mooney | ok i did not think we had that last bit. neet | |
| 10:30:04 | swp20 | sean-k-mooney: recently, our client meet the problem that the instance's owner has no permission to get console auth token with T version. From U we have used new policy rule, so i propose this patch base on Train branch: https://review.opendev.org/c/openstack/nova/+/795496 | |
| 10:31:53 | sean-k-mooney | swp20: that cahnge does not allow them to get a console auth token | |
| 10:32:10 | sean-k-mooney | swp20: it allows them to use a token to get the connection info | |
| 10:32:57 | swp20 | we have tested this change works. | |
| 10:33:48 | sean-k-mooney | well you can do it in you policy.json without the code change but that is not what the rule is for | |
| 10:34:29 | sean-k-mooney | that is for https://docs.openstack.org/api-ref/compute/?expanded=show-console-connection-information-detail#show-console-connection-information | |
| 10:36:11 | lyarwood | sean-k-mooney: the host there is the compute host right? | |
| 10:37:10 | sean-k-mooney | i think its the proxy | |
| 10:37:21 | sean-k-mooney | but it could be | |
| 10:45:13 | swp20 | sean-k-mooney: how can i do in policy.json? does the instance's own donnot has the permission? | |
| 10:49:26 | sean-k-mooney | this is what i would have used in the past https://docs.openstack.org/api-ref/compute/?expanded=get-vnc-console-os-getvncconsole-action-deprecated-detail#get-vnc-console-os-getvncconsole-action-deprecated | |
| 10:49:42 | sean-k-mooney | that will give you the console url and the auth token | |
| 10:51:21 | sean-k-mooney | the newer way woudl be to use https://docs.openstack.org/api-ref/compute/?expanded=create-console-detail#create-console | |
| 10:53:08 | swp20 | this is no what we want. | |
| 10:53:57 | sean-k-mooney | swp20: to override the policy in policy.json you just do "rule name":["rules"] | |
| 10:54:43 | sean-k-mooney | swp20: it is what you said your customer wanted the creaqte api will return a new auth token/url for the server console | |
| 10:56:36 | swp20 | we have two platform A and B, A platform want use the console token to visit the instance on B platform, we need the host and port with the api https://docs.openstack.org/api-ref/compute/?expanded=show-console-connection-information-detail,create-console-detail#show-console-connection-information | |
| 10:57:17 | sean-k-mooney | swp20: why does A not just use the create api on b to get the url and token | |
| 10:57:25 | sean-k-mooney | swp20: is A unwaware of the server uuid | |
| 10:57:50 | swp20 | yes, A is unware of the server uuid. | |
| 10:58:52 | sean-k-mooney | i see well given the console_token is not intended to be used by normal users as a handel to identify a server im not conviced we should make that change in code | |
| 10:58:58 | swp20 | or A use no admin account. | |