| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-07 | |||
| 12:44:34 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/794639 | |
| 13:04:09 | opendevreview | John Garbutt proposed openstack/nova-specs master: Re-propose Unified Limits in Nova https://review.opendev.org/c/openstack/nova-specs/+/789585 | |
| 13:50:50 | opendevreview | John Garbutt proposed openstack/nova master: Add legacy limits and usage to unified limits https://review.opendev.org/c/openstack/nova/+/713498 | |
| 13:56:15 | lyarwood | gibi, bauzas ; can I get reviews on https://review.opendev.org/c/openstack/nova/+/794639 please? Trying to set SEV QE'd downstream and hit this roadblock | |
| 13:56:28 | bauzas | lyarwood: sure, I can take a look | |
| 13:56:55 | lyarwood | hmmm the LC job still isn't happy with something | |
| 13:57:42 | kashyap | LC? | |
| 13:58:13 | lyarwood | lower constraints | |
| 13:58:15 | kashyap | Maybe you mean "Live Migration Ceph" | |
| 13:58:35 | kashyap | Oh, right. The LM Ceph job is non-voting | |
| 13:58:55 | bauzas | lyarwood: I guess we don't have yet functional tests for SEV instances ? | |
| 13:59:19 | bauzas | lyarwood: I was wondering about a regression test but if not, fair. | |
| 14:00:48 | lyarwood | I can land some tests after this but backporting functional tests to stable/train is a royal PITA at the moment | |
| 14:01:08 | lyarwood | there's an actual issue with this that didn't come up in the unit tests btw | |
| 14:01:13 | lyarwood | but somehow the LC job caught it | |
| 14:02:01 | lyarwood | during a live migration we pass the _get_volume_config method around and end up calling it from nova.virt.libvirt.migration._update_volume_xml without access to the instance, borking the approach I've taken | |
| 14:02:15 | kashyap | bauzas: Also ... as you know, to meaningfully test SEV, you need real hardware | |
| 14:02:16 | lyarwood | I'll correct and respin now | |
| 14:02:32 | lyarwood | kashyap: well not functional, that's the entire point | |
| 14:02:45 | bauzas | lyarwood: yeah I wasn't asking about a functtest in the main change, sorry | |
| 14:02:55 | kashyap | lyarwood: Right; I realize. "Functional" in Nova still does some stubbing, right? | |
| 14:03:04 | bauzas | lyarwood: something like a separate patch we could use for verifying this works | |
| 14:03:34 | kashyap | lyarwood: Anyway...don't want to dissuade you from any tests you have in mind | |
| 14:03:35 | lyarwood | kashyap: yeah and here we are just asserting things about the XML we are providing libvirt | |
| 14:03:42 | bauzas | lyarwood: like we actually do for virtual GPUs for example | |
| 14:03:49 | kashyap | lyarwood: Yeah, for that part, it's fair enough | |
| 14:27:05 | opendevreview | John Garbutt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/c/openstack/nova/+/712142 | |
| 14:37:32 | opendevreview | John Garbutt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/c/openstack/nova/+/712143 | |
| 14:39:01 | opendevreview | John Garbutt proposed openstack/nova master: Update limit APIs https://review.opendev.org/c/openstack/nova/+/712707 | |
| 14:41:56 | opendevreview | John Garbutt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/c/openstack/nova/+/712749 | |
| 15:17:50 | artom | When was the last time we talked about preemptible instances? (Most recent) Denver? | |
| 15:18:05 | artom | Anyone remember the outcome? | |
| 15:26:53 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option https://review.opendev.org/c/openstack/nova/+/794796 | |
| 15:28:20 | kashyap | artom: Hey, completely unrelated: did I miss anything else to bump in the above? (I'm pinging you, as you did something similar for your "socket" (for PCI NUMA affinity) thingie) | |
| 15:28:38 | artom | kashyap, lemme check | |
| 15:29:50 | kashyap | artom: Hmm, okay ... this is the one failing test: http://paste.openstack.org/show/806427/. How do I update that hash? | |
| 15:30:02 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/794639 | |
| 15:30:30 | artom | kashyap, it's in nova/tests/unit/objects/test_objects.py - just grep for the old 'reference' hash, and change it to the new one | |
| 15:31:46 | kashyap | artom: Okay, a stupid question: where do I "discover" the new hash? | |
| 15:31:57 | artom | kashyap, you don't, the tests will tell you :) | |
| 15:32:08 | artom | At least that's what I always do. | |
| 15:32:15 | kashyap | Ah, right; it should catch it | |
| 15:32:34 | kashyap | artom: Okay, that's good. Lemme try | |
| 15:32:41 | artom | Any time I change objects, I try to remember to run test_objects, then update the hashes. | |
| 15:33:44 | kashyap | artom: You mean 'test_versions'? | |
| 15:33:51 | kashyap | But yeah, point noted... | |
| 15:35:11 | kashyap | artom: Thanks. | |
| 15:36:01 | artom | kashyap, well, test_versions in test_objects.py | |
| 15:37:18 | kashyap | Yep; yar. | |
| 15:38:27 | kashyap | Alright, that fixes it | |
| 15:42:16 | opendevreview | Kashyap Chamarthy proposed openstack/nova master: Allow 'bochs' as a display device option https://review.opendev.org/c/openstack/nova/+/794796 | |
| 15:52:02 | bauzas | artom: about preemptible instances, we said "go for it" | |
| 15:52:11 | bauzas | but not something in Nova | |
| 15:52:27 | bauzas | a specific other service, and it was maybe Blazar | |
| 15:52:40 | bauzas | priteau: do you remember when and where we said this ? | |
| 15:52:40 | artom | IIRC there was a thing called "Reaper"? | |
| 15:53:01 | bauzas | artom: correct, something done by john and the CERN IIRC | |
| 15:53:52 | bauzas | I remember this https://specs.openstack.org/openstack/blazar-specs/specs/ussuri/blazar-preemptible-instances.html | |
| 15:54:07 | priteau | bauzas: I think we mentioned the reaper in Blazar in Denver PTG (Sep 2018) | |
| 15:54:23 | opendevreview | Lee Yarwood proposed openstack/nova-specs master: Add attachmentId to responses of the os-volume_attachments API https://review.opendev.org/c/openstack/nova-specs/+/794799 | |
| 15:54:58 | kashyap | artom: When you can, please give your ack (or nack, if need be) again? I uploaded a rev right after you did. | |
| 15:55:17 | priteau | bauzas: but that was maybe before aardvark was completed | |
| 15:56:18 | lyarwood | https://review.opendev.org/c/openstack/nova/+/793463 should be ready for review if anyone has time btw | |
| 15:56:30 | bauzas | priteau: this one, right? https://gitlab.cern.ch/ttsiouts/aardvark | |
| 15:56:33 | bauzas | artom: ^ | |
| 15:56:38 | priteau | yep | |
| 15:58:07 | artom | Is https://gitlab.cern.ch/ttsiouts/aardvark the continuation of https://gitlab.cern.ch/ttsiouts/ReaperServicePrototype? | |
| 15:58:12 | artom | Also, both look fairly dead | |
| 16:10:29 | priteau | artom: I believe it the continuation, yes. Unfortunately ttsiouts has left CERN and I don't believe this work has been picked up by anyone else. | |
| 16:10:56 | priteau | Also I think there were some disagreement on the nova modifications required for this (pending state) | |
| 16:11:36 | artom | priteau, ack, thanks for the context! | |
| 16:11:42 | artom | priteau, are you with CERN, btw? | |
| 16:15:02 | priteau | I am not, but I work with John Garbutt at StackHPC who I think was involved in the discussions | |
| 16:16:23 | priteau | See https://review.opendev.org/q/owner:theodoros.tsioutsias%2540cern.ch+project:openstack/nova for the proposed changes | |
| 16:21:40 | artom | priteau, yep, I remember John being involved/interested | |
| 16:23:05 | artom | priteau, reason for all these questions is that we (Red Hat) have been asked to make preemptible instances a thing | |
| 16:23:38 | priteau | By customers? | |
| 16:23:52 | artom | priteau, yeah. I suspect the answer will be "no" because we don't have the manpower to essentially bootstrap a new project (Reaper, or whatever it ends up being called) by ourselves | |
| 16:24:12 | artom | But maybe, just maybe, if there's enough money on the line, and community drive, it can happen | |
| 16:24:18 | artom | An item for next PTG, perhaps | |
| 16:26:20 | priteau | Yeah that would be good | |
| 16:28:01 | priteau | I've proposed a spec for blazar to implement preemptibles, because in the context of using reservations it can be done without changes to nova | |
| 16:30:52 | priteau | That's the one linked by bauzas earlier: https://specs.openstack.org/openstack/blazar-specs/specs/ussuri/blazar-preemptible-instances.html | |
| 16:31:19 | artom | priteau, if that's the way it moves forward, RH would still have to productize Blazaar... | |
| 16:31:50 | artom | priteau, but good to know there would be no new code for us (RH) to write | |
| 16:31:53 | priteau | Yeah I am not saying this is a full solution for you ;) | |
| 16:32:11 | artom | Despite our millions, we're surprisingly people-strapped :P | |
| 16:32:30 | artom | Just getting Designate up and running was a more than year-long thing. | |
| 17:20:05 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/794639 | |
| 17:31:45 | opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Set driver_iommu when attaching virtio devices to SEV instance https://review.opendev.org/c/openstack/nova/+/794639 | |
| 17:42:35 | opendevreview | Merged openstack/nova stable/wallaby: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/794345 | |
| 17:57:34 | opendevreview | Ade Lee proposed openstack/nova master: Add check job for FIPS https://review.opendev.org/c/openstack/nova/+/790519 | |
| 20:17:16 | opendevreview | melanie witt proposed openstack/nova stable/victoria: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/795175 | |
| 20:19:39 | opendevreview | melanie witt proposed openstack/nova stable/ussuri: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/795176 | |
| 20:21:05 | opendevreview | melanie witt proposed openstack/nova stable/train: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/795177 | |
| 20:25:20 | melwitt | dansmith: if you fancy unblocking the stable/victoria gate https://review.opendev.org/c/openstack/nova/+/794674 | |
| 20:43:57 | opendevreview | Vlad Gusev proposed openstack/nova stable/stein: Honor [neutron]http_retries in the manual client https://review.opendev.org/c/openstack/nova/+/795138 | |
| 21:07:23 | dansmith | melwitt: and what if I like it broken? | |
| 21:08:12 | melwitt | dansmith: then you get the angry eyebrows >:| | |
| 21:08:32 | dansmith | ...which are more scary than a blocked gate, so... okay | |