| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-06-01 | |||
| 13:21:14 | sean-k-mooney | ganso: this is a feature that would require a spec and someone more expert in the strage layware like lyarwood to review | |
| 13:22:32 | sean-k-mooney | ganso: the failure could actully be handeled internally in the driver just roleing back and rejecting the attach but we would have to code with that in mind and think about the ux and error message we give to a user | |
| 13:23:05 | sean-k-mooney | whihc is one of the reason i think this woudl need a spec rather then trateing it as a bugfix | |
| 13:24:10 | ganso | sean-k-mooney: yea, just like the hotplugged error message for IDE devices, I was confused at first when the attach didn't work while the request was accepted, but I had no obvious error message | |
| 13:24:20 | sean-k-mooney | ganso: the driver code in general assumes there is only one value for hw_disk_bus for the entire vm so thre are proably edgcases like rescue and move operations that might break. | |
| 13:24:21 | ganso | sean-k-mooney: I agree! +1 | |
| 13:30:10 | ganso | sean-k-mooney: btw, if you have a minute, that patch you previously reviewed already has a +2. I was wondering if you could please take another look at it when you have a minute, since you're already familiar with it: https://review.opendev.org/c/openstack/nova/+/784166 | |
| 13:36:11 | sean-k-mooney | ah yes am i do not have +2 rights on nova but ill take a look now and maybe poke some of the nova cores to review when im done | |
| 13:49:14 | opendevreview | Merged openstack/nova master: Add unit test for importing ed25519 ssh key https://review.opendev.org/c/openstack/nova/+/789642 | |
| 13:50:12 | opendevreview | Merged openstack/nova master: Change minversion of tox to 3.18.0 https://review.opendev.org/c/openstack/nova/+/791968 | |
| 13:51:11 | sean-k-mooney | bauzas: you like anit-afintiy groups right :P care to review ganso's patch https://review.opendev.org/c/openstack/nova/+/784166 | |
| 13:51:53 | opendevreview | Merged openstack/nova master: Remove unused DeleteFromSelect db api method https://review.opendev.org/c/openstack/nova/+/784528 | |
| 13:52:14 | bauzas | sean-k-mooney: not sure it's correct to say "I like" for the instance groups but sure ;) | |
| 13:52:50 | sean-k-mooney | hehe that was ment to be drowning in sarcasim but i for got to anotate that :) | |
| 13:56:27 | sean-k-mooney | do we have quota for how may revision of a patch you are allow to have without unit tests passing... | |
| 13:57:28 | sean-k-mooney | i fell like if we did its less then 51 in 6 weeks | |
| 14:01:00 | bauzas | ganso: I provided another +2 but please look at my comment in https://review.opendev.org/c/openstack/nova/+/784166 | |
| 14:01:49 | bauzas | once you look at it, tell me and then I'll +W your change | |
| 14:02:30 | sean-k-mooney | bauzas: yes adding an explaintion would be nice to avoid the tribal knoladge that live migration never reschdules | |
| 14:02:44 | bauzas | can be a follow-ip | |
| 14:02:46 | bauzas | up* | |
| 14:03:09 | sean-k-mooney | also yes i agree it can be a followup | |
| 14:03:19 | bauzas | ganso: do you want to backport your change, actually ? | |
| 14:03:38 | bauzas | if so, maybe we would need to have a new revision for the relnote | |
| 14:03:54 | sean-k-mooney | we can backport the followup too | |
| 14:04:01 | sean-k-mooney | just and fyi | |
| 14:04:03 | bauzas | or squashing both when backporting but... | |
| 14:04:05 | sean-k-mooney | reno is ok with that | |
| 14:04:13 | sean-k-mooney | no need to squash | |
| 14:04:30 | sean-k-mooney | we could but you can edit renos after the fact | |
| 14:04:41 | bauzas | sure, but I don't like to have two patches when backporting when one of them is just a FUP | |
| 14:04:49 | sean-k-mooney | fair | |
| 14:05:23 | bauzas | either way, wanting ganso to reply... | |
| 14:05:31 | ganso | reading scrollback now | |
| 14:07:20 | ganso | sean-k-mooney: loved the term tribal knowledge! didnt know it! will now use it for many things lol! | |
| 14:07:30 | ganso | bauzas: yes, I plan to backport. Will look at the patch now | |
| 14:08:02 | bauzas | ganso: okay, then please provide a new PS and I'll directly +2/+W | |
| 14:08:13 | opendevreview | Balazs Gibizer proposed openstack/placement master: [doc] Redirect people to #openstack-nova https://review.opendev.org/c/openstack/placement/+/793832 | |
| 14:08:58 | ganso | bauzas: great! will work on that now! thank you! | |
| 14:09:12 | bauzas | ganso: ping me when you're done | |
| 14:13:38 | gibi | bauzas, sean-k-mooney, melwitt: when you have time please check back to the placement re-parenting spec. https://review.opendev.org/c/openstack/nova-specs/+/788243 | |
| 14:13:47 | gibi | thanks | |
| 14:13:50 | bauzas | gibi: sure thing | |
| 14:15:06 | gibi | :) | |
| 14:19:32 | sean-k-mooney | gibi: yes its on my list for today. just looking at the review priorty doc review now | |
| 14:19:43 | sean-k-mooney | gibi: do we have the team meeting here today by the way | |
| 14:19:58 | sean-k-mooney | or are we using #openstack-meeting-3 | |
| 14:20:02 | sean-k-mooney | if that exists here | |
| 14:23:21 | opendevreview | Stephen Finucane proposed openstack/nova master: Deprecate filters that have been replaced by placement filters https://review.opendev.org/c/openstack/nova/+/745605 | |
| 14:25:52 | gibi | sean-k-mooney: we will be on #openstack-meeting-3 | |
| 14:26:02 | sean-k-mooney | ack | |
| 14:26:05 | gibi | it do exists | |
| 14:26:17 | gibi | but I will raise the question if we want to move the meeting to here | |
| 14:31:24 | opendevreview | Rodrigo Barbieri proposed openstack/nova master: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/784166 | |
| 14:31:46 | ganso | bauzas: ^ I improved the reno and commit message | |
| 15:06:10 | stephenfin | lyarwood: $ openstack server create ... --block-device source_type=volume,uuid=44d317a3-6183-4063-868b-aa0728576f5f,destination_type=volume,delete_on_termination=true --wait test-server | |
| 15:06:18 | stephenfin | <class 'nova.exception.VolumeNotFound'> (HTTP 500) (Request-ID: req-7fe03627-c4ce-4f4b-9d5c-3abd6b88d3e3) | |
| 15:06:18 | stephenfin | Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible. | |
| 15:09:12 | stephenfin | lyarwood: full traceback here http://paste.openstack.org/show/806238/ | |
| 15:15:46 | sean-k-mooney | stephenfin: your create a server with a prexising volumn | |
| 15:15:53 | stephenfin | yes | |
| 15:16:04 | sean-k-mooney | stephenfin: did you intent to create a server wiht a boot volume form an image? | |
| 15:16:08 | stephenfin | nope | |
| 15:16:14 | stephenfin | I'm updating delete_on_termination=true | |
| 15:16:15 | stephenfin | whoops | |
| 15:16:17 | opendevreview | Merged openstack/placement master: [doc] Redirect people to #openstack-nova https://review.opendev.org/c/openstack/placement/+/793832 | |
| 15:16:18 | stephenfin | doc/source/user/launch-instance-from-volume.rst | |
| 15:16:23 | stephenfin | to use OSC | |
| 15:16:38 | sean-k-mooney | well to use your new os command | |
| 15:16:43 | sean-k-mooney | not just osc | |
| 15:16:54 | sean-k-mooney | but that is weird that sould be correct | |
| 15:16:59 | stephenfin | both | |
| 15:17:11 | stephenfin | the command is correct except I did use the wrong UUID | |
| 15:17:19 | stephenfin | that's my image UUID, not the volume | |
| 15:17:30 | stephenfin | but the server should be handling this and spitting out a better error | |
| 15:17:37 | sean-k-mooney | ya that would make sense | |
| 15:17:43 | sean-k-mooney | it should not be a 500 | |
| 15:17:47 | stephenfin | exactly | |
| 15:17:47 | sean-k-mooney | it should be a 400 | |
| 15:18:25 | sean-k-mooney | ya so i guess we just need to wrap the volumen not found expciton | |
| 15:18:27 | sean-k-mooney | although | |
| 15:18:30 | stephenfin | I can fix but I'm notifying lyarwood since this seems like something that wouldn't go unnoticed for long, so I suspect it's only broken recently (like, last year) | |
| 15:18:34 | sean-k-mooney | we really should be validating this in the api | |
| 15:19:06 | sean-k-mooney | im not sure about that | |
| 15:20:22 | sean-k-mooney | stephenfin: i would expect most peopple to use "openstack server create --flavor 2 --volume VOLUME_ID myInstanceFromVolume" | |
| 15:20:38 | stephenfin | I'd say that will fail with the same error message | |
| 15:20:45 | stephenfin | since it's doing the same thing under the hood | |
| 15:21:00 | sean-k-mooney | it will but i thik they would be less likely to make the mistake of mixing the uuids | |
| 15:22:02 | sean-k-mooney | am i right that you had just previouly tested "-block-device source_type=image,uuid=44d317a3-6183-4063-868b-aa0728576f5f,destination_type=volume,delete_on_termination=true" | |
| 15:22:24 | stephenfin | nope, I just made a mistake | |
| 15:22:32 | stephenfin | the previous command had been 'openstack image list' | |
| 15:22:33 | sean-k-mooney | and then updated the source_type to volumn with out actully updatign the uuid | |
| 15:22:35 | sean-k-mooney | oh ok | |
| 15:22:52 | stephenfin | so my lazy brain grabbed the first UUID it saw on screen :) | |
| 15:23:52 | sean-k-mooney | stephenfin: well the current error is happing on the compute so this should defintly be caught in the api before we create a server record | |
| 15:27:24 | sean-k-mooney | maybe here https://github.com/openstack/nova/blob/da57eebc9e1ab7e48d4c4ef6ec1eeba80d867d81/nova/api/openstack/compute/servers.py#L470 | |
| 15:30:09 | sean-k-mooney | oh in _validate_and_build_base_options https://github.com/openstack/nova/blob/c0c2888acaaccfa4266874523f62039cb9e143e0/nova/compute/api.py#L968 | |
| 15:45:51 | kashyap | stephenfin: [Off-topic] I have an inkling you'll like this: https://www.merriam-webster.com/words-at-play/can-a-ship-flounder | |
| 15:46:40 | kashyap | stephenfin: Also did you know both noun and verb usage of 'flounder and 'founder'? (Before reading the article :) | |
| 15:46:59 | sean-k-mooney | they are two differnt things | |