| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-05-26 | |||
| 15:38:12 | ozzzo | when I google it I find this: https://bugzilla.redhat.com/show_bug.cgi?id=1658406 | |
| 15:38:25 | sean-k-mooney | thats a different upgrade issue where they chagne that between centos 8 and centos 7 | |
| 15:45:56 | ozzzo | sean-k-mooney: how can I work around it? | |
| 15:46:20 | sean-k-mooney | stephenfin: we have two fixes that work | |
| 15:47:12 | sean-k-mooney | stephenfin: https://review.opendev.org/c/openstack/os-vif/+/792840 fixed lc and https://review.opendev.org/c/openstack/os-vif/+/793155 also fix it | |
| 15:47:38 | sean-k-mooney | zuul faild for other reasons | |
| 15:49:14 | sean-k-mooney | ozzzo: i think you need to update the version fo qemu then hard reboot the guest | |
| 15:49:34 | sean-k-mooney | ozzzo: i dont think there is a fix for that that does not invovle a guest reboot | |
| 15:50:25 | sean-k-mooney | ozzzo: so effectivly you cant avoid guest downtime so your simplest solution would be to cold migrate | |
| 15:51:02 | ozzzo | ok I'll experiment with cold-migration | |
| 15:51:11 | sean-k-mooney | ozzzo: unfortnetly this is a libvirt abi breakage that we cannot fix in nova | |
| 15:52:51 | ozzzo | sean-k-mooney: got it. thanks for your advice! | |
| 15:53:55 | gibi | sean-k-mooney: replied in https://review.opendev.org/c/openstack/nova-specs/+/785014 I think we are more or less on the same page | |
| 15:55:46 | sean-k-mooney | gibi: cool ill quickly skim over them one sec | |
| 15:58:07 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Repropose "vm-boot-with-unaddressed-port" spec https://review.opendev.org/c/openstack/nova-specs/+/793199 | |
| 16:02:40 | sean-k-mooney | gibi: cool i agree with youre respeonces so +w but just want to reinfoce that there is no way currently to make a neutron extention required unless nova is willign to stop supportin all neutron backends | |
| 16:03:17 | sean-k-mooney | gibi: i have brought up this problem at the last couple of ptgs | |
| 16:03:22 | gibi | sean-k-mooney: ack, then it means we will keep support for both format for a while | |
| 16:03:36 | gibi | and I will look into adding support for making someting mandatory in neutron | |
| 16:03:49 | sean-k-mooney | gibi: yes but if more them me are asking for this maybe we can actully get neutron to add a way | |
| 16:04:56 | sean-k-mooney | gibi: this type of exteniton can be implemented at the m2 2 level but since they still supprot monolity plugins the only way to make it mandatory is to implemetned above the ml2 laywer | |
| 16:05:11 | sean-k-mooney | as in move it to the core api | |
| 16:05:35 | sean-k-mooney | or start requiring that monolitich plugins implemenet a subset of the extentions | |
| 16:06:23 | bauzas | * bauzas needs to go off but I could chime on gibi's pps spec if needed | |
| 16:06:45 | sean-k-mooney | bauzas: i dont have any open issues with nova | |
| 16:06:52 | sean-k-mooney | bauzas: or the nova part of the spec | |
| 16:07:54 | sean-k-mooney | bauzas: its a neuton process/rules change that im raising | |
| 16:08:59 | bauzas | ack, will look at the spec | |
| 16:12:11 | sean-k-mooney | bauzas: i had just put a +w on it do you want me to remvoe that and leave it to you | |
| 16:13:49 | gibi | there are feedback in the neutron pps spec but I can only take that tomorrow so it is totally ok to keep the nova spec open | |
| 16:13:53 | gibi | * gibi leaves the building | |
| 16:14:49 | sean-k-mooney | you have a very well put together spec so i would also be happy addressing any nits that arise as a folow up if that works for you | |
| 16:18:23 | sean-k-mooney | i removed -w to let bauzas read the latest comments but feel free to re add it | |
| 16:21:34 | sean-k-mooney | lyarwood: minor point on your spec https://review.opendev.org/c/openstack/nova-specs/+/783806/2/specs/xena/approved/ephemeral-encryption.rst#187 | |
| 16:21:38 | stephenfin | sean-k-mooney: +w away | |
| 16:21:47 | stephenfin | we can always revert if needed | |
| 16:21:56 | stephenfin | IMO | |
| 16:21:57 | sean-k-mooney | lyarwood: are we going to have COMPUTE_EPHEMERAL_ENCRYPTION_LUKSV1 and COMPUTE_EPHEMERAL_ENCRYPTION_LUKSV2 or COMPUTE_EPHEMERAL_ENCRYPTION_LUKS and COMPUTE_EPHEMERAL_ENCRYPTION_LUKSV2 | |
| 16:23:03 | lyarwood | ENCRYPTION_LUKS and ENCRYPTION_LUKSV2 are already in os-traits | |
| 16:23:35 | sean-k-mooney | oh... | |
| 16:23:44 | lyarwood | I get that v1/v2 would be nicer but I think this was done to mirror the volume encryption types we have defined in os-brick | |
| 16:23:48 | sean-k-mooney | because we approve the spec last cycle | |
| 16:23:53 | lyarwood | that pre-date v2 so we started with luks and then added luksv2 later | |
| 16:24:00 | lyarwood | yeah | |
| 16:24:02 | sean-k-mooney | if the traits are already there then ok | |
| 16:24:24 | lyarwood | cool cool | |
| 16:25:13 | sean-k-mooney | i feel like im +w too many thing so i just +2'd https://review.opendev.org/c/openstack/nova-specs/+/783806 | |
| 16:25:41 | stephenfin | +W ALL the things! | |
| 16:25:58 | stephenfin | I did it for you ;) | |
| 16:26:21 | sean-k-mooney | * sean-k-mooney is trying to be conservitive with merge writes | |
| 16:26:45 | sean-k-mooney | * sean-k-mooney is also reading a lot of well trought out specs | |
| 16:26:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Enable 'vmcoreinfo' feature by default https://review.opendev.org/c/openstack/nova/+/752912 | |
| 16:26:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: libvirt: Make vmcoreinfo checks guest arch specific https://review.opendev.org/c/openstack/nova/+/790946 | |
| 16:26:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Make vmcoreinfo dependent on feature flag https://review.opendev.org/c/openstack/nova/+/779342 | |
| 16:26:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove 'create_fake_libvirt_mock' https://review.opendev.org/c/openstack/nova/+/790945 | |
| 16:27:15 | stephenfin | lyarwood: Could I get your +2 on the first of those again? ^ | |
| 16:27:19 | stephenfin | merge conflict :( | |
| 16:27:37 | lyarwood | yup no issues | |
| 16:33:44 | artom | sean-k-mooney, so about https://bugzilla.redhat.com/show_bug.cgi?id=1963164 - you said libvirt being restarted will remove and re-add the TAP interface, right? | |
| 16:33:45 | openstack | bugzilla.redhat.com bug 1963164 in openstack-nova "[update] 16.1 to 16.2 update fail on ping loss." [Urgent,New] - Assigned to nova-maint | |
| 16:34:02 | sean-k-mooney | artom: i belive it will trigger https://github.com/libvirt/libvirt/blob/c8238579fb0b1c3affbd77749ae2b2c4dfafb2d6/src/util/virnetdevopenvswitch.c#L158-L159 | |
| 16:34:17 | sean-k-mooney | we shoudl get them to confirm if that is the case | |
| 16:34:27 | artom | sean-k-mooney, this is OVN though | |
| 16:34:33 | sean-k-mooney | yes | |
| 16:34:43 | sean-k-mooney | form a libvirt point of view it cant tell teh difference | |
| 16:34:54 | artom | OK, that code looks like OVS, but that's just my ignorance talking | |
| 16:35:00 | sean-k-mooney | ovn is a replamcent for the neutorn l2 agent not a replacment for ovs | |
| 16:35:51 | artom | So we need to get #virt eyes on the BZ then... | |
| 16:36:20 | sean-k-mooney | yes to confirm if restrating will cause the port add to be reporces after a contaienr upgrade | |
| 16:36:32 | artom | (We're in the wrong channel, aren't we?) | |
| 16:36:45 | sean-k-mooney | on 16/traing plug_vif is a noop for ovn | |
| 16:36:52 | artom | This was supposed to be downstream, but with the, err, kerfuffle, I have more networks open than before ;) | |
| 16:36:55 | sean-k-mooney | both work | |
| 16:37:27 | sean-k-mooney | there is noting private related to that | |
| 16:37:50 | artom | I know, just scope-wise | |
| 16:38:24 | sean-k-mooney | scope wise i am 99.99% sure this is not related to nova | |
| 16:38:28 | sean-k-mooney | or os-vif | |
| 16:39:03 | sean-k-mooney | so yes we should follow up with the libvirt folks downstream and get them to confrim | |
| 16:44:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Remove 'hosts_up' https://review.opendev.org/c/openstack/nova/+/773641 | |
| 16:44:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Remove 'USES_ALLOCATION_CANDIDATES' https://review.opendev.org/c/openstack/nova/+/773640 | |
| 16:44:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Merge 'FilterScheduler' into base class https://review.opendev.org/c/openstack/nova/+/773643 | |
| 16:44:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove FakeScheduler (for realz) https://review.opendev.org/c/openstack/nova/+/773642 | |
| 16:44:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Drop references to non-filter scheduler drivers https://review.opendev.org/c/openstack/nova/+/773645 | |
| 16:44:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Merge driver into manager https://review.opendev.org/c/openstack/nova/+/773644 | |
| 16:44:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Remove deprecated aliases https://review.opendev.org/c/openstack/nova/+/773647 | |
| 16:44:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Merge 'test_utils', 'test_scheduler_utils' https://review.opendev.org/c/openstack/nova/+/773646 | |
| 16:45:04 | stephenfin | lyarwood: might ask for you to look at https://review.opendev.org/c/openstack/nova/+/773640/ again too, if you could. Again, trivial merge conflict | |
| 16:45:17 | stephenfin | I'll bug bauzas for reviews on that tomorrow and try close it out | |
| 16:45:27 | stephenfin | Or Monday, rather | |
| 16:45:33 | stephenfin | * stephenfin is out for the rest of the week | |
| 16:46:26 | lyarwood | Yup no issues I can hit that again later this evening or tomorrow | |
| 16:47:22 | stephenfin | Perfect, thanks. Let me know if I can return the favour | |
| 17:04:57 | openstackgerrit | Merged openstack/nova-specs master: Repropose flavour and image defined ephemeral storage encryption https://review.opendev.org/c/openstack/nova-specs/+/783806 | |
| 18:36:46 | openstackgerrit | Lee Yarwood proposed openstack/nova master: hardware: Use image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/790660 | |
| 18:36:47 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Skip swap_volume tests as part of nova-next https://review.opendev.org/c/openstack/nova/+/793219 | |
| 18:36:49 | lyarwood | ^ giving up trying to fix swap_volume for now as the change above is more important, core reviews would be appreciated. | |
| 18:40:17 | sean-k-mooney | https://review.opendev.org/c/openstack/os-vif/+/792840 has now passed ci | |
| 18:41:10 | sean-k-mooney | stephenfin: ^ are you ok with me continutin gto back port your change | |
| 18:49:55 | melwitt | sean-k-mooney[m]: did you want stephenfin to ack that before +W? | |
| 18:50:55 | sean-k-mooney[m] | melwitt: am i think we can proceed but stephenfin was suggesting that if it does not work we can just delete the job | |