| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-05-26 | |||
| 08:12:47 | bauzas | good morning Nova | |
| 08:17:48 | lyarwood | Morning | |
| 08:18:41 | lyarwood | so what happens to this channel if I look in a mirror and say `Libera Chat` three times? | |
| 08:19:24 | lyarwood | https://twitter.com/fosdem/status/1397454352835653632 context | |
| 08:19:54 | lyarwood | gibi: stephenfin | |
| 08:20:03 | lyarwood | argh sorry can you hit https://review.opendev.org/c/openstack/nova/+/790660 again please | |
| 08:20:34 | lyarwood | * lyarwood is still getting use to nick auto-complete in the element matrix client | |
| 08:38:05 | gibi | sure' | |
| 09:13:00 | openstackgerrit | Vlad Gusev proposed openstack/nova stable/stein: libvirt: Ignore device already in the process of unplug errors https://review.opendev.org/c/openstack/nova/+/793044 | |
| 10:13:42 | sean-k-mooney[m] | lyarwood: i think i figured out the cause of https://bugs.launchpad.net/nova/+bug/1929446 by the way so hopefully we will be able to fix that relitivly quickly | |
| 10:13:43 | openstack | Launchpad bug 1929446 in OpenStack Compute (nova) "check_can_live_migrate_source taking > 60 seconds in CI" [Medium,Triaged] | |
| 10:14:04 | lyarwood | * lyarwood clicks | |
| 10:14:37 | lyarwood | that's blocking the other nova thread? | |
| 10:14:51 | sean-k-mooney[m] | https://zuul.opendev.org/t/openstack/build/bb6fd21b5d8c471a89f4f6598aa84e5d/log/controller/logs/screen-n-cpu.txt#12242 | |
| 10:15:11 | sean-k-mooney[m] | yep all logs form the agent stop until the timeout fires | |
| 10:17:27 | lyarwood | req-00377477-1efd-417a-b9c1-5db2f656c051 seems to run just fine in between | |
| 10:17:49 | lyarwood | and req-cb0aa064-b389-4cd5-aeb3-5c5cf0541b00 | |
| 10:18:24 | sean-k-mooney[m] | yep but that could just be down to the order in whic the green thread are resumed | |
| 10:19:39 | lyarwood | * lyarwood < https://matrix.org/_matrix/media/r0/download/matrix.org/iVBmpWasUBctVWPeNDxVklaG/message.txt > | |
| 10:19:42 | lyarwood | :| | |
| 10:19:54 | lyarwood | was just checking _check_shared_storage_test_file to see if that spawned anything | |
| 10:20:08 | lyarwood | and that caught my eye | |
| 10:21:02 | sean-k-mooney[m] | the exists check will yelid | |
| 10:22:02 | sean-k-mooney[m] | we do not need the polling behavior in os-vif | |
| 10:22:34 | sean-k-mooney[m] | so im going to see if i can disable it without having to recreate the connection every time we plug or unplug a port | |
| 10:25:34 | lyarwood | kk there is a call to libvirt in between the two logged lines for this request btw | |
| 10:26:12 | lyarwood | there's a lookupByUUIDString | |
| 10:26:17 | lyarwood | fetching the guest | |
| 10:28:54 | sean-k-mooney | ya that coudl be related as we have had similar blocking issue there too | |
| 11:23:25 | sean-k-mooney | stephenfin: you missing a comma in https://review.opendev.org/c/openstack/nova/+/792356/3/nova/tests/unit/virt/libvirt/test_vif.py#1076 | |
| 11:23:39 | sean-k-mooney | thats why the jobs failed. | |
| 11:25:33 | sean-k-mooney | ill update https://review.opendev.org/c/openstack/nova/+/777679 quickly for the nits and let you know when its done | |
| 11:36:09 | sean-k-mooney | gibi: i have one comment that i would like your opipion on https://review.opendev.org/c/openstack/nova-specs/+/787178/5/specs/xena/approved/cyborg-no-user-token.rst#56 | |
| 11:37:01 | sean-k-mooney | im +1 on the spec currently if other are ok with that then im also +2 i think. its a relitvly simple change and it mirror what we do for other services so i dont think this is really that contoversial. | |
| 11:44:21 | gibi | sean-k-mooney: you have a good point. I dropped my +2. Lets document the compromise in the secuirty section then I'm +2 again | |
| 11:44:49 | sean-k-mooney | ok works for me | |
| 12:06:32 | lyarwood | Would anyone care if we dropped the direct swap volume tests from tempest and instead just had the indirect volume migration/retype tests to exercise it? | |
| 12:06:43 | lyarwood | it's failing again at the moment on master | |
| 12:11:21 | gibi | lyarwood: is it so that the direct test is someting that a user would never do as swap volume is for cinder to call? | |
| 12:11:51 | lyarwood | admins can use it at the moment but I've wanted to move it under the external events API | |
| 12:11:54 | stephenfin | lyarwood: I don't really understand the question, so I'll defer to your judgement 0:) | |
| 12:11:56 | lyarwood | happy to wait until that's done to remove it | |
| 12:12:09 | lyarwood | lol | |
| 12:12:28 | lyarwood | anyway the CI failures a valid so I'll fix these first | |
| 12:12:53 | lyarwood | http://paste.openstack.org/show/805745/ - I assume something has changed with the way in which libvirt looks up devices | |
| 12:18:43 | gibi | lyarwood: if you have a clue how to fix it then it is better to fix first and then decide on if we want to move | |
| 12:18:55 | gibi | does the indirect test uses the API differently that it is not affected? | |
| 12:21:20 | sean-k-mooney | lyarwood: if the direct swap volume tests are currently calling apis that we only expect cinder to call then defintly agree we shoudl disable them | |
| 12:21:50 | sean-k-mooney | i assume the inderct test call cinder to drive the workflow | |
| 12:22:16 | lyarwood | gibi: it will likely hit this as well if I'm understanding the issue correctly | |
| 12:22:37 | lyarwood | sean-k-mooney: yeah correct cinder-api drives things with volume migrations and retypes | |
| 12:22:41 | sean-k-mooney | nova's swap volume is cinders retype rightr | |
| 12:22:52 | lyarwood | yup | |
| 12:23:17 | sean-k-mooney | ok then if we have the cidner test i think that is enough coverage | |
| 12:23:38 | sean-k-mooney | at least untill we do the cahgne to external events | |
| 12:24:40 | sean-k-mooney | read ^ as a +0.5 sure but not may area :) | |
| 12:33:56 | gibi | I agree with sean-k-mooney here. | |
| 12:36:18 | stephenfin | sean-k-mooney: RE: the broken l-c jobs on os-vif stable branches: I see you're trying to fix them | |
| 12:36:23 | stephenfin | should we be bothering though | |
| 12:36:35 | stephenfin | if it's broken now then it was always broken | |
| 12:36:39 | sean-k-mooney | the inital backport https://review.opendev.org/c/openstack/os-vif/+/792840 failed to install hacking | |
| 12:36:43 | stephenfin | pip's broken resolver was just hiding that | |
| 12:37:07 | sean-k-mooney | i can ditch that and drop it for stable branchs but i would like elod and lyarwood to comment on that | |
| 12:37:27 | stephenfin | yeah, I would be in favour of dropping this rather than investing more effort in it, personally | |
| 12:37:33 | stephenfin | but stable cores should weigh in. melwitt too | |
| 12:37:46 | lyarwood | yup FWIW I'm fine dropping it | |
| 12:38:45 | gibi | our agreement was that we try to fix but drop it if we cannot | |
| 12:38:57 | gibi | so if the consensus is that it is now hard to fix then I'm fine to drop it | |
| 12:39:26 | sean-k-mooney | from stable only or also form master? | |
| 12:39:26 | stephenfin | yeah, that's my recollection also | |
| 12:39:37 | stephenfin | if master is still working, I see no reason to drop it there | |
| 12:39:39 | stephenfin | personally | |
| 12:39:47 | sean-k-mooney | master is yes | |
| 12:40:12 | stephenfin | but per gibi's comment above, if it breaks and is more than trivial to resolve, we should drop from master also | |
| 12:40:21 | sean-k-mooney | and stable wallaby is since it has your fix | |
| 12:40:31 | sean-k-mooney | so it would be victoria and older | |
| 12:40:35 | gibi | I agree with stephenfin | |
| 12:40:48 | stephenfin | sean-k-mooney: victoria and older wfm | |
| 12:41:32 | sean-k-mooney | ok i just reject the victoria fix if that fails to install hacking again or fails in general ill drop it and then propose the other patches for stable and rebase any pending patches | |
| 12:41:52 | sean-k-mooney | well the 2 i want to backport in anycase :) | |
| 13:07:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document virtio-net multiqueue https://review.opendev.org/c/openstack/nova/+/792362 | |
| 13:07:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add 'hw:vif_multiqueue_enabled' flavor extra spec https://review.opendev.org/c/openstack/nova/+/792356 | |
| 13:07:05 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware https://review.opendev.org/c/openstack/nova/+/792364 | |
| 13:16:36 | openstackgerrit | Elod Illes proposed openstack/os-vif stable/victoria: [stable-only] Fix lower-constraints https://review.opendev.org/c/openstack/os-vif/+/793155 | |
| 13:17:04 | elod | sean-k-mooney: this worked for me locally, let's see if zuul is also happy with it ^^^ | |
| 13:17:36 | sean-k-mooney | elod: so did the patch i pushed :) | |
| 13:17:51 | sean-k-mooney | elod: https://review.opendev.org/c/openstack/os-vif/+/792840 | |
| 13:17:58 | elod | oh did it meanwhile? :) I just saw that it failed :) | |
| 13:18:15 | sean-k-mooney | well it passed before i pushed it | |
| 13:18:24 | sean-k-mooney | it failed in teh gate because it could not install hacking | |
| 13:18:34 | sean-k-mooney | i think that was a limestone issue | |
| 13:20:10 | sean-k-mooney | elod: the recheck of min passed lower constratits for what its worth | |
| 13:20:46 | elod | it was passing before if I remember correctly | |
| 13:20:51 | sean-k-mooney | https://a23e1d5d8671587c8417-333846024fbe3cd00d8d8f9166c680e2.ssl.cf2.rackcdn.com/792840/1/check/openstack-tox-lower-constraints/f0bf4ed/ | |
| 13:21:43 | sean-k-mooney | looks like other josb are failing to conenct to opendev.org | |
| 13:22:16 | elod | the only concern why I sticked to the fixing of constraints instead of removing most of them is I think it is more "future proof" to keep more constraints. otherwise the resolver could become slower and slower. | |
| 13:22:36 | elod | but, anyway, both patch works for me :) | |
| 13:26:04 | sean-k-mooney | elod: it could although os-vif tries to have relitivly minimal deps | |
| 13:27:16 | sean-k-mooney | i would even like to reduce the set we have futher by removng oslo.i18n | |
| 13:28:00 | sean-k-mooney | we have never hadn and translsation for os-vif and i dont think we do that anymore for logs/errors in general | |