| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-05-11 | |||
| 16:46:40 | bauzas | or this could be a second label | |
| 16:46:48 | gibi | and that is why I propose to have only the second level :) | |
| 16:46:48 | gibi | and that is why I propose to have only the second level :) | |
| 16:47:04 | bauzas | I guess I need to see how this works | |
| 16:47:04 | bauzas | I guess I need to see how this works | |
| 16:47:13 | gibi | we can do an experiment | |
| 16:47:13 | gibi | we can do an experiment | |
| 16:47:15 | stephenfin | I don't think that's necessary. I occasionally review the list of open bugs looking for things that are important. I can set the label for anything I find | |
| 16:47:15 | stephenfin | I don't think that's necessary. I occasionally review the list of open bugs looking for things that are important. I can set the label for anything I find | |
| 16:47:20 | stephenfin | or anyone else | |
| 16:47:20 | stephenfin | or anyone else | |
| 16:47:36 | bauzas | gibi: yep, hence my concerns are nitty | |
| 16:47:36 | bauzas | gibi: yep, hence my concerns are nitty | |
| 16:47:50 | bauzas | gibi: but again, I need to understand what we would do | |
| 16:47:50 | bauzas | gibi: but again, I need to understand what we would do | |
| 16:48:03 | bauzas | like, I'm seeing some changes and think those are nice for other cores | |
| 16:48:03 | bauzas | like, I'm seeing some changes and think those are nice for other cores | |
| 16:48:12 | bauzas | then I'll set the label to +1 | |
| 16:48:12 | bauzas | then I'll set the label to +1 | |
| 16:48:24 | bauzas | magically, other cores will see those changes in their dashboards | |
| 16:48:24 | bauzas | magically, other cores will see those changes in their dashboards | |
| 16:48:36 | bauzas | and will consider signing off for reviews | |
| 16:48:36 | bauzas | and will consider signing off for reviews | |
| 16:49:01 | bauzas | so, the label is just a signal to the other cores ? | |
| 16:49:02 | bauzas | so, the label is just a signal to the other cores ? | |
| 16:49:04 | bauzas | or, | |
| 16:49:04 | bauzas | or, | |
| 16:49:07 | bauzas | the other way | |
| 16:49:08 | bauzas | the other way | |
| 16:49:20 | bauzas | someone pings me on IRC begging for reviews | |
| 16:49:20 | bauzas | someone pings me on IRC begging for reviews | |
| 16:49:36 | bauzas | i don't have time now but I want to review such | |
| 16:49:36 | bauzas | i don't have time now but I want to review such | |
| 16:49:39 | gibi | it is signal for other cores that this patch seems to be ready and important. And it is signal for the author to expect incoming reviews | |
| 16:49:39 | gibi | it is signal for other cores that this patch seems to be ready and important. And it is signal for the author to expect incoming reviews | |
| 16:49:43 | bauzas | so I'd tag the change for later | |
| 16:49:43 | bauzas | so I'd tag the change for later | |
| 16:49:57 | gibi | bauzas: your second use case already covered by starring a review | |
| 16:49:57 | gibi | bauzas: your second use case already covered by starring a review | |
| 16:50:05 | bauzas | gibi: right, I know | |
| 16:50:24 | bauzas | gibi: okay, then the first usecase I mentioned, which I honestly think won't help | |
| 16:50:24 | bauzas | gibi: okay, then the first usecase I mentioned, which I honestly think won't help | |
| 16:50:41 | bauzas | because we assume the signal isn't lost | |
| 16:50:41 | bauzas | because we assume the signal isn't lost | |
| 16:50:44 | gibi | even if we look at the marked review on the weekly | |
| 16:50:44 | gibi | ? | |
| 16:50:44 | gibi | even if we look at the marked review on the weekly | |
| 16:51:07 | bauzas | and we assume the cores will commit to it, whatever their respective bandwidthes are | |
| 16:51:07 | bauzas | and we assume the cores will commit to it, whatever their respective bandwidthes are | |
| 16:51:51 | bauzas | gibi: the only benefit I see honestly is the weekly meeting | |
| 16:51:51 | bauzas | gibi: the only benefit I see honestly is the weekly meeting | |
| 16:52:11 | bauzas | gibi: because we already signal important changes we care by other means, like pings | |
| 16:52:11 | bauzas | gibi: because we already signal important changes we care by other means, like pings | |
| 16:52:16 | gibi | right. I consider adding +1 priority only to a patch when I commit to review it within a week or even less | |
| 16:52:16 | gibi | right. I consider adding +1 priority only to a patch when I commit to review it within a week or even less | |
| 16:52:45 | bauzas | ok, so the signal is different | |
| 16:52:45 | bauzas | ok, so the signal is different | |
| 16:53:01 | bauzas | you're not sending a signal that's "cores, please review" | |
| 16:53:01 | bauzas | you're not sending a signal that's "cores, please review" | |
| 16:53:16 | bauzas | but rather a signal saying "I have free time to this change and I commit to it" | |
| 16:53:16 | bauzas | but rather a signal saying "I have free time to this change and I commit to it" | |
| 16:53:43 | bauzas | that's not an actional item for others then, it's an actional item for the core | |
| 16:53:43 | bauzas | that's not an actional item for others then, it's an actional item for the core | |
| 16:54:10 | bauzas | (which is better than now, agreed= | |
| 16:54:10 | bauzas | (which is better than now, agreed= | |
| 16:54:29 | gibi | my runway experience was that thing in the slot did not get review bandwidht because we missed the commitment part | |
| 16:54:29 | gibi | my runway experience was that thing in the slot did not get review bandwidht because we missed the commitment part | |
| 16:54:35 | bauzas | agreed | |
| 16:54:39 | bauzas | 100% to it | |
| 16:54:39 | bauzas | 100% to it | |
| 16:54:55 | bauzas | but I think I wasn't clear about the use of this new label | |
| 16:54:55 | bauzas | but I think I wasn't clear about the use of this new label | |
| 16:55:11 | bauzas | and i also think the change isn't explaining how we'll use it | |
| 16:55:11 | bauzas | and i also think the change isn't explaining how we'll use it | |
| 16:55:34 | bauzas | if it's a label for me committing to a change, then OK | |
| 16:55:34 | bauzas | if it's a label for me committing to a change, then OK | |
| 16:56:01 | bauzas | that being said, ones could tell we can just use gerrit CCs | |
| 16:56:01 | bauzas | that being said, ones could tell we can just use gerrit CCs | |
| 16:56:06 | sean-k-mooney | gibi: bauzas so just asked fungi , the review priorty lable is not defiend globlly so we can define it as we want for nova and we can make it sticky yes | |
| 16:56:06 | sean-k-mooney | gibi: bauzas so just asked fungi , the review priorty lable is not defiend globlly so we can define it as we want for nova and we can make it sticky yes | |
| 16:56:20 | fungi | yeah, look at cinder's acl for an example | |
| 16:56:20 | fungi | yeah, look at cinder's acl for an example | |
| 16:56:32 | bauzas | I'm not debating over the label itself | |
| 16:56:32 | bauzas | I'm not debating over the label itself | |
| 16:56:39 | sean-k-mooney | https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/cinder.config#L25-L35 | |
| 16:56:39 | sean-k-mooney | https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/cinder.config#L25-L35 | |
| 16:56:55 | bauzas | I'm more concerned by the solely usage we, as nova contributors, will make of it | |
| 16:56:55 | bauzas | I'm more concerned by the solely usage we, as nova contributors, will make of it | |
| 16:56:58 | gibi | bauzas: point taken. I need to write the procee up in a patch to the intree contributor doc | |
| 16:56:58 | gibi | bauzas: point taken. I need to write the procee up in a patch to the intree contributor doc | |
| 16:57:00 | sean-k-mooney | bauzas: sure just confirm ing we can customise it to have the behavior we desire | |
| 16:57:00 | sean-k-mooney | bauzas: sure just confirm ing we can customise it to have the behavior we desire | |
| 16:57:15 | bauzas | gibi: one last thing before I stop | |
| 16:57:15 | bauzas | gibi: one last thing before I stop | |
| 16:57:17 | gibi | bauzas: I wanted to start the discussion before I do that. Now I think I got enough input from you to do it | |
| 16:57:17 | gibi | bauzas: I wanted to start the discussion before I do that. Now I think I got enough input from you to do it | |
| 16:57:30 | bauzas | gibi: I'm not sure we need to restrict such label to the cores | |
| 16:57:30 | bauzas | gibi: I'm not sure we need to restrict such label to the cores | |
| 16:57:39 | bauzas | if it's a signal about committing to review | |
| 16:57:39 | bauzas | if it's a signal about committing to review | |