Earlier  
Posted Nick Remark
#openstack-nova - 2021-04-28
08:04:37 gibi it seems it interferes with the bionic jobs
08:04:37 gibi it seems it interferes with the bionic jobs
08:04:48 lyarwood https://review.opendev.org/c/openstack/devstack/+/779624
08:04:48 lyarwood https://review.opendev.org/c/openstack/devstack/+/779624
08:05:00 lyarwood I was sure I pinned the bionic jobs to tgtadm
08:05:00 lyarwood I was sure I pinned the bionic jobs to tgtadm
08:05:35 gibi http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Failed%20to%20start%20rtslib-fb-targetctl.service%5C%22 this query shows that it is mostly hit on bionic
08:05:35 gibi http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Failed%20to%20start%20rtslib-fb-targetctl.service%5C%22 this query shows that it is mostly hit on bionic
08:07:40 lyarwood oh it's because this is still the old grenade multinode job
08:07:40 lyarwood oh it's because this is still the old grenade multinode job
08:07:42 lyarwood gah
08:07:42 lyarwood gah
08:08:10 lyarwood we really need to land https://review.opendev.org/c/openstack/nova/+/778885 soonish assuming everyone is okay with the job
08:08:10 lyarwood we really need to land https://review.opendev.org/c/openstack/nova/+/778885 soonish assuming everyone is okay with the job
08:08:34 gibi I'm on it
08:08:34 gibi I'm on it
08:09:00 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726
08:10:34 gibi lyarwood: fyi there are other than the nova grenade jobs out there that is blocked now, so while I totally agree to move forward with the new grenade jobs in nova it is not a full fix for the gate (it fixes the nova gate though :))
08:10:34 gibi lyarwood: fyi there are other than the nova grenade jobs out there that is blocked now, so while I totally agree to move forward with the new grenade jobs in nova it is not a full fix for the gate (it fixes the nova gate though :))
08:14:24 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Pin nova-grenade-multinode to tgtadm CINDER_ISCSI_HELPER https://review.opendev.org/c/openstack/nova/+/788425
08:14:25 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Pin nova-grenade-multinode to tgtadm CINDER_ISCSI_HELPER https://review.opendev.org/c/openstack/nova/+/788425
08:14:28 lyarwood gibi: so the other fix is that ^
08:14:28 lyarwood gibi: so the other fix is that ^
08:14:35 lyarwood * lyarwood looks at the logstash query
08:15:10 lyarwood yeah these are all dsvm bionic jobs, gah
08:15:11 lyarwood yeah these are all dsvm bionic jobs, gah
08:17:56 lyarwood let me fix this in devstack actually
08:17:56 lyarwood let me fix this in devstack actually
08:18:07 lyarwood these jobs really need to be updated anyway
08:18:07 lyarwood these jobs really need to be updated anyway
08:20:35 gibi OK
08:20:51 gibi I continue review the patch that adds the new grenade job to nova
08:20:51 gibi I continue review the patch that adds the new grenade job to nova
08:35:24 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - testing nova-grenade-multinode fix https://review.opendev.org/c/openstack/nova/+/788430
08:35:24 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - testing nova-grenade-multinode fix https://review.opendev.org/c/openstack/nova/+/788430
08:39:35 lyarwood gibi: https://review.opendev.org/c/openstack/devstack/+/788429 should fix all jobs
08:39:35 lyarwood gibi: https://review.opendev.org/c/openstack/devstack/+/788429 should fix all jobs
08:45:39 gibi does that ^^ superseeds https://review.opendev.org/c/openstack/nova/+/788425 ?
08:45:39 gibi does that ^^ superseeds https://review.opendev.org/c/openstack/nova/+/788425 ?
08:47:18 lyarwood gibi: well I've posted three changes in all, one that fixes just nova-grenade-multinode as it currently is, one that fixes nova-grenade-multinode by moving to the zuulv3 based jobs and a devstack change to fix all bionic based jobs
08:47:18 lyarwood gibi: well I've posted three changes in all, one that fixes just nova-grenade-multinode as it currently is, one that fixes nova-grenade-multinode by moving to the zuulv3 based jobs and a devstack change to fix all bionic based jobs
08:47:40 lyarwood gibi: https://review.opendev.org/c/openstack/nova/+/788425 is something we can land quickly IMHO
08:47:41 lyarwood gibi: https://review.opendev.org/c/openstack/nova/+/788425 is something we can land quickly IMHO
08:47:41 gibi I've just approved the zuul v3 move
08:47:42 gibi I've just approved the zuul v3 move
08:47:47 lyarwood ah there we go then
08:47:47 lyarwood ah there we go then
08:47:58 lyarwood I'll drop https://review.opendev.org/c/openstack/nova/+/788425
08:47:59 lyarwood I'll drop https://review.opendev.org/c/openstack/nova/+/788425
08:48:01 gibi Ok
08:48:01 gibi Ok
08:48:29 gibi thanks
08:48:48 lyarwood the zuulv3 change should also move our grenade testing to focal to focal finally
08:48:48 lyarwood the zuulv3 change should also move our grenade testing to focal to focal finally
08:48:55 lyarwood we dropped bionic back in ussuri
08:48:56 lyarwood we dropped bionic back in ussuri
09:11:09 sean-k-mooney does anyone know why we have an os_type column in the instances table
09:11:10 sean-k-mooney does anyone know why we have an os_type column in the instances table
09:12:03 sean-k-mooney as far as i can tell we always use the os_type image metadata property when generating xmls or schduling
09:12:04 sean-k-mooney as far as i can tell we always use the os_type image metadata property when generating xmls or schduling
09:12:11 sean-k-mooney not an os_type form the instance
09:12:12 sean-k-mooney not an os_type form the instance
09:23:04 stephenfin bauzas: Are you okay with me addressing your nits and then reviewing https://review.opendev.org/c/openstack/nova/+/695012 myself? I think the bulk of the change will stay the same
09:23:04 stephenfin bauzas: Are you okay with me addressing your nits and then reviewing https://review.opendev.org/c/openstack/nova/+/695012 myself? I think the bulk of the change will stay the same
09:23:47 bauzas stephenfin: woah, long story here, I can't remember the context but sure
09:23:47 bauzas stephenfin: woah, long story here, I can't remember the context but sure
09:24:42 sean-k-mooney we really should try and get that serise merged
09:24:42 sean-k-mooney we really should try and get that serise merged
09:26:45 sean-k-mooney hum i wonder why i never left any review comments on that unless its a different seriese form mark
09:26:45 sean-k-mooney hum i wonder why i never left any review comments on that unless its a different seriese form mark
09:29:56 sean-k-mooney oh i was thinking of https://review.opendev.org/c/openstack/nova/+/710848 https://review.opendev.org/c/openstack/nova/+/710847 and https://review.opendev.org/c/openstack/nova/+/760354
09:29:56 sean-k-mooney oh i was thinking of https://review.opendev.org/c/openstack/nova/+/710848 https://review.opendev.org/c/openstack/nova/+/710847 and https://review.opendev.org/c/openstack/nova/+/760354
09:50:38 stephenfin gibi: Could I get you to review the small diff on https://review.opendev.org/c/openstack/nova/+/676209 yet again, please? /o\
09:50:38 stephenfin gibi: Could I get you to review the small diff on https://review.opendev.org/c/openstack/nova/+/676209 yet again, please? /o\
09:51:01 stephenfin lyarwood: Any chance you'd be able to slog through that so I can finally close it out? I genuinely think it's a useful addition
09:51:01 stephenfin lyarwood: Any chance you'd be able to slog through that so I can finally close it out? I genuinely think it's a useful addition
09:58:12 lyarwood stephenfin: yup I'll queue it up for later today if that's okay
09:58:12 lyarwood stephenfin: yup I'll queue it up for later today if that's okay
09:58:22 stephenfin wfm. Thanks
09:58:22 stephenfin wfm. Thanks
09:58:32 lyarwood stephenfin: and I'll likely ask for the same later in the cycle for the block layer
09:58:33 lyarwood stephenfin: and I'll likely ask for the same later in the cycle for the block layer
09:58:39 stephenfin fair :)
09:58:39 stephenfin fair :)
10:12:14 gibi stephenfin: I will check it after my lunch
10:12:14 gibi stephenfin: I will check it after my lunch
10:24:12 openstackgerrit Lee Yarwood proposed openstack/nova stable/victoria: libvirt: Ignore device already in the process of unplug errors https://review.opendev.org/c/openstack/nova/+/788467
10:24:47 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Ignore device already in the process of unplug errors https://review.opendev.org/c/openstack/nova/+/788468
10:24:47 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Ignore device already in the process of unplug errors https://review.opendev.org/c/openstack/nova/+/788468
10:26:33 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: libvirt: Ignore device already in the process of unplug errors https://review.opendev.org/c/openstack/nova/+/788469
10:26:33 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: libvirt: Ignore device already in the process of unplug errors https://review.opendev.org/c/openstack/nova/+/788469
10:41:04 sean-k-mooney stephenfin: +1 on the first patch for nova.pci
10:41:04 sean-k-mooney stephenfin: +1 on the first patch for nova.pci
10:41:15 stephenfin thanks :)
10:41:15 stephenfin thanks :)
10:41:28 sean-k-mooney stephenfin: i have 2 other review i want to complte first then ill see if i can get back to the rest
10:41:28 sean-k-mooney stephenfin: i have 2 other review i want to complte first then ill see if i can get back to the rest
10:45:02 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704
11:00:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: Testing with sqlalchemy 1.4 https://review.opendev.org/c/openstack/nova/+/788471
11:00:22 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: Testing with sqlalchemy 1.4 https://review.opendev.org/c/openstack/nova/+/788471

Earlier   Later