Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-04-20
14:22:22 sean-k-mooney gibi: they only have policy rules for device profile
14:22:28 sean-k-mooney but not for the rest
14:22:28 sean-k-mooney but not for the rest
14:23:52 sean-k-mooney i assume the middleware should be a noop in that case
14:23:52 sean-k-mooney i assume the middleware should be a noop in that case
14:24:15 sean-k-mooney stephenfin: maybe you know this is likely defiend in oslo.policy right?
14:24:15 sean-k-mooney stephenfin: maybe you know this is likely defiend in oslo.policy right?
14:25:33 sean-k-mooney oh its going to use the default rule
14:25:33 sean-k-mooney oh its going to use the default rule
14:25:40 gibi sean-k-mooney: I don't know what would be the default policy
14:25:40 gibi sean-k-mooney: I don't know what would be the default policy
14:25:52 stephenfin I haven't a clue. It's not controlled by middleware though afaik
14:25:52 stephenfin I haven't a clue. It's not controlled by middleware though afaik
14:26:04 sean-k-mooney https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L213
14:26:05 sean-k-mooney https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L213
14:26:09 stephenfin I mean, that's why we have 'context.check' calls everywhere
14:26:09 stephenfin I mean, that's why we have 'context.check' calls everywhere
14:28:50 sean-k-mooney its currently coming form https://github.com/openstack/cyborg/blob/master/cyborg/common/policy.py#L26-L42
14:28:50 sean-k-mooney its currently coming form https://github.com/openstack/cyborg/blob/master/cyborg/common/policy.py#L26-L42
14:29:21 sean-k-mooney they seam to be moving things around
14:29:21 sean-k-mooney they seam to be moving things around
14:29:44 sean-k-mooney and also enbablign system scopes so the current polices are in 2 differnet locations
14:29:44 sean-k-mooney and also enbablign system scopes so the current polices are in 2 differnet locations
14:31:39 sean-k-mooney so its using https://github.com/openstack/cyborg/blob/025188ce27dd7711d00c843166e588fdaa14df79/cyborg/policies/base.py#L127-L133
14:31:39 sean-k-mooney so its using https://github.com/openstack/cyborg/blob/025188ce27dd7711d00c843166e588fdaa14df79/cyborg/policies/base.py#L127-L133
14:31:57 sean-k-mooney so check_str='rule:admin_or_owner',
14:31:57 sean-k-mooney so check_str='rule:admin_or_owner',
14:32:51 sean-k-mooney ok so the do at least have policy in code
14:32:51 sean-k-mooney ok so the do at least have policy in code
14:33:28 sean-k-mooney but they have not defined the default polices for the other resouces sicne they created cyborg/policies/
14:33:28 sean-k-mooney but they have not defined the default polices for the other resouces sicne they created cyborg/policies/
14:33:43 sean-k-mooney and they are relying on there old rules that predate the scope_type support
14:33:43 sean-k-mooney and they are relying on there old rules that predate the scope_type support
14:50:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: [func test]: create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205
14:50:07 openstackgerrit Balazs Gibizer proposed openstack/nova master: [func test]: create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205
14:50:10 openstackgerrit Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206
14:51:26 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208
14:57:43 gibi sean-k-mooney: if you interested ^^ adds a bit of code and a bunch of TODOs showing where and how nova needs to be changed to support the pps qos feature from neutron
14:57:43 gibi sean-k-mooney: if you interested ^^ adds a bit of code and a bunch of TODOs showing where and how nova needs to be changed to support the pps qos feature from neutron
14:58:33 sean-k-mooney :) i may not get to the code this week but ill try and take a look
14:58:33 sean-k-mooney :) i may not get to the code this week but ill try and take a look
15:03:26 gibi sean-k-mooney: no worries. I just started poking around in nova to see the size of the impact. It help me discover where changes are needed. Like I totally forget about $ nova-manage placement heal_allocation originally
15:03:27 gibi sean-k-mooney: no worries. I just started poking around in nova to see the size of the impact. It help me discover where changes are needed. Like I totally forget about $ nova-manage placement heal_allocation originally
16:46:30 openstackgerrit Balazs Gibizer proposed openstack/placement master: Add a reproduction test for bug story/2008831 https://review.opendev.org/c/openstack/placement/+/787266
16:46:30 openstackgerrit Balazs Gibizer proposed openstack/placement master: Add a reproduction test for bug story/2008831 https://review.opendev.org/c/openstack/placement/+/787266
16:46:35 openstackgerrit Balazs Gibizer proposed openstack/placement master: Make sure the policy upgrade check get a valid config https://review.opendev.org/c/openstack/placement/+/787267
16:50:33 lyarwood is anyone looking at the test_live_migration_with_trunk failures in master btw?
16:50:33 lyarwood is anyone looking at the test_live_migration_with_trunk failures in master btw?
16:53:12 gibi lyarwood: yes
16:53:12 gibi lyarwood: yes
16:53:15 gibi there is a fix
16:53:15 gibi there is a fix
16:53:28 gibi lyarwood: https://review.opendev.org/c/openstack/tempest/+/786465
16:53:28 gibi lyarwood: https://review.opendev.org/c/openstack/tempest/+/786465
16:56:40 lyarwood cool I did think it would be something like that in the end
16:56:40 lyarwood cool I did think it would be something like that in the end
16:59:12 gibi I'm glad that it was simple
16:59:12 gibi I'm glad that it was simple
21:05:59 openstackgerrit melanie witt proposed openstack/placement master: Add 'cryptography' package to test-requirements.txt https://review.opendev.org/c/openstack/placement/+/787289
21:26:55 gmann gibi: thanks for taking care of CONF object issue, https://review.opendev.org/c/openstack/placement/+/787267
21:26:55 gmann gibi: thanks for taking care of CONF object issue, https://review.opendev.org/c/openstack/placement/+/787267
21:28:05 gmann I now realized it was separate conf object which was initialized there instead of cfg.CONF like most of the services
21:28:05 gmann I now realized it was separate conf object which was initialized there instead of cfg.CONF like most of the services
22:55:02 openstackgerrit melanie witt proposed openstack/placement master: Add 'cryptography' package to test-requirements.txt https://review.opendev.org/c/openstack/placement/+/787289
23:17:34 openstackgerrit Merged openstack/placement master: Add a reproduction test for bug story/2008831 https://review.opendev.org/c/openstack/placement/+/787266
23:17:34 openstackgerrit Merged openstack/placement master: Add a reproduction test for bug story/2008831 https://review.opendev.org/c/openstack/placement/+/787266
23:57:27 openstackgerrit Merged openstack/nova master: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/783275
23:57:27 openstackgerrit Merged openstack/nova master: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/783275
#openstack-nova - 2021-04-21
01:08:59 openstackgerrit melanie witt proposed openstack/placement master: Add 'cryptography' package to test-requirements.txt https://review.opendev.org/c/openstack/placement/+/787289
01:08:59 openstackgerrit melanie witt proposed openstack/placement master: Add 'cryptography' package to test-requirements.txt https://review.opendev.org/c/openstack/placement/+/787289
01:22:11 openstackgerrit melanie witt proposed openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170
01:22:11 openstackgerrit melanie witt proposed openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170
01:22:20 openstackgerrit melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441
01:22:32 openstackgerrit melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486
07:07:46 gibi gmann: yeah, placement does it differently. And I missed it in the original code review
07:07:46 gibi gmann: yeah, placement does it differently. And I missed it in the original code review
07:14:45 openstackgerrit Slawek Kaplonski proposed openstack/nova stable/wallaby: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787251
07:14:45 openstackgerrit Slawek Kaplonski proposed openstack/nova stable/wallaby: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787251
07:15:16 gibi stephenfin: hi! could you look back to https://review.opendev.org/c/openstack/nova/+/770246/28 lyarwood already happy with it and last time you only had a small comment I fixed in the meantime
07:15:16 gibi stephenfin: hi! could you look back to https://review.opendev.org/c/openstack/nova/+/770246/28 lyarwood already happy with it and last time you only had a small comment I fixed in the meantime
07:15:35 openstackgerrit Slawek Kaplonski proposed openstack/nova stable/victoria: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787252
07:16:40 openstackgerrit Slawek Kaplonski proposed openstack/nova stable/ussuri: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787253
07:19:00 openstackgerrit Slawek Kaplonski proposed openstack/nova stable/train: [neutron] Get only ID and name of the SGs from Neutron https://review.opendev.org/c/openstack/nova/+/787316
07:43:29 openstackgerrit norman shen proposed openstack/nova master: Force raising an timeout exception for rados connect https://review.opendev.org/c/openstack/nova/+/768530
07:43:29 openstackgerrit norman shen proposed openstack/nova master: Force raising an timeout exception for rados connect https://review.opendev.org/c/openstack/nova/+/768530
09:12:18 stephenfin gibi: Done. https://review.opendev.org/c/openstack/nova/+/779704/ is in the same series and could do with _your_ attention :)
09:12:18 stephenfin gibi: Done. https://review.opendev.org/c/openstack/nova/+/779704/ is in the same series and could do with _your_ attention :)
09:12:46 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM libvirt: Switch to q35 as the default x86_64 machine type https://review.opendev.org/c/openstack/nova/+/787330
09:12:46 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM libvirt: Switch to q35 as the default x86_64 machine type https://review.opendev.org/c/openstack/nova/+/787330
09:13:04 lyarwood ^ ignore this, just testing
09:13:04 lyarwood ^ ignore this, just testing
09:17:02 openstackgerrit Balazs Gibizer proposed openstack/placement master: Make sure the policy upgrade check get a valid config https://review.opendev.org/c/openstack/placement/+/787267
09:17:02 openstackgerrit Balazs Gibizer proposed openstack/placement master: Make sure the policy upgrade check get a valid config https://review.opendev.org/c/openstack/placement/+/787267
09:17:06 gibi stephenfin: sure, I will look
09:17:06 gibi stephenfin: sure, I will look
09:30:25 gibi done, +2
09:30:25 gibi done, +2
09:32:30 openstackgerrit Wenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/c/openstack/nova-specs/+/787178
09:43:50 openstackgerrit Wenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/c/openstack/nova-specs/+/787178
09:46:25 openstackgerrit Wenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/c/openstack/nova-specs/+/787178

Earlier   Later