| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-04-12 | |||
| 16:50:19 | openstack | bug 1879878 in OpenStack Compute (nova) train "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Undecided,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | |
| 16:50:48 | elod | (and sorry for pinging you only now :X) | |
| 16:51:52 | lyarwood | elod: I *think* we are carrying this downstream so both bug #1879878 and making any future backports easier upstream in stable/train | |
| 16:51:54 | openstack | bug 1879878 in OpenStack Compute (nova) train "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Undecided,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | |
| 16:55:04 | elod | lyarwood: I see. As I was not fond of backporting that amount of test refactors... I waited to approve these test refactors until the bugfix part is reviewed by more eyes, to reduce the risk of introducing regressions | |
| 16:58:00 | lyarwood | elod: I understand but we are actually reducing the amount of code churn in backports by pulling back something like this | |
| 16:58:34 | elod | yes, for train, but for stein, we have to do the churn anyway o:) | |
| 16:58:46 | elod | but I understand that you only support train | |
| 16:59:02 | lyarwood | well we support Queens still but only really target Train at the moment | |
| 16:59:32 | lyarwood | but yeah eventually we will have to avoid the backport and just do the hard work but I'd prefer to defer that as long as possible | |
| 16:59:45 | lyarwood | we already suffer on stable/train without _create_server etc in the func tests | |
| 17:00:01 | lyarwood | but anyway, I don't see the harm when it's this self contained tbh | |
| 17:00:20 | lyarwood | let me hit the tip of the series | |
| 17:00:27 | lyarwood | and we can go from there | |
| 17:01:09 | elod | so as a standalone patch I wouldn't really merge it. but I understand the need... :S | |
| 17:02:17 | elod | also train-em transition is closer and closer. if it's not a risk, then it's okay to be part of the last release, otherwise I would consider waiting until the transition is done | |
| 18:01:18 | sean-k-mooney | elod: so add them after its EM or just not at all | |
| 18:01:53 | sean-k-mooney | elod: context is we need to support train for 3 more years so it would be nice to have them as we backport regression tests | |
| 18:02:01 | sean-k-mooney | * downstream | |
| 18:03:52 | openstackgerrit | Rodrigo Barbieri proposed openstack/nova master: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/784166 | |
| 18:14:08 | elod | sean-k-mooney: yes, I understand that and accept the reason. I just wanted to avoid regression (especially now when train will trainsition to extended maintenance). that's why I wanted more eyes on the bugfix part. | |
| 18:15:12 | sean-k-mooney | sure i was just asking if you were ok with it going in after it was EM or if you wanted to not backport the _create_server and start_compute functions | |
| 18:18:22 | elod | well, as I said, I'm not fond of backporting such test refactors, but if stable cores are fine with it then we can merge it | |
| 18:18:50 | elod | and we can even merge it now, if it is considered not risky | |
| 18:19:32 | elod | (as I am maybe overcautious in this big patch series... :X) | |
| 18:21:26 | elod | (this one: https://review.opendev.org/q/topic:%22bug%252F1879878%22 ) | |
| 18:22:27 | sean-k-mooney | well https://review.opendev.org/c/openstack/nova/+/751364 is kind of indepent of that | |
| 18:23:03 | sean-k-mooney | its a funciontal test change only so it cant break production code | |
| 18:24:48 | elod | yes it is, but it is in the middle of a big patch series o:) | |
| 18:25:57 | sean-k-mooney | true altouh its number 3 in the seriese and the other patches before it are like wise test only changes | |
| 18:26:24 | sean-k-mooney | i do understand the caution | |
| 18:27:15 | sean-k-mooney | which is why i did not backport them myself the last time to avoid having to disucss the merrits or them and focus just on the minium code change for the bug i was fixing | |
| 18:39:57 | elod | well, as I understood we don't even backport standalone test refactoring patches without any reason, so if they are not bug related | |
| 18:50:41 | sean-k-mooney | dansmith: gibi i dont know if i had a bp or bug before for the az filter but i filed https://blueprints.launchpad.net/nova/+spec/remove-deprecated-filters now to track it in either case for xena | |
| 18:51:14 | sean-k-mooney | i dont know if ill get to it before the ptg but ill see if i can get around to it tomorrow | |
| 18:51:17 | dansmith | okay I'd probably argue we don't need a spec for this.. assume you're just planning a bp? | |
| 18:51:30 | sean-k-mooney | oh ya planning a specless blueprint | |
| 18:51:34 | dansmith | ack | |
| 18:52:05 | sean-k-mooney | i just want something to track it in launchpad and a bug felt weird | |
| 23:53:41 | yonglihe | review request: Repropose smartnic support spec: https://review.opendev.org/c/openstack/nova-specs/+/783632 | |
| #openstack-nova - 2021-04-13 | |||
| 01:43:09 | openstackgerrit | Merged openstack/nova master: Neutron fixture: don't clobber profile and vif_details if empty https://review.opendev.org/c/openstack/nova/+/783385 | |
| 04:10:35 | openstackgerrit | Merged openstack/nova stable/victoria: Fix the vGPU dynamic options race https://review.opendev.org/c/openstack/nova/+/784907 | |
| 06:45:16 | slaweq | gibi and other nova cores: hi, can You take a look at https://review.opendev.org/c/openstack/nova/+/783275 ? thx in advance | |
| 07:16:00 | Luzi | lyarwood, are backports to stein still valid? asking for this one: https://review.opendev.org/c/openstack/nova/+/783199 | |
| 08:33:40 | openstackgerrit | zitoun proposed openstack/nova master: Explaining when a base image is considered unused to avoid confusion why some images aren't deleted. https://review.opendev.org/c/openstack/nova/+/786016 | |
| 09:00:33 | rpittau | sean-k-mooney: good morning! did the discussion on grenade from yesterday bring to any solution? | |
| 09:53:39 | openstackgerrit | Elod Illes proposed openstack/nova stable/train: libvirt: Increase incremental and max sleep time during device detach https://review.opendev.org/c/openstack/nova/+/757307 | |
| 10:51:28 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: libvirt: Log exception when unable to import rbd or rados https://review.opendev.org/c/openstack/nova/+/758240 | |
| 11:16:50 | lyarwood | Luzi: sorry missed this earlier, yes stable/stein is still open | |
| 11:16:56 | lyarwood | looking at https://review.opendev.org/c/openstack/nova/+/783199 | |
| 11:17:14 | lyarwood | ack'd | |
| 12:25:06 | openstackgerrit | Merged openstack/nova stable/stein: Correctly disable greendns https://review.opendev.org/c/openstack/nova/+/784581 | |
| 12:55:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add test coverage for security group checking https://review.opendev.org/c/openstack/nova/+/786044 | |
| 14:11:19 | openstackgerrit | zitoun proposed openstack/nova master: line limited to 80 chars https://review.opendev.org/c/openstack/nova/+/786057 | |
| 14:23:26 | openstackgerrit | zitoun proposed openstack/nova master: Explaining when a base image is considered unused to avoid confusion why some images aren't deleted. https://review.opendev.org/c/openstack/nova/+/786059 | |
| 14:48:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: QoS minimum guaranteed packet rate https://review.opendev.org/c/openstack/nova-specs/+/785014 | |
| 15:24:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Update min supported service version for Xena. https://review.opendev.org/c/openstack/nova/+/782171 | |
| 15:32:46 | bauzas | gibi: why are you holding https://review.opendev.org/c/openstack/nova/+/782171 ? | |
| 15:32:58 | bauzas | the master branch is already Xena | |
| 15:33:24 | bauzas | just in case the service version is updated for Wallaby ? | |
| 15:33:56 | gibi | bauzas: in the unlikely event that we got a last minute critical problem that need to be fixed with a service version bump before the W release goes out tomorrow | |
| 15:34:03 | bauzas | kk | |
| 15:34:10 | gibi | it is really unlikely | |
| 15:34:28 | gibi | but it is cheap to hold it for an extra day | |
| 15:34:50 | gibi | same with the db schema backport placeholders | |
| 15:34:51 | bauzas | gibi: I just reviewed it ,) | |
| 15:34:55 | gibi | thanks | |
| 15:35:08 | bauzas | gibi: which change for the db schema ? | |
| 15:35:28 | gibi | yours https://review.opendev.org/c/openstack/nova/+/778923 | |
| 15:36:08 | bauzas | ah k | |
| 15:36:24 | gibi | :) | |
| 15:43:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Change error code when vDPA is unsupported https://review.opendev.org/c/openstack/nova-specs/+/781259 | |
| 16:23:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document options for remaining nova-* commands https://review.opendev.org/c/openstack/nova/+/726195 | |
| 16:23:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Populate "See Also" section with meaningful links https://review.opendev.org/c/openstack/nova/+/729917 | |
| 16:23:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add man pages for 'nova-policy' https://review.opendev.org/c/openstack/nova/+/729918 | |
| 17:08:15 | openstackgerrit | Merged openstack/nova stable/stein: Add config parameter 'live_migration_scheme' to live migration with tls guide https://review.opendev.org/c/openstack/nova/+/783199 | |
| 23:06:49 | guilhermesp | hey there! quick question: if we, in any case, do a `virsh undefine <guest>` and then `openstack server reboot --hard <id>`, is the guest going to be recreated? | |
| #openstack-nova - 2021-04-14 | |||
| 00:55:47 | melwitt | guilhermesp: you can just do the openstack server reboot --hard to regenerate the guest xml | |
| 00:58:32 | guilhermesp | indeed! thanks melwitt | |
| 00:59:51 | melwitt | don't think you needed the undefine but I've been wrong before | |
| 02:26:02 | guilhermesp | melwitt: i'm my case ( an openstack-helm deployment ) my nova compute pod wasnt starting for some reason after a power shutdown. All guests were present on the node but in shutoff state and refusing to start, causing the compute node to crash loop and never be UP | |
| 02:26:02 | guilhermesp | melwitt: i'm my case ( an openstack-helm deployment ) my nova compute pod wasnt starting for some reason after a power shutdown. All guests were present on the node but in shutoff state and refusing to start, causing the compute node to crash loop and never be UP | |
| 02:27:31 | guilhermesp | so using cli wasnt an option... after undefine all guests that the pod was able to start the compute and things got back to normal :) ( guests were recreated ofc ) | |
| 02:27:31 | guilhermesp | so using cli wasnt an option... after undefine all guests that the pod was able to start the compute and things got back to normal :) ( guests were recreated ofc ) | |
| 06:47:10 | openstackgerrit | zitoun proposed openstack/nova master: Explaining when a base image is considered unused to avoid confusion why some images aren't deleted. https://review.opendev.org/c/openstack/nova/+/786059 | |
| 06:47:10 | openstackgerrit | zitoun proposed openstack/nova master: Explaining when a base image is considered unused to avoid confusion why some images aren't deleted. https://review.opendev.org/c/openstack/nova/+/786059 | |
| 09:08:10 | hemanth_n | sean-k-mooney: hi, this is pending final review for a long time https://review.opendev.org/c/openstack/nova/+/761824 (rocky backport), this is not urgent so please review only when you get some time.. thanks | |
| 09:08:10 | hemanth_n | sean-k-mooney: hi, this is pending final review for a long time https://review.opendev.org/c/openstack/nova/+/761824 (rocky backport), this is not urgent so please review only when you get some time.. thanks | |
| 09:51:23 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add man pages for 'nova-policy' https://review.opendev.org/c/openstack/nova/+/729918 | |
| 10:30:28 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Change error code when vDPA is unsupported https://review.opendev.org/c/openstack/nova-specs/+/781259 | |
| 10:30:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Change error code when vDPA is unsupported https://review.opendev.org/c/openstack/nova-specs/+/781259 | |
| 10:54:48 | openstackgerrit | Merged openstack/nova-specs master: Change error code when vDPA is unsupported https://review.opendev.org/c/openstack/nova-specs/+/781259 | |
| 10:54:48 | openstackgerrit | Merged openstack/nova-specs master: Change error code when vDPA is unsupported https://review.opendev.org/c/openstack/nova-specs/+/781259 | |
| 11:04:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document location of nova.conf files https://review.opendev.org/c/openstack/nova/+/786202 | |
| 11:55:49 | zigo | Hi. Could we get reviews on that trivial doc (config file help) patch? https://review.opendev.org/c/openstack/nova/+/786059 | |
| 11:55:49 | zigo | Hi. Could we get reviews on that trivial doc (config file help) patch? https://review.opendev.org/c/openstack/nova/+/786059 | |
| 12:02:43 | gibi | zigo: done | |
| 12:02:43 | gibi | zigo: done | |
| 12:02:51 | zigo | Thanks. | |
| 12:02:51 | zigo | Thanks. | |