| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-26 | |||
| 12:35:37 | sean-k-mooney | shoudl not be use in image meta | |
| 12:35:47 | sean-k-mooney | only the flavor can allow it | |
| 12:37:05 | sean-k-mooney | https://github.com/openstack/glance/blob/master/etc/metadefs/compute-libvirt-image.json#L54-L59 is the only image metadata value | |
| 12:38:15 | kashyap | sean-k-mooney: You mean "hw_rng:allowed" can only be used by extra_spec and not image_meta? | |
| 12:38:21 | sean-k-mooney | yes | |
| 12:38:42 | sean-k-mooney | that was a desgin chocie | |
| 12:39:09 | sean-k-mooney | because we used to use /dev/random not /dev/urandom as you know | |
| 12:39:17 | sean-k-mooney | there were concerns about running out of entropy | |
| 12:39:26 | kashyap | sean-k-mooney: Wait. What you're pointing to is different: "hw_rng_model" --> this is useless now. | |
| 12:39:30 | sean-k-mooney | so it was an admin only extra spec | |
| 12:39:38 | sean-k-mooney | which defaut to false | |
| 12:39:59 | kashyap | sean-k-mooney: Okay ... so it's not a "bug" to not have it via image_meta | |
| 12:40:25 | sean-k-mooney | right it would be a bug to use it in image meta but the fact its not there is not | |
| 12:40:47 | sean-k-mooney | hw_rng_model is pretty useless not too yes | |
| 12:41:03 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L387-L394 | |
| 12:41:21 | sean-k-mooney | kashyap: but as you said we should not remove/deprecate it yet ^ | |
| 12:41:38 | kashyap | sean-k-mooney: You mean "as I said" in the commit message? :) | |
| 12:41:43 | sean-k-mooney | unless that comment you worte is also incorect | |
| 12:42:18 | kashyap | sean-k-mooney: No; it's not incorrect. I also wrote this in the commit message of the patch that introduced it: | |
| 12:42:21 | kashyap | - The 'hw_rng_model' image metadata property is now rendered | |
| 12:42:24 | kashyap | (temporarily) useless -- as it's not used anywhere outside the | |
| 12:42:26 | kashyap | _add_rng_device() method. But we don't want to deprecate it yet, as | |
| 12:42:29 | kashyap | we may extend it (see code comment for details); docucment that. | |
| 12:42:30 | kashyap | So we wan to keep it. | |
| 12:42:47 | sean-k-mooney | well there too but i was not reading the comit message | |
| 12:43:13 | sean-k-mooney | i rember this form when the rng supprot was first beign added | |
| 12:43:15 | kashyap | Righ; I wrote the code comment in image_meta.py | |
| 12:58:53 | openstackgerrit | Balazs Gibizer proposed openstack/osc-placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781894 | |
| 13:02:22 | openstackgerrit | Balazs Gibizer proposed openstack/osc-placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781894 | |
| 13:14:05 | dansmith | gibi: ah, based on the time, it must have been the last one before I went to bed, cool | |
| 13:19:27 | gibi | dansmith: yepp you almost saw the patch landing | |
| 13:19:30 | gibi | :) | |
| 13:21:36 | dansmith | well, sorry | |
| 13:22:54 | gibi | no worries. I'm glad you pushed the patch forwatrd | |
| 13:40:19 | openstackgerrit | Merged openstack/placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/placement/+/783234 | |
| 14:04:43 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/nova/+/783218 | |
| 14:10:28 | gibi | sean-k-mooney: could you please hit this two automatic os-vif patches https://review.opendev.org/c/openstack/os-vif/+/781891 ? | |
| 14:17:50 | openstackgerrit | Merged openstack/os-vif master: Update master for stable/wallaby https://review.opendev.org/c/openstack/os-vif/+/781890 | |
| 14:22:34 | openstackgerrit | Merged openstack/placement stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/placement/+/783232 | |
| 14:22:57 | openstackgerrit | Merged openstack/placement stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/placement/+/783233 | |
| 14:23:18 | openstackgerrit | Merged openstack/placement master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/placement/+/783235 | |
| 14:23:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/nova/+/783218 | |
| 14:34:04 | sean-k-mooney | gibi: ill take a look now | |
| 14:34:26 | sean-k-mooney | gibi: a gmann has don it alredy | |
| 14:34:28 | gibi | sean-k-mooney: thanks | |
| 14:34:51 | gibi | ohh | |
| 14:35:03 | sean-k-mooney | gmann++ | |
| 14:35:15 | gibi | thanks then | |
| 15:08:12 | artom | sean-k-mooney, hey, in https://review.opendev.org/c/openstack/nova/+/783084/1/nova/tests/functional/libvirt/test_pci_sriov_servers.py#382 when you say it's a side effect of our Neutron fixture, what did you mean? | |
| 15:08:36 | artom | Btw, that should have been WIP :P | |
| 15:08:48 | artom | I'm just starting to explore wth's going on | |
| 15:08:52 | sean-k-mooney | i mean that in reality you will not get that key error | |
| 15:09:06 | sean-k-mooney | the pci_slot key will be set in the profile | |
| 15:09:12 | sean-k-mooney | it just will have the wrong value | |
| 15:09:22 | sean-k-mooney | so your test is failing but not for the correct reason | |
| 15:09:49 | sean-k-mooney | did you see my top level comment | |
| 15:09:57 | artom | sean-k-mooney, right, so... 1. what bit in the fixture isn't like reality? and 2. dvd seems to have gotten the same keyerror here: https://bugzilla.redhat.com/show_bug.cgi?id=1767797#c17 | |
| 15:09:59 | sean-k-mooney | i suggested how to write the test diffeerntly | |
| 15:09:59 | openstack | bugzilla.redhat.com bug 1767797 in openstack-nova "When unshelving an SR-IOV instance, the binding profile isn't reclaimed or rescheduled, and this might cause PCI-PT conflicts" [High,Assigned] - Assigned to alifshit | |
| 15:10:49 | artom | sean-k-mooney, yeah, I actually started like that, and then went back because... well, I wasn't thinking straight. Lemme do it "properly", and upload that I find | |
| 15:11:12 | sean-k-mooney | i think that was self inflicted | |
| 15:11:19 | sean-k-mooney | you can actully unshleve i hvae tested that | |
| 15:11:47 | sean-k-mooney | so the nasty part of this bug is it appears to work but its subtely broken | |
| 15:11:54 | valleedelisle | sean-k-mooney, can we unshelve on a host with the same pci device in use? | |
| 15:12:07 | artom | valleedelisle, oh that's your upstream nick | |
| 15:12:09 | valleedelisle | valleedelisle, I think that the point of that bz is the pci device not being re-calculated | |
| 15:12:16 | valleedelisle | yeah dvd is already in use hehe | |
| 15:12:17 | sean-k-mooney | valleedelisle: no that will cause the libvirt error in the upstream bug | |
| 15:12:30 | sean-k-mooney | libvirt/qemu will cay the device is already in use | |
| 15:12:38 | sean-k-mooney | but if the pci device is not in use then yes | |
| 15:12:46 | artom | valleedelisle, 'dvd :No such nick/channel' | |
| 15:12:49 | valleedelisle | sean-k-mooney, yeah but shouldn't we recalculate pci device ? | |
| 15:12:55 | valleedelisle | artom, it's registered | |
| 15:12:57 | sean-k-mooney | we do | |
| 15:13:02 | artom | Bleah :( | |
| 15:13:03 | sean-k-mooney | and we claim it in the db | |
| 15:13:10 | sean-k-mooney | we just dont update the port profile | |
| 15:13:18 | sean-k-mooney | which is the bug | |
| 15:13:22 | valleedelisle | ack | |
| 15:13:58 | sean-k-mooney | i repodcued the bug manually on my sriov hardware at home and confirmed that i just did not have time to work on a fix a the time | |
| 15:15:49 | openstackgerrit | Merged openstack/nova master: Update master for stable/wallaby https://review.opendev.org/c/openstack/nova/+/783217 | |
| 15:39:01 | artom | sean-k-mooney, btw, in order to actually write the unshelve func test properly, I need to fix the Neutron fixture to go further than that KeyError | |
| 15:46:00 | gibi | sean-k-mooney: you will probably like this https://storyboard.openstack.org/#!/story/2008764 | |
| 15:46:26 | sean-k-mooney | gibi: well its on story borad but lets see | |
| 15:46:45 | sean-k-mooney | oh ya i think it has uses | |
| 15:47:22 | sean-k-mooney | ya preventing loops and orpans is something we woudl have to do | |
| 15:47:32 | sean-k-mooney | to mantain the DAG stucture | |
| 15:47:36 | gibi | sean-k-mooney: how can we make orphans? | |
| 15:47:48 | gibi | sean-k-mooney: loop check is already implemented | |
| 15:47:51 | sean-k-mooney | settign parent to None | |
| 15:48:04 | gibi | that does not orphan things that creates a new root provider | |
| 15:48:05 | sean-k-mooney | or a rp that does not exist | |
| 15:48:16 | sean-k-mooney | well it would be a root provider yes | |
| 15:48:22 | gibi | yeah, non existing RP needs to be rejected (an rejected already) | |
| 15:48:31 | sean-k-mooney | but if you did that to your bandwith RPs it woudl be kind of broken | |
| 15:48:51 | gibi | broken from nova an neutron perspective but not from placement perspective | |
| 15:48:55 | sean-k-mooney | yep i just commenting on jays comment you copied | |
| 15:49:01 | sean-k-mooney | well the TODO | |
| 15:49:12 | gibi | placement does not know the intention of the clients | |
| 15:49:13 | sean-k-mooney | gibi: yep it would be a logic error | |