Earlier  
Posted Nick Remark
#openstack-nova - 2021-03-19
14:34:49 gibi jkulik: no objection. If pathces are proposed against osc-placement to add support for the newer versions then please ping me and I will try to review them
14:34:51 viks____ Also if we rescue instance, it asks to set a password, but that also does not work? how to make rescue password work?
14:34:56 stephenfin jkulik: I can't think of one, no
14:35:14 stephenfin We probably have just been forgetting to bump things like we do in novaclient
14:35:34 jkulik ok. I'll propose a patch for the latest versions.
14:35:46 stephenfin jkulik: With that said, adding e.g. 1.29 to that list doesn't really do anything new
14:35:58 stephenfin Unless you implement the functionality of that microversion
14:36:07 jkulik stephenfin: it actually does
14:36:20 jkulik it allows me to query allocation candidates that are in trees
14:36:39 jkulik before, I don't get anything returned. with 1.29, I get the providers like I got on queens btw.
14:36:40 stephenfin Doesn't that require changes to the client?
14:36:50 stephenfin I assume the output from the server is different?
14:37:26 jkulik hm ... looks the same to me. we still have queens around and I compared the output right now.
14:37:49 jkulik having the rocky code-base and an api-version below 1.29 returns nothing anymore.
14:39:42 jkulik https://docs.openstack.org/placement/latest/placement-api-microversion-history.html#support-allocation-candidates-with-nested-resource-providers
14:40:57 jkulik we could™ extend osc-placement to show the new "parent_provider_uuid" and "root_provider_uuid"
14:43:02 gibi jkulik: I think you are correct. the two new things is are those^^ attributesd in the a_c response
14:43:12 gibi the rest is just logic change in the placement server
14:43:24 gibi but no structural change in the input or output
14:51:57 jkulik gibi, stephenfin https://review.opendev.org/c/openstack/osc-placement/+/781749
14:52:52 stephenfin +2 from me
14:55:06 gibi stephenfin: jkulik: gerrit now showed that there is already a patch for 1.29 and it is more widespread change that adds mutliple things that is missing from the client like support for 1.25 adding granular request https://review.opendev.org/c/openstack/osc-placement/+/696251
14:55:46 stephenfin I saw that conflict and skipped over it once I saw 1.25 in the commit message
14:55:49 stephenfin I can review that now
14:56:11 gibi jkulik: do you also need support for 1.25 and so on?
14:57:03 jkulik gibi: 1.26 would be nice, yes
14:58:25 jkulik shall I abandon my request in favor of the exiting one?
15:02:33 gibi I think https://review.opendev.org/c/openstack/osc-placement/+/696251 would be better as it is a more complete solution than just enabling 1.29
15:02:39 stephenfin agreed
15:05:00 jkulik I agree. abandoned my change.
15:23:20 kashyap stephenfin: I blame you for my slow-gaining rST obsession. In my reviews in libvirt rST docs upstream, I began typing out little rST tweaks they could do :D
15:23:42 stephenfin Good :) It's got a learning curve but it is very powerful stuff
15:24:00 stephenfin especially when you introduce extensions
15:24:47 kashyap stephenfin: Yeah, I'm nowhere near your ability to spot all rST problems from a mile away...but still, now I feel like I should tackle this 8000+ line doc
15:24:50 kashyap stephenfin: While you're here:
15:25:23 kashyap stephenfin: Say, a project prefers at most 80 cols of text width. Do you care to adjust pre-formatted and tables which overflow 80 cols?
15:26:20 stephenfin I try to wrap e.g. commands in code-blocks, but only because they don't wrap very well in PDF output
15:26:35 stephenfin but obviously you can't do that for source code snippets
15:26:39 kashyap Right
15:26:54 kashyap stephenfin: A libvirt dev was asking me would you _do_ anything about it
15:26:59 stephenfin Also, you can unusually replace literal tables with e.g. the '.. list-table' directive
15:27:23 kashyap (Where "it" == long code snippets; or other similar pre-formatted stuff)
15:27:24 stephenfin It's not as nice to read in the source, but it's far simpler to prepare and the output is identical
15:27:37 kashyap stephenfin: Ah, nice
15:27:49 stephenfin I'd keep those things as-is, personally
15:27:53 kashyap stephenfin: I didn't know the ".. list-table" directive. Do we have an example of it in our docs?
15:28:02 kashyap stephenfin: Okay, that's what I thought. It's less work too
15:28:20 stephenfin loads of examples, yes
15:28:30 stephenfin doc/source/cli/nova-manage.rst for one
15:29:18 kashyap stephenfin: Thanks. And speaking of extensions, what extensions are recommended? Even if it's your subjective list
15:29:51 stephenfin That's entirely doc specific
15:30:28 stephenfin We use a load of custom ones for things like autodocumenting oslo.policy and oslo.config code that wouldn't make sense outside of OpenStack
15:30:58 kashyap stephenfin: Ah, okay. I'll be modest and fix the obvious stuff for libvirt. I'm just adjusting some secure boot docs in libvirt, hence this chatter here
15:31:01 stephenfin Once you start needing to cross-reference project-unique things or auto-generate some kind of docs, this stuff starts becoming useful
15:31:33 kashyap They recently big-bang convereted HTML to rST an 8000-line file (this one, which we commonly refer to: https://libvirt.org/formatdomain.html)
15:32:00 kashyap With `pandoc`: https://gitlab.com/pipo.sk/libvirt/-/commit/81e494bb5a3c442e875996beaed972904323d3cb
15:32:20 kashyap Ignore the silly GitLab thing in the commit message. It converted :anchor: to ⚓ emoji :D
15:39:33 stephenfin gibi: melwitt: You think we can go ahead with https://review.opendev.org/c/openstack/osc-placement/+/743976 now?
15:39:34 stephenfin I just got asked "why doesn't 'openstack resource provider inventory list' show usage" downstream and was like, aha, I'm not crazy!
15:42:22 jkulik stephenfin: can you elaborate on that?
15:42:34 stephenfin jkulik: On that patch?
15:42:43 jkulik stephenfin: on not showing usage
15:42:56 openstackgerrit Merged openstack/osc-placement master: Support granular allocation candidate list https://review.opendev.org/c/openstack/osc-placement/+/696251
15:43:12 stephenfin oh, 'openstack resource provider inventory list' shows total available inventory for a resource provider
15:43:20 stephenfin but it doesn't include usage information
15:43:34 jkulik yes. we built our on little command to also see the usage next to it
15:43:39 jkulik why isn't that included?
15:43:42 stephenfin to get that, you need to use a separate command, 'openstack resource provider usage show'
15:43:53 stephenfin jkulik: That's my argument: it should be :)
15:43:59 jkulik oh :D
15:44:08 jkulik I read your message wrong :D
15:44:15 stephenfin So I'm adding it there and proposing we eventually deprecated the separate usage command
15:44:26 stephenfin *deprecate
15:45:02 jkulik should just have clicked the review link, thanks m)
16:02:04 gibi stephenfin: I have to get back to this on Monday
16:04:08 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/778885
16:04:08 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Add nova-live-migration-ceph job https://review.opendev.org/c/openstack/nova/+/768466
16:04:09 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Remove nova-dsvm-multinode-base https://review.opendev.org/c/openstack/nova/+/778908
16:04:10 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Create and use nova-libvirt-irrelevant-files https://review.opendev.org/c/openstack/nova/+/778909
16:46:15 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP zuul: Create and use nova-libvirt-irrelevant-files https://review.opendev.org/c/openstack/nova/+/778909
16:46:15 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Remove nova-dsvm-multinode-base https://review.opendev.org/c/openstack/nova/+/778908
17:48:43 openstackgerrit Merged openstack/nova stable/victoria: libvirt: Use specific user when probing encrypted rbd disks during extend https://review.opendev.org/c/openstack/nova/+/773443
17:49:40 openstackgerrit Merged openstack/nova master: doc: mark the max microversion for wallaby https://review.opendev.org/c/openstack/nova/+/780401
19:02:44 openstackgerrit Merged openstack/nova master: releasenotes: Fix typo https://review.opendev.org/c/openstack/nova/+/781725
19:48:07 openstackgerrit OpenStack Release Bot proposed openstack/os-vif stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/os-vif/+/781888
19:48:12 openstackgerrit OpenStack Release Bot proposed openstack/os-vif stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/os-vif/+/781889
19:48:27 openstackgerrit OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/wallaby https://review.opendev.org/c/openstack/os-vif/+/781890
19:48:32 openstackgerrit OpenStack Release Bot proposed openstack/os-vif master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/os-vif/+/781891
19:48:48 openstackgerrit OpenStack Release Bot proposed openstack/osc-placement stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781892
19:48:52 openstackgerrit OpenStack Release Bot proposed openstack/osc-placement stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781893
19:48:56 openstackgerrit OpenStack Release Bot proposed openstack/osc-placement master: Update master for stable/wallaby https://review.opendev.org/c/openstack/osc-placement/+/781894
19:49:21 openstackgerrit OpenStack Release Bot proposed openstack/python-novaclient stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/python-novaclient/+/781895
19:49:29 openstackgerrit OpenStack Release Bot proposed openstack/python-novaclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/python-novaclient/+/781896
19:49:39 openstackgerrit OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/wallaby https://review.opendev.org/c/openstack/python-novaclient/+/781897
19:49:43 openstackgerrit OpenStack Release Bot proposed openstack/python-novaclient master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/python-novaclient/+/781898
#openstack-nova - 2021-03-20
01:57:58 openstackgerrit Merged openstack/python-novaclient master: Use well named anchor into the microversion history https://review.opendev.org/c/openstack/python-novaclient/+/781484
01:58:01 openstackgerrit Merged openstack/python-novaclient master: Update master for stable/wallaby https://review.opendev.org/c/openstack/python-novaclient/+/781897
06:44:01 openstackgerrit Merged openstack/python-novaclient master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/python-novaclient/+/781898
10:27:41 openstackgerrit Merged openstack/nova master: api: Block unsupported actions with vDPA https://review.opendev.org/c/openstack/nova/+/780333
10:39:42 openstackgerrit Merged openstack/nova master: tests: Add functional test for vDPA device https://review.opendev.org/c/openstack/nova/+/780112

Earlier   Later