| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-18 | |||
| 09:45:26 | stephenfin | I think so too. I thought there was an explicit "the server understands this request but can't service it" code, but I can't find one | |
| 09:45:47 | stephenfin | Sounds good. I'll propose a spec update on the assumption that we're going with HTTP 409. I can update if gmann talks us around | |
| 09:47:53 | lyarwood | sounds good | |
| 09:47:57 | lyarwood | ops snap | |
| 09:48:09 | lyarwood | stephenfin: how's the hangover btw? | |
| 09:48:39 | stephenfin | from all the pints in the pubs I wasn't allowed into? | |
| 09:48:40 | stephenfin | :) | |
| 09:49:26 | lyarwood | stephenfin: fair point, I did stumble across this yesterday and suddenly wanted a pint https://soundsofthepub.com/ | |
| 09:50:39 | lyarwood | 24 days until beer gardens open | |
| 09:50:43 | lyarwood | and I bet it rains, all day. | |
| 09:50:45 | stephenfin | hahaha | |
| 09:50:49 | stephenfin | nice one | |
| 09:51:20 | gibi | stephenfin, lyarwood: yeah, as I said before I have no hard opininon. And also nova is not consistent about such error code so nothing to force ourselves into. | |
| 09:51:40 | kashyap | lyarwood: What do you mean 24 days? Is it some UK deadline? | |
| 09:51:48 | kashyap | Morning, BTW | |
| 09:51:49 | lyarwood | kashyap: yes | |
| 09:52:09 | kashyap | lyarwood: Sweet. On rain ... paradise is a well-watered garden, ya know :D | |
| 09:52:12 | lyarwood | kashyap: beer gardens (pubs) and outside dining allowed in ~24 days. | |
| 09:52:18 | gibi | stephenfin: I think the understood, but cannot support is a 500 code like 501 | |
| 09:52:27 | kashyap | lyarwood: Nice. I thought I'll slowly go senile and die before seeing any of these | |
| 09:52:53 | kashyap | (I mean, they're making similar murmurs here too of opening by 01May) | |
| 09:54:49 | gibi | stephenfin: but the https://specs.openstack.org/openstack/api-wg/guidelines/http/response-codes.html#use-of-501-not-implemented disagrees with me about 501 | |
| 09:56:18 | gibi | if we follow that guide ^^ then we should use 400 | |
| 09:56:42 | gibi | but I agree to wait for gmann to get up and make a decision | |
| 10:00:46 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: DNM - Testing glance backports to fix bug #1919993 https://review.opendev.org/c/openstack/nova/+/781237 | |
| 10:00:48 | openstack | bug 1919993 in Glance "test_image_web_download_import_with_bad_url failing on stable/victoria" [Undecided,New] https://launchpad.net/bugs/1919993 | |
| 10:01:17 | lyarwood | dansmith: ^ re https://bugs.launchpad.net/glance/+bug/1919993 and https://review.opendev.org/c/openstack/glance/+/781236 - when you're online could you take a swing at these glance backports to unblock stable/victoria for Nova? | |
| 10:01:36 | lyarwood | branchless tempest ftw once again | |
| 10:07:11 | lyarwood | elod: ^ btw, that should unblock stable/victoria, not sure if you're in stable-glance-core via stable-maint? | |
| 10:15:18 | elod | lyarwood: yes I have +2 right there as well, I'll review it now | |
| 10:18:40 | lyarwood | thanks | |
| 10:20:14 | gibi | stephenfin: I need your sphinx experties in https://review.opendev.org/c/openstack/nova/+/780401/1/nova/api/openstack/compute/rest_api_version_history.rst#1145 | |
| 10:20:35 | gibi | stephenfin: the current way is fine by me but maybe there is other possibilities | |
| 10:23:03 | stephenfin | gibi: That works, but we could/should probably just update the release note in novaclient | |
| 10:23:28 | stephenfin | i.e. add https://review.opendev.org/c/openstack/nova/+/780401/1/nova/api/openstack/compute/rest_api_version_history.rst#392 | |
| 10:24:44 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: trivial: Fix spelling, formatting of vDPA spec https://review.opendev.org/c/openstack/nova-specs/+/781260 | |
| 10:24:44 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Change error code when vDPA is unsupported https://review.opendev.org/c/openstack/nova-specs/+/781259 | |
| 10:26:02 | gibi | stephenfin: so have an explicit well named anchor in the nova doc and update the novaclient reno to refer to the well named anchor? | |
| 10:26:14 | stephenfin | I think that would be a better approach, yes | |
| 10:26:20 | stephenfin | Personally | |
| 10:26:47 | gibi | OK lets do that | |
| 10:26:57 | gibi | I can propose the fix | |
| 10:27:05 | stephenfin | Sounds good. Happy to review | |
| 10:27:09 | gibi | cool | |
| 11:10:30 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Reject requests to commit intermediary snapshot of an inactive instance https://review.opendev.org/c/openstack/nova/+/781138 | |
| 11:12:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Delegate OVS plug to os-vif https://review.opendev.org/c/openstack/nova/+/602432 | |
| 11:20:23 | lyarwood | gibi: mind if I add a cinder cross project session in the PTG pad, have a topic. | |
| 11:20:38 | gibi | lyarwood: please do | |
| 11:28:10 | lyarwood | done thanks | |
| 11:50:07 | lyarwood | elod: https://review.opendev.org/c/openstack/nova/+/758733/ is ready for review btw | |
| 12:31:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add a resource limits guide https://review.opendev.org/c/openstack/nova/+/781433 | |
| 12:31:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove duplicate TPM extra spec info https://review.opendev.org/c/openstack/nova/+/781435 | |
| 12:31:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add a real-time guide https://review.opendev.org/c/openstack/nova/+/781434 | |
| 12:31:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add SEV guide https://review.opendev.org/c/openstack/nova/+/781437 | |
| 12:31:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Remove duplicated PCI passthrough extra spec info https://review.opendev.org/c/openstack/nova/+/781436 | |
| 12:31:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Change formatting of hypervisor config guides https://review.opendev.org/c/openstack/nova/+/781439 | |
| 12:31:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add CPU models guide https://review.opendev.org/c/openstack/nova/+/781438 | |
| 12:31:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add libvirt misc doc https://review.opendev.org/c/openstack/nova/+/781440 | |
| 12:31:29 | stephenfin | Some good docs there. I was holding off until after feature freeze ^ | |
| 12:36:45 | kashyap | stephenfin: Cool; a separate CPU models guide is good; instead of that info buried elsewhere | |
| 12:37:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add image metadata property reference guide https://review.opendev.org/c/openstack/nova/+/756867 | |
| 12:37:10 | kashyap | stephenfin: We could also link docs like these into it: something like "See also: https://docs.openstack.org/nova/latest/admin/mitigation-for-Intel-MDS-security-flaws.html" | |
| 12:37:31 | kashyap | If only to make it more discoverable; /me adds a note in the review | |
| 12:37:40 | stephenfin | I'll probably move that doc into the cpu-models one (with a redirect) at some point | |
| 12:37:59 | stephenfin | It would fit nicely in there as a concrete use case | |
| 12:39:31 | kashyap | Yeah. Idd | |
| 12:41:24 | kashyap | stephenfin: There's additional things we can mention on 'host-model' that can be very useful for people to know _why_ we default to it | |
| 12:49:19 | elod | lyarwood: +2+W'd | |
| 13:02:39 | lyarwood | elod: thanks | |
| 13:10:27 | kashyap | stephenfin: Sorry for the wall o' text here, but I hope some useful crumbs in there: https://review.opendev.org/c/openstack/nova/+/781438 | |
| 13:13:20 | kashyap | s/hope/hope there are/ | |
| 13:23:26 | dansmith | lyarwood: ugh, yeah sorry.. fix a bug, get punished I guess | |
| 13:24:13 | dansmith | lyarwood: assuming that's going to affect all older branches, we may want to make tempest only rely on that behavior for new enough glance | |
| 13:28:09 | gibi | stephenfin: it seems '.. _2.88 microversion:' does not generate an anchor but '.. _microversion 2.88:' does generate 'microversion-2-88' as an anchor | |
| 13:28:53 | gibi | so I'm wondering how our other anchors starting with numbers in the microversion history document ever worked | |
| 13:28:59 | lyarwood | dansmith: no issues, no idea about the glance jobs but Nova only started testing that in stable/victoria so the backports should be enough for us | |
| 13:29:40 | dansmith | lyarwood: ahh, right | |
| 13:31:21 | dansmith | man gerrit is s l o w today | |
| 13:56:52 | openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Use well named anchor into the microversion history https://review.opendev.org/c/openstack/python-novaclient/+/781484 | |
| 14:03:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: doc: mark the max microversion for wallaby https://review.opendev.org/c/openstack/nova/+/780401 | |
| 14:04:51 | gibi | stephenfin: ^^ your turn | |
| 14:07:28 | mnaser | weirdest thing ever | |
| 14:07:46 | mnaser | we changed the db for a system (literally, just mysqldump | mysql) | |
| 14:07:59 | mnaser | and now, limit= from nova api is always returning exactly half of what we are supposed to get | |
| 14:08:16 | mnaser | https://www.irccloud.com/pastebin/BEMJghhM/ | |
| 14:08:20 | mnaser | anyone seen something like this? o_O | |
| 14:18:12 | openstackgerrit | Lee Yarwood proposed openstack/nova master: block_device: Use initialize APIs to refresh when reported as idempotent https://review.opendev.org/c/openstack/nova/+/720769 | |
| 14:25:54 | gmann | lyarwood: gibi stephenfin IMO, 400 is right one and if we change existing 409/403 to 400 it does not require microversion bump. | |
| 14:44:18 | lyarwood | mnaser: odd running master? | |
| 14:44:47 | lyarwood | stephenfin: ^ are you cool with gmann's suggestion? | |
| 14:57:07 | dansmith | elod: [07:53:00] <abhishekk> lyarwood, dansmith may be Elod will approve the patches while I am gone | |
| 14:57:16 | elod | lyarwood: I think https://review.opendev.org/781493 needs to be squashed with https://review.opendev.org/781426/ otherwise gate won't pass, am I right? | |
| 14:57:52 | elod | dansmith: sure | |
| 14:57:55 | abhishekk | elod, right | |
| 14:58:34 | lyarwood | jebus | |
| 14:58:36 | lyarwood | okay sorry | |
| 14:58:36 | abhishekk | dansmith, so to avoid all this dance, can we just drop lower constraints job? | |
| 14:59:01 | dansmith | abhishekk: yeah, for sure, I was just trying to avoid the dance since it was supposed to all be headed to the gate | |
| 14:59:13 | dansmith | abhishekk: but if you want to push that in underneath (or get lyarwood to do it) that's fine with me | |
| 14:59:16 | abhishekk | and sqash the dropping of nova-ceph job with action wrapper | |