Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-03-12
18:54:45 sean-k-mooney i ocationllay modify this but its really annoying that we have PF and type-
18:54:50 sean-k-mooney type-PF
18:55:14 sean-k-mooney ya im going to sotp using the pci_info as the name
18:55:31 stephenfin I'd rather we moved away from passing the type and instead had e.g. 'add_pci_device', 'add_pci_device_with_mdev', 'add_pci_device_with_vf' etc. helpers
18:55:38 stephenfin that would be clearer IMO
18:55:52 sean-k-mooney ya
18:56:17 stephenfin That would be a good follow-up, but I think my changes there are already too invasive without tacking on even more
18:56:41 sean-k-mooney althoguh i still want fakelibvirt.HostPCIDevicesInfo( num_pci=0, num_pfs=1, num_vfs=0, num_vdpa=2)
18:57:00 stephenfin by all means, go for it. It should be relatively easy to add
18:57:17 stephenfin I only had one caller so I stuck with explicit
18:57:24 stephenfin if we've got more, we can make it more generic
18:58:28 sean-k-mooney im finding it quite hard to follow what that test is doing if im honest
18:59:05 sean-k-mooney espcailly the self.stub_out(
18:59:07 sean-k-mooney 'nova.virt.libvirt.guest.Guest.create',
18:59:39 stephenfin that's a pattern I copied from the SR-IOV test. I want to inspect what the XML being used to create the guest is
18:59:41 sean-k-mooney is vdpa_info.add_device(f'vdpa_vdpa{idx}', idx, vf)
18:59:42 stephenfin so I'm spying on it
18:59:46 sean-k-mooney what makes it a vdpa device
19:00:11 sean-k-mooney right but i dont think we should be doing that in this test
19:00:22 sean-k-mooney or at least i dont think my test should do that
19:00:35 stephenfin no, yours shouldn't. We only need it once
19:00:44 stephenfin it's just to make sure everything is wired up correctly
19:00:47 sean-k-mooney right i would not have put that in the basic create
19:00:58 sean-k-mooney i would have put that explicy in its own test
19:01:24 stephenfin I didn't want two tests that did the exact same thing and only changed what they were looking at
19:01:59 stephenfin If I had another test for e.g. resizing, I wouldn't bother with this
19:02:18 stephenfin I just want to make sure what we're handing off to neutron and libvirt is correct
19:02:51 stephenfin i.e. black box testing, looking at only at the inputs and outputs (from the nova service to other services)
19:03:07 sean-k-mooney yep i know anyway i think i have figured out what is needed an not thanks
19:03:31 sean-k-mooney stephenfin: it just a case of you are asserting two thing in one test and i was trying to fiture out what was the minium i needed
19:03:43 stephenfin gotcha
19:03:53 stephenfin yeah, to recap you don't need the libvirt spy
19:04:02 stephenfin nor do you really need to look at the neutron requests
19:04:11 stephenfin or PCI device counts in the DB
19:04:37 stephenfin just create a port, create a server, and then try your various and see that they're correctly rejects, I guess?
19:04:44 sean-k-mooney and i should not need to pass the libvirt and qemu version explictly either
19:05:01 sean-k-mooney since you are passing the default
19:05:20 stephenfin you will
19:05:32 stephenfin the FakeLibvirtFixture defaults to the minimums
19:05:34 stephenfin which are too low
19:05:40 sean-k-mooney oh ok
19:05:53 stephenfin sean-k-mooney: btw, the 'test_vtpm' module has examples you can use
19:05:54 sean-k-mooney i though it was max
19:06:04 stephenfin e.g. test_live_migrate_server
19:06:08 stephenfin test_shelve_server
19:06:11 sean-k-mooney i have some working
19:06:13 sean-k-mooney ya
19:06:20 sean-k-mooney ill take a look
19:06:20 stephenfin great :)
19:06:30 sean-k-mooney im trying to use/extend the integrated helpers
19:06:55 sean-k-mooney so added attach/detach interface with calls to the fakenotifier to wait
19:07:10 sean-k-mooney that kind of thing
19:07:21 sean-k-mooney for shelve i think we already have that there
19:14:55 openstackgerrit Merged openstack/nova stable/ussuri: Prevent archiving of pci_devices records because of 'instance_uuid' https://review.opendev.org/c/openstack/nova/+/760977
19:16:28 gibi stephenfin: thanks for the update of the vdpa func test, it looks good now
19:22:46 sean-k-mooney stephenfin: what did you fix between v3 and v4
19:23:01 sean-k-mooney i might need to rebase my patch to pick up the v4 changs
19:25:59 sean-k-mooney ya you changed enough that i should
19:28:13 sean-k-mooney one thing that is confusiton me is i am seeing different pci address then i expect to see
20:04:45 sean-k-mooney .... stephenfin before i rebased on v4 of you patch my 2 test passed and my first test failed
20:04:58 sean-k-mooney after my first test passed and my second test failed
20:05:22 sean-k-mooney and i did not notice fo the last hour and was editing the wrong thing
20:38:07 openstackgerrit Merged openstack/nova master: apidb: Compact Train database migrations https://review.opendev.org/c/openstack/nova/+/771420
20:47:23 lbragstad sean-k-mooney gmann not that you need to do anything with this now, but i had to start getting ideas on paper from today's discussion - https://etherpad.opendev.org/p/consuming-system-scope
20:47:54 sean-k-mooney cool ill book mark it
20:48:42 sean-k-mooney one thing i tought about afer is when issuing the token we might also want to list the roles
20:49:11 sean-k-mooney so you had openstack token issue --os-cloud system-admin --for-project foo
20:49:47 sean-k-mooney but we might want "openstack token issue --os-cloud system-admin --for-project foo --roles project_member"
20:49:52 openstackgerrit Merged openstack/nova stable/train: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/c/openstack/nova/+/768736
21:20:11 sean-k-mooney ok i now have the block patch written jsut need to add doc and releasenote then ill push
21:45:14 openstackgerrit sean mooney proposed openstack/nova master: block unsupported actions with vdpa. https://review.opendev.org/c/openstack/nova/+/780333
21:45:42 sean-k-mooney gibi: stephenfin ^ proably need more work but that is basicly the blocker patch
21:46:16 sean-k-mooney i think i might be able to rewrite it to use the network info cache in some cases instead
21:46:39 sean-k-mooney of calling neutron but that is more or less what it will look like
22:42:10 openstackgerrit Merged openstack/nova master: Add generate schemas tool https://review.opendev.org/c/openstack/nova/+/769796
23:21:43 openstackgerrit melanie witt proposed openstack/nova master: Add --task-log option to nova-manage db archive_deleted_rows https://review.opendev.org/c/openstack/nova/+/780395
23:38:35 openstackgerrit Merged openstack/nova master: nova-next: Start testing the q35 machine type https://review.opendev.org/c/openstack/nova/+/708701
#openstack-nova - 2021-03-13
01:27:17 openstackgerrit Merged openstack/nova stable/stein: [stable-only] gate: Pin CEPH_RELEASE to nautilus in LM hook https://review.opendev.org/c/openstack/nova/+/780277
01:30:33 openstackgerrit Merged openstack/nova master: Support per port numa policies with SR-IOV https://review.opendev.org/c/openstack/nova/+/773792
03:24:44 openstackgerrit Takashi Natsume proposed openstack/nova master: doc: mark the max microversion for wallaby https://review.opendev.org/c/openstack/nova/+/780401
04:36:18 openstackgerrit Takashi Natsume proposed openstack/nova-specs master: Create specs directory for Xena https://review.opendev.org/c/openstack/nova-specs/+/772878
05:57:20 kinpaa12389 Hi,
05:57:21 kinpaa12389 1. Added [service_user] and all fields in nova.conf as https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html
05:57:21 kinpaa12389 i am testing service_token between nova and glance on devstack.
05:57:22 kinpaa12389 3. Add delay in snapshot as https://review.opendev.org/c/openstack/nova/+/419666
05:57:22 kinpaa12389 2. Add expiration 100 seconds in keystone.conf [token] and restart keystone, nova, glance
05:57:23 kinpaa12389 ideally it should have taken service_token and continue/finish the snapshot operation. Am I missing something ?
05:57:23 kinpaa12389 4. trigger snapshot.. it fails with 401 after expiration seconds.
12:28:23 openstackgerrit Merged openstack/nova master: trivial: Clarify purpose of 'Host.supports_*' properties https://review.opendev.org/c/openstack/nova/+/778739
13:51:30 gmann lbragstad: thanks
15:48:03 openstackgerrit Merged openstack/nova stable/train: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761811
#openstack-nova - 2021-03-14
06:19:39 openstackgerrit Merged openstack/nova master: add constants for vnic type vdpa https://review.opendev.org/c/openstack/nova/+/770474
08:13:52 openstackgerrit Merged openstack/nova master: hardware: Start parsing 'os_secure_boot' https://review.opendev.org/c/openstack/nova/+/682628
08:14:25 openstackgerrit Merged openstack/nova master: compute: Report COMPUTE_SECURITY_UEFI_SECURE_BOOT https://review.opendev.org/c/openstack/nova/+/776679
08:15:03 openstackgerrit Merged openstack/nova master: scheduler: Translate secure boot requests to trait https://review.opendev.org/c/openstack/nova/+/776680
08:22:49 openstackgerrit Merged openstack/nova master: libvirt: Add parsing of firmware metadata files https://review.opendev.org/c/openstack/nova/+/779302
08:23:22 openstackgerrit Merged openstack/nova master: libvirt: Move some host arch checks to guest checks https://review.opendev.org/c/openstack/nova/+/779303
15:31:07 openstackgerrit Merged openstack/nova master: objects: Add 'VDPA' to 'PciDeviceType' https://review.opendev.org/c/openstack/nova/+/777481
#openstack-nova - 2021-03-15
01:57:33 openstackgerrit Jinsheng Zhang proposed openstack/nova stable/victoria: Add nova support ironic instance port group network metadata https://review.opendev.org/c/openstack/nova/+/780209
02:17:10 openstackgerrit Wenping Song proposed openstack/nova-specs master: Trival change: correct some nits https://review.opendev.org/c/openstack/nova-specs/+/780443

Earlier   Later