| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-03-12 | |||
| 08:59:15 | gibi | there is no DB/RPC change in vdpa or smartnic | |
| 08:59:20 | gibi | but both changes ovo | |
| 08:59:23 | bauzas | because merging those while we're already close to RC1 means that if we see problems, it could be difficult to just revert the changes | |
| 08:59:24 | gibi | smartnic adds field https://review.opendev.org/c/openstack/nova/+/771363/13/nova/objects/network_request.py | |
| 08:59:36 | bauzas | /o\ | |
| 08:59:52 | bauzas | if we merge those ovo changes today, I'm OK | |
| 09:00:05 | bauzas | what I'm not OK it to merge ovo changes like next week | |
| 09:00:08 | gibi | vdpa adds enum value https://review.opendev.org/c/openstack/nova/+/777481/8/nova/objects/fields.py | |
| 09:00:19 | bauzas | I know for vdpa | |
| 09:00:20 | gibi | bauzas: fair point | |
| 09:00:36 | gibi | then I think smartnic needs to be deferred | |
| 09:00:56 | gibi | I'm not happy to merge the ovo change today without seeing the whole series coming together | |
| 09:00:57 | bauzas | again, it's more a question about how to be reverting if we merge them next week and we see problems | |
| 09:01:09 | bauzas | gibi: yeah :( | |
| 09:01:20 | gibi | and you have a valid point about the risk in ovo | |
| 09:01:43 | bauzas | but for example, I could be OK with merging a new config option on Monday | |
| 09:01:58 | bauzas | Wednesday is late | |
| 09:02:11 | bauzas | but, at least if we see problems, it's simple to just revert | |
| 09:02:35 | bauzas | people could tell it's simple to revert ovo changes | |
| 09:02:50 | bauzas | but the problem here is that master is down then | |
| 09:03:07 | gibi | what do you mean by down? | |
| 09:08:43 | bauzas | gibi: I mean that if we would want to revert an ovo patch, this would mean that we absolutely need to be sure that we don't merge other ovo changes after this one | |
| 09:08:55 | bauzas | we can pretend it never existed but there is a high risk of tangling | |
| 09:09:19 | bauzas | hence me being super conservative about such changes to be merged while we're so close from RC1 | |
| 09:09:45 | gibi | tanglig by having two different ovo object with the same version | |
| 09:12:23 | gibi | yonglihe: bauzas had a point above about the ovo change being risky close to RC1 and I think his point is valid. I'm affraid we have to defer the smartnic series to X | |
| 09:12:40 | gibi | alex_xu: ^^ | |
| 09:12:52 | bauzas | I'll review the series this morning | |
| 09:13:02 | bauzas | it's fair to look at the change before cutting the rope | |
| 09:13:39 | yonglihe | gibi: got, that's reasonable. likely, we could merge smartnic in very ealry stage of X | |
| 09:13:49 | bauzas | but since I haven't reviewed the spec, it'll take time for me to load the context in mind :) | |
| 09:14:18 | bauzas | yonglihe: if you don't mind then, I can propose sponsoring your series as soon as we branch RC1 | |
| 09:14:29 | bauzas | which will be in two weeks | |
| 09:15:16 | yonglihe | bauzas, sure, that sound good for me, and thanks. | |
| 09:15:24 | gibi | yonglihe: sorry for the bad news and thanks for the flexibility | |
| 09:15:35 | bauzas | yonglihe: thanks for your understanding :( | |
| 09:15:35 | gibi | I will summarize this to the ML | |
| 09:15:59 | bauzas | yonglihe: ping me once RC1 is cut, and then I'll review your patches | |
| 09:16:43 | yonglihe | bauzas: we all responsible to minimize risk, that's right way to go. thanks. | |
| 09:17:08 | bauzas | yonglihe: don't forget to ping me as I could forget | |
| 09:18:31 | yonglihe | bauzas, sure. | |
| 09:19:04 | openstackgerrit | Wenping Song proposed openstack/nova master: Remove get_device_profile_request_groups function in cyborg.py https://review.opendev.org/c/openstack/nova/+/780206 | |
| 09:29:51 | alex_xu | gibi: bauzas got it, thanks for the review and feedback anyway | |
| 09:44:22 | openstackgerrit | Jinsheng Zhang proposed openstack/nova stable/victoria: Add nova support ironic instance port group network metadata https://review.opendev.org/c/openstack/nova/+/780209 | |
| 10:00:15 | gibi | sean-k-mooney, stephenfin: I finished reading the new patches of vdpa. Left some small comments and question inline. I will be off for a while between 13:00 - 16:00 CET but I will review whatever needs to be reviewed. just let me know | |
| 10:03:33 | stephenfin | gibi: ack, working on a functional tests atm to prove it out before giving my final review | |
| 10:03:41 | gibi | stephenfin: cool | |
| 10:16:43 | bauzas | I can cycle a bit of reviews for the vdpa stuff | |
| 10:30:42 | gibi | bauzas: your help might be needed on the functional test patch as that is written by stephenfin so he cannot +2 it | |
| 10:33:53 | sean-k-mooney | o/ | |
| 10:34:09 | sean-k-mooney | thanks ill take a look and answer them as best i can shortly | |
| 10:34:44 | gibi | sean-k-mooney: \o | |
| 10:37:02 | sean-k-mooney | ah damb it i dropt the vdpa path in the wrong patch | |
| 10:37:33 | sean-k-mooney | ya that should be in the previous one i did it at the end and did an interactive rebase to suash it in but obvioulsy picked the wong patch | |
| 10:40:48 | sean-k-mooney | gibi: while im fixing the pep8 issue in pci: Add vDPA vnic to PCI request mapping and filtering ill fix the odd indenting too | |
| 10:40:58 | gibi | cool | |
| 10:41:53 | sean-k-mooney | one thing im debating is shoudl i rebase this seriese on top of the pci/socket and port numa changes or wait until we get to the final functional patch which is the only one that is in conflict with those | |
| 10:43:17 | gibi | I think you can wait until the functional patch | |
| 10:44:14 | sean-k-mooney | cool that avoid needing to rebase the frist couple of patches | |
| 10:44:37 | sean-k-mooney | lyarwood: have your devstack changes merged for the cinder issue | |
| 10:45:00 | sean-k-mooney | the tgtadm WWN issue | |
| 10:46:26 | lyarwood | sean-k-mooney: no, they wanted to hold off until after FF as we don't have any proof that it is causing the detach issue | |
| 10:47:02 | sean-k-mooney | ok | |
| 10:47:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode https://review.opendev.org/c/openstack/nova/+/778885 | |
| 10:47:42 | lyarwood | one more change to go and I'll try to reproduce the issue in your cloud again | |
| 10:48:01 | lyarwood | I *think* I fsck'd up earlier in the week and forgot to upgrade my tempest.conf to allow volume attached LM | |
| 10:48:09 | lyarwood | update* | |
| 10:50:46 | sean-k-mooney | ah. well in the last 7 days we have hit the detach issue 275 times although my current match seems to trigger 3 times on each event os closer to 90 failed jobs | |
| 10:51:29 | sean-k-mooney | we also seam to have some other libvirt issue too that i have seen intermitently but i cant recall it now | |
| 11:15:04 | openstackgerrit | Lee Yarwood proposed openstack/nova master: block_device: Use initialize APIs to refresh when reported as idempotent https://review.opendev.org/c/openstack/nova/+/720769 | |
| 11:17:47 | lyarwood | elod: https://review.opendev.org/c/openstack/nova/+/780014 - thoughts on this? | |
| 11:24:04 | elod | lyarwood: oh, sorry, I've lost it in my TODOs :S +2+W'd | |
| 11:24:36 | lyarwood | elod: np thanks | |
| 11:31:31 | openstackgerrit | sean mooney proposed openstack/nova stable/train: add functional regression test for bug #1888395 https://review.opendev.org/c/openstack/nova/+/759533 | |
| 11:31:34 | openstack | bug 1888395 in OpenStack Compute (nova) train "live migration of a vm using the single port binding work flow is broken in train as a result of the introduction of sriov live migration" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to Billy Olsen (billy-olsen) | |
| 11:58:47 | stephenfin | functional tests works. hurrah | |
| 11:58:50 | stephenfin | sean-k-mooney: are you addressing gibi's nits and mine or will I? | |
| 11:59:01 | stephenfin | I don't mind. I have to push the functional test anyway | |
| 11:59:14 | sean-k-mooney | i am yes | |
| 11:59:18 | stephenfin | okay, great | |
| 11:59:42 | sean-k-mooney | if you push with -R it wont rebase my stuff and i can cherry pick in your test when i push | |
| 11:59:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: tests: Make mdev stubs work like vDPA https://review.opendev.org/c/openstack/nova/+/780234 | |
| 11:59:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add functional test for vDPA device https://review.opendev.org/c/openstack/nova/+/780112 | |
| 11:59:57 | stephenfin | already done ^ | |
| 12:00:04 | sean-k-mooney | yep | |
| 12:00:06 | stephenfin | bauzas: gibi: ^ | |
| 12:00:09 | gibi | ack | |
| 12:34:10 | sean-k-mooney | so artoms socket patch hit the block detach failure again https://review.opendev.org/c/openstack/nova/+/772779 | |
| 12:34:32 | sean-k-mooney | this time in the gate queue | |
| 12:34:53 | sean-k-mooney | shoudl we keep rechecking this or do we have another solution? | |
| 12:35:16 | lyarwood | looks like there are other failures in there as well | |
| 12:35:22 | lyarwood | nova-next failed with a ssh timeout | |
| 12:35:40 | sean-k-mooney | yep but the same tests passed in check | |
| 12:35:50 | lyarwood | nova-ceph-multistore failed with a volume backup failure | |
| 12:35:50 | sean-k-mooney | granted its mixed with other patchs in gate | |
| 12:36:05 | sean-k-mooney | but i dont think those failures are related | |
| 12:36:44 | sean-k-mooney | i think all the failures it hit are intermitent failure in the jobs | |
| 12:36:47 | lyarwood | nova-live-migration failed but not because of a detach issue AFAICT | |
| 12:36:54 | lyarwood | the instance just didn't migrate | |
| 12:37:51 | sean-k-mooney | glanceclient.exc.HTTPNotFound: HTTP 404 Not Found: No image found with ID 202b34e0-db15-437c-8a19-ab391dfcf6e0 | |