Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-03-01
16:23:59 openstackgerrit Merged openstack/nova master: apidb: Compact Mitaka database migrations https://review.opendev.org/c/openstack/nova/+/759400
16:24:13 stephenfin sean-k-mooney: Can you live with the bit of duplication in this? https://review.opendev.org/c/openstack/nova/+/775415/ I'd like to keep that series moving forward /o\
16:33:12 openstackgerrit Balazs Gibizer proposed openstack/nova stable/pike: rt: Make resource tracker always invoking get_inventory() https://review.opendev.org/c/openstack/nova/+/778014
16:34:30 openstackgerrit Balazs Gibizer proposed openstack/nova stable/pike: Update resources once in update_available_resource https://review.opendev.org/c/openstack/nova/+/612295
16:37:59 sean-k-mooney stephenfin: ill take a look after the meeting
16:53:30 dansmith bauzas: the compute 6.0 patch is failing almost everything because of versioning stuff. You have a TODO to fix that in the commit message, but are you looking for help via review or are we still waiting for you to work those issues out first?
16:59:11 bauzas dansmith: I'm just fixing a lot of them ;)
16:59:29 bauzas I saw a lot of stuff I forgot to modify
16:59:45 bauzas hopefully, will upload this in 1 hour
16:59:52 dansmith bauzas: ah cool
17:02:10 bauzas dansmith: thanks for having looked at it btw. ;)
17:02:34 dansmith bauzas: np, I said I would help, so definitely hold me to it.. just didn't want to duplicate effort
17:03:35 bauzas dansmith: thanks
17:23:15 openstackgerrit Balazs Gibizer proposed openstack/nova stable/ussuri: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/773932
17:23:50 gibi melwitt: fixed the functional test in the backport ^^
17:26:45 sean-k-mooney stephenfin: oh it was the os.name poison change
17:26:51 stephenfin yarp
17:27:06 sean-k-mooney stephenfin: since other dont think its worth effort to remove the duplication fair ennough i guess.
17:27:29 sean-k-mooney i would still like it to be done but i can live with it so ill change to +1 after i quickly re review
17:27:52 sean-k-mooney i dont think you have changed anything since i last looked have you
17:28:01 stephenfin nope, same as previously
17:29:28 sean-k-mooney ya just rebases ok +1'd
17:29:36 stephenfin ta
17:30:21 sean-k-mooney stephenfin: bauzas suggested thinking about putting it in the integreated_helpers module as a followup
17:30:29 sean-k-mooney not sure if you saw that
17:31:11 sean-k-mooney i also think there is a tone of stuff in the chain after it and its not worth the gate time to respin now
17:31:37 stephenfin I did. Given this thing is only used in unit tests, I don't think we want to be dragging in stuff from the functional test module
17:31:39 stephenfin I can reply now
17:32:05 sean-k-mooney fair we import things form unti in fucntional
17:32:22 sean-k-mooney so better to avoid possible curcular deps between the too
17:32:54 stephenfin yeah, if I had my way we wouldn't even import from unit inside functional tests
17:33:01 stephenfin fixtures should be a separate submodule
17:33:05 stephenfin but that's a lot of work
17:44:33 lyarwood stephenfin: so I'm stuck on https://review.opendev.org/c/openstack/nova/+/673790/14/nova/virt/libvirt/host.py#1235
17:45:26 lyarwood stephenfin: what's the reasoning behind flagging support based *any* machine type indicating support and not the default or requested machine type?
17:45:43 lyarwood stephenfin: I guess they all support UEFI and secure boot for x86_64
17:46:00 lyarwood stephenfin: but couldn't that cause issues on other arches if it isn't the case
17:50:24 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: Bump the Compute RPC API to version 6.0 https://review.opendev.org/c/openstack/nova/+/761452
17:50:45 bauzas dansmith: hopefully this latest rev should fix all the func/unit tests $
17:50:48 bauzas ^
17:51:08 bauzas now, I need to see what tempest and grenade tell me
18:11:12 dansmith bauzas: ack cool, will circle back later to see how zuul has judged you :P
18:11:35 sean-k-mooney fyi ptg dates are April 19-23, 2021
18:12:35 sean-k-mooney gibi: i assume you will create a poll for times and such at some point but the foundation just annouched that and registrations aree now open
18:15:34 bauzas a bit sad to have again a virtual DFG instead of a face-to-face :(
18:16:29 sean-k-mooney well in that time frame realsiticlaly vactiontion wont be to the point that people could attend
18:16:34 sean-k-mooney maybe in november
18:16:50 sean-k-mooney or whenever the next one would be.
18:26:19 sean-k-mooney stephenfin: by the way yes it would be nice if the fixtures were in a sperate module not under the unit or functional test but also yes that is a lot of work
18:30:16 atmark Hello, I have 2x NVMes that has same vendor and product id and I want to setup PCI passthrough. How can I separate the two NVMes in the alias? I currently have the following config
18:30:22 atmark passthrough_whitelist = {"vendor_id":"1344", "product_id":"51b2"}
18:30:27 atmark alias = {"vendor_id":"1344", "product_id":"51b2", "device_type":"type-PCI", "name":"nvme"}
18:32:14 sean-k-mooney atmark: technially that is not supported. or rather nova pci passtough is only supported when passing through stateless devices
18:32:20 sean-k-mooney NVME ssd are state full
18:32:32 sean-k-mooney its technically a security risk to sue them with nvme devices
18:32:48 sean-k-mooney since we will not ease the data when the vm is deleted
18:33:32 sean-k-mooney atmark: with that said that whitelist and alias should work
18:34:16 sean-k-mooney can you explain what you mean by seperate the two in teh whitelist
18:34:42 sean-k-mooney are you trying to tag the devices in some way and match the alias to a specific device on the host via that tag
18:36:04 sean-k-mooney there is no supported way to do that im affraid
18:36:18 sean-k-mooney the schema for the alias is https://github.com/openstack/nova/blob/master/nova/pci/request.py#L64-L97
18:36:35 sean-k-mooney it does not have a way to match on the extra tags you can add in the pci whitelist
18:36:51 sean-k-mooney nor can it match on a pci address or similar and that is by design
18:37:40 sean-k-mooney the alias is not allowed to be host specific
18:37:52 atmark Yup. I want to tag devices that match alias to a specific device on a host. I have these NVMes which has same product and vendor ID
18:38:00 atmark IOMMU Group 30 41:00.0 Non-Volatile memory controller [0108]: Micron Technology Inc Device [1344:51b2] (rev 02)
18:38:01 atmark IOMMU Group 30 42:00.0 Non-Volatile memory controller [0108]: Micron Technology Inc Device [1344:51b2] (rev 02)
18:38:31 sean-k-mooney atmark: ya so we do not supprot that. i can see aded support for matching on the extra tags in teh pci whitelist
18:38:40 sean-k-mooney but not specificly based on address
18:39:02 sean-k-mooney atmark: the alais has to be the same on all compute nodes and the contolers so we need a layer of indriection
18:39:37 sean-k-mooney this would be a new feature unfortunetly and it still would not adress the fact that stateful devices are unsupported both upstream and downstream
18:40:08 sean-k-mooney stateful devices can work but there is no tenant isolation
19:00:09 atmark Thanks for the info. I will consider other solution then.
19:44:07 openstackgerrit Merged openstack/nova master: tests: Add 'nova.virt.libvirt.utils.get_arch' stub to fixture https://review.opendev.org/c/openstack/nova/+/774904
19:44:41 openstackgerrit Merged openstack/nova master: tests: Remove unnecessary mock https://review.opendev.org/c/openstack/nova/+/774905
20:48:23 openstackgerrit sean mooney proposed openstack/nova master: extend pci dev_type for vdpa https://review.opendev.org/c/openstack/nova/+/777481
20:48:23 openstackgerrit sean mooney proposed openstack/nova master: [WIP] add vdpa nodedev parsing and interface config gen https://review.opendev.org/c/openstack/nova/+/770532
20:48:24 openstackgerrit sean mooney proposed openstack/nova master: [WIP] add vdpa device detection https://review.opendev.org/c/openstack/nova/+/770533
21:29:22 openstackgerrit Merged openstack/nova master: scheduler: Add 'socket' PCI NUMA affinity policy trait https://review.opendev.org/c/openstack/nova/+/772749
21:30:36 openstackgerrit Sylvain Bauza proposed openstack/nova master: Bump the Compute RPC API to version 6.0 https://review.opendev.org/c/openstack/nova/+/761452
21:32:58 bauzas dansmith: zuul gave me a -1 but I think i fixed the latest issues ^
21:34:03 bauzas just a concern about a grenade multihost job giving me a -1 but when looking at the logs, it's about a timeout
22:11:05 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-manage: Add libvirt update_machine_type command https://review.opendev.org/c/openstack/nova/+/774896
22:11:06 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-status: Add hw_machine_type check for libvirt instances https://review.opendev.org/c/openstack/nova/+/770643
22:11:06 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-manage: Add libvirt list_unset_machine_type command https://review.opendev.org/c/openstack/nova/+/774897
22:11:07 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Add a config update workflow test for [libvirt]hw_machine_type https://review.opendev.org/c/openstack/nova/+/774898
22:11:09 openstackgerrit Lee Yarwood proposed openstack/nova master: docs: Add admin docs for configuring and updating machine types https://review.opendev.org/c/openstack/nova/+/774899
22:42:20 lyarwood sean-k-mooney: https://zuul.opendev.org/t/openstack/build/ba023003dd21428b95f27a200437dfd8/log/job-output.txt / https://review.opendev.org/c/openstack/os-vif/+/765419/6 ; had a quick look at the os-vif backports, did you plan on fixing the LC job?
22:42:44 lyarwood sean-k-mooney: if not I could take a look after M3
#openstack-nova - 2021-03-02
00:53:48 openstackgerrit Merged openstack/nova master: libvirt: Define and emit DeviceRemovedEvent and DeviceRemovalFailedEvent https://review.opendev.org/c/openstack/nova/+/749929
02:03:04 openstackgerrit Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336
02:06:42 openstackgerrit Merged openstack/nova master: libvirt: Remove dead code https://review.opendev.org/c/openstack/nova/+/772928
02:17:29 openstackgerrit Merged openstack/nova master: rpc: Rework 'get_notifier', 'wrap_exception' https://review.opendev.org/c/openstack/nova/+/741663
07:25:46 openstackgerrit Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362
07:25:47 openstackgerrit Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363
07:25:48 openstackgerrit Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944
07:40:56 openstackgerrit Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944
08:03:21 openstackgerrit Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362
08:03:23 openstackgerrit Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363
08:03:25 openstackgerrit Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944

Earlier   Later