| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-24 | |||
| 10:52:28 | gibi | Fl1nt: I'm happy that I could help | |
| 10:53:04 | belmoreira | one line patch review: https://review.opendev.org/c/openstack/nova/+/776428 Let me know if this makes sense. Created a lot of confusion some time ago :) | |
| 10:54:35 | gibi | belmoreira: make sense to me | |
| 11:39:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add tests for insecure UEFI configuration https://review.opendev.org/c/openstack/nova/+/777367 | |
| 11:39:32 | stephenfin | bauzas: ^ | |
| 11:39:43 | bauzas | ta | |
| 11:39:51 | bauzas | will look | |
| 11:54:52 | gibi | sean-k-mooney: could you take a look on https://review.opendev.org/c/openstack/nova/+/750552 we have +2s from cores, but you had issues with the ipVersion vs ip_version in the spec. The impl goes with ipVersion. Is it a dealbreakre for you? | |
| 11:55:16 | sean-k-mooney | no its not | |
| 11:55:23 | sean-k-mooney | i prefer ip_version | |
| 11:55:28 | sean-k-mooney | but both work | |
| 11:56:05 | gibi | thanks, then I will approve the impl with ipVersion as there was no real preference in the existing attribute names for either ways | |
| 11:56:09 | sean-k-mooney | we coudl fix it with a follow up to the spec or code to bring them in line | |
| 11:56:33 | gibi | as far as I understand there is no definit line | |
| 11:56:34 | gibi | https://review.opendev.org/c/openstack/nova/+/750552/10/nova/virt/libvirt/config.py#3459 | |
| 11:56:56 | sean-k-mooney | i dont think we currently have any 2 word elemnts | |
| 11:57:02 | sean-k-mooney | at least not nova ones | |
| 11:57:30 | gibi | no, not nova ones | |
| 11:57:36 | gibi | but in general | |
| 11:57:50 | sean-k-mooney | well libvirt uses _ | |
| 11:58:07 | sean-k-mooney | <on_reboot>restart</on_reboot> | |
| 11:58:37 | sean-k-mooney | but its a minor nit | |
| 11:59:08 | sean-k-mooney | not a deal breaker i would just prefer to use _ when i extend it with the flavor info next cycle since i never got to it this cycle | |
| 11:59:41 | sean-k-mooney | acutlly it uses both | |
| 12:00:13 | sean-k-mooney | <currentMemory unit='KiB'>1048576</currentMemory> | |
| 12:00:28 | sean-k-mooney | so both are fine lets leave it as is | |
| 12:00:35 | sean-k-mooney | ill comment the same in the bug | |
| 12:00:39 | sean-k-mooney | *patch | |
| 12:02:11 | gibi | thanks | |
| 12:04:50 | sean-k-mooney | done | |
| 12:06:01 | sean-k-mooney | un related to that change but when we use https://www.openstack.org/xmlns/libvirt/nova/1.1 as a namespace url that is actully ment to be a vaild path to the xml schema | |
| 12:06:32 | sean-k-mooney | i dont know if we care to fix that at some point since we dont actully have a schema for the metadta xml elemnet just said i would note that in passing | |
| 12:11:44 | gibi | good point maybe we can fix that next cycle when we extend the schema further | |
| 12:13:07 | sean-k-mooney | ya not sure how we would fix it unless we put it in the docs and linked to the doc site or to the git repo on opendev.org | |
| 12:13:34 | sean-k-mooney | xml parsers can parse without a schema file they just cant validate it | |
| 12:13:41 | sean-k-mooney | well beyond syntax | |
| 12:14:22 | sean-k-mooney | but this is an internal api fro dubuging any way so its only ment to be read by humans not software | |
| 12:14:56 | tosky | hi nova people! It looks like the devstack-plugin-nfs tempest jobs are failing on ussuri only (see the last jobs on https://review.opendev.org/q/project:openstack/devstack-plugin-nfs+status:open ) | |
| 12:15:18 | tosky | whoami-rajat commented on one of the failures, it seems there is something weird on the nova side (please see the last comment here: https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/763516/ ) | |
| 12:15:40 | tosky | are you aware of any NFS-related fix which hasn't been backported yet to ussuri? | |
| 12:15:47 | tosky | or at least can you please take a look? | |
| 12:15:49 | sean-k-mooney | i think lyarwood was tryign to get that to work again | |
| 12:15:56 | lyarwood | it's on my TODO list | |
| 12:16:09 | sean-k-mooney | tosky: we know of nfs related bugs | |
| 12:16:16 | lyarwood | tosky: nothing specific to ussuri btw | |
| 12:16:29 | tosky | right, so this may be another issue? | |
| 12:16:38 | lyarwood | tosky: yeah there are several with this codepath | |
| 12:16:46 | lyarwood | tosky: it's unique to NFS volumes | |
| 12:16:47 | sean-k-mooney | maybe the nfs backend is one of the most problematic we have support for currently | |
| 12:16:50 | lyarwood | tosky: and not maintained | |
| 12:16:54 | tosky | because really -ussuri seems to be consistently failing in the last builds | |
| 12:17:20 | lyarwood | kk well I can't think of anything that has landed since that could cause this tbh | |
| 12:17:35 | lyarwood | could someone write up a bug and I'll take a look early next week? | |
| 12:17:44 | tosky | sure | |
| 12:17:46 | lyarwood | thanks | |
| 12:17:59 | sean-k-mooney | looks like its the volumn snapshot tests that are failing | |
| 12:18:18 | sean-k-mooney | there are issue with snapshots and the nfs backend right | |
| 12:21:36 | sean-k-mooney | it looks like the nfs backend does not supprot snapshots of inuse volumen based on the error | |
| 12:22:57 | lyarwood | new test? | |
| 12:23:19 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/e9e69b9af21c414a83c0437894826178/log/controller/logs/screen-n-cpu.txt#48082 | |
| 12:23:29 | sean-k-mooney | Unknown base file: /opt/stack/data/nova/instances/_base/c4c416ed67a8e3a5f1de44029e480806bb6a55f9 | |
| 12:23:39 | whoami-rajat | sean-k-mooney: nfs driver supports it via blockrebase and blockcommit which is done by nova, but not sure exactly what you mean | |
| 12:24:21 | sean-k-mooney | there is a libviet error with ehcomand | |
| 12:24:39 | sean-k-mooney | libvirt.libvirtError: internal error: qemu block name 'json:{"backing": {"driver": "raw", "file": {"driver": "file", "filename": "/opt/stack/data/nova/mnt/896fb15da6036b68a917322e72ebfe57/volume-3c98d95e-a839-4eaf-ba76-325ed3a3a946"}}, "driver": "qcow2", "file": {"driver": "file", "filename": | |
| 12:24:41 | sean-k-mooney | "/opt/stack/data/nova/mnt/896fb15da6036b68a917322e72ebfe57/volume-3c98d95e-a839-4eaf-ba76-325ed3a3a946.adb8bb67-dfb5-4ac7-8e95-3643f8a0e8ed"}}' doesn't match expected '/opt/stack/data/nova/mnt/896fb15da6036b68a917322e72ebfe57/volume-3c98d95e-a839-4eaf-ba76-325ed3a3a946.adb8bb67-dfb5-4ac7-8e95-3643f8a0e8ed' | |
| 12:27:28 | sean-k-mooney | so the block commit is failing but i think that path comes form cinder? not sure i know this api is slightly weird. | |
| 12:29:06 | sean-k-mooney | its the snapshot delete that looks like its failing | |
| 12:29:08 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/e9e69b9af21c414a83c0437894826178/log/controller/logs/screen-n-cpu.txt#48125 | |
| 12:30:26 | sean-k-mooney | : {'file_to_merge': 'volume-3c98d95e-a839-4eaf-ba76-325ed3a3a946.adb8bb67-dfb5-4ac7-8e95-3643f8a0e8ed', 'merge_target_file': 'volume-3c98d95e-a839-4eaf-ba76-325ed3a3a946', 'type': 'qcow2', 'volume_id': '3c98d95e-a839-4eaf-ba76-325ed3a3a946'} | |
| 12:30:45 | sean-k-mooney | i think file_to_merge and merge_target_file come form cinder | |
| 12:35:06 | sean-k-mooney | tosky: you could poteanally skip that on ussuri temporally i guess if its fine on other brances | |
| 12:35:27 | sean-k-mooney | it might be due to the libvirt version we are using | |
| 12:35:40 | sean-k-mooney | but this does look like there is a real bug | |
| 12:41:41 | openstackgerrit | Merged openstack/nova master: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816 | |
| 12:45:18 | whoami-rajat | lyarwood: sean-k-mooney https://bugs.launchpad.net/nova/+bug/1916750 | |
| 12:45:20 | openstack | Launchpad bug 1916750 in OpenStack Compute (nova) "[gate] devstack-plugin-nfs-tempest-full-ussuri job failing" [Undecided,New] | |
| 12:45:48 | sean-k-mooney | whoami-rajat: thanks | |
| 13:01:53 | tosky | whoami-rajat: thanks | |
| 13:07:47 | gibi | stephenfin, bauzas: I'm +2 through the whole api db compaction series. | |
| 13:10:29 | whoami-rajat | np | |
| 13:17:12 | stephenfin | gibi: \o/ | |
| 13:17:31 | stephenfin | Let me know if I can return the favour. I think I'm on top of most of your work | |
| 13:18:00 | gibi | stephenfin: yes, my only remaning sizeable thing is the device detach series but there I have to do fixes in the last patch | |
| 13:18:12 | sean-k-mooney | stephenfin: not sure if you saw the sqlalchemy migrate thread on the mailing list | |
| 13:18:16 | gibi | fortunatley I'm running out of code to write as the FF closes in, so I can focus on review | |
| 13:18:23 | sean-k-mooney | stephenfin: is you current db compation work just the comparction | |
| 13:18:34 | sean-k-mooney | or will you have swapped nova to almenbic this cycle | |
| 13:18:39 | gibi | just compaction | |
| 13:18:43 | sean-k-mooney | ok | |
| 13:18:56 | sean-k-mooney | since matt left no one has maintained it | |
| 13:19:28 | sean-k-mooney | gibi: so its currenly unmaintained and we need to adress that untill nova nolonger uses it | |
| 13:19:47 | stephenfin | dansmith: If you have time this week, your attention would still be appreciated on the API DB compaction series. My testing methodology was identical to the main DB | |
| 13:19:53 | gibi | sean-k-mooney: I think stephenfin could propose to move to alembic in the next cycle ;) | |
| 13:20:01 | sean-k-mooney | yep | |
| 13:20:03 | stephenfin | sean-k-mooney: I have an alembic migration series locally, but I'm not going to push it until after M3 | |
| 13:20:19 | stephenfin | We have enough work on our plates :) | |
| 13:20:21 | sean-k-mooney | http://lists.openstack.org/pipermail/openstack-discuss/2021-February/020666.html this is the thread | |
| 13:20:39 | sean-k-mooney | stephenfin: i think the issue is oslo db deprectaed support for it | |
| 13:20:45 | stephenfin | I did that | |
| 13:21:04 | sean-k-mooney | ya so some are concerned that its un maintined and that its not deprecated in oslo | |