Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-02-19
17:02:09 bauzas this would give us the list of segments the network relates to
17:02:31 bauzas there is the fields param that does me for free :)
17:02:43 sean-k-mooney true
17:03:05 bauzas so this would actually be a rewrite of get_segment_ids_for_network()
17:03:13 bauzas and I would keep the method
17:03:18 bauzas at least its signature
17:03:28 bauzas tempting
17:03:43 sean-k-mooney so really its just GET /subnet?network_id=<id>&fileds=segment_id
17:03:48 bauzas yup
17:03:53 bauzas gibi: opinions on it ?
17:04:22 sean-k-mooney maybe keep both funciton in neutorn.py then
17:04:35 sean-k-mooney just change the url
17:05:23 bauzas yah
17:06:19 sean-k-mooney ok so you just need to update https://review.opendev.org/c/openstack/nova/+/773976/10/nova/network/neutron.py#3510
17:06:29 sean-k-mooney that sound good to me
17:06:53 sean-k-mooney gibi: that is a really good catch by the way
17:07:55 gibi "GET /subnet?network_id=<id>&fileds=segment_id" looks good to me
17:08:18 bauzas gibi: can you please tell me what gives you the segment_id field on a non-configured subnet ?
17:08:32 bauzas the field is empty or unexisting ?
17:08:46 bauzas the API docs is not describing it
17:09:37 gibi bauzas: trying ...
17:09:43 bauzas thanks
17:09:47 bauzas I really need to get some env
17:10:27 sean-k-mooney http://paste.openstack.org/show/802840/
17:11:37 gibi bauzas: the above GET results in http://paste.openstack.org/show/802841/ if the subnet has a segment_id set
17:11:38 sean-k-mooney so it looks like if the extnsion is not there its an error
17:11:48 gibi bauzas: will check the no segment_id case in a sec
17:11:49 sean-k-mooney but we have the check for that so it should be fine
17:12:06 sean-k-mooney gibi: im expecting an empty list
17:12:42 bauzas sean-k-mooney: your paste probably doesn't have the extension
17:12:45 sean-k-mooney so proably {"subnets":[]}
17:12:53 sean-k-mooney bauzas: it does not
17:13:06 sean-k-mooney bauzas:which is why i said we just need to keep the extension test
17:13:13 sean-k-mooney *check
17:13:21 bauzas sean-k-mooney: yup, I just changed one liner
17:13:29 bauzas ie. the Neutron client call
17:13:34 gibi bauzas: and this is the case when the subnet has no segment_id set http://paste.openstack.org/show/802842/
17:13:59 sean-k-mooney oh its null
17:14:10 sean-k-mooney {"subnets":[{"segment_id":null}]}
17:14:12 bauzas perfect
17:14:23 gibi so you get a list of subnets and for each subnet you get a segment_id which is either null or a uuid
17:14:24 bauzas the client will then return None
17:14:35 bauzas right, it's not a list
17:14:41 openstackgerrit Lee Yarwood proposed openstack/nova master: block_device: Use initialize APIs to refresh when reported as idempotent https://review.opendev.org/c/openstack/nova/+/720769
17:14:50 bauzas because there is a 1:1 mapping segment/subnet
17:14:57 gibi yepp
17:14:58 sean-k-mooney well its a dict os with a list of dicts
17:15:05 bauzas all good, touching my UTs and I'm done
17:15:06 sean-k-mooney one per subnet on the network
17:15:29 bauzas yeah, I also changed the comprehension list
17:15:52 bauzas but we're all good
17:17:18 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove unnecessary mock https://review.opendev.org/c/openstack/nova/+/774905
17:17:18 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add 'nova.virt.libvirt.utils.get_arch' stub to fixture https://review.opendev.org/c/openstack/nova/+/774904
17:17:19 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities https://review.opendev.org/c/openstack/nova/+/673790
17:17:19 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Poison os.uname https://review.opendev.org/c/openstack/nova/+/775415
17:17:20 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add missing type hints https://review.opendev.org/c/openstack/nova/+/775688
17:17:20 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Stop passing around virt_type, caps https://review.opendev.org/c/openstack/nova/+/775689
17:17:22 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Start parsing 'os_secure_boot' https://review.opendev.org/c/openstack/nova/+/682628
17:17:23 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Switch to libvirt's firmware auto-selection https://review.opendev.org/c/openstack/nova/+/775691
17:17:24 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Report secure boot support to scheduler https://review.opendev.org/c/openstack/nova/+/775690
17:17:26 openstackgerrit Stephen Finucane proposed openstack/nova master: compute: Report COMPUTE_SECURITY_UEFI_SECURE_BOOT https://review.opendev.org/c/openstack/nova/+/776679
17:17:26 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add firmware auto-configuration support https://review.opendev.org/c/openstack/nova/+/776678
17:17:27 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Translate secure boot requests to trait https://review.opendev.org/c/openstack/nova/+/776680
17:17:29 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Wire up 'os_secure_boot' property https://review.opendev.org/c/openstack/nova/+/776681
17:17:33 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add functional tests for UEFI, secure boot https://review.opendev.org/c/openstack/nova/+/776682
17:17:39 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove duplicated 'start_compute' helper https://review.opendev.org/c/openstack/nova/+/776683
17:17:43 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Document UEFI secure boot feature https://review.opendev.org/c/openstack/nova/+/776684
17:18:04 stephenfin well gdi, didn't I time that well
17:18:32 bauzas sean-k-mooney: gibi: someone fancy reporting a neutron bug against the segments API ?
17:18:59 bauzas I'm adding a fat comment explaining this is borked and ideally I should mention the bug report
17:19:46 sean-k-mooney bauzas: ya although there wont be a performace hit so less of an issue
17:20:19 stephenfin Anyone want to give me a one line about what I've missed RE: some segment issue?
17:20:24 gibi bauzas, sean-k-mooney: I'm not sure I understand why returning a segment from a network is a bad thing especially as the API is created to list segments per network
17:21:03 gibi stephenfin: routed net patch had issue with collecting segment_ids from neutron
17:21:03 sean-k-mooney stephenfin: /segments?network=<id> does not give you the routed segement for the subnets on the network
17:21:25 sean-k-mooney gibi: the segmentation id is ment to be admin only
17:21:35 gibi bauzas, sean-k-mooney: so I let you report a bug
17:21:45 sean-k-mooney gibi: the provider:segmenat_id that is
17:21:51 stephenfin hmm, so how do we get it? Can we?
17:22:02 stephenfin I'm guessing we need to do the filtering ourselves?
17:22:03 sean-k-mooney stephenfin: ya via the subnets endpoint
17:22:08 stephenfin Ah
17:22:49 openstackgerrit Lee Yarwood proposed openstack/nova master: block_device: Use initialize APIs to refresh when reported as idempotent https://review.opendev.org/c/openstack/nova/+/720769
17:23:00 sean-k-mooney so /subnets?network_id=<id>&fields=segment_id
17:23:51 sean-k-mooney stephenfin: i think we are all good bauzas is updating test now
17:24:00 bauzas I'm 99% done
17:24:05 bauzas just running UTs
17:24:10 bauzas for regression testing
17:24:16 bauzas all good, uploading
17:25:18 bauzas stephenfin: that reminds me, we haven't discussed on the exception handling you'd like
17:25:28 bauzas could you tl;dr your concerns ?N
17:26:22 stephenfin I'd like us to go back to raising a generic NovaException-derived exception, and simply capture/transform that into something scheduler-specific inside the pre-filter
17:27:32 bauzas ack ok
17:28:01 bauzas so, leave the exceptions be neutron-somehow specific and just catch and reraise in the prefilter, gotcha
17:28:08 stephenfin yup, please :)
17:28:14 bauzas I can do it
17:28:34 bauzas whoaw, that's now 2 mins I'm uploading the series
17:28:51 bauzas 800kps up
17:28:58 bauzas kbps even
17:29:30 bauzas with small caps for the 'b'

Earlier   Later