| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-18 | |||
| 15:44:29 | sean-k-mooney | well you did kill the code for xen | |
| 15:44:42 | stephenfin | yes, we had no choice there. The APIs didn't work without it | |
| 15:44:51 | sean-k-mooney | and we have killed the code for nova networks and cells v1 | |
| 15:45:17 | stephenfin | but we never had a release where 2.N still existed but gave different responses to previous releases | |
| 15:45:44 | sean-k-mooney | im not sure about that | |
| 15:46:12 | stephenfin | 2.N should yield consistent behaviour until we reach the point where we can no longer support it, in which case it'll return 404 or 410 for all microversions | |
| 15:46:17 | sean-k-mooney | do we still have the code for the xen specific console server action | |
| 15:46:45 | stephenfin | I think that's a HTTP 410 now | |
| 15:46:51 | stephenfin | Or 404, I don't recall | |
| 15:47:07 | sean-k-mooney | so there is a case where its go. | |
| 15:47:22 | sean-k-mooney | your conserned that we woudl be breaking server cretae for those that use file injection | |
| 15:47:29 | sean-k-mooney | usign the old microverion | |
| 15:47:34 | stephenfin | yeah, exactly | |
| 15:47:47 | sean-k-mooney | right im suggesting its been deprecated for remval since queens | |
| 15:47:51 | sean-k-mooney | and we shoudl actully remove it | |
| 15:48:05 | stephenfin | We don't think anyone was using the Xen stuff, and we know they couldn't use the nova-network stuff | |
| 15:48:19 | stephenfin | You'd only know that if you used a newer microversion though | |
| 15:48:26 | stephenfin | and if you're using OSC, you're probably using 2.1 | |
| 15:48:33 | stephenfin | for now - we're working on it | |
| 15:48:38 | sean-k-mooney | yep probably | |
| 15:48:46 | stephenfin | this really feels like a PTG discussion | |
| 15:48:50 | stephenfin | or at least openstack-discuss | |
| 15:48:56 | sean-k-mooney | well its a long standing public security bug | |
| 15:49:05 | stephenfin | since you and I can't decide this unilaterally | |
| 15:49:06 | sean-k-mooney | we can fix it other ways too | |
| 15:49:28 | stephenfin | yup, aware there are attenuating circumstances here | |
| 15:49:32 | sean-k-mooney | i just dont want us to keep putting of fixing the secuity bug | |
| 15:50:55 | sean-k-mooney | deprecation happend via this spec by the way minimum supported microversion in the distant future. | |
| 15:50:58 | sean-k-mooney | .... | |
| 15:51:03 | sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/deprecate-file-injection.html#rest-api-impact | |
| 15:51:23 | stephenfin | now bumping the API minimum is something I could get behind | |
| 15:51:30 | stephenfin | we're coming close to 3 digit microversions... | |
| 15:51:51 | stephenfin | that's _definitely_ a PTG discussion though :-D | |
| 15:51:51 | sean-k-mooney | yep | |
| 15:51:56 | openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: [OVN] Adapt the live-migration job scripts to work with OVN https://review.opendev.org/c/openstack/nova/+/776419 | |
| 15:51:59 | sean-k-mooney | and we called that out in the spec by the way | |
| 15:52:02 | sean-k-mooney | " The point of this microversion is really to signal that users should not be using this legacy part of the compute API, and to set a timer on when it could be removed if nova ever starts requiring a higher minimum supported microversion in the distant future." | |
| 15:52:46 | sean-k-mooney | gibi: is there an etherpad for the xena ptg? | |
| 15:53:09 | sean-k-mooney | gibi: part of me really wants to declare xena a tech debt removal cycle | |
| 15:54:02 | sean-k-mooney | but i do think discussing raising the min microverion may be somethign we shoudl discuss or a differnt path to removing long deperecated apis | |
| 15:54:16 | gibi | sean-k-mooney: good point I should have start a xena ptg pad | |
| 15:54:40 | sean-k-mooney | gibi: ya that getting worringly close... | |
| 15:55:07 | gibi | sean-k-mooney: I've just read back, if you want to discuss the unembargoed security bug on the meeting then please bring it up :) either in the bug section or in the OpenDiscussion | |
| 15:56:02 | sean-k-mooney | an sure i thin the networking one im goign to fix via other work so ill just add it to the things i test | |
| 15:56:17 | gibi | ok | |
| 16:00:55 | gibi | sean-k-mooney: xena ptg etherpad https://etherpad.opendev.org/p/nova-xena-ptg | |
| 16:01:19 | sean-k-mooney | gibi: thanks im going to try and avoid adding too much to it if i can :) | |
| 16:01:43 | gibi | sean-k-mooney: do not limit yourself, we can always remove things later :) | |
| 16:01:52 | sean-k-mooney | oh you already have the do not translate message nice | |
| 16:02:41 | gibi | carried over from the wallaby pad :) | |
| 16:02:45 | sean-k-mooney | ya i guess i just havent done my onw retro on how things have gone over the last 6-12 monts and what did/didnt get done | |
| 16:03:03 | gibi | sean-k-mooney: btw team meeting is ongoing :) | |
| 16:03:08 | sean-k-mooney | oh ya :) | |
| 16:03:08 | gibi | if you want to mention something | |
| 16:58:07 | sean-k-mooney | actully looks liek we have a few others that were not on the list | |
| 16:58:31 | sean-k-mooney | like https://bugs.launchpad.net/nova/+bug/1861893 | |
| 16:58:32 | openstack | Launchpad bug 1861893 in OpenStack Compute (nova) "os-assisted-volume-snapshots passes unsanitised file path to the libvirt driver" [Medium,Confirmed] | |
| 16:59:08 | sean-k-mooney | we could not actuly exploit ^ so its just a security hardening case | |
| 16:59:29 | openstackgerrit | Vishal Manchanda proposed openstack/nova master: Docs: Correct ``Password injection using the dashboard`` Explanation https://review.opendev.org/c/openstack/nova/+/775084 | |
| 16:59:44 | sean-k-mooney | specificly class c1 "Not considered a practical vulnerability (but some people might assign a CVE for it)" | |
| 17:00:48 | openstack | Launchpad bug 1861893 in OpenStack Compute (nova) "os-assisted-volume-snapshots passes unsanitised file path to the libvirt driver" [Medium,Confirmed] | |
| 17:05:49 | gibi | stephenfin, dansmith: I have extra logs for the slowness of the db migration tests (even after the compaction) https://review.opendev.org/c/openstack/nova/+/775094 This result confirms for me that it is simply an extremely slow test node with noisy neighbors. I have not got new ideas how to move forward with this | |
| 17:13:49 | sean-k-mooney | can we increase the timeout wait again | |
| 17:14:16 | sean-k-mooney | you tweaked it previously if im remebring corectly | |
| 17:14:41 | sean-k-mooney | if its really just a slow node retrying it like the pytest flaky decorator does wont help | |
| 17:15:14 | sean-k-mooney | gibi: alternitivly i dont know if there is a way to do the db walk in multiple tests | |
| 17:15:49 | sean-k-mooney | e.g decompose it to do it in severnal batches of verions over 2+ tests | |
| 17:16:11 | sean-k-mooney | but ya not really sure how to workaroud this | |
| 17:16:46 | sean-k-mooney | at least nothing to adress the underlying issue | |
| 17:16:50 | dansmith | gibi: what provider? | |
| 17:17:30 | dansmith | gibi: tripleo was having some IO problems on a vexx node, but we did a bunch of digging into the node stats and it seemed like it was just too many noisy neighbors | |
| 17:18:36 | dansmith | gibi: oh that's an arm64 run | |
| 17:19:17 | sean-k-mooney | in that case ya | |
| 17:20:03 | sean-k-mooney | so Provider: linaro-us | |
| 17:20:45 | sean-k-mooney | although the py39 verion passed in hlaf the time | |
| 17:21:17 | sean-k-mooney | so its not a genral problem with the provider but there might be too high a contention on some hosts | |
| 17:21:23 | gibi | sean-k-mooney: I can increase the timeout yes | |
| 17:21:41 | gibi | dansmith: I can do some more recheck to get a non arm failure if that helps | |
| 17:22:13 | dansmith | gibi: well, I'm just saying, I don't know much about that environment.. could be raspberry pis and slow SD cards for all I know :P | |
| 17:22:29 | gibi | dansmith: OK :) | |
| 17:22:32 | sean-k-mooney | dansmith: they are realy arm server systems | |
| 17:23:15 | dansmith | sean-k-mooney: I know :P | |
| 17:24:15 | stephenfin | I think they're emulated | |
| 17:24:32 | stephenfin | Assuming it's the same machines that you linked me from the kolla jobs yesterday, sean-k-mooney | |
| 17:24:34 | dansmith | really? I thought these were actual arm boxes | |
| 17:24:35 | sean-k-mooney | dansmith: https://zuul.openstack.org/build/b038b4112ef34b15b885f204da27c808/log/primary/logs/kolla/nova/nova-compute.txt#843 | |
| 17:24:50 | sean-k-mooney | stephenfin: its is and its not emulated | |
| 17:25:18 | sean-k-mooney | well they are vms if that is what you mean | |
| 17:25:44 | stephenfin | I mean it's using <domain>qemu</domain> | |
| 17:25:45 | sean-k-mooney | but this i arm hardware provide by linaro to do real testing on arm | |
| 17:25:49 | stephenfin | not <domain>kvm</domain> | |
| 17:26:03 | stephenfin | so it's entirely software emulation, right? | |
| 17:26:03 | sean-k-mooney | stephenfin: right but thats becasue we disabel nested vert | |
| 17:26:29 | sean-k-mooney | the vms created by it will use qemu without kvm in the kolla job | |
| 17:26:29 | stephenfin | okay, cool, that's all I was saying | |
| 17:26:47 | stephenfin | the PPC jobs you linked are running on bare metal (with KVM) | |
| 17:26:56 | sean-k-mooney | but the vms we are runing the test in are on real arm hardware | |
| 17:27:10 | sean-k-mooney | stephenfin: yep its a third party ci | |
| 17:27:37 | sean-k-mooney | stephenfin: nested vrit was disabled by policy in the first party ci | |
| 17:28:13 | sean-k-mooney | that has been relaxed slightly more recnetly but its still not gernarally avaliable | |