| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-17 | |||
| 18:19:52 | stephenfin | I added the feature to neutronclient. It didn't exist before :) | |
| 18:20:04 | sean-k-mooney | ok well using neutorn clinet more feels liek a regression since eventually we want to remove it | |
| 18:20:05 | stephenfin | Also, moving to sdk is a _lot_ of work. We saw that with the ironic series previously | |
| 18:20:29 | sean-k-mooney | we still use the ironic clinet in places | |
| 18:20:37 | stephenfin | My point exactly :) | |
| 18:20:40 | sean-k-mooney | that was never finsihed | |
| 18:20:49 | stephenfin | Wouldn't the ksa calls be replaced by sdk also? | |
| 18:20:57 | sean-k-mooney | yes | |
| 18:21:13 | stephenfin | Right, so neutronclient gets us simpler code for now, and when we switch we're replacing one thing rather than two | |
| 18:21:22 | sean-k-mooney | but move backward | |
| 18:21:41 | sean-k-mooney | it would be better to go striat form ksa to sdk | |
| 18:21:43 | stephenfin | I don't see why though. neutronclient is actively supported | |
| 18:22:12 | stephenfin | I mean, I realise that one client to rule them all is better in the long run | |
| 18:22:26 | sean-k-mooney | well this isnt an osc thng | |
| 18:22:33 | stephenfin | one library so | |
| 18:22:34 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Regression test https://review.opendev.org/c/openstack/nova/+/776250 | |
| 18:22:37 | sean-k-mooney | its related | |
| 18:22:50 | sean-k-mooney | ya its a libvary that is not ment to be used by any project outside of openstack | |
| 18:22:55 | stephenfin | I don't get why neutronclient is worse than a homemade ksa invocation | |
| 18:23:03 | sean-k-mooney | but enven then we wanted ot encurage the project to stop using them | |
| 18:23:17 | stephenfin | eh, yes and no | |
| 18:23:30 | stephenfin | we want to drop use of the project specific CLIs | |
| 18:23:50 | sean-k-mooney | i just dont see why we would bother changin it when it snot broken if we are not going to change it to sdk since that what we want to use long term | |
| 18:24:07 | sean-k-mooney | stephenfin: we want to drop novaclint as a lib too eventually | |
| 18:24:16 | sean-k-mooney | not just as a cli | |
| 18:24:28 | stephenfin | because the SDK change could be 5 years off, and that ksa change and the related code it needs is there now | |
| 18:24:45 | sean-k-mooney | it does not have to be monoltic | |
| 18:24:50 | sean-k-mooney | we have sdk usage already | |
| 18:25:23 | stephenfin | not for neutron though | |
| 18:25:33 | sean-k-mooney | sure but lets add it incrementally | |
| 18:26:23 | stephenfin | eh, idk. While that changeover happens everything is worse and more confusing that it was previously | |
| 18:26:35 | stephenfin | including things like the NeutronFixture | |
| 18:26:55 | sean-k-mooney | well this more or less hould be nitten form mos of nova | |
| 18:26:56 | stephenfin | this makes my life easier, with far less effort than switching to sdk does | |
| 18:27:03 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816 | |
| 18:27:07 | stephenfin | huh? | |
| 18:27:11 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: extra specs/image props: add `socket` PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748 | |
| 18:27:11 | sean-k-mooney | the nova/network/neutorn module will hide that form the rest of nova | |
| 18:27:17 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749 | |
| 18:27:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Track host NUMA topology in PCI manager https://review.opendev.org/c/openstack/nova/+/774149 | |
| 18:27:27 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: pci: implement the `socket` NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | |
| 18:28:08 | stephenfin | sean-k-mooney: If you do look at the patch, ignore the fact that it's using neutronclient for a bit and tell me it doesn't make e.g. the NeutronFixture easier to grok | |
| 18:28:28 | stephenfin | that's where I'm coming from | |
| 18:28:58 | stephenfin | I'll do the sdk work eventually, once the OSC gaps are closed, but I think this is a win for now | |
| 18:29:32 | sean-k-mooney | well it not going to change the public api of that module so im not sure it will | |
| 18:29:42 | sean-k-mooney | im looking at it now | |
| 18:30:32 | sean-k-mooney | but the frecatorign you are ding im not sure require the code changes | |
| 18:31:58 | sean-k-mooney | none of those private api shoudl be needed in the generic neutron fixture https://review.opendev.org/c/openstack/nova/+/706295/10/nova/tests/fixtures.py#b1769 | |
| 18:32:11 | sean-k-mooney | they should not be called outside the neutron moduule | |
| 18:32:22 | sean-k-mooney | only the public funtion will be | |
| 18:33:05 | stephenfin | They're called inside the neutron module | |
| 18:33:21 | sean-k-mooney | yep which can stub them in its own unit tests | |
| 18:33:35 | stephenfin | NeutronFixture is weird. It mocks APIs from both neutronclient and nova.network.neutron | |
| 18:33:48 | sean-k-mooney | ya | |
| 18:34:07 | sean-k-mooney | i then to use the libvirt version of it too at least when wriging func test | |
| 18:34:18 | sean-k-mooney | there is value in this yes | |
| 18:34:18 | stephenfin | no, it we don't stub them out then we need to provide an entire mock of e.g. 'bind_ports_to_host' | |
| 18:34:48 | sean-k-mooney | well we proably shoudl do htat since we need it for live migration right | |
| 18:35:01 | stephenfin | well we do | |
| 18:35:09 | stephenfin | by mocking out the private APIs it calls | |
| 18:35:39 | stephenfin | that API is the glue. We don't want to mock that out | |
| 18:35:50 | stephenfin | but we do want to mock out the neutron API calls | |
| 18:36:09 | stephenfin | I said above that the fixture is weird because it mocks APIs from both neutronclient and nova.network.neutron | |
| 18:36:10 | sean-k-mooney | yes which is what it was doing before | |
| 18:36:38 | stephenfin | but it really shouldn't be doing that. The reason it has to is because we're providing our own neutronclient implementation of sorts using KSA | |
| 18:36:45 | stephenfin | so it has to mock those | |
| 18:36:53 | stephenfin | things like _create_port_binding | |
| 18:37:22 | stephenfin | which, I'll note, is also what neutronclient uses now that I look at it | |
| 18:37:24 | sean-k-mooney | im surpised that has actully been added to neutronclint | |
| 18:37:38 | sean-k-mooney | it was ment to back in rocky but never happened | |
| 18:38:05 | sean-k-mooney | i cant argue that its not shorter | |
| 18:38:27 | sean-k-mooney | and it appear to more or less be functional | |
| 18:39:05 | stephenfin | yeah, I added it because the ksa stuff confused me | |
| 18:39:21 | stephenfin | What's the easiest thing to do if something confuses you? Delete it! | |
| 18:39:23 | stephenfin | :) | |
| 18:39:45 | sean-k-mooney | well the reason i brougt this up is i am concerned by what it might conflict with | |
| 18:39:54 | sean-k-mooney | in terms of backports | |
| 18:40:46 | sean-k-mooney | stephenfin: it conclitc with https://review.opendev.org/c/openstack/nova/+/653506 | |
| 18:41:00 | sean-k-mooney | whcih we partly fixed a different way but we proably shoudl stil merge this | |
| 18:41:19 | stephenfin | It's easy to rework these things and we bring them back | |
| 18:41:27 | stephenfin | no different to using f-strings in code, surely? :) | |
| 18:41:43 | stephenfin | see what I did there? | |
| 18:42:33 | sean-k-mooney | readding ksa is alot harder | |
| 18:43:05 | sean-k-mooney | i guess on hte backport it will already be there | |
| 18:43:37 | sean-k-mooney | and if the neutron client fucntio you are using is not supprot by the older version of neutron clinet on the stable branch you would have to use ksa anyway | |
| 18:43:56 | stephenfin | yeah, unfortunately so. We can't bump deps either | |
| 18:44:01 | stephenfin | Anyhow, /me really needs to get to the gym | |
| 18:44:08 | stephenfin | (home gym, sadly) | |
| 18:44:09 | stephenfin | o/ | |
| 18:44:13 | sean-k-mooney | i guess we can proceed with thsi but i feel somewhat blind sided by it | |
| 18:44:24 | sean-k-mooney | i just wasnt expecting you to be reworking that | |
| 18:44:36 | sean-k-mooney | enjoy o/ | |
| 21:45:26 | openstackgerrit | melanie witt proposed openstack/nova master: Add regression test for bug 1914777 https://review.opendev.org/c/openstack/nova/+/775307 | |
| 21:45:27 | openstackgerrit | melanie witt proposed openstack/nova master: Handle instance = None in _local_delete_cleanup https://review.opendev.org/c/openstack/nova/+/775308 | |
| 21:45:27 | openstack | bug 1914777 in OpenStack Compute (nova) "Possible race condition between n-cpu and n-api when deleting a building instance" [High,In progress] https://launchpad.net/bugs/1914777 - Assigned to melanie witt (melwitt) | |
| 22:35:17 | openstackgerrit | Belmiro Moreira proposed openstack/nova master: Change API unexpected exception message https://review.opendev.org/c/openstack/nova/+/628061 | |
| #openstack-nova - 2021-02-18 | |||
| 01:12:27 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: pci: implement the `socket` NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | |
| 07:07:40 | openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552 | |
| 09:42:15 | swp20 | gibi: morning, please check the NOVNC patch https://review.opendev.org/c/openstack/nova/+/622336 if you have spare time. | |
| 10:00:34 | openstackgerrit | Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/c/openstack/nova/+/763550 | |