| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-02-08 | |||
| 17:16:47 | bauzas | thanks | |
| 17:17:01 | gibi | sean-k-mooney: I would appreciate your view on the question in https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py#312 | |
| 17:17:25 | bauzas | gibi: then hopefully I'll switch soon on the compute RPC API version bump now that dansmith is back :) | |
| 17:17:27 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags` https://review.opendev.org/c/openstack/nova/+/774240 | |
| 17:17:36 | gibi | bauzas: awesome :0\ | |
| 17:17:38 | gibi | :) | |
| 17:17:52 | bauzas | I was mostly done with it, but faced problems | |
| 17:18:23 | bauzas | now it will require some rebase, as I think we had a new minor bump due to cyborg shelve/unshelve | |
| 17:18:40 | gibi | yepp | |
| 17:19:11 | bauzas | but honestly, the test failure puzzles me | |
| 17:22:01 | gibi | dansmith: hi! as per http://lists.openstack.org/pipermail/openstack-discuss/2021-February/020186.html could you help me adding the nova-stable-maint group to the placement-stable-maint group in gerrit. I'm not in the latter so I cannot do the change | |
| 17:22:31 | bauzas | gibi: I can do it | |
| 17:22:49 | gibi | bauzas: no you can't | |
| 17:22:58 | gibi | you are not in the placement-stable-maint as far as I see | |
| 17:23:02 | gibi | https://review.opendev.org/admin/groups/7b73c52bbb180a693bac4f2fcca01a6dab9c1222,members | |
| 17:23:12 | bauzas | ah shit indeed, the other way :) | |
| 17:23:28 | bauzas | and not a stable-maint-core :) | |
| 17:23:52 | gibi | :) | |
| 17:34:29 | sean-k-mooney | gibi: as far as i know its invalid for a port with multiple fixed_ip from different segments to be created | |
| 17:34:58 | sean-k-mooney | gibi: there may be one excption | |
| 17:35:22 | sean-k-mooney | having ips on differnet segment implies that port is on multiple differnt l2 broadcast domain concurrently | |
| 17:35:32 | sean-k-mooney | which is not physically possible | |
| 17:35:54 | sean-k-mooney | the caveate which i think we should declare out of scope would be a situration where you are using routed network with trunk portrs | |
| 17:36:36 | sean-k-mooney | in principal each subport could be on a different physical network and the the parent port could therefor hoave fixed ips form different segments i think | |
| 17:37:15 | sean-k-mooney | gibi: we might be able to support that at some point but for now i think we would be better off documenting that as a limition in this release | |
| 17:37:27 | sean-k-mooney | an enable that if someone asks for it in the future | |
| 17:38:01 | sean-k-mooney | gibi: i think multiple fixed ips is fine just they should have the same sgement | |
| 17:38:32 | sean-k-mooney | they could have different subnets e.g. if you ran out of ips and wantted to add more to a segment via a second subnet | |
| 17:38:49 | sean-k-mooney | but 1 segment and 1 l2 broadcast domain i hope that makes sense? | |
| 17:39:06 | sean-k-mooney | ill review bauzas patch in either case | |
| 17:40:43 | sean-k-mooney | trunk ports being https://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html | |
| 17:51:05 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Allow disabling CPU flags via `cpu_model_extra_flags` https://review.opendev.org/c/openstack/nova/+/774240 | |
| 17:51:33 | kashyap | gibi (and others): For tomm --^ :) | |
| 17:51:58 | kashyap | gibi: You must be drowning in review requests. Sorry for the deluge | |
| 18:04:06 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/749068/12/nova/scheduler/request_filter.py#312 commented inline | |
| 18:04:40 | dansmith | gibi: sorry was on a call, looking now | |
| 18:05:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/c/openstack/nova/+/676209 | |
| 18:05:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/c/openstack/nova/+/705657 | |
| 18:05:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/c/openstack/nova/+/705658 | |
| 18:05:23 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures https://review.opendev.org/c/openstack/nova/+/764806 | |
| 18:06:12 | dansmith | gibi: how's that? | |
| 18:20:34 | ganso | 915055 | |
| 18:20:34 | openstack | Launchpad bug 1 in Ubuntu Malaysia LoCo Team "Microsoft has a majority market share" [Critical,In progress] - Assigned to MFauzilkamil Zainuddin (apogee) | |
| 18:20:34 | ganso | Hi Nova folks! Does this look like a legit bug to you? I'm thinking of ways to fix it, either change "openstack usage show" to use created_at instead of launched_at (negative side effects are created instances that were launched) or stop updating the launched at field on resize and unshelved. Thinking about it, a cold migration or a stop/start operation does not update the launched field, why should a resize do? https://bugs.launchpad.net/nova/+bug/1 | |
| 18:20:44 | ganso | lol it cropped at the bug ID | |
| 18:20:54 | openstack | Launchpad bug 1915055 in OpenStack Compute (nova) "launched_at's reset when resizing/reverting and unshelving impacts "openstack usage show"" [Undecided,New] | |
| 18:20:54 | ganso | https://bugs.launchpad.net/nova/+bug/1915055 | |
| 18:32:41 | sean-k-mooney | ganso: we had a bug similar to this not so long ago which we rejected | |
| 18:33:09 | ganso | sean-k-mooney: hmmm my search didn't come up with anything. Do you remember why it was rejected? | |
| 18:33:11 | sean-k-mooney | ganso: we decieded not to change the existing behavior | |
| 18:34:15 | sean-k-mooney | bascilly becasue we dont really feel this type of api should be provided by nova and analtics of this type would be better done externally | |
| 18:34:26 | sean-k-mooney | by consuming the instance life cycle events | |
| 18:34:39 | sean-k-mooney | it came up in the nova meeting a few weeks ago | |
| 18:37:09 | sean-k-mooney | http://eavesdrop.openstack.org/meetings/nova/2020/nova.2020-12-03-16.00.log.txt | |
| 18:37:30 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/711113 | |
| 18:37:34 | ganso | sean-k-mooney: shouldn't this API be deprecated? From what you said it sounds like you'd like to disencourage its usage | |
| 18:38:00 | sean-k-mooney | ganso: well we already do discuage usage :) but its not deprecated | |
| 18:38:39 | sean-k-mooney | we resovled to instead update the docs to call out its expected usage i think | |
| 18:40:08 | sean-k-mooney | ganso: this api has a pretty heavy perfomance impact too in comparision to outer apis so it does not scale well | |
| 18:41:39 | ganso | sean-k-mooney: thanks for the info, I will close the bug as invalid! | |
| 18:42:05 | sean-k-mooney | ganso: can you like to the previous meeting and that patch that was abandoned for context | |
| 18:42:15 | ganso | sean-k-mooney: yes, I will include those links | |
| 18:42:17 | sean-k-mooney | ganso: out of interest what was your usecase for this | |
| 18:42:32 | openstack | Launchpad bug 1913641 in OpenStack Compute (nova) "Incorrect Shelved_offloaded instance metrics on openstack usage show output" [Undecided,In progress] - Assigned to Rodrigo Barbieri (rodrigo-barbieri2010) | |
| 18:42:32 | ganso | sean-k-mooney: it was fixing this bug: https://bugs.launchpad.net/nova/+bug/1913641 | |
| 18:42:35 | ganso | see the last comment ^ | |
| 18:42:50 | ganso | I implemented the fix, but then I found that other issue | |
| 18:43:19 | sean-k-mooney | ah ok well that is likely invalid too | |
| 18:43:43 | ganso | yes. I will close that one too, because it is pointless fixing that without fixing the launched_at being reset | |
| 18:45:11 | sean-k-mooney | ya so i would clouse one of those two bugs as a duplicate of the other then close the scond with refrences to the meeting as wontfix or invalid | |
| 18:45:43 | sean-k-mooney | ganso: melwitt also commened on comment one that it was intended behavior too. | |
| 18:46:13 | sean-k-mooney | although that was more on the difference between counting quota with placement or not | |
| 18:47:25 | ganso | sean-k-mooney: my understading from her comment was that it was intentional in the past, but now with that new count_quota_from_placement that it could change, so I moved forward with a fix | |
| 18:48:03 | sean-k-mooney | not the intent is eventually to remove the current api and only count quota and usage via placment | |
| 18:48:14 | sean-k-mooney | that is part of teh unified limits work | |
| 18:48:50 | sean-k-mooney | ganso: placment has its own usage api https://docs.openstack.org/api-ref/placement/?expanded=list-usages-detail#usages | |
| 18:49:14 | sean-k-mooney | that wont give you historic usage over a time interval but it will tell you the current usage of a project | |
| 18:51:08 | ganso | sean-k-mooney: thanks! | |
| 19:07:29 | ganso | sean-k-mooney: I added the comment, but I lack the powers to mark both as "won't fix". I don't see them as duplicates, neither invalid ones. I do think they are legit, but considering the usage API is discouraged, they will not be fixed. Could you please mark both as "won't fix" ? | |
| 19:08:08 | sean-k-mooney | am sure. you need to be in the nova bug group. its an open team in launchpad so anyone can join but ill update them now | |
| 19:08:27 | ganso | oh cool, anyone can join. Will join them now | |
| 19:10:10 | sean-k-mooney | ganso: done if you want to join just join here https://launchpad.net/~nova-bugs | |
| 19:10:19 | ganso | sean-k-mooney: just did =) | |
| 19:10:40 | sean-k-mooney | cool i think you need to renew it every 1-2 years but its simple to do | |
| 19:36:43 | melwitt | removes counting of shelved offloaded | |
| 19:36:43 | melwitt | ganso, sean-k-mooney: fwiw ganso's interpretation of my comment is correct, I think it could be debated whether usage should count shelved offloaded instances (same way it could be debated whether quota should count it). that said, I could see it making sense to keep both behaviors consistent (as long as default quota behavior counts shelved offloaded, so does usage). if/when default quota behavior turns to placement counting, usage | |
| 19:38:23 | sean-k-mooney | melwitt: where you in the team meeting when https://review.opendev.org/c/openstack/nova/+/711113 was discuessed | |
| 19:39:02 | sean-k-mooney | that attempted to cahnge the meaning of the usage api to only cound it when the vm was active and running | |
| 19:39:05 | melwitt | no, I missed that | |
| 19:39:12 | melwitt | ah ok | |
| 19:39:48 | sean-k-mooney | we decieded not to basically because we did not want to change its current meaning | |
| 19:40:12 | sean-k-mooney | it could be done but we did not really want too do it as a bug fix | |
| 19:40:46 | sean-k-mooney | its really an api change and im not sure how open we are to adding more uses of or enhanceing the simple tenant usage api | |
| 19:40:49 | melwitt | thanks for that link, that helps | |
| 19:40:59 | sean-k-mooney | personally i would be in favor of eventually removing it | |
| 19:41:17 | melwitt | I see, was just reading through the irc discussion linked on the abandoned patch | |
| 19:41:39 | sean-k-mooney | we could revisit this dicussion | |
| 19:41:50 | sean-k-mooney | if you think there is merit in it | |
| 19:42:13 | sean-k-mooney | but it feels to me that this should be a spec if we were to change the api behavior | |
| 19:42:30 | sean-k-mooney | with a new microverion to request the new behaivor | |