| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-28 | |||
| 00:27:03 | gmann | brinzhang_: i commented in this file that we do not need to change get_instance_security_groups method itself https://review.opendev.org/c/openstack/nova/+/766726/11/nova/network/security_group_api.py#279 | |
| 00:27:39 | gmann | we get the sg from neutron and neutron does return tenant_id and project_id in sg response but both are same thing | |
| 00:28:01 | gmann | they kept both for backward compatibility as they do not have microversion concept. | |
| 00:29:19 | brinzhang_ | gmann:in "def _convert_to_nova_security_group_format(" we update the security_group[], does it need to be consider? | |
| 00:29:58 | gmann | brinzhang_: this one right https://review.opendev.org/c/openstack/nova/+/766726/11/nova/network/security_group_api.py#279 | |
| 00:30:35 | gmann | we can just change L275 from 'nova_group['project_id'] = security_group['tenant_id']' -> nova_group['project_id'] = security_group['project_id'] | |
| 00:31:12 | gmann | and without microversion condition. that way we do not need to change the signature of any interface | |
| 00:31:48 | brinzhang_ | I think I get you idea | |
| 00:31:59 | brinzhang_ | s/you/your/ | |
| 00:32:04 | gmann | cool | |
| 00:33:08 | brinzhang_ | in neutron api, we dont need to be consider the nova microversion, we just need to get the sg keep the same way | |
| 00:33:36 | gmann | yeah and fetch project_id from neutron sg instead of tenant_id | |
| 00:34:24 | gmann | because at some point in future neutron also will remove the tenant_id form their API so we can take care of that in advance | |
| 00:34:37 | brinzhang_ | yeah | |
| 00:34:45 | gmann | brinzhang_: and in first commit, we can remove the 2.89 sample. i commented in previous PS also. sorry about asking for that in initial reiview. this one - https://review.opendev.org/c/openstack/nova/+/764292/14/nova/tests/functional/api_sample_tests/test_servers.py#659 | |
| 00:36:05 | brinzhang_ | gmann: np, will update in next patch | |
| 00:36:12 | gmann | brinzhang_: thanks | |
| 00:36:56 | brinzhang_ | gmann: did you review the os-simple-project-suage patch? the router change, and that hit the test issue? | |
| 00:38:01 | gmann | brinzhang_: I did until 766726 but I will check the simple-project-usage tomorrow | |
| 00:38:04 | brinzhang_ | that I requested 2.90, but it always goto <=2.89 index or show APis | |
| 00:38:51 | gmann | humm strange | |
| 00:38:52 | brinzhang_ | gmann: dont worry^, my env has broken yesterday, firstly, I will restore my env | |
| 00:39:11 | gmann | I will debug that tomorrow. dinner time for me | |
| 00:39:31 | gmann | routes.py looks fine to me in first glance may be API controller causing it | |
| 00:39:52 | brinzhang_ | gmann: thanks, have a good dinner ^^ | |
| 06:15:32 | openstackgerrit | Hemanth N proposed openstack/nova stable/rocky: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761824 | |
| 11:00:11 | lyarwood | stephenfin: looking to undeprecate ['glance']/allowed_direct_url_schemes now that it's used by https://review.opendev.org/q/topic:bp/nova-image-download-via-rbd | |
| 11:01:03 | lyarwood | stephenfin: is that just a case of removing the deprecation notes etc? | |
| 11:01:32 | stephenfin | Yeah, remove the deprecation note from the config opt itself and if it's not already done, add a release note | |
| 11:04:25 | lyarwood | ack thanks | |
| 11:12:31 | zigo | This looks like general to OpenStack, and feels like yet-another-problem-with-eventlet... :( | |
| 11:12:31 | zigo | I got the same problem with neutron-rpc-server when trying to tell Nova that my VM port is up: http://paste.openstack.org/show/802071/ | |
| 11:12:31 | zigo | Swift fails with Python 3.9 under Debian Unstable with Python 3.9: http://paste.openstack.org/show/802063/ | |
| 11:20:55 | stephenfin | anyone want to speed up our docs build? https://review.opendev.org/c/openstack/nova/+/751034 | |
| 11:40:25 | kashyap | stephenfin: Nice | |
| 11:41:12 | kashyap | stephenfin: Thanks for that; several times I wished for speeder doc builds! | |
| 11:44:43 | kashyap | Gave my lowly +1, FWIW | |
| 11:59:21 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use specific user when probing encrypted rbd disks during extend https://review.opendev.org/c/openstack/nova/+/772869 | |
| 12:01:39 | lyarwood | stephenfin: looking | |
| 12:01:53 | lyarwood | stephenfin: also I've lost the tabs with the reviews you asked me about yesterday, what were they again? | |
| 12:02:44 | stephenfin | https://review.opendev.org/c/openstack/nova/+/75655, https://review.opendev.org/c/openstack/nova/+/752912 and if possible https://review.opendev.org/c/openstack/nova/+/756552 | |
| 12:03:24 | lyarwood | ack | |
| 12:03:26 | lyarwood | thanks | |
| 12:18:09 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Mark nova-lvm as voting https://review.opendev.org/c/openstack/nova/+/772871 | |
| 12:18:09 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Increase SWIFT_LOOPBACK_DISK_SIZE within nova-lvm job https://review.opendev.org/c/openstack/nova/+/772702 | |
| 12:47:21 | openstackgerrit | Lee Yarwood proposed openstack/nova master: glance: Remove [glance]/allowed_direct_url_schemes https://review.opendev.org/c/openstack/nova/+/772874 | |
| 13:30:41 | openstackgerrit | Takashi Natsume proposed openstack/nova-specs master: Create specs directory for Xena https://review.opendev.org/c/openstack/nova-specs/+/772878 | |
| 13:57:43 | openstackgerrit | Ghanshyam proposed openstack/placement master: Move policy deprecation to base rules https://review.opendev.org/c/openstack/placement/+/772784 | |
| 14:00:02 | lyarwood | stephenfin: https://review.opendev.org/c/openstack/nova/+/771981 - would you mind hitting this today if you have some docs review bandwidth | |
| 14:00:23 | lyarwood | https://review.opendev.org/c/openstack/nova/+/772874 might also be something you'd be interested in | |
| 14:02:12 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/772871/ - could you take a look at this change marking the nova-lvm job as voting (and the fix underneath it)? | |
| 14:02:56 | gibi | lyarwood: ack, added to my queue. (that queue getting log in the last couple of days) | |
| 14:03:35 | lyarwood | gibi: ack np, if there's anything I can trade let me know | |
| 14:03:54 | lyarwood | gibi: systemctl restart nova-compute? ;) | |
| 14:05:10 | gibi | yepp that what couple of our customers do weekly but they getting impatient | |
| 14:05:24 | gibi | fun stuf | |
| 14:05:26 | lyarwood | ouch | |
| 14:06:29 | gibi | I had the same experience a decade ago with jvm :D the solution was the same, restart it during maintenance window to free up ram | |
| 14:08:00 | sean-k-mooney | gibi: given python is garbage collected any memory leask is likely form interaction with libvirt right | |
| 14:08:17 | sean-k-mooney | e.g. the proxy objects | |
| 14:08:33 | sean-k-mooney | or well interaction with external things via real threads | |
| 14:08:50 | gibi | sean-k-mooney: or thing the code actually stores and accumlates for no reason | |
| 14:09:05 | sean-k-mooney | i know we can have meemory issue if we return excptions instead of raising them too on python 3 | |
| 14:09:06 | sean-k-mooney | *2 | |
| 14:09:22 | gibi | like this https://github.com/openstack/oslo.messaging/blob/00d15eaeaba0ded0330cdcec7b19eee3adbfb1e1/oslo_messaging/_drivers/amqpdriver.py#L426 | |
| 14:09:42 | sean-k-mooney | gibi: ah well that is less a leak but rather using more memory then it need to due to a poor algorithim | |
| 14:10:13 | gibi | yepp | |
| 14:10:30 | gibi | actually I can hit that log in pike devstack by poking rabbitmq | |
| 14:10:37 | sean-k-mooney | oh in this case it also qould be an rabbitissue | |
| 14:11:21 | sean-k-mooney | ya that could grow if the reply are lost right | |
| 14:12:27 | gibi | I see two types of increase one that eventually recovers. after a long timeout the disconnect is logged in nova side and the connection is removed | |
| 14:12:28 | sean-k-mooney | back to debuging why an osp env that is freshly deployed passes tempest but then after 9+ hours apparenlty stops working | |
| 14:12:54 | gibi | but there are connections that does not freed even after an hour | |
| 14:13:29 | sean-k-mooney | that sound like an amqp bug | |
| 14:13:52 | sean-k-mooney | like the clinet has gone away but for some reason it keeps the file desctprot for the connection open | |
| 14:14:00 | sean-k-mooney | and never recognises the disconnect | |
| 14:14:05 | gibi | could be | |
| 14:14:12 | sean-k-mooney | althoug | |
| 14:14:16 | gibi | now I have to proove that this is what happens in the customer env | |
| 14:14:27 | gibi | as it is still in my local devstack | |
| 14:14:44 | sean-k-mooney | ya not sure how to determin that | |
| 14:15:20 | gibi | I bet on the warning log from oslo | |
| 14:15:28 | gibi | If the customer sees that then I have a lead | |
| 14:27:59 | lyarwood | ~. | |
| 15:02:03 | stephenfin | lyarwood: comments left on one, +2 on the other | |
| 15:06:09 | lyarwood | kashyap: libvirt is always starts with a lower case l right? | |
| 15:06:20 | lyarwood | kashyap: I'm sure this came up in the past and has confused me for ages | |
| 15:07:24 | kashyap | lyarwood: On a call; bbiab | |
| 15:07:29 | sean-k-mooney | i have seen both | |
| 15:07:30 | kashyap | But yes, lower case | |
| 15:07:31 | lyarwood | np | |
| 15:07:36 | sean-k-mooney | but its normally lowercase | |
| 15:07:57 | lyarwood | yeah this came up before and I was told always lowercase for $reasons | |
| 15:08:45 | sean-k-mooney | if its in a commit mesage or specs then i always use libvirt instead of Libvirt | |
| 15:08:51 | sean-k-mooney | same for release notes | |
| 15:11:03 | sean-k-mooney | although funally enough it's uppercase here https://github.com/libvirt/libvirt/blob/30703564c2ac8d95279801a821cf5510fa4b8149/docs/ci.rst#libvirt-continuous-integration but i think thats wrong | |
| 15:11:56 | sean-k-mooney | also a few places in the readme too https://github.com/libvirt/libvirt/blob/30703564c2ac8d95279801a821cf5510fa4b8149/README.rst | |
| 15:12:36 | sean-k-mooney | but again that feel more like there editor auto capitalising then intentional as the use lowercase when its not the start of a sentence | |
| 15:16:59 | openstackgerrit | Ghanshyam proposed openstack/nova master: DNM:try l-c with direct deps https://review.opendev.org/c/openstack/nova/+/772780 | |
| 15:24:52 | kashyap | lyarwood: Back; unless it's at the start of a sentence, it's always lowercase. | |