Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-27
13:47:28 openstackgerrit Merged openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231
13:58:48 lyarwood \o/
14:08:06 openstackgerrit Lee Yarwood proposed openstack/nova master: docs: Move the LibvirtDistroSupportMatrix wiki page into our docs https://review.opendev.org/c/openstack/nova/+/771981
14:49:12 stephenfin lyarwood: I have an open API policy question on https://review.opendev.org/c/openstack/nova/+/768352/
14:53:12 lyarwood stephenfin: ah my bad, looking
14:53:17 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP zuul: Increase SWIFT_LOOPBACK_DISK_SIZE within nova-lvm job https://review.opendev.org/c/openstack/nova/+/772702
14:57:10 openstackgerrit Merged openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/c/openstack/nova/+/756895
15:08:07 dansmith sean-k-mooney: gdi, I do that *every* dang time :/
15:11:28 openstackgerrit Stephen Finucane proposed openstack/nova master: rpc: Rework 'get_notifier', 'wrap_exception' https://review.opendev.org/c/openstack/nova/+/741663
15:11:30 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/c/openstack/nova/+/676209
15:11:32 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/c/openstack/nova/+/705657
15:11:34 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/c/openstack/nova/+/705658
15:11:36 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures https://review.opendev.org/c/openstack/nova/+/764806
15:11:37 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170
15:24:50 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1909120 https://review.opendev.org/c/openstack/nova/+/768351
15:24:52 openstack bug 1909120 in OpenStack Compute (nova) "n-api should reject requests to detach a volume when the compute is down" [Medium,Confirmed] https://launchpad.net/bugs/1909120 - Assigned to Lee Yarwood (lyarwood)
15:24:58 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Reject requests to detach a volume when the compute is down https://review.opendev.org/c/openstack/nova/+/768352
15:41:45 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1908075 https://review.opendev.org/c/openstack/nova/+/766976
15:41:46 openstack bug 1908075 in OpenStack Compute (nova) "Nova allows a non-multiattach volume to be attached to multiple instances *if* its volume state is reset by an admin" [Undecided,New] https://launchpad.net/bugs/1908075 - Assigned to Lee Yarwood (lyarwood)
15:41:47 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Reject volume attach requests when an active bdm exists https://review.opendev.org/c/openstack/nova/+/768472
15:53:05 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Rationalize attachment of USB tablet https://review.opendev.org/c/openstack/nova/+/756551
15:53:06 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add support for virtio-based input devices https://review.opendev.org/c/openstack/nova/+/756552
16:10:30 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Enable 'vmcoreinfo' feature by default https://review.opendev.org/c/openstack/nova/+/752912
16:11:51 gmann stephenfin: lbragstad sean-k-mooney replied on https://review.opendev.org/c/openstack/placement/+/760240/21/placement/policies/base.py#20
16:12:30 gmann Let's go with SYSTEM_ADMIN so that we donot depends on the timing of removing the old rule and enforce_scope=true by default
16:24:25 openstackgerrit sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/c/openstack/nova/+/602432
16:31:51 stephenfin lyarwood: Two of those three patches from me above ^ previously had +2 from you but conflicted with the just-merged Xen removal patch. Can you (re)look at them real quick?
16:33:16 stephenfin If you could get to https://review.opendev.org/c/openstack/nova/+/756552 too that'd be extra awesome. Spec is approved, fwiw
16:37:43 lyarwood stephenfin: need to run for a while now but I'll try to look later or first thing tomorrow
16:37:56 stephenfin ack, thanks
16:38:43 openstackgerrit Vlad Gusev proposed openstack/nova stable/stein: tests: Add regression test for bug 1894966 https://review.opendev.org/c/openstack/nova/+/772720
16:38:45 openstack bug 1894966 in OpenStack Compute (nova) stein "Create servergroup failed with unexpected error" [Undecided,Confirmed] https://launchpad.net/bugs/1894966
16:42:58 openstackgerrit Vlad Gusev proposed openstack/nova stable/stein: api: Set min, maxItems for server_group.policies field https://review.opendev.org/c/openstack/nova/+/772721
16:46:36 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Enable parallel docs build https://review.opendev.org/c/openstack/nova/+/751034
16:47:02 gmann lbragstad: did your single tests for all persona approach worked? https://review.opendev.org/c/openstack/placement/+/760238/9/placement/tests/functional/gabbits/inventory-legacy-rbac.yaml#20
16:47:56 lbragstad gmann i haven't gotten back around to it - i've been helping cinder setup test plumbing
16:47:56 gmann nova did the same to avoid 409 or creating new resource per persona though nova tests are with stub for non-api layer
16:48:07 gmann ohk
16:49:48 lbragstad i can repropose the beginning of that series since it sounds like we have consensus on the check string
16:50:10 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add support for virtio-based input devices https://review.opendev.org/c/openstack/nova/+/756552
16:51:35 gmann lbragstad: for using common constraint from oslo?
16:52:19 lbragstad oh - no, i was just going to rebase them and cleanup the concern in the aggregate patch
16:52:56 gmann lbragstad: ah this https://review.opendev.org/c/openstack/placement/+/760235/10/placement/policies/aggregate.py#52
16:53:34 lbragstad yeah
16:55:08 gmann lbragstad: ok, as you are rebasing what you think of https://review.opendev.org/c/openstack/placement/+/760240/21/placement/policies/resource_provider.py#50
16:55:29 gmann this can leave all explicit deprecation in policies.
16:56:22 gmann and deprecate current admin with system-admin rule in base.py and use system-admin rule as check_str
16:56:43 gmann and in system-admin rule we will use common string from oslo whenever we are ready
16:57:34 gmann lbragstad: if that is too much asking at this stage then we can leave that i can do that in follow up for all policy together
16:57:50 lbragstad gmann stephenfin has a patch to do the deprecation https://review.opendev.org/c/openstack/placement/+/772334/4
16:58:14 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: extra specs/image pros: add `socket PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748
16:58:14 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816
16:58:15 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749
16:58:22 gmann lbragstad: i see, l do that there.
16:58:28 stephenfin lbragstad: gmann: Yeah, I just replied :)
16:59:50 gmann stephenfin: nice, do you mind if I update that to define all other deprecation also in common place? https://review.opendev.org/c/openstack/placement/+/772334/4
17:00:06 stephenfin Not at all. Go for it
17:00:11 gmann or i can do on top of that to see how it look like
17:00:20 gmann ok
17:27:27 openstackgerrit Merged openstack/nova stable/victoria: Add regression test for bug #1899649 https://review.opendev.org/c/openstack/nova/+/764611
17:27:30 openstack bug 1899649 in OpenStack Compute (nova) "Volume marked as available after a failure to build" [Undecided,In progress] https://launchpad.net/bugs/1899649 - Assigned to Lee Yarwood (lyarwood)
17:33:17 kashyap gibi: stephenfin: When you get a minute, can you please have a gander at this (but it is from chengsheng, a new contributor, fixing a good problem): https://review.opendev.org/c/openstack/nova/+/762330/
17:33:45 gibi kashyap: ack, added to my queue
17:33:46 kashyap It is related using the correct CPU APIs
17:34:05 kashyap And he's addressed some feedback of mine in the past; and it also checks off one of the items in this old spec:
17:34:26 kashyap https://opendev.org/openstack/nova-specs/commit/70811da221035044e27 (Add "CPU selection with hypervisor consideration" spec)
17:35:39 openstackgerrit Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785
17:35:40 openstackgerrit Lance Bragstad proposed openstack/placement master: policy: Suppress policy deprecation warnings https://review.opendev.org/c/openstack/placement/+/771852
17:35:41 openstackgerrit Lance Bragstad proposed openstack/placement master: policy: Don't persist default rule changes in tests https://review.opendev.org/c/openstack/placement/+/772508
17:35:46 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240
17:35:47 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235
17:35:48 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236
17:35:52 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237
17:35:58 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238
17:36:02 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239
17:36:08 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241
17:36:13 openstackgerrit Lance Bragstad proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242
17:36:16 openstackgerrit Lance Bragstad proposed openstack/placement master: policy: Remove the deprecated 'placement' rule https://review.opendev.org/c/openstack/placement/+/772333
17:36:19 openstackgerrit Lance Bragstad proposed openstack/placement master: policy: Deprecate 'admin_api' rule https://review.opendev.org/c/openstack/placement/+/772334
17:36:23 lbragstad stephenfin gmann sean-k-mooney since i needed to go through and fix things early in the series, i cleaned up a bunch of the one-off patches later in the series
17:36:39 lbragstad i abandoned the ones i had the ability to abandon
17:36:46 sean-k-mooney lbragstad: yep just saw them come in
17:37:00 lbragstad and i left comments on others that can be abandoned because i rolled them into subsequent patches
17:37:00 gmann lbragstad: thanks,
17:37:27 sean-k-mooney i need to look at how the roles compose and this works again because it sound like its working muc differently then i tought
17:37:43 sean-k-mooney to the point where im questinging the feature
17:38:00 sean-k-mooney i hope i am just missundering how the tests are written
17:39:54 sean-k-mooney basically the point im trying to figure out is as a SYSTEM_ADMIN do i only have the admin role or do i also have the member and reader role
17:40:00 sean-k-mooney im hoping its the former
17:40:10 sean-k-mooney and that we have ineritence between the roles
17:40:45 stephenfin ack
17:41:30 sean-k-mooney if we dont have inheritance betwen the roles then i dont think it make sense to have personas and reference them in the policy rules
17:44:44 sean-k-mooney if im reading https://specs.openstack.org/openstack/keystone-specs/specs/keystone/queens/system-scope.html#system-roles-implied-roles-inherited-roles correctly
17:45:20 sean-k-mooney if i have role:admin i should have role:member and role:reader trasitivly as they are implied roles
17:45:31 sean-k-mooney but i shoudl not have to add them to my user explictly
17:46:44 sean-k-mooney so im very confused by https://review.opendev.org/c/openstack/placement/+/760240/21/placement/tests/functional/gabbits/resource-provider-legacy-rbac.yaml#9
17:47:09 stephenfin sean-k-mooney: I'm pretty sure it is implied, and because it's implied both the main role and the implied roles are included in the HTTP_X_ROLES header in CSV form
17:47:57 stephenfin so the implied link is encoded in keystone, and oslo.context and oslo.policy don't need to know about it. They can simply check for the role they care about
17:48:05 sean-k-mooney right i think including them in the x roles header explictly is odd
17:48:21 lbragstad if you have the admin role on a project and you look at the token response, you'll see keystone expands those out for you

Earlier   Later