Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-22
13:55:10 sean-k-mooney i think its in osc-lib
13:56:03 nightmare_unreal i am working on a bug : osc client does not read placement API version variable . variable name placement_api_version
13:56:26 nightmare_unreal so i am trying to figure out where in osc it reads the yaml file
13:57:04 sean-k-mooney its case sensitive and has to be uppercase just an fyi
13:57:11 sean-k-mooney i think
13:57:27 openstackgerrit Lee Yarwood proposed openstack/nova master: docs: Move the LibvirtDistroSupportMatrix wiki page into our docs https://review.opendev.org/c/openstack/nova/+/771981
13:57:29 sean-k-mooney that would be in osc-placement
13:57:32 nightmare_unreal obvious solution that will not be good is to read the config file in osc_placement plugin and look for that value if it's set then good .
13:57:41 lyarwood stephenfin / kashyap ; ^ would you mind reviewing this, still need to add some versions and work out where it should live (if not in our reference docs)
13:58:14 sean-k-mooney nightmare_unreal: https://github.com/openstack/osc-placement/blob/master/osc_placement/plugin.py#L53
13:59:05 sean-k-mooney it uses https://github.com/openstack/osc-lib/blob/ec1b7dda0e6dc1ec614a92e24267d058783ad27f/osc_lib/utils/__init__.py#L134-L144
13:59:15 sean-k-mooney to get the values for the env
13:59:24 nightmare_unreal in clouds.yaml it should be defined like that ? OS_PLACEMENT_API_VERSION but i think there is a file that automatically does that
13:59:29 sean-k-mooney but i think cloud.yaml is expeorted to the evn
13:59:34 nightmare_unreal I see
13:59:58 nightmare_unreal in my head the env is when in cli we explicitly do export OS_BLAH_BLAH
14:00:09 sean-k-mooney yes it is
14:00:11 nightmare_unreal but if it takes clouds.yaml as env
14:00:20 nightmare_unreal then i have to think
14:00:29 sean-k-mooney but i think we extract some paramaters and add them to it
14:00:44 sean-k-mooney i havent looked at this closely but was how i understood it to work
14:01:16 gmann brinzhang_: ack, I will check those in details and see were it is wrong. basically having separate APi controller class should not cause any issue
14:02:14 nightmare_unreal I see. yeah trying to figure it out myself :)
14:03:12 sean-k-mooney so i think this is wher we read the cloud.yaml https://github.com/openstack/osc-lib/blob/ec1b7dda0e6dc1ec614a92e24267d058783ad27f/osc_lib/shell.py#L408-L413
14:03:18 gmann sean-k-mooney: gibi I thikn 2 hr is even more time for that job disbale swift and does not run swift/keystone/slow tests
14:03:39 sean-k-mooney gmann: ya i mentioned the timeout befor ei check the build page
14:03:43 kashyap lyarwood: Hey, will check; sigh, missed the notif here
14:03:45 gmann ohk
14:03:52 sean-k-mooney gmann: it shoudl be fine just a slow node
14:04:01 gmann sean-k-mooney: yeah.
14:04:30 gmann except tripleo jobs almost all our gate are with max 2 hrs job run
14:04:59 sean-k-mooney yep
14:05:02 kashyap lyarwood: Thanks for moving; I think I have a half-done patch for it somewhere; but didn't update it
14:06:16 nightmare_unreal thanks sean-k-mooney , looking :D
14:06:32 sean-k-mooney that delegating to the sdk now
14:09:06 sean-k-mooney nightmare_unreal: this is what does the actul loading i think https://github.com/openstack/openstacksdk/blob/4ce235d36dfa3420534ad1b145cc7c5f7438e8e0/openstack/config/loader.py#L140
14:10:58 nightmare_unreal yeah i think so too, looking
14:14:40 sean-k-mooney nightmare_unreal: regardelss of how its parsed i think this is what you are really looking for https://github.com/openstack/openstacksdk/blob/4ce235d36dfa3420534ad1b145cc7c5f7438e8e0/openstack/config/loader.py#L1057
14:15:17 sean-k-mooney to lookup a value in the config
14:15:46 nightmare_unreal yes exactly , and also to check if the defined key:value in clouds.yaml is read or not
14:15:50 nightmare_unreal thanks
14:16:08 kashyap lyarwood: Do you havea rendered version of it?
14:18:46 kashyap lyarwood: sean-k-mooney: For testing w/ Secure Boot in the Gate ... none of the cloud images are built with EFI partition ... I'm wondering if are allowed to upload new images for testing?
14:19:06 lyarwood kashyap: http://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8b1/771981/1/check/openstack-tox-docs/8b1d7c4/docs/reference/libvirt-distro-support-matrix.html
14:19:09 kashyap The short context is: you'd need a disk image with EFI partition in it
14:19:42 kashyap I'm thinking of making a custom template image for testing; is it allowed to upload somewhere via the infra and make use of it?
14:19:55 lyarwood kashyap: we shouldn't need to upload an image into CI, we can just host and reference one that does in a test job
14:20:17 lyarwood kashyap: assuming you're talking about the test instances and not the test hosts
14:20:19 kashyap lyarwood: Ah; okay. I'll find a suitable location to host it, once I prepare it
14:20:33 kashyap lyarwood: Test instance, indeed. I'm talking about a guest
14:20:51 sean-k-mooney kashyap: do you mean the guest image e.g. cirros
14:21:06 lyarwood kashyap: right then there's likely best practice our where we can host it, if it needs to be cached etc but we should be able to drop in a suitable image
14:21:17 lyarwood practice around*
14:21:22 sean-k-mooney we are not ment to pull arbiary blobs down in the jobs
14:21:24 kashyap lyarwood: E.g. this is what a guest image that can do EFI/SB should have, to start with: http://paste.openstack.org/show/801871/
14:21:30 kashyap sean-k-mooney: Yes, guest images indeed.
14:21:39 sean-k-mooney so if we need a special test image we need to have that hostsed/cached by infra
14:21:48 kashyap sean-k-mooney: Okay; I'll check w/ the infra folks.
14:21:55 sean-k-mooney kashyap: are there any test image packaged in distors
14:22:07 sean-k-mooney kashyap: i know we sometimes have isos deistibted by rpms
14:22:09 kashyap No, none do it; most do it via install trees
14:22:15 kashyap sean-k-mooney: For example, see how I test it here: https://kashyapc.fedorapeople.org/Create-a-SecureBoot-enabled-VM.bash
14:23:12 sean-k-mooney what we would praobly want to do is convert that into a diskimage builder element
14:23:28 sean-k-mooney then have nodepool build it for us
14:23:46 sean-k-mooney and cache it on the provieders
14:24:27 lyarwood can the instances pull images from glance in these envs?
14:24:42 lyarwood or swift
14:24:47 lyarwood I guess so
14:24:59 sean-k-mooney i dont think so . i mean they could but dont have logisn to do so
14:25:05 kashyap Yeah, that's the question. The simplest way to get this going is to have a pre-made template (which I'll make) image that Just Works
14:25:24 sean-k-mooney but ya having nodepool upload it as a glance image to the base cloud was one of the thigns i was thinking of
14:25:40 sean-k-mooney but infra also publish the images too on a webshare
14:27:42 sean-k-mooney here https://nb03.opendev.org/
14:27:57 sean-k-mooney actully no that the lgos there is a place
14:32:00 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Remove allocations before setting vm_status to SHELVED_OFFLOADED https://review.opendev.org/c/openstack/nova/+/771985
14:32:30 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: Remove allocations before setting vm_status to SHELVED_OFFLOADED https://review.opendev.org/c/openstack/nova/+/771986
14:58:34 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Add spec for configurable-instance-hostnames https://review.opendev.org/c/openstack/nova-specs/+/770842
14:58:52 stephenfin gibi: Address your comments ^
14:59:13 stephenfin lyarwood: Fancy looking at that simple spec today? ^
14:59:59 lyarwood stephenfin: yup
15:00:13 lyarwood stephenfin: wasn't the deadline EOD yesterday ;)
15:01:33 gibi the deadline was EOD yesterday :/
15:02:36 gibi stephenfin: do you want to persuade me to allow a small deadline extension for that? ;)
15:02:39 kashyap gibi: If it's quick, and stephenfin is on fire, any problem in merging it? I'm asking from a purely bystander PoV :-) I don't need that feature myself
15:03:09 gibi kashyap: no real problem, the worst thing is that we will not have time to implement it or review the implementation of it
15:05:51 melwitt elod: re: https://review.opendev.org/c/openstack/nova/+/747362 I had thought the cherry pick check would catch wrong hashes? :/
15:05:56 kashyap gibi: (Nod)
15:07:17 gibi sean-k-mooney: hi! I don't find the bp https://blueprints.launchpad.net/nova/+spec/port-scoped-sean-k-mooney: I don't find the bp https://blueprints.launchpad.net/nova/+spec/port-scoped-sriov-numa-affinity behind https://review.opendev.org/c/openstack/nova-specs/+/765901 spec
15:07:53 sean-k-mooney oh i might not have filed it ill check just on a call
15:08:01 gibi sean-k-mooney: cool, thanks
15:08:11 gibi just link me to the bp and I will approve it as the spec was mereged
15:09:17 elod melwitt: it did catch :)
15:10:23 melwitt elod: oh, good. ah, it hadn't had its zuul result yet at the time I reviewed. ok, all makes sense now :)
15:10:35 stephenfin gibi: I have the code done and the change is small, but it's also probably not important enough to warrant a spec freeze exception
15:10:51 gibi stephenfin: let's merge it today
15:10:55 gibi lyarwood: ^^
15:11:45 spatel sean-k-mooney: thank for you comments - https://bugs.launchpad.net/nova/+bug/1912273
15:11:46 openstack Launchpad bug 1912273 in OpenStack Compute (nova) "SRIOV instance Error: Exception during message handling: KeyError: 'pci_slot'" [Undecided,Incomplete]
15:12:01 lyarwood gibi: ack, just on a call now, I'll review once this is over
15:12:14 gibi thanks

Earlier   Later