| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-19 | |||
| 18:19:00 | sean-k-mooney | why are we altering the templates by the way. | |
| 18:19:20 | sean-k-mooney | given grenade and the multi node one are both listed in our .zuul.yaml in the check pipeline | |
| 18:19:45 | sean-k-mooney | https://github.com/openstack/nova/blob/master/.zuul.yaml#L443-L470 | |
| 18:20:09 | sean-k-mooney | given noone else use integrated-gate-compute | |
| 18:20:22 | sean-k-mooney | im not sure moving grenade into that nessisarly helps | |
| 18:22:00 | sean-k-mooney | im not sure maintianing https://opendev.org/openstack/tempest/src/branch/master/zuul.d/integrated-gate.yaml#L369-L383 makes sense | |
| 18:22:22 | sean-k-mooney | at least im not sure it should live in tempest | |
| 18:22:52 | gmann | sean-k-mooney: it need to be at central place in QA side. | |
| 18:22:59 | sean-k-mooney | same for the other project for that matter | |
| 18:23:07 | sean-k-mooney | i dont really thing it does | |
| 18:23:37 | gmann | this can be extended in future to add slow test job too which is currently not separated out as such | |
| 18:24:10 | sean-k-mooney | it could but since we would want the project input when doing that | |
| 18:24:18 | sean-k-mooney | does it not make sense to defien it in the proejcts | |
| 18:24:52 | gmann | its both project and QA | |
| 18:25:45 | sean-k-mooney | right but it feels odd that tempest would reference any job not defiend in it in that template | |
| 18:27:28 | sean-k-mooney | gmann: if dansmith is ok with it i guess its fine it just feels odd that the qa team would be defining jobs that run against nova outside of the nova repo | |
| 18:27:43 | dansmith | tons of jobs are like that? | |
| 18:27:51 | dansmith | we define jobs other projects run | |
| 18:28:06 | sean-k-mooney | well i dont know tha tfeels more elective | |
| 18:28:19 | sean-k-mooney | i guess its just greneade the feels weried to me | |
| 18:28:22 | sean-k-mooney | i dotn know why | |
| 18:28:34 | sean-k-mooney | i know all the tox jobs work this way | |
| 18:28:53 | sean-k-mooney | i just wasnt expecting to see grenade in those templates | |
| 18:29:35 | sean-k-mooney | since that was managed in tree by project grenade supported | |
| 18:30:44 | sean-k-mooney | for example neutron https://github.com/openstack/neutron/blob/master/zuul.d/project.yaml#L21-L22 | |
| 18:32:15 | sean-k-mooney | although they do not use integrated-gate-networking | |
| 18:33:41 | sean-k-mooney | gmann: ignore me ill get used to it | |
| 18:34:07 | gmann | neutron has done this changes due to the such optimization only like multiple grenade jobs running | |
| 18:34:23 | gmann | template help in long term when we extend it to cover the common things. | |
| 18:34:51 | sean-k-mooney | im not sure what else you would add | |
| 18:35:20 | gmann | slow job is one in list which should be optimize per integrated service and run on gate | |
| 18:35:38 | sean-k-mooney | if this was a PTI template or something sure but this partly feels like a resstion to defining everything in the project_config repo | |
| 18:35:39 | gmann | integrated-gate-compute does not cover all the tempest tests | |
| 18:35:58 | sean-k-mooney | gmann: yes but im not sure we want it too | |
| 18:36:14 | sean-k-mooney | if we did we would need to test multipel storage backend for example | |
| 18:36:15 | gmann | overall idea is have a common template which can cover all the related tests (which might be in different jobs due to requried configuration) | |
| 18:36:26 | sean-k-mooney | so we would need at least 2 jobs running full tempest | |
| 18:36:55 | gmann | 'full tempest' cannot be covered by two jobs. full name is confusing there always :) | |
| 18:37:33 | sean-k-mooney | no i meen we need two jobs running all tempest test with different config | |
| 18:38:17 | sean-k-mooney | for exmple nova libvirt backed has 3 ways to pass sotrage to a guest so if you wante test all 3 with live migraiton you need basially 2 jobs | |
| 18:38:43 | sean-k-mooney | one with lvm/iscis to test cinder voluems and block stoarge and one with ceph to test qemu driect connect | |
| 18:38:53 | sean-k-mooney | *qemu network stoage | |
| 18:39:16 | sean-k-mooney | we also have thigs liek multi cell | |
| 18:39:32 | sean-k-mooney | so if you want to test every thign in gate you have to run most of check again | |
| 18:40:32 | sean-k-mooney | personally i think the way we defien the jobs in the project repo today is better then trying to put service speicic repos in tempest | |
| 18:40:52 | gmann | sure, I mean all tempest tests at least with any one configuration. | |
| 18:41:30 | gmann | we have tests also in Tempest for 6 services so same way jobs. I feel that is easy to maintain and control also | |
| 18:42:18 | gmann | previously infra used to do that, maintain integrated template. and with migration to opendev it is more QA doing those jobs | |
| 18:43:31 | sean-k-mooney | right but i am not sure its adding much value currently at least for nova everythin in the template is also in our project config | |
| 18:43:59 | sean-k-mooney | if we removed - integrated-gate-compute template it would not change the runnign jobs at all | |
| 18:45:03 | sean-k-mooney | we overrite the jobs in repo anyway https://github.com/openstack/nova/blob/master/.zuul.yaml#L451-L471 | |
| 18:45:11 | sean-k-mooney | https://github.com/openstack/nova/blob/master/.zuul.yaml#L497-L500 | |
| 18:45:29 | sean-k-mooney | so we can pass our own irrelevant-files list | |
| 18:59:10 | openstackgerrit | Merged openstack/nova stable/train: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761725 | |
| 19:55:23 | openstackgerrit | sean mooney proposed openstack/nova-specs master: libvirt: support vdpa kernel networking https://review.opendev.org/c/openstack/nova-specs/+/764999 | |
| 19:59:25 | sean-k-mooney | artom: hopefully that adds what you wanted ^ | |
| 20:00:10 | sean-k-mooney | gibi: stephenfin assuming artom is happy can ye rereivew tommorow | |
| 21:26:43 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/c/openstack/nova/+/758730 | |
| 21:27:18 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: libvirt: Skip encryption metadata lookups if secret already exists on host https://review.opendev.org/c/openstack/nova/+/765772 | |
| 21:27:36 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: Use absolute path during qemu img rebase https://review.opendev.org/c/openstack/nova/+/757098 | |
| 22:42:15 | openstackgerrit | Ghanshyam proposed openstack/nova master: DNM: Testing system scope in tempest https://review.opendev.org/c/openstack/nova/+/740124 | |
| #openstack-nova - 2021-01-20 | |||
| 07:07:01 | openstackgerrit | Hemanth N proposed openstack/nova stable/stein: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761727 | |
| 08:49:45 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | |
| 08:49:46 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | |
| 08:49:46 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | |
| 08:49:47 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace os-simple-tenant-usage with os-simple-project-usage https://review.opendev.org/c/openstack/nova/+/768852 | |
| 08:49:47 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace tenants* with projects* of policies https://review.opendev.org/c/openstack/nova/+/765315 | |
| 09:54:35 | brinzhang | stephenfin, gibi: there is a small change for the host.nodename, pls review, it's updated the sean-k-monney's comments in the shelve/unshelve patch https://review.opendev.org/c/openstack/nova/+/762499 | |
| 10:09:22 | stephenfin | brinzhang: ack | |
| 10:10:18 | stephenfin | lyarwood: Does the 'nova server-migration-list' command only list *ongoing* migrations or does it list all migrations in the past? | |
| 10:10:21 | stephenfin | (I don't have a multi-node deployment or I'd test this myself) | |
| 10:10:48 | stephenfin | I tried to migrate a server on single node deployment, which justifiably failed, but it doesn't appear in that list | |
| 10:16:10 | brinzhang | stephenfin: thanks | |
| 10:16:50 | lyarwood | stephenfin: I think it's all | |
| 10:17:00 | lyarwood | stephenfin: I don't have an env to check | |
| 10:20:36 | stephenfin | Okay, I'll say all for the OSC docs so | |
| 10:38:24 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: libvirt: Add support for flavor and image defined ephemeral encryption https://review.opendev.org/c/openstack/nova-specs/+/771474 | |
| 10:38:32 | lyarwood | gibi: ^ thanks for the review | |
| 10:39:21 | lyarwood | stephenfin / bauzas ; can I ask for reviews on that spec today please? Appreciate it's late etc, I should be able to respin quickly today outside of ~13:30-15:00 GMT | |
| 10:39:29 | stephenfin | sure thing | |
| 10:39:33 | lyarwood | thanks | |
| 10:39:40 | stephenfin | looking at artom's spec atm, that's next on the queue | |
| 10:41:02 | lyarwood | ack thanks, I'll also try to look at specs this morning | |
| 11:09:22 | hemanth_n | lyarwood stephenfin elod: sorry to bother you again, can you review stein backported patch https://review.opendev.org/c/openstack/nova/+/761727 when you get some time | |
| 11:38:09 | lyarwood | hemanth_n: looking | |
| 11:40:48 | openstackgerrit | Merged openstack/nova-specs master: `socket` PCI NUMA-affinity Policy https://review.opendev.org/c/openstack/nova-specs/+/765551 | |
| 11:40:53 | openstackgerrit | Merged openstack/nova-specs master: remove unicode from code https://review.opendev.org/c/openstack/nova-specs/+/769260 | |
| 11:49:17 | sean-k-mooney | stephenfin: this is why the trait is needed https://review.opendev.org/c/openstack/nova-specs/+/764999/4/specs/wallaby/approved/libvirt-vdpa-support.rst#79 | |
| 11:51:47 | stephenfin | sean-k-mooney: so it's an optimization. Would it make sense to avoid this pre-optimization and suggest that people use provider.yaml if they hit the issue? | |
| 11:52:18 | sean-k-mooney | its not really an optimisation in that you cant limit the placment allcoation set if you dont have it | |
| 11:52:33 | sean-k-mooney | if we were to go the provider.yaml route | |
| 11:52:38 | sean-k-mooney | then it would be a custom trait | |
| 11:52:48 | sean-k-mooney | whcih we can do but i would prefer to do that in code | |
| 11:52:57 | sean-k-mooney | i can drop it but it fells like a hack to not have it | |
| 11:53:04 | stephenfin | True. Same issue with PCI devices, NUMA topologies etc. though | |
| 11:53:28 | sean-k-mooney | not entirely the same thign although i waint traits for numa support | |
| 11:53:30 | stephenfin | Yeah, I'd agree with this normally but it does feel like we're using a trait as a stand in for proper resource reporting | |
| 11:53:33 | sean-k-mooney | i just have not needed them | |
| 11:53:56 | sean-k-mooney | well traits are for capablities | |
| 11:54:30 | sean-k-mooney | lets see what gibi thinks and ill go with whatever the two of ye decied unless other weigh in | |