| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-18 | |||
| 17:31:05 | kashyap` | gibi: Are you referring to this? | |
| 17:31:08 | kashyap` | live=live, | |
| 17:33:00 | gibi | kashyap`: https://github.com/openstack/nova/blob/5b65812ef2c6ac46bea30e2e603284eac232339e/nova/virt/libvirt/guest.py#L315 | |
| 17:33:28 | gibi | this is how nova checks if a device is in the config and I think it is checking the live config | |
| 17:34:06 | gibi | kashyap`: for vifs the code is here https://github.com/openstack/nova/blob/5b65812ef2c6ac46bea30e2e603284eac232339e/nova/virt/libvirt/guest.py#L230 | |
| 17:35:10 | gibi | I guess the key is self._domain.XMLDesc(0) in both case but I failed to find the proper doc what 0 means and what else I can plug there | |
| 17:35:31 | gibi | anyhow I have to drop off | |
| 17:35:33 | kashyap` | gibi: Ah, it's all custom parsing of the XML | |
| 17:35:33 | gibi | for today | |
| 17:35:42 | gibi | yep | |
| 17:35:47 | kashyap` | Yeah, I need to head out shortly too; we can work it out tomm | |
| 17:35:55 | gibi | kashyap`: thanks for the help, let's continue this tomorrow | |
| 17:35:59 | gibi | o/ | |
| 18:42:02 | gmann | gibi: stephenfin can either of you check this- https://review.opendev.org/c/openstack/placement/+/764394 | |
| 18:56:30 | elod | lyarwood: sorry, I was off today, but will look into the patches tomorrow | |
| 19:01:35 | openstackgerrit | sean mooney proposed openstack/nova-specs master: libvirt: support vdpa kernel networking https://review.opendev.org/c/openstack/nova-specs/+/764999 | |
| 19:04:02 | sean-k-mooney | artom: im proably going to call it there for today let me know if there is anything else you want me to adress in ^ | |
| 19:04:20 | sean-k-mooney | it will be tomorrow before i get to it proably | |
| 19:04:35 | artom | sean-k-mooney, cool, thanks! | |
| 19:04:56 | artom | Guyze. | |
| 19:05:03 | artom | Guyze guyze guyzes. | |
| 19:05:07 | artom | http://www.hardware.py/ is available! | |
| 19:06:06 | artom | Aww, it's restricted :( | |
| 19:10:25 | sean-k-mooney | hehe while agree the docs to that moduel are lacking im not sure it need its own webseit even thouh it could definetly fill one | |
| 19:12:57 | openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy https://review.opendev.org/c/openstack/nova-specs/+/765551 | |
| #openstack-nova - 2021-01-19 | |||
| 01:51:26 | openstackgerrit | Brin Zhang proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336 | |
| 05:56:44 | openstackgerrit | Rico Lin proposed openstack/nova master: add openstack-python3-wallaby-jobs-arm64 job https://review.opendev.org/c/openstack/nova/+/742094 | |
| 07:24:12 | openstackgerrit | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | |
| 07:24:12 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | |
| 07:24:13 | openstackgerrit | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | |
| 08:08:35 | gibi | lyarwood, kashyap: never mind I think I found the doc for XMLDesc https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetXMLDesc | |
| 08:40:09 | openstackgerrit | Xing Zhang proposed openstack/nova stable/train: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/c/openstack/nova/+/768736 | |
| 08:47:20 | lyarwood | gibi: sorry had already logged yesterday when you asked that | |
| 08:47:28 | lyarwood | teething-- | |
| 09:00:29 | lyarwood | stephenfin / sean-k-mooney ; https://review.opendev.org/c/openstack/nova/+/761725 - would you mind taking a look at this stable/train backport and the changes made for stable/train? LGTM from a stable core point of view. | |
| 09:19:15 | kashyap | gibi: Ah, nod | |
| 09:27:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Add nova-live-migration-ceph job https://review.opendev.org/c/openstack/nova/+/768466 | |
| 09:28:46 | lyarwood | finally \o/ | |
| 09:29:15 | lyarwood | still needs some devstack-plugin-ceph and devstack changes to land but it's almost there | |
| 09:29:36 | lyarwood | then it's just the multinode grenade job iirc | |
| 09:33:18 | openstackgerrit | Merged openstack/nova-specs master: Libvirt supports composing cyborg owned vGPU accelerator into domain XML https://review.opendev.org/c/openstack/nova-specs/+/750116 | |
| 09:36:43 | stephenfin | lyarwood: looking | |
| 10:01:57 | lyarwood | did we agree on a spec review day before the deadline btw? | |
| 10:02:17 | lyarwood | I'm trying to finish the libvirt eph encryption spec today for review but appreciate it's pretty late | |
| 10:20:38 | bauzas | lyarwood: no, we said no during the meeting | |
| 10:21:01 | bauzas | but we can continue to look at the specs | |
| 10:21:01 | lyarwood | bauzas: ack thanks, and the deadline is Thursday for specs right? | |
| 10:21:05 | bauzas | correct | |
| 10:21:17 | lyarwood | bauzas: ack thanks, I'll get this posted today and go from there | |
| 10:21:19 | bauzas | ++ | |
| 10:24:11 | sean-k-mooney | lyarwood: yep just have a meeting in a at half past but ill look at it after. i am familar with the backport and it is something we shoudl do but ill do an actual review after the meeting | |
| 10:24:57 | bauzas | stephenfin: do you want to have +2/+W for all the series before merging https://review.opendev.org/c/openstack/nova/+/758155 or do you prefer to merge each of them | |
| 10:24:59 | bauzas | ? | |
| 10:25:01 | openstackgerrit | Merged openstack/placement master: [goal] Deprecate the JSON formatted policy file https://review.opendev.org/c/openstack/placement/+/764394 | |
| 10:25:06 | bauzas | honestly, I'm fine with both | |
| 10:25:27 | stephenfin | bauzas: they can go in individually | |
| 10:25:49 | bauzas | sure, I was asking for the series, but at least the first can be merged now | |
| 10:26:58 | stephenfin | yeah, I don't think there'll be a case where patch N has to change because of something in M, if that's what you mean. No dependencies | |
| 10:27:10 | stephenfin | at least not in that way | |
| 10:36:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Liberty database migrations https://review.opendev.org/c/openstack/nova/+/759399 | |
| 10:36:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Newton database migrations https://review.opendev.org/c/openstack/nova/+/759401 | |
| 10:36:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Mitaka database migrations https://review.opendev.org/c/openstack/nova/+/759400 | |
| 10:36:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Pike database migrations https://review.opendev.org/c/openstack/nova/+/759403 | |
| 10:36:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Ocata database migrations https://review.opendev.org/c/openstack/nova/+/759402 | |
| 10:36:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Rocky database migrations https://review.opendev.org/c/openstack/nova/+/759405 | |
| 10:36:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Queens database migrations https://review.opendev.org/c/openstack/nova/+/759404 | |
| 10:36:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Add manage.py script https://review.opendev.org/c/openstack/nova/+/771419 | |
| 10:36:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Stein database migrations https://review.opendev.org/c/openstack/nova/+/759406 | |
| 10:36:35 | openstackgerrit | Stephen Finucane proposed openstack/nova master: apidb: Compact Train database migrations https://review.opendev.org/c/openstack/nova/+/771420 | |
| 10:43:22 | bauzas | stephenfin: no worries, for the moment, I don't see any issue with this | |
| 11:04:51 | elod | lyarwood: I've commented on the train backport patch you mentioned yesterday | |
| 11:06:35 | elod | lyarwood: this one: https://review.opendev.org/c/openstack/nova/+/770944 | |
| 11:07:01 | elod | lyarwood: I'd rather not backport those 2 patches :/ | |
| 11:09:08 | lyarwood | elod: ack, I'll add context in the review but tl;dr downstream our OSP 16 release maps to stable/train and we plan on keeping it around until ~2025 https://access.redhat.com/support/policy/updates/openstack/platform/ | |
| 11:09:26 | lyarwood | elod: we've backported a few things downstream and hit issues with pyflakes 1.2.3 not supporting f-strings | |
| 11:09:41 | lyarwood | elod: and assume that in the future we could easily also land things upstream that hit the same issue | |
| 11:10:04 | lyarwood | elod: as this is just a lint tooling bump we thought we'd try to land this in stable/train first before doing anything downstream only | |
| 11:10:29 | lyarwood | maybe that wasn't a true tl;dr but hopefully you see what I was trying to do now ;) | |
| 11:15:42 | elod | lyarwood: in train python 2 is still there, and f-sting is not in python2 | |
| 11:16:20 | elod | I guess you support train with python3 (of course) | |
| 11:16:55 | lyarwood | elod: yeah indeed only on py36 downstream | |
| 11:17:12 | lyarwood | elod: was it a supported runtime in stable/train? | |
| 11:17:29 | lyarwood | ah it was | |
| 11:17:33 | lyarwood | okay then ignore me | |
| 11:17:35 | elod | the job is still there | |
| 11:17:37 | lyarwood | sorry I thought it wasn't | |
| 11:17:39 | lyarwood | https://governance.openstack.org/tc/reference/runtimes/train.html | |
| 11:17:45 | lyarwood | I'll just backport these downstream | |
| 11:17:53 | lyarwood | apologies for the noise | |
| 11:18:38 | elod | lyarwood: ussuri is the 1st one without py2 | |
| 11:18:46 | elod | lyarwood: no problem | |
| 11:19:15 | lyarwood | yup ETOOMANYVERSIONS :) | |
| 11:19:22 | elod | lyarwood: I just don't feel it appropriate upstream :/ | |
| 11:19:45 | lyarwood | yup it isn't if we support py27 still as f-strings are not valid in stable/train as a result | |
| 11:19:58 | lyarwood | I'll just modify the backports downstream to avoid this and move on | |
| 11:20:07 | lyarwood | as it's only f-strings | |
| 11:20:31 | elod | lyarwood: ok, thanks | |
| 11:24:05 | bauzas | stephenfin: man, I don't know how other people do for reviewing your DB changes, but it'll need time for me for looking at all the modifications for https://review.opendev.org/c/openstack/nova/+/758394/4 | |
| 11:25:37 | stephenfin | bauzas: You can put this script in the root of your nova repo, run it on master and then it run after the change is applied, comparing the diff (there shouldn't be one) https://review.opendev.org/c/openstack/nova/+/769796 | |
| 11:25:46 | stephenfin | I've done that a few times now | |