Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-14
15:59:38 lyarwood gibi: feel free to pull that out and rebase it under your changes
16:00:11 gibi lyarwood: I think I will do it but not today
16:00:11 gibi lyarwood: ack
16:00:30 lyarwood gibi: np
16:06:18 sean-k-mooney andrewbogott: its the user keypair yes
16:06:42 sean-k-mooney not an unique constratint or forien key at the db level
16:06:55 andrewbogott and yet the migration fails if it's unset :/
16:07:10 andrewbogott I don't see keypairs in my db though, I see mostly NULLS and some json elsewhere
16:07:14 andrewbogott https://www.irccloud.com/pastebin/CIh6rCTi/
16:07:15 sean-k-mooney yep so it looke like you missed a previous migration to populate tehm
16:09:54 andrewbogott maybe. My test cloud has the same weird state. Lots of nulls, a few json objects.
16:10:23 andrewbogott anyway I can insert the empty json object into my null records
16:13:31 andrewbogott ok, I've confirmed that the keypair issue is not the thing that's breaking my migration. It fails gracefully if there are no keypairs, as it should.
16:29:23 lyarwood melwitt: https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/711625 - so this works if I enable c-bak and c-vol on the subnode, fun.
16:43:09 sean-k-mooney bauzas: so lookign that the cyborg vgpu spec the last version i reviewd was version 9
16:43:16 sean-k-mooney bauzas: what was your outstanding issue
16:43:51 bauzas sean-k-mooney: the 'other deployer impact' section, starting PS12 AFAICR
16:44:11 sean-k-mooney it looks like many of my comments were adress but i need to review it porperly
16:44:18 sean-k-mooney ah the advataghes stuff
16:44:32 bauzas and the fact that they weren't using the same methods for modifying the XML, but eventually the last revision fixes it
16:44:53 sean-k-mooney ya
16:45:03 bauzas anyway, /me needs to stop working early
16:45:03 sean-k-mooney that is one of the the thigns i rememebred
16:45:17 sean-k-mooney i porably would just drop the comparison form the spec
16:45:29 sean-k-mooney in the other deployer impact section
16:45:42 sean-k-mooney and jsut leave the note about not configuring the same device in both services
16:45:43 bauzas sean-k-mooney: that's my point indeed
16:45:48 bauzas yeah
16:46:16 sean-k-mooney ok ill leave the same comment after i do a full review
16:46:32 bauzas my other concern would be to maybe use the same module for creating both inventories
16:46:46 bauzas but we could do it as a follow-up
16:46:53 bauzas like, creating a common package
16:47:13 bauzas for both the cyborg agent and the nova-libvirt code
16:47:29 bauzas this way, gibi's concerns about maintenance would be fixed
16:47:47 bauzas if both services would eventually share the same code
16:47:59 bauzas anyway, /me needs to run
16:48:20 sean-k-mooney as in a shared lib
16:48:37 sean-k-mooney we could but im not sure we want to create a new repo at this point in the cycle
16:49:00 sean-k-mooney given the pacakging work that would entail
16:49:18 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP zuul: Add nova-live-migration-ceph job https://review.opendev.org/c/openstack/nova/+/768466
16:50:08 sean-k-mooney bauzas: i tought gibis main concern in relation to code duplciation was the rest of the code for tracking and assigning mdevs
16:50:19 sean-k-mooney although i may have misread that
16:52:20 sean-k-mooney andrewbogott: by the way did you do the normal db migration before running the online ones?
16:52:32 sean-k-mooney andrewbogott: e.g. nova-manage db sync
16:52:35 andrewbogott I did
16:53:13 andrewbogott sean-k-mooney: I've now determined that the keypair errors were a red herring. It might be that the whole thing was a red herring and stdout was just overly verbose but I need to circle back.
16:53:26 andrewbogott the keypair migration throws a log warning about missing keypairs but moves on as it should
16:53:48 sean-k-mooney andrewbogott: so it might be related to this
16:53:50 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/633351/31/nova/objects/instance_mapping.py#250
16:54:02 sean-k-mooney we skipi instance that dont have instance cell mappings
16:54:29 andrewbogott yeah, I think that's likely the issue. I need to get out of my deployment window and then I'll circle back and debug :)
16:54:29 sean-k-mooney so before you run that you need to ensure all instance have the cell mappings set
16:55:01 andrewbogott hm, I thought that the cell mapping thing was handled by an upgrade script many versions ago
16:55:09 andrewbogott but since I only have one cell it should be easy to fix by hand in the db
16:56:14 sean-k-mooney it could be deleted but unachived/purged isntances
16:56:28 sean-k-mooney which is why it suggest nova-manage db archive_deleted_rows --purge
16:57:19 andrewbogott yeah, I ran that but it didn't do anything (didn't report anything on stdout and also didn't affect behavior of the migration)
17:01:17 sean-k-mooney ya so i would guess you jsut need to add the mappings and hopefully it will correct the isseu you have
17:19:16 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING https://review.opendev.org/c/openstack/nova/+/754702
17:19:18 lyarwood gibi: ^ fixed, sorry about that.
17:24:24 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIR_ERR_DEVICE_MISSING https://review.opendev.org/c/openstack/nova/+/754702
17:36:49 lyarwood does anyone recall where we list the supported distros for a release?
17:37:06 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Add spec for configurable-instance-hostnames https://review.opendev.org/c/openstack/nova-specs/+/770842
17:37:08 stephenfin lyarwood: that was in the wiki
17:37:24 stephenfin actually, no - I'm thinking of the libvirt version matrix
17:38:04 lyarwood https://github.com/openstack/governance/blob/2bdd9cff00fb40b2f95b66cad47ae1cfd14a2f1b/reference/project-testing-interface.rst#linux-distributions is all I can find
17:38:16 stephenfin artom: Looking at your spec now, but just FYI I've a super low priority proposal for a '--hostname' parameter here https://review.opendev.org/c/openstack/nova-specs/+/770842 Had a look earlier and it's pretty easy
17:38:19 lyarwood and yeah our distro matrix in the wiki just lists versions
17:38:27 stephenfin lyarwood: fungi would probably know
17:38:33 stephenfin lyarwood++ good call
17:38:57 fungi it's in governance, getting it now
17:39:48 fungi https://governance.openstack.org/tc/reference/runtimes/wallaby.html
17:39:49 lyarwood oh sorry I see the runtime link at the bottom now, helps if I view the hosted page instead of the source
17:39:57 lyarwood fungi: many thanks
17:40:00 fungi yw
17:42:41 sean-k-mooney fungi: that does not cover libvirt verions
17:42:46 sean-k-mooney or qemu
17:43:01 sean-k-mooney we manage that seperatly
17:43:28 lyarwood I didn't need that, just the distros
17:43:48 sean-k-mooney ah then ya latest lts of ubuntu centos and suse
17:43:48 lyarwood or openSUSE sorry
17:44:39 sean-k-mooney fungi: has there been any moemente on updating centos 8 sot centos 8 stream
17:44:54 sean-k-mooney fungi: i assume we will change that in X
17:45:27 fungi sean-k-mooney: i'm not aware of any tc level decision around that yet. discussions were that we only needed to solve it for the cycle in which 8 becomes eol
17:45:49 sean-k-mooney ok so i guess technialy Y then
17:46:02 sean-k-mooney EOL is decemebr
17:46:06 fungi though i'm not entirely sure what it means for stable branches which supported 8 and how we choose to test them
17:46:25 sean-k-mooney ya
17:46:38 fungi since opendev doesn't usually continue to provide images for eol distro versions for very long
17:46:46 sean-k-mooney one option might be to use rocky linux or one of the repelacement for centos
17:47:41 sean-k-mooney i guess we will see how things play out
17:48:59 sean-k-mooney centos 8 stream should sablise once centos 9 stream is a thing but no idea when that will be a thing or how long centos 8 stream will be supported when its released
17:58:02 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_BLOCKDEV https://review.opendev.org/c/openstack/nova/+/754701
17:58:02 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/c/openstack/nova/+/754703
17:58:03 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_S390X_CPU_COMPARE https://review.opendev.org/c/openstack/nova/+/754704
18:05:34 openstackgerrit sean mooney proposed openstack/nova stable/train: only wait for plugtime events in pre-live-migration https://review.opendev.org/c/openstack/nova/+/770844
18:11:53 stephenfin lyarwood: Seeing as you're looking at DB stuff at the moment, think you could take a look at these, my two oldest outstanding patches? :) https://review.opendev.org/c/openstack/nova/+/530905/ https://review.opendev.org/c/openstack/nova/+/530487/
18:12:44 openstackgerrit sean mooney proposed openstack/nova master: use psycopg2 binary instead of source package https://review.opendev.org/c/openstack/nova/+/770473
18:16:30 sean-k-mooney stephenfin: why do we need uuid in the pci devices table?
18:18:04 sean-k-mooney oh its for tracking them in placment

Earlier   Later