Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-12
17:48:26 lyarwood nope, my connection to my VPS stalled again
17:48:32 lyarwood at least it appears to
17:48:49 lyarwood no updates on my screen session until I ssh back in etc
17:49:42 lyarwood ~. was just to force ssh to die so I could log back in, looks like I borked the first attmept ^_^
17:50:22 sean-k-mooney ah right the sential escape sequence
17:50:35 sean-k-mooney i normally only have to use that with ipmi or some other serial connection
17:50:54 sean-k-mooney but i have had that kill my putty conenction before where they were the same
17:51:21 lyarwood yeah I think there's something up with the network on my vps (DO) tbh this has been going on since before the break
17:53:29 sean-k-mooney two days before we got back my server decided to not negociate full duplex connectivity. networking proablems that just happen are awsome...
17:53:48 sean-k-mooney my home cloud is now running on 2 usb 1 gig nics
17:55:10 sean-k-mooney huh i guess those are usb3 ports just hit 870mbps over the link lol
18:05:16 sean-k-mooney lyarwood: regarding the ppc unit test failures
18:05:48 sean-k-mooney lyarwood: could we set an arch env var and use a fixture to mock out different architetures
18:06:25 sean-k-mooney then jsut run OS_ARCH=ppc tox -e py3
18:06:52 sean-k-mooney we will see if ibm can run the tests it sound like they will be able too
18:07:06 sean-k-mooney but if not im wondering if we can fake it in the jobs
18:09:44 sean-k-mooney i guess that would not be quite the same as running them on ppc64le
18:30:45 lyarwood sean-k-mooney: sorry was afk, that could be one way of fixing this, https://review.opendev.org/c/openstack/nova/+/769920 has shown a huge number of tests calling arch.from_host that would need to be covered.
18:34:20 sean-k-mooney ya although we generally expect the test to be written as arch independent event if its called underneath
18:35:05 sean-k-mooney so even if they call it doesnt mean its wrong nessacaraly but im not suprrised to se the libvirt tests there
18:35:31 sean-k-mooney we check the arch on startup of the libvirt driver
18:37:49 lyarwood That should be easy enough to resolve there
18:38:21 lyarwood mock it out to return x86_64 and just override it for the specific tests for other archs
18:38:51 lyarwood anyway, that's something for closer to M3 unless others want to pick it up
20:31:23 artom Is there a list of the "tags" available in nova-specs (or specs in general I suppose)
20:31:40 artom Specifically I want something to indicate an aside, or annex (but inline, and not at the end)
20:56:04 openstackgerrit sean mooney proposed openstack/nova master: add constants for vnic type vdpa https://review.opendev.org/c/openstack/nova/+/770474
20:56:04 openstackgerrit sean mooney proposed openstack/nova master: use psycopg2 binary instead of source package https://review.opendev.org/c/openstack/nova/+/770473
20:56:20 sean-k-mooney artom: maybe just put it in ()
21:22:00 openstackgerrit Artom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy https://review.opendev.org/c/openstack/nova-specs/+/765551
21:27:45 artom sean-k-mooney, so apparently seealso is a thing, though I'm the first one to use it in Nova.
21:27:55 artom It sorta fits what I want.
#openstack-nova - 2021-01-13
01:28:14 openstackgerrit Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311
01:28:14 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292
02:35:49 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380
04:57:41 openstackgerrit sean mooney proposed openstack/os-traits master: add vdpa trait https://review.opendev.org/c/openstack/os-traits/+/770530
05:12:07 openstackgerrit sean mooney proposed openstack/os-traits master: add vdpa trait https://review.opendev.org/c/openstack/os-traits/+/770530
05:14:27 openstackgerrit sean mooney proposed openstack/nova master: [WIP] add vdpa nodedev parsing and interface config gen https://review.opendev.org/c/openstack/nova/+/770532
05:14:28 openstackgerrit sean mooney proposed openstack/nova master: [WIP] add vdpa trait reporting. https://review.opendev.org/c/openstack/nova/+/770533
05:21:10 openstackgerrit sean mooney proposed openstack/nova master: add constants for vnic type vdpa https://review.opendev.org/c/openstack/nova/+/770474
05:21:11 openstackgerrit sean mooney proposed openstack/nova master: [WIP] add vdpa trait reporting. https://review.opendev.org/c/openstack/nova/+/770533
05:21:11 openstackgerrit sean mooney proposed openstack/nova master: [WIP] add vdpa nodedev parsing and interface config gen https://review.opendev.org/c/openstack/nova/+/770532
05:47:30 openstackgerrit sean mooney proposed openstack/nova master: [WIP] add vdpa prefilter https://review.opendev.org/c/openstack/nova/+/770534
07:55:03 gibi good morning
08:48:44 lyarwood Morning
08:49:43 gibi lyarwood: melwit explained one of my questions in the detach patch, so I have things to do with that patch, but if you have any other hints about open question then I would be glad to discuss
08:51:51 lyarwood gibi: I've just got the change open now, let me take a look
08:51:56 gibi cool
08:52:12 gibi I promise I will not dissapera now for couple of hours :)
09:12:14 lyarwood gibi: okay updated, I need to check if there's an internal libvirt timeout for these detach events
09:15:56 lyarwood gibi: ah nope, it's raised on a sync failure, there's no async checking within libvirtd that raises it
09:16:22 lyarwood I didn't post my comments anyway, doh!
09:18:53 gibi lyarwood: thanks
09:19:06 gibi lyarwood: yeah, the persisten/live error comes synchronously
09:20:45 gibi lyarwood: do you happen to know that when we check that the device is in the domain does that check looks into the live domian?
09:23:33 lyarwood gibi: iirc we use XMLDesc(0) to dump the domain and that's the live config
09:23:50 lyarwood gibi: there was a bug about this for paused instances iirc
09:24:06 lyarwood gibi: where we need to provide the VIR_DOMAIN_XML_INACTIVE flag https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags
09:27:20 gibi lyarwood: thanks, so we check the live config, thats good, then if the synch error came then we can simply check the live domain and it device is there then we can retry
09:29:19 lyarwood gibi: yeah I'd continue to retry on a direct sync error if the device is still there, VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED (but that should be a direct sync failure?) and a configurable timeout within n-cpu
09:29:44 gibi VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED is the failed event
09:29:51 gibi so tathat is async
09:30:37 gibi I can unify the retry if we get sync or async failure and the device is still in the live domain then we retry
09:30:48 lyarwood right sorry my point was that within libvirt at least it looks like that's only actually raised synchronously with the failure of the initial request to QEMU and that should bubble up directly to our call to libvirt
09:31:06 lyarwood yup cool that works
09:31:29 lyarwood I'm likely missing something in the libvirt code anyway regarding where VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED is being raised so that sounds like the best approach
09:32:10 gibi ack, thanks for the help
09:32:53 gibi if you get the libvirt timeout value for detach event then let me know and I will update the nova timeout value to be bigger
09:35:05 lyarwood kashyap: https://review.opendev.org/c/openstack/nova/+/770246 ; you might be interested in this, gibi is trying to rewrite our detach device logic in the libvirt driver to use events. I've made some comments in the change but if you have anymore context feel free to add it there.
09:35:34 kashyap lyarwood: Yeah, was just skimming the chat here. Was responding to something downstream that was breathing down my neck
09:35:41 lyarwood np
09:37:51 lyarwood switching topics, stephenfin how's your SQL/sqlalchemy foo? trying to work out if 1. the following is a valid query for a nova-status command and 2. if it would work in sqlalchemy.
09:37:58 lyarwood select distinct instances.uuid from instances left join instance_system_metadata on instances.uuid = instance_system_metadata.instance_uuid where instances.uuid not in (select instance_system_metadata.instance_uuid from instance_system_metadata where instance_system_metadata.key = 'hw_machine_type');
09:38:23 lyarwood tl;dr I'm trying to list the instance uuids that *don't* have a `hw_machine_type` key set in instance_system_metadata
09:38:50 lyarwood and it has been waaaaaaaaaaaay too long since I wrote any SQL so this might be entirely wrong
09:40:13 kashyap gibi: Thx for taking up that; I just skimmed the patch. I'll look deeper; once I switch context.
09:41:29 gibi kashyap: thanks
09:41:30 lyarwood oh and that reminds me, sean-k-mooney, you know how you asked if we could stash image metadata properties in instance_system_metadata? Well they are already there.
09:42:01 stephenfin lyarwood: It's not my strongest skill, but that does look reasonable to me. I don't think the subquery is necessary, but the syntax I'm thinking of could be backend-specific
09:42:22 lyarwood sean-k-mooney: https://github.com/openstack/nova/blob/e6f5e814050a19d6f027037424556b2889514ec3/nova/objects/image_meta.py#L113-L127
09:43:37 lyarwood stephenfin: yeah I couldn't work out the SQL to select instances.uuid where instance_system_metadata.key doesn't contain 'hw_machine_type'
09:45:05 lyarwood stephenfin: I'll convert this into sqla for now and go from there, thanks
09:47:30 stephenfin lyarwood: 0c441e636ba9d287909584b6ddf15eab5d479f0e would be good prior art also
09:48:24 stephenfin If not an exact match, at least it might help in terms of wiring up the machinery for an online migration
09:49:30 lyarwood stephenfin: I wasn't going to write an online migration for this
09:49:43 lyarwood stephenfin: this is something n-cpu will populate at startup
09:50:01 lyarwood stephenfin: and nova-status can warn about later prior to changing defaults
09:50:06 stephenfin ah, gotcha
09:50:13 lyarwood stephenfin: I don't see a query in that change FWIW
09:50:23 lyarwood well not a join etc
10:28:38 openstackgerrit YumengBao proposed openstack/os-traits master: add owner traits for accelerator resources https://review.opendev.org/c/openstack/os-traits/+/770569
10:32:33 openstackgerrit Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726
10:34:06 gibi brinzhang, alex_xu: responded in https://review.opendev.org/c/openstack/nova/+/729563 (finally)
10:34:47 openstackgerrit Kashyap Chamarthy proposed openstack/os-traits master: Add a trait for UEFI Secure Boot support https://review.opendev.org/c/openstack/os-traits/+/770570
10:42:01 openstackgerrit Stephen Finucane proposed openstack/python-novaclient master: Add support for microversion v2.88 https://review.opendev.org/c/openstack/python-novaclient/+/770573
10:49:35 brinzhang gibi: so we wont merge this patch, right?
11:46:55 gibi brinzhang: we need a separate bugfix, that is all what I said
11:48:09 brinzhang IMO, the bug fix shuold not prevent this patch go
11:48:30 brinzhang we shuold register a bugfix, and then fix it
11:51:58 gibi brinzhang: yepp, that works for me

Earlier   Later