| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2021-01-12 | |||
| 15:42:32 | sean-k-mooney | stephenfin reviewed suggestions inline | |
| 15:43:08 | sean-k-mooney | stephenfin: nothing major, more or less looks fine | |
| 15:58:14 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: DNM try to replace retry with libvirt event in detach https://review.opendev.org/c/openstack/nova/+/770246 | |
| 15:58:20 | gibi | lyarwood: sorry it was a hectic day. I my current attempt on the detach event ^^ it passes some volume and interface detach tempest cases locally and the logs seems OK. But I have no way to generate slow libvirt related scenarios ^^ | |
| 15:58:26 | gibi | and again I have to leave the keyboard | |
| 15:58:37 | gibi | so we can talk about it maybe today | |
| 15:59:31 | gibi | melwitt: ^^ | |
| 15:59:41 | gibi | s/today/tomorrow/ | |
| 16:01:40 | sean-k-mooney | gibi: in func test you could jsut add a sleep right | |
| 16:02:23 | lyarwood | sean-k-mooney: the race is within QEMU so that isn't going to help unfortunatley | |
| 16:02:44 | sean-k-mooney | well its not really | |
| 16:03:10 | sean-k-mooney | the race was we were just retyrin gon a timer while the async operation in qemu was running | |
| 16:04:01 | sean-k-mooney | we cant recreate that behavior but we can simulate a slow libvirt event | |
| 16:04:16 | sean-k-mooney | it depends on what gibi actully wanted to recreate | |
| 16:05:21 | lyarwood | I don't see any value in simulating a slow event tbh, we should just be asserting that we don't retry the detach without getting a _FAILED event back from libvirt etc | |
| 16:05:46 | sean-k-mooney | lyarwood: well we could do that by posing the detach call | |
| 16:06:38 | sean-k-mooney | e.g. after the first invocation make it soe it raises an error if called again until we fail or complete | |
| 16:07:36 | sean-k-mooney | anyway im going to jsut review what gibi has instead of speculating | |
| 16:33:20 | bauzas | sean-k-mooney: quick question, do you know if an instance has 2 ports, the instance should use the same subnet for routed networks ? | |
| 16:35:24 | bauzas | nevermind, I'll provide a FIXME | |
| 16:36:18 | sean-k-mooney | no it can have different subnets in that case but they should be on the same segment | |
| 16:36:28 | sean-k-mooney | well technically that is not required either | |
| 16:36:36 | sean-k-mooney | but the host need to be connect ot both segment | |
| 16:36:46 | sean-k-mooney | if the subnets are form different ones | |
| 16:37:14 | sean-k-mooney | we need a host that would be in the intersection of all segments required by the ports | |
| 16:37:38 | sean-k-mooney | the simpelst case of tha twould be both ports are in the same subnet/segment | |
| 16:37:59 | sean-k-mooney | if the host has multiple nic however you can have other toplogies that are valid | |
| 17:09:59 | stephenfin | sean-k-mooney: addressed your comments on https://review.opendev.org/q/project:openstack/python-openstackclient+is:open+owner:stephenfin%2540redhat.com+branch:master+file:compute+is:mergeable | |
| 17:10:05 | stephenfin | let me know if anything isn't clear :) | |
| 17:12:15 | sean-k-mooney | thanks ill rereview them now | |
| 17:24:49 | sean-k-mooney | stephenfin: im +1 on the 4 patches now | |
| 17:24:58 | stephenfin | thanks! | |
| 17:25:00 | sean-k-mooney | thanks for respinning them | |
| 17:25:13 | stephenfin | nw, good to have other eyes on them | |
| 17:47:49 | lyarwood | ~./ | |
| 17:48:11 | lyarwood | *sigh* | |
| 17:48:13 | sean-k-mooney | hehe is that a way or a failed change of directory | |
| 17:48:26 | lyarwood | nope, my connection to my VPS stalled again | |
| 17:48:32 | lyarwood | at least it appears to | |
| 17:48:49 | lyarwood | no updates on my screen session until I ssh back in etc | |
| 17:49:42 | lyarwood | ~. was just to force ssh to die so I could log back in, looks like I borked the first attmept ^_^ | |
| 17:50:22 | sean-k-mooney | ah right the sential escape sequence | |
| 17:50:35 | sean-k-mooney | i normally only have to use that with ipmi or some other serial connection | |
| 17:50:54 | sean-k-mooney | but i have had that kill my putty conenction before where they were the same | |
| 17:51:21 | lyarwood | yeah I think there's something up with the network on my vps (DO) tbh this has been going on since before the break | |
| 17:53:29 | sean-k-mooney | two days before we got back my server decided to not negociate full duplex connectivity. networking proablems that just happen are awsome... | |
| 17:53:48 | sean-k-mooney | my home cloud is now running on 2 usb 1 gig nics | |
| 17:55:10 | sean-k-mooney | huh i guess those are usb3 ports just hit 870mbps over the link lol | |
| 18:05:16 | sean-k-mooney | lyarwood: regarding the ppc unit test failures | |
| 18:05:48 | sean-k-mooney | lyarwood: could we set an arch env var and use a fixture to mock out different architetures | |
| 18:06:25 | sean-k-mooney | then jsut run OS_ARCH=ppc tox -e py3 | |
| 18:06:52 | sean-k-mooney | we will see if ibm can run the tests it sound like they will be able too | |
| 18:07:06 | sean-k-mooney | but if not im wondering if we can fake it in the jobs | |
| 18:09:44 | sean-k-mooney | i guess that would not be quite the same as running them on ppc64le | |
| 18:30:45 | lyarwood | sean-k-mooney: sorry was afk, that could be one way of fixing this, https://review.opendev.org/c/openstack/nova/+/769920 has shown a huge number of tests calling arch.from_host that would need to be covered. | |
| 18:34:20 | sean-k-mooney | ya although we generally expect the test to be written as arch independent event if its called underneath | |
| 18:35:05 | sean-k-mooney | so even if they call it doesnt mean its wrong nessacaraly but im not suprrised to se the libvirt tests there | |
| 18:35:31 | sean-k-mooney | we check the arch on startup of the libvirt driver | |
| 18:37:49 | lyarwood | That should be easy enough to resolve there | |
| 18:38:21 | lyarwood | mock it out to return x86_64 and just override it for the specific tests for other archs | |
| 18:38:51 | lyarwood | anyway, that's something for closer to M3 unless others want to pick it up | |
| 20:31:23 | artom | Is there a list of the "tags" available in nova-specs (or specs in general I suppose) | |
| 20:31:40 | artom | Specifically I want something to indicate an aside, or annex (but inline, and not at the end) | |
| 20:56:04 | openstackgerrit | sean mooney proposed openstack/nova master: add constants for vnic type vdpa https://review.opendev.org/c/openstack/nova/+/770474 | |
| 20:56:04 | openstackgerrit | sean mooney proposed openstack/nova master: use psycopg2 binary instead of source package https://review.opendev.org/c/openstack/nova/+/770473 | |
| 20:56:20 | sean-k-mooney | artom: maybe just put it in () | |
| 21:22:00 | openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy https://review.opendev.org/c/openstack/nova-specs/+/765551 | |
| 21:27:45 | artom | sean-k-mooney, so apparently seealso is a thing, though I'm the first one to use it in Nova. | |
| 21:27:55 | artom | It sorta fits what I want. | |
| #openstack-nova - 2021-01-13 | |||
| 01:28:14 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | |
| 01:28:14 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | |
| 02:35:49 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | |
| 04:57:41 | openstackgerrit | sean mooney proposed openstack/os-traits master: add vdpa trait https://review.opendev.org/c/openstack/os-traits/+/770530 | |
| 05:12:07 | openstackgerrit | sean mooney proposed openstack/os-traits master: add vdpa trait https://review.opendev.org/c/openstack/os-traits/+/770530 | |
| 05:14:27 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] add vdpa nodedev parsing and interface config gen https://review.opendev.org/c/openstack/nova/+/770532 | |
| 05:14:28 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] add vdpa trait reporting. https://review.opendev.org/c/openstack/nova/+/770533 | |
| 05:21:10 | openstackgerrit | sean mooney proposed openstack/nova master: add constants for vnic type vdpa https://review.opendev.org/c/openstack/nova/+/770474 | |
| 05:21:11 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] add vdpa trait reporting. https://review.opendev.org/c/openstack/nova/+/770533 | |
| 05:21:11 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] add vdpa nodedev parsing and interface config gen https://review.opendev.org/c/openstack/nova/+/770532 | |
| 05:47:30 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] add vdpa prefilter https://review.opendev.org/c/openstack/nova/+/770534 | |
| 07:55:03 | gibi | good morning | |
| 08:48:44 | lyarwood | Morning | |
| 08:49:43 | gibi | lyarwood: melwit explained one of my questions in the detach patch, so I have things to do with that patch, but if you have any other hints about open question then I would be glad to discuss | |
| 08:51:51 | lyarwood | gibi: I've just got the change open now, let me take a look | |
| 08:51:56 | gibi | cool | |
| 08:52:12 | gibi | I promise I will not dissapera now for couple of hours :) | |
| 09:12:14 | lyarwood | gibi: okay updated, I need to check if there's an internal libvirt timeout for these detach events | |
| 09:15:56 | lyarwood | gibi: ah nope, it's raised on a sync failure, there's no async checking within libvirtd that raises it | |
| 09:16:22 | lyarwood | I didn't post my comments anyway, doh! | |
| 09:18:53 | gibi | lyarwood: thanks | |
| 09:19:06 | gibi | lyarwood: yeah, the persisten/live error comes synchronously | |
| 09:20:45 | gibi | lyarwood: do you happen to know that when we check that the device is in the domain does that check looks into the live domian? | |
| 09:23:33 | lyarwood | gibi: iirc we use XMLDesc(0) to dump the domain and that's the live config | |
| 09:23:50 | lyarwood | gibi: there was a bug about this for paused instances iirc | |
| 09:24:06 | lyarwood | gibi: where we need to provide the VIR_DOMAIN_XML_INACTIVE flag https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainXMLFlags | |
| 09:27:20 | gibi | lyarwood: thanks, so we check the live config, thats good, then if the synch error came then we can simply check the live domain and it device is there then we can retry | |
| 09:29:19 | lyarwood | gibi: yeah I'd continue to retry on a direct sync error if the device is still there, VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED (but that should be a direct sync failure?) and a configurable timeout within n-cpu | |
| 09:29:44 | gibi | VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED is the failed event | |
| 09:29:51 | gibi | so tathat is async | |
| 09:30:37 | gibi | I can unify the retry if we get sync or async failure and the device is still in the live domain then we retry | |