Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-07
10:15:15 Yumeng cool. thanks!
11:13:55 brinzhang bauzas: https://review.opendev.org/c/openstack/nova/+/729563 I replied your comments, pls review cyborg shelve/unshelve support patch
11:14:23 brinzhang I was not found there are sth. need to change
11:45:43 openstackgerrit Lee Yarwood proposed openstack/nova-specs master: libvirt: Update instance machine type stash spec https://review.opendev.org/c/openstack/nova-specs/+/769547
11:48:25 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Clean up base migration https://review.opendev.org/c/openstack/nova/+/758155
11:48:26 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Drop "remove" of index https://review.opendev.org/c/openstack/nova/+/758157
11:48:26 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Merge in unique constraints https://review.opendev.org/c/openstack/nova/+/758156
11:48:27 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Juno database migration https://review.opendev.org/c/openstack/nova/+/758395
11:48:27 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Icehouse database migrations https://review.opendev.org/c/openstack/nova/+/758394
11:48:28 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Liberty database migrations https://review.opendev.org/c/openstack/nova/+/758397
11:48:28 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/c/openstack/nova/+/758396
11:48:29 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Newton database migrations https://review.opendev.org/c/openstack/nova/+/759085
11:48:29 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Mitaka database migrations https://review.opendev.org/c/openstack/nova/+/758398
11:48:30 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Pike database migrations https://review.opendev.org/c/openstack/nova/+/759087
11:48:30 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Ocata database migrations https://review.opendev.org/c/openstack/nova/+/759086
11:48:31 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Rocky database migrations https://review.opendev.org/c/openstack/nova/+/759089
11:48:31 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Queens database migrations https://review.opendev.org/c/openstack/nova/+/759088
11:48:32 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Train database migrations https://review.opendev.org/c/openstack/nova/+/759091
11:48:32 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Stein database migrations https://review.opendev.org/c/openstack/nova/+/759090
11:50:18 stephenfin gibi: Fixed those issues in the Kilo and Liberty migration compactions, and also found a way to resolve the boolean constraint issue
12:40:59 gibi stephenfin: ack, will check it today
12:41:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720
12:42:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530
12:43:09 gibi stephenfin: I fixed your comments in ^^ but I have to do a rebase to resolve merge conflict
12:48:21 openstackgerrit Lee Yarwood proposed openstack/nova-specs master: libvirt: Update instance machine type stash spec https://review.opendev.org/c/openstack/nova-specs/+/769547
12:52:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move query param generation to RequestGroup o.vo https://review.opendev.org/c/openstack/nova/+/756894
12:52:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109
12:52:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/c/openstack/nova/+/756895
12:56:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110
12:58:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111
13:00:05 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614
13:01:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720
13:02:57 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530
13:04:02 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152
13:04:23 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove unused Instance method https://review.opendev.org/c/openstack/nova/+/757615
13:04:47 gibi stephenfin: now the rebase is also done in the qos series
13:10:22 gibi stephenfin: the kilo compaction now looks good to me
13:25:40 openstackgerrit Balazs Gibizer proposed openstack/nova stable/victoria: Reproduce bug 1907522 in functional test https://review.opendev.org/c/openstack/nova/+/769736
13:25:42 openstack bug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host " [High,In progress] https://launchpad.net/bugs/1907522 - Assigned to Balazs Gibizer (balazs-gibizer)
13:35:13 openstackgerrit Balazs Gibizer proposed openstack/nova stable/victoria: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/769727
13:44:58 stephenfin gibi: Ack, will look today
14:23:13 gibi thanks
14:47:14 sean-k-mooney gibi: do you have time to reivew https://review.opendev.org/c/openstack/nova/+/767368
14:48:17 sean-k-mooney its a minimal change that is backportable to enable neutron to fix there issue https://review.opendev.org/c/openstack/neutron/+/766277
14:49:32 sean-k-mooney its also required for https://review.opendev.org/c/openstack/nova/+/602432 to proceed so im trying to move it forward so we can backport it ahead fo this change
14:55:45 artom sean-k-mooney, this being you, I made a point of ignoring the typos on https://review.opendev.org/c/openstack/nova-specs/+/765901 ;) It's perfectly readable, I figured I wouldn't lay into you
14:56:44 sean-k-mooney artom: hehe thanks i can fix them while fixing the white spaces issues
14:59:21 artom And I just realized my question doesn't make sense :(
15:00:47 sean-k-mooney you were wondering how thes related to the default numa polices in the pci alias
15:00:57 sean-k-mooney and conflating that with the whitelist right
15:01:28 sean-k-mooney e.g. the numa_affinity policy is not in the whitelist its in the aliase so interface dont have one until they are claimed
15:02:11 artom sean-k-mooney, yeah, my question would have made sense on the "original" config-based affinity
15:02:16 sean-k-mooney so yes the affinity comes with the boot request not an atibuge of the pci device
15:02:30 artom Since that's per-host, so the scheduler could in theory make that choice
15:02:49 sean-k-mooney even the config based affinity does not apply here
15:02:54 hemanth_n sean-k-mooney: can you look at my comment https://review.opendev.org/c/openstack/nova/+/761701 when you get time, we discussed this before EOY holiday period.. appreciate if you leave your suggestions/comments
15:02:57 sean-k-mooney the policy is in the alias not the whitelist
15:03:17 artom Ah, yeah, and that's at the API level
15:03:49 sean-k-mooney hemanth_n: oh ya am given the number of backports was increains im ok with proceedign with the squashed version so ill chnage that to a +1
15:04:56 hemanth_n sean-k-mooney: ack, thanks in that case i believe the patch is good to go for WF and merge
15:06:59 sean-k-mooney lyarwood: could you take a look at https://review.opendev.org/c/openstack/nova/+/761701 for hemanth_n
15:17:14 lyarwood sean-k-mooney: yup sure
15:24:05 stephenfin gibi: done
15:24:09 stephenfin (the QoS series)
15:38:38 gmann lyarwood: stable/rocky and queens are green on swfit exta requirement issue right? i can abandon these two - https://review.opendev.org/q/topic:%22bug%252F1909018%22+(status:open%20OR%20status:merged
15:42:14 lyarwood gmann: yeah we already landed https://review.opendev.org/q/I294d5350e2f418614e54ff7bdd47dff16bfdcdbc there so it was green the last time I looked
15:42:35 gmann lyarwood: cool, thanks
15:42:47 lyarwood wait https://review.opendev.org/q/I8f24b839bf42e2fb9803dc7df3a30ae20cf264
15:42:54 lyarwood gmann: wasn't that the change that broke it?
15:43:01 lyarwood gmann: maybe we still need this?
15:43:29 gmann lyarwood: yeah stopping test requirement broke it but i see swift job green on stable/rocky not sure why
15:43:58 gmann before debugging I wanted to check with you if any failure on stable/rocky if so then debug otherwise not
15:44:46 gmann like this is passing https://review.opendev.org/c/openstack/swift/+/766491
15:46:04 lyarwood gmann: ah right and that was after https://review.opendev.org/q/I8f24b839bf42e2fb9803dc7df3a30ae20cf264 sorry my bad
15:47:27 gmann lyarwood: let me check their functional job and then i will abandon
15:57:48 gibi nova meeting starts in 2 minutes on #openstack-meeting-3
15:59:48 gibi sean-k-mooney: will look at it
16:00:07 gibi stephenfin: thanks for the review
16:21:04 openstackgerrit sean mooney proposed openstack/nova master: test numa and vcpu topologies bug: #1910466 https://review.opendev.org/c/openstack/nova/+/769601
16:21:06 openstackgerrit sean mooney proposed openstack/nova master: fix max cpu topologies with numa affinity https://review.opendev.org/c/openstack/nova/+/769614
16:21:06 openstack bug 1910466 in OpenStack Compute (nova) "NUMA instance spawn fails on get_best_cpu_topology when there is no 'threads' preference" [Medium,In progress] https://launchpad.net/bugs/1910466 - Assigned to sean mooney (sean-k-mooney)
16:22:21 sean-k-mooney melwitt: i found another bug while updating those but i belive ^ should adress the orignal bug
16:22:50 sean-k-mooney the new issue is the vcpu_toplogy in the numa toplogy object dont actully match the toplogy of the vm
16:23:07 sean-k-mooney so we need to fix that seperatly but that is independent of this bug
16:23:37 sean-k-mooney it just ment i could not use them in my functional test assertions which is why i found it
16:43:24 gibi sean-k-mooney: sent https://review.opendev.org/c/openstack/nova/+/767368 to the gate
16:44:33 sean-k-mooney gibi: thanks that will help move things along
16:45:01 sean-k-mooney assuming the gate is working
16:48:25 openstackgerrit Stephen Finucane proposed openstack/nova master: DNM: Add generate schemas tool https://review.opendev.org/c/openstack/nova/+/769796
17:36:40 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Normalize exception handling for os-hypervisors https://review.opendev.org/c/openstack/nova/+/769520
17:36:41 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Drop statistics-style fields from os-hypervisors https://review.opendev.org/c/openstack/nova/+/764040
17:38:02 stephenfin gmann: Address the comments on that series. Should be good to go now, hopefully
17:38:39 gmann stephenfin: thanks, will check
18:01:01 openstackgerrit sean mooney proposed openstack/nova-specs master: libvirt: support vdpa kernel networking https://review.opendev.org/c/openstack/nova-specs/+/764999
18:13:02 openstackgerrit Elod Illes proposed openstack/nova stable/stein: [stable-only] Cap bandit and make lower-constraints job non-voting https://review.opendev.org/c/openstack/nova/+/766487
18:31:36 openstackgerrit Elod Illes proposed openstack/nova stable/stein: WIP [stable-only] Fix lower-constraints job https://review.opendev.org/c/openstack/nova/+/769809
18:54:09 sean-k-mooney bauzas: reviewded https://review.opendev.org/c/openstack/nova/+/749068 some comments inline namely some fo the fuct test are asserting behavior that is incorrect
18:55:21 sean-k-mooney bauzas: you have 2 segments and only one host in each segment so non of the move operation excpet shelve/unshelve can work
18:56:52 sean-k-mooney bauzas: overall though it looks pretty good.
22:36:47 gmann stephenfin: almost good, one comment on adding immediate previous microversion unit tests for protection. I agree functional test not needed, i forgot to delete that comment. https://review.opendev.org/c/openstack/nova/+/764040/1/nova/tests/functional/api_sample_tests/test_hypervisors.py#285

Earlier   Later