Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2021-01-07
09:51:15 Yumeng gibi: Can you check my response here? https://review.opendev.org/c/openstack/nova-specs/+/750116/14/specs/wallaby/approved/support-vGPU-nova-cyborg-interaction.rst#225
09:54:04 gibi Yumeng: thanks. The time off was good.
09:54:27 gibi I will try to check back to that spec
09:54:34 Yumeng gibi: sounds nice!
09:54:40 Yumeng thanks!
09:55:08 gibi Yumeng: did you have some time of during this period or you will be off for the chinees new year instead?
09:56:13 Yumeng This year's Chinees new year holiday starts from Feb 11, so we still have time ^^
09:57:44 gibi OK
09:59:37 Yumeng gibi: but there will be some change in cyborg team this month. I will changed my company and work priority since Jan 18. So I'm going to step down from the PTL position and Xinran Wang will take over the PTL duty.
10:00:36 gibi Yumeng: thanks for the information, will you be able to push the implementation forward after jan 18 or it will also be taken over by somebody else?
10:02:59 Yumeng gibi: after jan 18, vGPU will be taken over by wenpingsong and chenke from Cyborg team.
10:03:09 gibi Yumeng: thanks for that info too
10:03:30 Yumeng It also makes sense to ping the new PTL as well ^^
10:06:36 gibi bauzas: do you have any outstanding issues with the cyborg spec other than the deprecation issue? https://review.opendev.org/c/openstack/nova-specs/+/750116
10:07:40 Yumeng gibi: now in the cyborg side, we are pushing the driver implementation:https://review.opendev.org/q/topic:%22enable-vgpu-in-cyborg%22+(status:open%20OR%20status:merged). We will try to merge before I leave. so that you guys can see at least a whole implementation in cyborg side.
10:08:10 gibi Yumeng: cool. Does it contain support for vgpu in the fake driver we use in tempest testing?
10:08:22 Yumeng emmm not yet
10:08:42 Yumeng we can test in real env at this moment
10:08:45 gibi it is not super urgent, but good to not forget about it
10:08:51 bauzas gibi: honestly, I need to do a second revision
10:09:25 Yumeng yep, we need to do that.
10:09:53 gibi bauzas: no worries, we have two weeks still until spec freeze
10:10:14 bauzas gibi: I'll try to look at it this week honestly
10:10:19 gibi thanks
10:11:41 bauzas gibi: Yumeng: my main concerns about this spec (outside the fact of the deprecation) were about making sure that both vGPU ways work
10:11:57 bauzas and maybe by the same methods if we could
10:12:14 gibi I agree that we need to reuse as much in the existing nova code as possible
10:12:21 bauzas (without changing the flavors=
10:13:01 bauzas gibi: but maybe I could leave some implementation concerns for the nova changes
10:13:23 bauzas and accepting the spec if I see it goes to a direction I like
10:13:44 gibi bauzas: if you have specific concerns then it does not harm to state them now.
10:13:49 bauzas I don't want to leave this spec not accepted b/c of any technical nits
10:13:56 gibi so that we wont forget it
10:14:15 bauzas gibi: sure, just explaining why I need to revise it
10:14:20 gibi cool
10:14:34 gibi sure we will wait for your re-review
10:15:15 Yumeng cool. thanks!
11:13:55 brinzhang bauzas: https://review.opendev.org/c/openstack/nova/+/729563 I replied your comments, pls review cyborg shelve/unshelve support patch
11:14:23 brinzhang I was not found there are sth. need to change
11:45:43 openstackgerrit Lee Yarwood proposed openstack/nova-specs master: libvirt: Update instance machine type stash spec https://review.opendev.org/c/openstack/nova-specs/+/769547
11:48:25 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Clean up base migration https://review.opendev.org/c/openstack/nova/+/758155
11:48:26 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Drop "remove" of index https://review.opendev.org/c/openstack/nova/+/758157
11:48:26 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Merge in unique constraints https://review.opendev.org/c/openstack/nova/+/758156
11:48:27 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Juno database migration https://review.opendev.org/c/openstack/nova/+/758395
11:48:27 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Icehouse database migrations https://review.opendev.org/c/openstack/nova/+/758394
11:48:28 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Liberty database migrations https://review.opendev.org/c/openstack/nova/+/758397
11:48:28 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/c/openstack/nova/+/758396
11:48:29 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Newton database migrations https://review.opendev.org/c/openstack/nova/+/759085
11:48:29 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Mitaka database migrations https://review.opendev.org/c/openstack/nova/+/758398
11:48:30 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Pike database migrations https://review.opendev.org/c/openstack/nova/+/759087
11:48:30 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Ocata database migrations https://review.opendev.org/c/openstack/nova/+/759086
11:48:31 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Rocky database migrations https://review.opendev.org/c/openstack/nova/+/759089
11:48:31 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Queens database migrations https://review.opendev.org/c/openstack/nova/+/759088
11:48:32 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Train database migrations https://review.opendev.org/c/openstack/nova/+/759091
11:48:32 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Stein database migrations https://review.opendev.org/c/openstack/nova/+/759090
11:50:18 stephenfin gibi: Fixed those issues in the Kilo and Liberty migration compactions, and also found a way to resolve the boolean constraint issue
12:40:59 gibi stephenfin: ack, will check it today
12:41:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720
12:42:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530
12:43:09 gibi stephenfin: I fixed your comments in ^^ but I have to do a rebase to resolve merge conflict
12:48:21 openstackgerrit Lee Yarwood proposed openstack/nova-specs master: libvirt: Update instance machine type stash spec https://review.opendev.org/c/openstack/nova-specs/+/769547
12:52:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Move query param generation to RequestGroup o.vo https://review.opendev.org/c/openstack/nova/+/756894
12:52:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109
12:52:52 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/c/openstack/nova/+/756895
12:56:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110
12:58:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111
13:00:05 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614
13:01:29 openstackgerrit Balazs Gibizer proposed openstack/nova master: Refactor ResourceRequest constructor https://review.opendev.org/c/openstack/nova/+/769720
13:02:57 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support interface attach with QoS ports https://review.opendev.org/c/openstack/nova/+/756530
13:04:02 openstackgerrit Balazs Gibizer proposed openstack/nova master: Enable mypy on scheduler/report.py https://review.opendev.org/c/openstack/nova/+/765152
13:04:23 openstackgerrit Balazs Gibizer proposed openstack/nova master: Remove unused Instance method https://review.opendev.org/c/openstack/nova/+/757615
13:04:47 gibi stephenfin: now the rebase is also done in the qos series
13:10:22 gibi stephenfin: the kilo compaction now looks good to me
13:25:40 openstackgerrit Balazs Gibizer proposed openstack/nova stable/victoria: Reproduce bug 1907522 in functional test https://review.opendev.org/c/openstack/nova/+/769736
13:25:42 openstack bug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host " [High,In progress] https://launchpad.net/bugs/1907522 - Assigned to Balazs Gibizer (balazs-gibizer)
13:35:13 openstackgerrit Balazs Gibizer proposed openstack/nova stable/victoria: Fallback to same-cell resize with qos ports https://review.opendev.org/c/openstack/nova/+/769727
13:44:58 stephenfin gibi: Ack, will look today
14:23:13 gibi thanks
14:47:14 sean-k-mooney gibi: do you have time to reivew https://review.opendev.org/c/openstack/nova/+/767368
14:48:17 sean-k-mooney its a minimal change that is backportable to enable neutron to fix there issue https://review.opendev.org/c/openstack/neutron/+/766277
14:49:32 sean-k-mooney its also required for https://review.opendev.org/c/openstack/nova/+/602432 to proceed so im trying to move it forward so we can backport it ahead fo this change
14:55:45 artom sean-k-mooney, this being you, I made a point of ignoring the typos on https://review.opendev.org/c/openstack/nova-specs/+/765901 ;) It's perfectly readable, I figured I wouldn't lay into you
14:56:44 sean-k-mooney artom: hehe thanks i can fix them while fixing the white spaces issues
14:59:21 artom And I just realized my question doesn't make sense :(
15:00:47 sean-k-mooney you were wondering how thes related to the default numa polices in the pci alias
15:00:57 sean-k-mooney and conflating that with the whitelist right
15:01:28 sean-k-mooney e.g. the numa_affinity policy is not in the whitelist its in the aliase so interface dont have one until they are claimed
15:02:11 artom sean-k-mooney, yeah, my question would have made sense on the "original" config-based affinity
15:02:16 sean-k-mooney so yes the affinity comes with the boot request not an atibuge of the pci device
15:02:30 artom Since that's per-host, so the scheduler could in theory make that choice
15:02:49 sean-k-mooney even the config based affinity does not apply here
15:02:54 hemanth_n sean-k-mooney: can you look at my comment https://review.opendev.org/c/openstack/nova/+/761701 when you get time, we discussed this before EOY holiday period.. appreciate if you leave your suggestions/comments
15:02:57 sean-k-mooney the policy is in the alias not the whitelist
15:03:17 artom Ah, yeah, and that's at the API level
15:03:49 sean-k-mooney hemanth_n: oh ya am given the number of backports was increains im ok with proceedign with the squashed version so ill chnage that to a +1
15:04:56 hemanth_n sean-k-mooney: ack, thanks in that case i believe the patch is good to go for WF and merge
15:06:59 sean-k-mooney lyarwood: could you take a look at https://review.opendev.org/c/openstack/nova/+/761701 for hemanth_n
15:17:14 lyarwood sean-k-mooney: yup sure
15:24:05 stephenfin gibi: done
15:24:09 stephenfin (the QoS series)

Earlier   Later