Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-12-22
11:59:44 lyarwood have to love not being able to run pep8 on stable/train and f33 anymore
12:00:38 lyarwood greenlet--
12:03:11 lyarwood oh it's py39 again
12:09:44 openstackgerrit Rocky proposed openstack/nova stable/ussuri: Bump hacking min version to 3.1.0 https://review.opendev.org/c/openstack/nova/+/768197
12:49:19 openstackgerrit Merged openstack/nova master: stabilize unit test asserting log https://review.opendev.org/c/openstack/nova/+/764796
12:49:45 openstackgerrit Merged openstack/nova master: stabilize set_host libvirt driver unit test https://review.opendev.org/c/openstack/nova/+/764797
13:28:20 openstackgerrit Rico Lin proposed openstack/nova master: Fix Unit test for arm64 https://review.opendev.org/c/openstack/nova/+/768202
14:18:47 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: tools: Allow check-cherry-picks.sh to be disabled by an env var https://review.opendev.org/c/openstack/nova/+/766024
15:35:49 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: [stable-only] Cap bandit to 1.6.2 and raise hacking, flake8 and stestr https://review.opendev.org/c/openstack/nova/+/766171
15:36:29 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: [stable-only] Cap bandit to 1.6.2 https://review.opendev.org/c/openstack/nova/+/766487
16:24:42 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: compute: Don't detach volumes when RescheduledException raised without retry https://review.opendev.org/c/openstack/nova/+/768194
16:31:52 ikla stephenfin, do I need to set any scheduler filter settings after cpu/ram_allocation is set?
16:32:26 stephenfin ikla: not that I can think of
16:35:04 ikla can pci devices be over subscribed like a nvidia or amd gpu?
16:36:43 stephenfin No, PCI devices cannot be shared by multiple instances. You'll need a GPU with virtualization support (mdev or SR-IOV capabilities) to be able to share a physical PCI device with multiple instances
17:59:58 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: objects: Add `socket` to NUMACell and PciDevice https://review.opendev.org/c/openstack/nova/+/766795
17:59:58 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: db: Add `socket` to pci_devices https://review.opendev.org/c/openstack/nova/+/766862
17:59:59 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Start populating `socket_id` in host NUMA topology https://review.opendev.org/c/openstack/nova/+/766816
18:50:06 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: [stable-only] Cap bandit to 1.6.2 and raise hacking, flake8 and stestr https://review.opendev.org/c/openstack/nova/+/766171
19:20:43 openstackgerrit Merged openstack/nova master: Revert "nova-multi-cell: Skip test_cold_migrate_unshelved_instance" https://review.opendev.org/c/openstack/nova/+/765933
21:26:55 openstackgerrit Rocky proposed openstack/nova stable/ussuri: Bump hacking min version to 3.1.0 https://review.opendev.org/c/openstack/nova/+/768197
23:51:51 prometheanfire looks like nova is failing on updates, I don't think it should be sqlalchemy...
23:51:54 prometheanfire https://review.opendev.org/767280
#openstack-nova - 2020-12-23
00:29:29 ikla does nova service needed restarted with a config change or is there a command to read the config file again?
00:49:06 prometheanfire iirc it needs a restart
07:15:41 frickler prometheanfire: from the backtrace I'd say it is fasteners: https://github.com/harlowja/fasteners/commit/6b59d8d432be2912f48c7dc67170991c0df696e8
07:16:12 frickler like needs a pin for now and then nova fixing their locking
10:47:53 openstackgerrit xinyu wang proposed openstack/nova master: CPU and memory live resize https://review.opendev.org/c/openstack/nova/+/768321
11:15:15 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: [stable-only] Cap bandit to 1.6.2 and raise hacking, flake8 and stestr https://review.opendev.org/c/openstack/nova/+/766171
13:15:30 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Deploy novnc from source in nova-next https://review.opendev.org/c/openstack/nova/+/768334
13:15:31 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - test novnc 1.2.0 in nova-next https://review.opendev.org/c/openstack/nova/+/768335
13:26:50 openstackgerrit Merged openstack/nova master: Ignore PCI devices with 32bit domain https://review.opendev.org/c/openstack/nova/+/756697
14:19:57 stephenfin lyarwood: RE: https://review.opendev.org/c/openstack/nova/+/758155 I agree it's a good idea but I'm not sure how to do it
14:22:13 stephenfin The only idea I have is to do a dump of the schemas at the various checkpoints (i.e. where I squash up to for each patch) and then compare to what's generated in the test ahead of time. I guess I could use sqlparse for that but it does sound rather laborious
16:50:45 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Reject requests to detach a volume when the compute is down https://review.opendev.org/c/openstack/nova/+/768352
16:50:45 openstack bug 1909120 in OpenStack Compute (nova) "n-api should reject requests to detach a volume when the compute is down" [Undecided,New] https://launchpad.net/bugs/1909120 - Assigned to Lee Yarwood (lyarwood)
16:50:45 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1909120 https://review.opendev.org/c/openstack/nova/+/768351
17:03:00 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Start populating `socket` in host NUMA topology https://review.opendev.org/c/openstack/nova/+/766816
17:03:01 openstackgerrit Artom Lifshitz proposed openstack/nova master: WIP: Start pupulating `socket` in PCI devices https://review.opendev.org/c/openstack/nova/+/768359
17:35:40 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Reject requests to detach a volume when the compute is down https://review.opendev.org/c/openstack/nova/+/768352
19:15:19 openstackgerrit Stephen Finucane proposed openstack/nova master: Add schema files to compare against after squashing https://review.opendev.org/c/openstack/nova/+/768364
19:15:56 stephenfin lyarwood: For the AM, how does https://review.opendev.org/c/openstack/nova/+/768364 look to compare schemas?
19:16:30 stephenfin lyarwood: It's not perfect and probably can't be CI'd since mysql at least has a bad habit of changing ordering between runs :-\ It should do to eyeball stuff though?
19:49:35 openstackgerrit Ghanshyam proposed openstack/nova master: DNM: testing novnc new version https://review.opendev.org/c/openstack/nova/+/768368
22:47:34 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Deploy novnc from source in nova-next https://review.opendev.org/c/openstack/nova/+/768334
22:47:35 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - test novnc 1.2.0 in nova-next https://review.opendev.org/c/openstack/nova/+/768335
#openstack-nova - 2020-12-24
02:18:31 openstackgerrit Jorhson Deng proposed openstack/nova master: add network interface card e1000-82545em https://review.opendev.org/c/openstack/nova/+/768384
02:31:46 openstackgerrit Jorhson Deng proposed openstack/nova master: add network interface card e1000-82545em https://review.opendev.org/c/openstack/nova/+/768384
09:50:10 lyarwood stephenfin: ack okay if this is the best we can do then I'm fine with it
09:50:16 lyarwood stephenfin: I can't think of anything else to try tbh
09:50:28 lyarwood stephenfin: I've asked in the review how you wanted to actually use this for each of your changes btw
09:50:50 lyarwood stephenfin: a DNM change after each or just a few checks throughout your series somehow
09:51:09 lyarwood stephenfin: I assume you don't actually want to carry these generated schema files in the tree
09:52:23 stephenfin I still haven't figured that out fully. I think I'll have to carry the initial schema files in tree short term anyway. I was thinking to add a test that simply ran the script and generated a diff that we could store in zuul. Manual inspection needed but nothing more than that
09:53:58 lyarwood stephenfin: ah well as long as they are gone by rc ;
09:54:27 lyarwood stephenfin: and yeah we could even do all of this in an experimental job in zuul tbh
09:54:43 lyarwood stephenfin: generate the initial schema and diff the new version
09:55:15 lyarwood stephenfin: obviously that would take some cycles to setup but it wouldn't leave anything in tree
10:02:41 stephenfin lyarwood: I don't know if we can generate the initial schema without messing with git history
10:03:39 stephenfin Take https://review.opendev.org/c/openstack/nova/+/758394/3 for example. When testing that, the initial schema becomes 234_icehouse.py
10:09:41 lyarwood stephenfin: right but in the change is there anything stopping us from checking out HEAD~1
10:10:06 lyarwood stephenfin: but yeah I get that this is tricky to do without dumping things ahead of time
10:15:34 stephenfin no, except I've to play with git history to do that. I guess if it's a totally separate zuul job that wouldn't be a huge issue
10:20:08 lyarwood stephenfin: yeah this is a one off zuul job where we are just running scripts against the codebase, not deploying or anything fancy
10:21:18 lyarwood anyone else loving the shortcuts in gerrit since the upgrade?
10:22:48 stephenfin I think most of them were there before. I've found it's actually regressed slightly in that I can't through the review dialog any more
10:23:10 stephenfin I mean, I can, but it takes way more effort than previously
10:23:42 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/c/openstack/nova/+/742424
10:24:33 lyarwood stephenfin: ah right I was wondering why they didn't have shortcuts for votes in that dialog
10:24:57 lyarwood stephenfin: at least you can submit comments quickly now with ctrl+enter
10:38:33 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/c/openstack/nova/+/742424
10:52:49 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Deploy novnc from source in nova-next https://review.opendev.org/c/openstack/nova/+/768334
10:54:12 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Deploy novnc from source in nova-next https://review.opendev.org/c/openstack/nova/+/768334
11:08:36 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP zuul: Add nova-live-migration-ceph job https://review.opendev.org/c/openstack/nova/+/768466
11:08:47 lyarwood \o/
13:12:27 openstackgerrit Brin Zhang proposed openstack/nova master: Improving the description for az of unshleve API https://review.opendev.org/c/openstack/nova/+/767251
13:14:10 brinzhang_ gmann, stephenfin, bauzas: may we can merge this patach firsyly, gmann's cleanup may start in X release, if we can merge now, that we can give the end user a friedly api-ref docs guide, IMO
13:14:31 brinzhang_ https://review.opendev.org/c/openstack/nova/+/767251
13:29:00 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Reject volume attach requests when an active bdm exists https://review.opendev.org/c/openstack/nova/+/768472
13:29:00 openstack bug 1908075 in OpenStack Compute (nova) "Nova allows a non-multiattach volume to be attached to multiple instances *if* its volume state is reset by an admin" [Undecided,New] https://launchpad.net/bugs/1908075 - Assigned to Lee Yarwood (lyarwood)
13:29:00 openstackgerrit Lee Yarwood proposed openstack/nova master: Add regression test for bug #1908075 https://review.opendev.org/c/openstack/nova/+/766976
13:41:17 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP zuul: Add nova-live-migration-ceph job https://review.opendev.org/c/openstack/nova/+/768466
15:47:16 gmann brinzhang_: yeah, we can document the current behavior in api -ref as new changes will be for new microversion, I will review it today
16:14:07 gmann brinzhang_: done, I am almost ok once you fix the nit from lyarwood https://review.opendev.org/c/openstack/nova/+/767251
16:14:28 gmann and once we have new microversion then we can update this note also.
16:18:21 openstackgerrit Merged openstack/nova stable/victoria: Set instance host and drop migration under lock https://review.opendev.org/c/openstack/nova/+/763154
#openstack-nova - 2020-12-25
00:41:02 openstackgerrit Brin Zhang proposed openstack/nova master: Improving the description for az of unshleve API https://review.opendev.org/c/openstack/nova/+/767251
00:41:40 brinzhang_ gmann, lyarwood: Thanks for your review, updated.
01:29:14 gmann brinzhang_: thanks checking
01:29:30 brinzhang_ gmann: ack, thanks
01:34:38 gmann brinzhang_: let's add that under request body section instead of under AZ param.
01:34:44 gmann sorry for not noticing this early
01:38:45 brinzhang_ gmann: your mean that should add the common place above on the Request? I mean on the "Request" in https://github.com/openstack/nova/blob/master/api-ref/source/servers-action-shelve.inc#request-2
01:39:23 gmann brinzhang_: yeah just under 'Request' heading
01:39:32 brinzhang_ we add note in parameter, it can tell the user to use it too, does it need to move?
01:39:35 gmann as it talk about allowed request not about AZ
01:40:18 gmann AZ param description can tell only about what to pass in AZ and Request heading can tell what all request body are allowed
01:41:01 brinzhang_ gmann: ok, let me update later
01:41:23 gmann brinzhang_: thanks, ping me once done I will be online for few more hrs.
01:45:33 openstackgerrit Brin Zhang proposed openstack/nova master: Improving the description for unshleve request body https://review.opendev.org/c/openstack/nova/+/767251

Earlier   Later