| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-12-16 | |||
| 18:51:54 | gmann | this is more context on that - https://review.opendev.org/c/openstack/nova/+/663851/34/nova/api/openstack/compute/schemas/servers.py#695 | |
| 18:52:05 | melwitt | ok so this decision would likely affect all apis going to a newer microversion? | |
| 18:52:15 | gmann | but yeah i agree on consistency part but which one we follow that is for discussion | |
| 18:52:55 | melwitt | I see. so we will either make unshelve allow {} or make lock disallow {} | |
| 18:53:28 | gmann | melwitt: yeah if we improve the other action APIs or when they have some request body change in new microversion then they will follow the pattern we decide now | |
| 18:53:33 | melwitt | got it | |
| 18:53:36 | gmann | yeah | |
| 18:54:00 | melwitt | ok, so I think {unknown: unknown} seems like the weirdest one that makes sense to block in new apis | |
| 18:54:10 | gmann | and brinzhang_ started to document the current behavior in api-ref https://review.opendev.org/c/openstack/nova/+/767251 | |
| 18:54:11 | melwitt | (as sean said earlier) | |
| 18:54:40 | gmann | melwitt: yeah {unknown: unknown} will be blocked for all new mprovement | |
| 18:54:43 | gmann | improvement | |
| 18:54:59 | melwitt | the {} makes some sense though and I could imagine veteran users being caught by surprise if we say that is no longer allowed to represent null | |
| 18:55:38 | melwitt | so it will be tradeoff between api purity vs user ease it seems | |
| 18:57:19 | melwitt | I think I'd be slightly in favor of allowing {} for the user ease reason | |
| 18:58:01 | melwitt | I do appreciate that it is redundant with null though | |
| 18:58:19 | gmann | ok, if user considering {} as null then not breaking existing users make sense. | |
| 19:00:10 | melwitt | yeah I mean, I think the use case will be automation or something that is setting values by a dict and when there is nothing they just do {} instead of saying "if nothing then null". but I don't know whether that is a thing people do | |
| 19:03:44 | gmann | i see, i think in python code it make sense as many automation might default to {} if nothing like kwargs or so. | |
| 19:06:24 | gmann | i agree on doing it consistently. | |
| 19:07:40 | gmann | melwitt: sean-k-mooney2 bauzas gibi let's do it in all action APIs to have consistency . i added this in api cleanup etherpad L89. https://etherpad.opendev.org/p/nova-api-cleanup | |
| 19:07:57 | gmann | may be late in this cycle to do? if so we can do in X cycle? | |
| 19:08:15 | gmann | brinzhang_: ^^ | |
| 19:09:26 | gmann | or we can do one more 'multiple API improvement' microversion and pick few more improvement to do along with this. | |
| 19:10:36 | sean-k-mooney2 | gmann: i woudl proably pair it with the return codes cleanup | |
| 19:10:54 | sean-k-mooney2 | so number 8 on line 73 | |
| 19:11:54 | gmann | sean-k-mooney2: that is huge change and in past discussion we thought it is not worth to do as it may change many users scripts or so. | |
| 19:12:11 | sean-k-mooney2 | gmann: stephenfin has a patch for that up | |
| 19:12:12 | gmann | but I am ok to re-iterate it | |
| 19:12:17 | gmann | yeah | |
| 19:12:31 | sean-k-mooney2 | so i assumed that would get done this cycle | |
| 19:13:00 | gmann | that needed spec which i think stephenfin said not worth or so but let me check that | |
| 19:13:31 | sean-k-mooney2 | it was a lower priority this cycle so i dont know if he filed one or was going to | |
| 19:14:35 | gmann | https://review.opendev.org/c/openstack/nova/+/749505 | |
| 19:15:00 | gmann | that is waiting for spec | |
| 19:16:13 | sean-k-mooney2 | stephenfin might have been hoping to do it as a specless blueprint since its resolving exisitng todos in the code but ya i know it lower on his list then the other items he is working on this cycle | |
| 19:17:04 | gmann | yeah. let's discuss it in X cycle PTG to pick few of them which are worth to do | |
| 19:17:22 | sean-k-mooney2 | works for me | |
| 19:18:03 | sean-k-mooney2 | i would like to see teh is_public flavor atitbue change done too at somepoint | |
| 19:18:16 | gmann | :) was typing that. | |
| 19:18:19 | sean-k-mooney2 | but not enought to prioritise it this cycle | |
| 19:18:28 | gmann | that is worth to fix | |
| 19:18:57 | sean-k-mooney2 | it is but on its own it a lot of work for littel benifit | |
| 19:19:12 | sean-k-mooney2 | with other changes it much much more resonable to me | |
| 19:19:33 | gmann | yeah with other improvement | |
| #openstack-nova - 2020-12-17 | |||
| 00:48:15 | brinzhang0 | gmann: ack, thanks, you have added in the cleanup apis etherpad, works for me, keep the consistency with other apis is better ^^ | |
| 02:45:15 | openstackgerrit | Wenping Song proposed openstack/nova master: Remove redundant code in instance delete https://review.opendev.org/c/openstack/nova/+/767449 | |
| 08:14:49 | openstackgerrit | zhulipeng proposed openstack/nova master: Fixed multipath residue when evacuating the VM https://review.opendev.org/c/openstack/nova/+/767468 | |
| 08:40:39 | bauzas | good morning Nova | |
| 08:53:31 | gibi | bauzas: good morning to you too | |
| 08:55:34 | bauzas | gibi: last 2 days for you too ? | |
| 08:55:48 | gibi | bauzas: yepp, I'm already a bit in vacation mood | |
| 08:55:53 | bauzas | LOL | |
| 08:56:33 | bauzas | I'm still trying to remove the -W flag from the routed networks change before I'm going south :) | |
| 08:57:18 | bauzas | and wow, Zuul gave me +1 on https://review.opendev.org/c/openstack/nova/+/749068/5 \o/ | |
| 08:57:22 | gibi | I know I will looking back at gerrit during the vacation periods as my wife has to work on some of the days | |
| 08:57:26 | bauzas | yeepeekay :) | |
| 08:57:39 | gibi | that is your present from Zuul :D | |
| 08:59:13 | bauzas | well, given how I battled with Zuul for this change, I'm more like this https://www.youtube.com/watch?v=YfpDSNNgYhI | |
| 09:01:28 | gibi | hehe, that is very vacation specific movie at least in my country :) | |
| 09:01:36 | gibi | almost like home alone | |
| 09:06:31 | bauzas | agreed, same here | |
| 09:07:15 | bauzas | I don't expect Christmas periods without Die Hard 2 or 1 movies being broadcasted on at least one of them | |
| 09:07:35 | bauzas | the 2 gets more broadcasted tho | |
| 09:09:31 | bauzas | wow, TIL the reasoning behind https://www.youtube.com/watch?v=KAYIgEpds_Y | |
| 09:09:54 | bauzas | the French dubbing totally trampled this phrase | |
| 09:20:10 | gibi | bauzas: I will get you the hungarian dub after my morning call | |
| 09:20:11 | gibi | :) | |
| 10:03:55 | gibi | bauzas: https://www.youtube.com/watch?v=BeH-ODa-41o | |
| 10:04:19 | gibi | interestingly there is two different hun dub for die hard 1 | |
| 10:08:36 | gibi | gmann, sean-k-mooney, melwitt, bauzas, brinzhang: I'm OK with the proposal in the API etherpad. I'm glad we found an agreeable way forward | |
| 10:08:46 | bauzas | me too | |
| 10:08:55 | bauzas | fwiw, I just modified my change | |
| 10:09:16 | bauzas | https://review.opendev.org/c/openstack/nova/+/749068/5/nova/tests/functional/integrated_helpers.py | |
| 10:09:34 | bauzas | but I'll split this hairy change into multiple pieces now that everything works | |
| 10:09:56 | bauzas | gibi: sharpen your pen, hopefully will upload the series later the day | |
| 10:10:14 | gibi | bauzas: sure, I will try to review it before I go | |
| 10:10:31 | bauzas | no rushes, we're half the cycle | |
| 10:10:42 | bauzas | but I'm glad this works, as proven by the functests | |
| 10:12:19 | gibi | I'm happy too, it was something I promised making happen in the past so I'm happy to sink time on reviewing it | |
| 10:15:49 | stephenfin | gibi: sorry, was out yesterday. Looking now | |
| 10:16:04 | gibi | stephenfin: ack, no worries | |
| 10:16:18 | stephenfin | in the meantime, bauzas/gibi: any chance you'd look at https://review.opendev.org/c/openstack/nova-specs/+/765796 to sync spec and code? | |
| 10:16:19 | brinzhang | gibi: yeah, me too, happy to see the ethpad for clean multi apis ^^ | |
| 10:16:44 | gibi | stephenfin: on it | |
| 10:16:52 | bauzas | stephenfin: kids taxi, but I'll look | |
| 10:17:32 | gibi | bauzas: you don't have to, gmann and I took care of it now | |
| 10:17:42 | bauzas | kk, ttyl | |
| 10:18:56 | gibi | lyarwood: I'm look at another possible race in tempest about volume handling https://zuul.opendev.org/t/openstack/build/fce0115deae94e38aaef4a349e271e20/log/job-output.txt#69070 | |
| 10:19:03 | stephenfin | Thanks! There's also a part 3, but that's got an open question on it from sean-k-mooney. I wonder if we should discuss in the team meeting today? https://review.opendev.org/c/openstack/nova-specs/+/765797/1/specs/wallaby/approved/modernize-os-hypervisors-api.rst | |
| 10:21:07 | lyarwood | gibi: oh fun | |
| 10:21:15 | lyarwood | gibi: let me take a look | |
| 10:25:51 | elod | lyarwood, similarly like yesterday: can you hit now the bandit patch in queens: https://review.opendev.org/c/openstack/nova/+/767364 o:) | |
| 10:28:40 | lyarwood | elod: ack will do | |
| 10:28:50 | openstackgerrit | Merged openstack/nova-specs master: Update modernize-os-hypervisors-api spec, pt. 2 https://review.opendev.org/c/openstack/nova-specs/+/765796 | |
| 10:30:46 | openstackgerrit | Alexandre arents proposed openstack/nova master: Revert "nova-multi-cell: Skip test_cold_migrate_unshelved_instance" https://review.opendev.org/c/openstack/nova/+/765933 | |
| 10:31:58 | zigo | One quick question about GPU in passthrough mode: what's the reason for moving from "type-PCI" to "type-PF" ? | |
| 10:31:58 | zigo | bauzas: Hi man! | |
| 10:32:18 | zigo | We had the issue when we upgraded from Rocky to Train ... | |
| 10:37:10 | bauzas | zigo: that depends on which GPU card you have | |