| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-12-15 | |||
| 16:59:49 | stephenfin | that extra newline was (mistakenly) not required in an old version of flake8 | |
| 17:00:27 | bauzas | for the extra newline, OK | |
| 17:00:39 | bauzas | for the continuous indentation, that's still there | |
| 17:00:55 | bauzas | so, ok, I mixed things | |
| 17:00:56 | gmann | nova is on 3.1.0. i could move placement too to that but 4.0.0 is already out to moving to it is easy. | |
| 17:01:26 | bauzas | gmann has to fix single lines within modules, but can just continue to leave uncontinuous indentation if he wishes | |
| 17:01:49 | gmann | anyways code is up and green so merging it is faster than splitting the patch now | |
| 17:02:53 | bauzas | well, I'm OK to remove my -1 for the sake of merging | |
| 17:03:01 | bauzas | but honestly, this is confisuing | |
| 17:04:12 | gmann | bauzas: how about if i explain those check fixes in cmt msg ? | |
| 17:04:43 | bauzas | I'm just saying we're again touching code for the beauty of our eyes and we're overcomplicating things, exactly like we did a couple of times in nova | |
| 17:04:50 | bauzas | but meh, I bail out | |
| 17:05:01 | bauzas | so, stephenfin can look at the change, I removed my -1 | |
| 17:05:18 | bauzas | the +2 from gibi is there, so... | |
| 17:05:24 | gibi | yeah | |
| 17:05:34 | gibi | honestly I don't feel this as such a big issue | |
| 17:05:41 | gibi | but that jsutme | |
| 17:05:46 | gibi | just me | |
| 17:05:55 | gmann | bauzas: you seems do not like hacking checks much :) | |
| 17:06:19 | bauzas | it's more or less a matter of touching production code for the sake of ourselves being pedantic :) | |
| 17:06:28 | bauzas | but okay | |
| 17:07:15 | bauzas | gmann: well, I'm just pragmatic about things that work | |
| 17:07:26 | bauzas | but fair enough | |
| 17:08:18 | gmann | I see your point. | |
| 17:20:32 | stephenfin | ta, done | |
| 17:33:27 | stephenfin | gmann: Could you look at https://review.opendev.org/c/openstack/nova/+/765798/ at some point? | |
| 17:33:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Merge 'test_hypervisor_status' into 'test_hypervisors' https://review.opendev.org/c/openstack/nova/+/764039 | |
| 17:33:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Change default policy for '/os-hypervisors' https://review.opendev.org/c/openstack/nova/+/765798 | |
| 17:33:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Drop statistics-style fields from os-hypervisors https://review.opendev.org/c/openstack/nova/+/764040 | |
| 17:33:33 | stephenfin | I'm not sure if I'm tackling that correctly | |
| 17:33:43 | stephenfin | Also, resolved your comment on https://review.opendev.org/c/openstack/nova/+/764039 | |
| 17:33:52 | gmann | stephenfin: sure, checking | |
| 17:36:29 | openstack | Launchpad bug 1906266 in OpenStack Compute (nova) "After upgrade: "libvirt.libvirtError: Requested operation is not valid: format of backing image %s of image %s was not specified"" [Undecided,New] | |
| 17:36:29 | stephenfin | lyarwood: you'd probably be interested in this at some point https://bugs.launchpad.net/nova/+bug/1906266 | |
| 17:37:04 | lyarwood | stephenfin: didn't we fix that a while ago? | |
| 17:37:31 | stephenfin | yup, they're saying the fix is incomplete | |
| 17:37:52 | gmann | stephenfin: yeah that is right way, as system scope is disable by default and we still have old legacy rule in deprecated rule so we are good, - https://review.opendev.org/c/openstack/nova/+/765798/2/nova/policies/hypervisors.py#b37 | |
| 17:38:08 | lyarwood | oh for existing images you actually need to add the backing format in, there's nothing n-cpu can do iirc | |
| 17:38:33 | gmann | stephenfin: no microversion needed for policy default, but please add releasenotes for that. I am checking other patches in that series | |
| 17:38:45 | stephenfin | gmann++ Great, thanks :) | |
| 17:38:54 | lyarwood | tbh I thought this was relaxed | |
| 17:39:21 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter https://review.opendev.org/c/openstack/nova/+/749068 | |
| 17:39:35 | stephenfin | maybe it was; they don't give any details about the versions they're using | |
| 17:43:46 | stephenfin | lyarwood: https://github.com/libvirt/libvirt/commit/ae9e6c2a2b75d958995c661f7bb64ed4353a6404 | |
| 17:44:23 | stephenfin | the few patches I grepped from https://www.redhat.com/archives/libvir-list/2020-February/msg00616.html appear to be in v6.1.0 | |
| 17:46:36 | lyarwood | ah! | |
| 17:46:46 | lyarwood | the error is still there but we don't get there now | |
| 17:47:02 | stephenfin | that's my reading of it too, yeah | |
| 17:50:25 | ganso | instructions in the placement docs are not very detailed to achieve what I need. Is anyone familiar with this use case or can think of any possible workarounds? | |
| 17:50:25 | openstack | Launchpad bug 1522307 in OpenStack Compute (nova) "duplicate for #1908133 Disk usage not work for shared storage" [Medium,Confirmed] | |
| 17:50:25 | ganso | Hi nova folks! Yesterday I logged bug https://bugs.launchpad.net/nova/+bug/1908133 and it has been closed as a duplicated. I'd like to discuss what possible workarounds there are (there are no mentions of workarounds in the duplicate entry). In my "steps to reproduce" I took 2 different approaches, the second one being relying on placement to control the shared allocations, but it is quite 100%, as I am not sure I am configuring it correctly. The | |
| 18:06:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Change default policy for '/os-hypervisors' https://review.opendev.org/c/openstack/nova/+/765798 | |
| 19:13:42 | jawad_axd | Hi folks! Error 43, windows 10 with gpu passthrough. Added img_hide_hypervisor_id=True to image property. Is there anything I need to do to load nvidia drivers in windows instance? | |
| 19:14:10 | jawad_axd | *anything else | |
| 19:48:50 | openstackgerrit | Ghanshyam proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | |
| 19:49:44 | openstackgerrit | Ghanshyam proposed openstack/nova master: Reuse code from oslo lib for JSON policy migration https://review.opendev.org/c/openstack/nova/+/763487 | |
| 20:02:16 | openstackgerrit | Elod Illes proposed openstack/nova stable/ussuri: [stable-only] fix lower-constraints and disable qos resize https://review.opendev.org/c/openstack/nova/+/766738 | |
| 20:44:11 | openstackgerrit | Merged openstack/nova master: libvirt: make cross cell resize spawn from snapshot image https://review.opendev.org/c/openstack/nova/+/765561 | |
| #openstack-nova - 2020-12-16 | |||
| 00:13:33 | openstackgerrit | Ghanshyam proposed openstack/placement master: Remove deprecated [placement]/policy_file config option https://review.opendev.org/c/openstack/placement/+/764409 | |
| 00:13:57 | openstackgerrit | Ghanshyam proposed openstack/placement master: [goal] Deprecate the JSON formatted policy file https://review.opendev.org/c/openstack/placement/+/764394 | |
| 00:15:14 | gmann | gibi: bauzas stephenfin please check these two placement patches also. for json->yaml migration community goal. https://review.opendev.org/c/openstack/placement/+/764409 https://review.opendev.org/c/openstack/placement/+/764394 | |
| 00:16:04 | gmann | 764409 is to remove the deprecated policy_file config option which is needed for this migration | |
| 00:56:56 | brinzhang | gibi, bauzas, sean-k-mooney: Since Microversion 2.77, we support specifying an avaiability_zone to unshleve an instance, it allowed {'unshelve': null} and {'unshelve': {'availability_zone': |
|
| 00:57:55 | brinzhang | gibi, bauzas, sean-k-mooney, gmann: this is the record https://review.opendev.org/c/openstack/nova/+/663851/13/nova/api/openstack/compute/schemas/servers.py#659 | |
| 00:59:50 | gmann | brinzhang: yeah as this action API need specific request body so disallow empty make sense. for other action API there is no specific request body so allowing null or anything is what we have during legacy way | |
| 00:59:55 | brinzhang | and we note that in https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/shelve.py#L28-L31 | |
| 01:02:15 | brinzhang | gmann: yes, I think gibi and bauzas's concern in the docs description, because of the availability_zone is optional, but we allowed request {'unshelve': {'availability_zone': <string>}}, if we dont chose the availability_zone, it will be {'unshelve': {} | |
| 01:03:11 | gmann | ok and we only allow {'unshelve': null} in that case | |
| 01:04:45 | gmann | brinzhang: may be we can update it in api-ref too https://docs.openstack.org/api-ref/compute/?expanded=unshelve-restore-shelved-server-unshelve-action-detail | |
| 01:04:54 | brinzhang | yes, I think this is reasonable too | |
| 01:05:00 | gmann | saying 2.77 onwards | |
| 01:05:44 | brinzhang | gmann: ok, let submit a patch to add a Note for the availability_zone | |
| 01:06:07 | brinzhang | s/let/ let me | |
| 01:06:13 | gmann | +1 | |
| 01:06:46 | brinzhang | Will do, and pls review it later | |
| 01:08:04 | gmann | thanks | |
| 01:12:29 | brinzhang | gmann: how abot saying: Since microversion 2.77, we are allowed to request {'unshelve': null} and {'unshelve': {'availability_zone': <string>}}, but not allowed to request {'unshelve': {}}. | |
| 01:16:10 | gmann | brinzhang: yeah, little modification- Since microversion 2.77, allowed request body schema are {'unshelve': null} or {'unshelve': {'availability_zone': <string>}}, and {'unshelve': {}} request body is not allowed. | |
| 01:31:08 | brinzhang | gmann: and let me register a bug to trace this change | |
| 01:32:57 | sean-k-mooney | gmann: brinzhang we were suggesting allowing {} ealier today | |
| 01:33:10 | sean-k-mooney | i think its perfectly consitent to treat null and {} the same | |
| 01:35:20 | gmann | sean-k-mooney: {} means allowed everything or any unknown request body which is later ignored so confusing for users. where {'unshelve': null} means allow only empty request body | |
| 01:35:53 | gmann | sean-k-mooney: like for {}. i can pass {'unshelve': {'unknown': 'anything', ....}} | |
| 01:36:16 | gmann | that was the reason we thought of improving it in 2.77 | |
| 01:50:51 | openstackgerrit | Brin Zhang proposed openstack/nova master: Improving the description for az of unshleve API https://review.opendev.org/c/openstack/nova/+/767251 | |
| 01:51:52 | brinzhang | sean-k-mooney: yeah, I agree with gmann, while I do the change of specifying az to unshelve a server, already talked, also with mriedem | |
| 01:52:19 | brinzhang | gmann: done, pls review https://review.opendev.org/c/openstack/nova/+/767251 | |
| 02:47:55 | openstackgerrit | Merged openstack/nova master: Refactoring of functional.regression.test_bug_1702454 https://review.opendev.org/c/openstack/nova/+/765997 | |
| 06:11:30 | openstackgerrit | Wenping Song proposed openstack/nova master: Resume accelerator guest state when a host is booted https://review.opendev.org/c/openstack/nova/+/767273 | |
| 08:10:11 | openstackgerrit | Mamduh proposed openstack/os-vif stable/ussuri: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765967 | |
| 08:16:26 | openstackgerrit | Merged openstack/placement master: Fix l-c job and move to latest hacking 4.0.0 https://review.opendev.org/c/openstack/placement/+/766994 | |
| 08:20:51 | openstackgerrit | Mamduh proposed openstack/os-vif stable/train: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765970 | |
| 08:22:46 | gibi | brinzhang, gmann: thanks for the historical context on unshelve: {} | |
| 08:23:52 | gibi | so the goal was to only allow unshelve:null but not unshelve:{'unknow': ''} but this still not mean we have to forbid unshelve:{} | |
| 08:33:21 | openstackgerrit | Mamduh proposed openstack/os-vif stable/stein: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765974 | |
| 08:56:04 | openstackgerrit | Mamduh proposed openstack/os-vif stable/rocky: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765977 | |
| 09:00:51 | openstackgerrit | Mamduh proposed openstack/os-vif stable/queens: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/c/openstack/os-vif/+/765983 | |
| 09:01:40 | gibi | I think what what brinzhang proposed in the comment of https://review.opendev.org/c/openstack/nova/+/663851/13/nova/api/openstack/compute/schemas/servers.py#659 allows unshelve: {}, unshelve:{"availability_zone": "foo"}, unshelve: null, but forbid unshelve: {"foo": "bar"} | |
| 09:01:52 | gibi | bauzas: you too ^^ | |
| 09:02:07 | gibi | which I think what is bauzas after | |