| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-12-10 | |||
| 09:40:14 | melwitt | *test_cross_cell_migrate.py | |
| 09:41:11 | melwitt | maybe that would be overkill anyway, I dunno | |
| 09:41:23 | gibi | melwitt: I think this upgrade check that breaks in stable is removed from master | |
| 09:41:45 | melwitt | gibi: it is but it's failing in a different way for the master branch | |
| 09:41:46 | brinzhang | lyarwood: yeah, I like that job too^, thanks | |
| 09:41:56 | gibi | melwitt: ohh, then I will check that too | |
| 09:42:31 | melwitt | gibi: here's my ML post with links to more info http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019319.html | |
| 09:43:56 | melwitt | lajoskatona is looking at the neutron side but I doubt it's neutron. it's just that when we request the port binding it results in neutron getting UnknownResourceProvider, I have no idea how that can happen | |
| 09:53:56 | gibi | melwitt: sorry I was pulled in a downstream call | |
| 09:54:02 | gibi | I will pick up the threads after it | |
| 09:54:16 | melwitt | thanks gibi++ | |
| 09:54:19 | melwitt | o/ | |
| 09:54:23 | gibi | melwitt: have a nice evening | |
| 10:00:17 | stephenfin | sean-k-mooney: The issue with https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises is nothing to do with mock the lib | |
| 10:00:26 | stephenfin | sean-k-mooney: that happens because of testtools | |
| 10:01:10 | stephenfin | sean-k-mooney: https://github.com/testing-cabal/testtools/issues/113 https://github.com/testing-cabal/testtools/issues/275 | |
| 10:02:26 | gibi | lyarwood: regarding qos stable failures: other than the the packaging 20.4 bump and the qos break, is there any other know break on stable/victoria at the moment? | |
| 10:04:09 | lyarwood | gibi: not on stable/victoria that I'm aware of | |
| 10:04:19 | lyarwood | gibi: <= stable/train has other issues | |
| 10:07:36 | brinzhang | hi all, the nova-multi-cell task always failed, is there a bug tracing? | |
| 10:07:47 | brinzhang | https://8881082f52814b33cb4d-7716d10619577c42ab1386a760b8bb5c.ssl.cf2.rackcdn.com/764292/8/check/nova-multi-cell/9429107/testr_results.html | |
| 10:10:41 | gibi | lyarwood: ack, I saw the bandit affecting train and older | |
| 10:10:56 | gibi | brinzhang: yes, the nova-cell-multi is broken right now | |
| 10:11:08 | gibi | brinzhang: I have to look at it after my current call | |
| 10:11:24 | brinzhang | gibi: ack | |
| 10:11:24 | gibi | brinzhang: here is melwitt's post about it from the mL http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019319.html | |
| 10:12:51 | brinzhang | gibi: I saw your talking about above, sorry to mention again | |
| 10:13:19 | lyarwood | gibi: ack kk, we could switch both jobs to NV and then land things? | |
| 10:16:41 | gibi | lyarwood: both job is nova specific? then yes. NV->fix1->fix2->revert NV could be a solution | |
| 10:17:39 | gibi | lyarwood: sorry I have to be off for an hour or so | |
| 10:19:05 | lyarwood | gibi: np | |
| 10:19:15 | lyarwood | gibi: pushing now, I'll ask elod and others to review | |
| 10:19:45 | lyarwood | git-review really takes a while now | |
| 10:20:02 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765749 | |
| 10:20:03 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: zuul: Temporarily make nova-multi-cell non-voting https://review.opendev.org/c/openstack/nova/+/766440 | |
| 10:20:45 | lyarwood | oh lyarwood-- | |
| 10:24:19 | openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552 | |
| 10:25:29 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: [stable-only] Temporarily make nova-multi-cell non-voting https://review.opendev.org/c/openstack/nova/+/766440 | |
| 10:25:30 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765749 | |
| 10:34:44 | lyarwood | elod / bauzas ^ would you mind taking a look at the above stable changes | |
| 10:35:16 | elod | lyarwood: sure, looking | |
| 10:37:24 | melwitt | gibi: one last update before I really go, I can see on zuul status that my stable/victoria change minbw tests have failed still but now for a different reason. the logs are not yet available but I suspect that now that the cell is correctly targeted, it's now hitting the same bug that exists on the master branch. just fyi | |
| 10:38:00 | lyarwood | can someone kick melwitt so she can get some sleep? | |
| 10:38:05 | lyarwood | :) | |
| 10:38:08 | melwitt | D: | |
| 10:38:15 | lyarwood | only joking | |
| 10:38:23 | lyarwood | but seriously get some sleep :D | |
| 10:38:38 | melwitt | I know, that was my OMG I CANT BELIEVE YOU SAID THAT look | |
| 10:38:44 | melwitt | :) | |
| 10:39:38 | melwitt | ok, gnight for reals | |
| 10:39:47 | lyarwood | hehe twas a good one :) | |
| 10:39:54 | lyarwood | \o | |
| 10:48:41 | elod | lyarwood: will the two patch work separately? Don't they need to be squashed to fix every issue? (or will the .zuul.yaml change only run limited tests that could pass? O.o) | |
| 10:49:57 | lyarwood | elod: yup I'm an idiot | |
| 10:51:47 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: lower-constraints: Bump packaging to 20.4 https://review.opendev.org/c/openstack/nova/+/765749 | |
| 10:51:50 | elod | lyarwood: I'm not sure, just asking | |
| 10:52:37 | lyarwood | elod: no no you are right, lower-constraints would fail in the standalone change | |
| 10:52:52 | lyarwood | elod: so I've squashed it into the fix for that job | |
| 10:53:06 | lyarwood | elod: and once we have a fix for the multi-cell job we should enable it again in that change | |
| 10:53:47 | lyarwood | elod: the only other way of fixing this would be to squash both fixes into one change | |
| 10:54:00 | lyarwood | elod: that I'm not a fan of tbh | |
| 10:55:42 | elod | lyarwood: ok, good, thx! | |
| 11:40:06 | openstackgerrit | Lucian Petrut proposed openstack/nova master: Fix unshelved image ref https://review.opendev.org/c/openstack/nova/+/765924 | |
| 11:58:03 | openstackgerrit | Lee Yarwood proposed openstack/nova-specs master: DNM/WIP Remove device from attach_volume request response https://review.opendev.org/c/openstack/nova-specs/+/765097 | |
| 12:00:25 | gibi | lyarwood: I will start looking into the qos failure on the master as melwitt said we propably hit that on stable after we fix the context targeting issue | |
| 12:01:05 | gibi | hm, first, I will confirm that the stable failure after the context targeting fix is the same as the master failure | |
| 12:12:49 | gibi | OK, I confirm that after https://review.opendev.org/c/openstack/nova/+/766364 on stable we hit the same issue as visible on msater | |
| 12:12:52 | gibi | master | |
| 12:13:33 | openstack | Launchpad bug 1907522 in OpenStack Compute (nova) "test_*_with_qos_min_bw_allocation fails in the nova-multi-cell job with: nova.exception.MigrationPreCheckError: Migration pre-check error: Failed to create port bindings for host <host>" [Undecided,New] | |
| 12:13:33 | gibi | so on master we need to fix https://bugs.launchpad.net/nova/+bug/1907522 and then backport the fix to stable on top of https://review.opendev.org/c/openstack/nova/+/766364 which is only needed on stable | |
| 12:13:41 | gibi | this will be fun | |
| 13:00:06 | gibi | lyarwood, melwitt : I'm affraid that we missed the qos support for cross cell resize. I think qos and cross cell work was done in parallel. | |
| 13:00:58 | gibi | as the migration uses different conductor tasks and ComputeManager methods we simply missing the qos code from the cross cell path | |
| 13:07:27 | openstackgerrit | Illes Elod proposed openstack/nova stable/train: DNM: tox constraints test https://review.opendev.org/c/openstack/nova/+/766463 | |
| 13:38:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Disable qos resize tempest test for nova-multi-cell job https://review.opendev.org/c/openstack/nova/+/766471 | |
| 13:38:35 | gibi | lyarwood, melwitt: ^^ this is my way forward on the master and this needs to be backported to stable | |
| 13:44:14 | bauzas | I agree | |
| 13:44:19 | bauzas | we need to revert the tests | |
| 13:44:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Disable qos resize tempest test for nova-multi-cell job https://review.opendev.org/c/openstack/nova/+/766471 | |
| 13:45:02 | gibi | bauzas: the test works fine with same cell resize so I would not revert the whole test | |
| 13:47:25 | bauzas | yeah, by reverting, I meant disabling the faulty ones | |
| 13:47:30 | bauzas | not the whole patch | |
| 13:47:37 | bauzas | anyway +2d with comments | |
| 13:49:01 | gibi | let me quicly fix those nits | |
| 13:52:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Disable qos resize tempest test for nova-multi-cell job https://review.opendev.org/c/openstack/nova/+/766471 | |
| 13:53:01 | gibi | bauzas: ^^ | |
| 13:54:03 | bauzas | ack | |
| 14:05:55 | elod | lyarwood: I think the bandit patch needs to be merged starting from pike, and then to newer branches, branch by branch... due to grenade job. (which would be unnecessary if bandit 1.6.3 was yanked, but that might not happen soon...) | |
| 14:08:27 | elod | lyarwood: also, I'm experimenting with the 'general' lower-constraint fix ( https://review.opendev.org/q/topic:"constrain-tox-install" ) but it might be better to try to fix the lower-constraints.txt instead, if it does not bring up infinite package version bumps there... | |
| 14:10:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/victoria: Disable qos resize tempest test for nova-multi-cell job https://review.opendev.org/c/openstack/nova/+/766474 | |
| 14:23:59 | gibi | elod: lyarwood: now I two possible way forward for stable. a) disable nova-multi-cell job b) disable the qos tests in the nova-multi-cell job | |
| 14:24:50 | lyarwood | hey sorry just back from lunch | |
| 14:25:03 | lyarwood | elod: ack I can work my way forwards from pike if it's going to be easier | |
| 14:25:38 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/765749 is alreadying in the gate for victoria | |
| 14:25:46 | lyarwood | gibi: making the entire job non-voting | |
| 14:26:53 | gibi | lyarwood: OK to merge that. Then to re-enable the job we need https://review.opendev.org/c/openstack/nova/+/766474 | |
| 14:27:41 | gibi | then the question what to do https://review.opendev.org/c/openstack/nova/+/766364/ | |
| 14:29:41 | lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/765749 isn't actually in the gate yet so we could yank it out now | |
| 14:29:45 | elod | lyarwood: I've just checked that there's no lower-constraint job @ pike, so bandit patch could be merged easier (fingers crossed) :] | |
| 14:30:27 | gibi | lyarwood: keep it as it is closer to merge | |