| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-12-03 | |||
| 01:19:54 | dcapone2004 | 1 more question...to potentially save me some time searching....do you know where the xml files for VMs is in a kolla containerized deployment? | |
| 01:20:13 | sean-k-mooney | oh you dont edit the xmls | |
| 01:20:19 | sean-k-mooney | i use kolla | |
| 01:20:30 | sean-k-mooney | you need to docker exec into nova_libvirt | |
| 01:20:43 | sean-k-mooney | e.g. docker exec -it nova_libvirt bash | |
| 01:20:54 | sean-k-mooney | then do virsh edit <vm id> | |
| 01:21:33 | sean-k-mooney | if you look at the extended atibute in the server show as an admin you can get teh libvirt domain name | |
| 01:21:49 | sean-k-mooney | otherwise you just need to find the one with the uuid that matches | |
| 01:23:49 | dcapone2004 | ok, I thought you said, "so you could manally edit the xml and add that" "then use libvirt to restart the vm | |
| 01:24:06 | sean-k-mooney | ah yes when you do virsh edit | |
| 01:24:21 | sean-k-mooney | it will open the xml in an editor for you | |
| 01:24:24 | sean-k-mooney | that is what i ment | |
| 01:24:39 | dcapone2004 | got it | |
| 01:24:41 | sean-k-mooney | it will also validate it with libvirt and only allow it to save if the edit is valid | |
| 01:25:22 | sean-k-mooney | anywyay its 01:25 here so im heading to bed | |
| 01:25:45 | sean-k-mooney | if that works defintly file the bug and we can see if we can fix this | |
| 01:26:10 | sean-k-mooney | the nova meeting is tomorrow too if you wanted to bring it up in open dicusstion | |
| 01:26:42 | sean-k-mooney | if you can confirm either way if setting that option fixes your issue let me know an i can bring it up if you cant attend | |
| 01:27:30 | dcapone2004 | will do | |
| 01:27:42 | dcapone2004 | just ran virsh reboot 35, so we shall see | |
| 01:28:20 | sean-k-mooney | you might need to stop the domin and start it by the way | |
| 01:28:31 | sean-k-mooney | i dont rembere if reboot does a soft reboot or hard | |
| 01:28:57 | sean-k-mooney | soft being a qemu monitor command to tell the os to reboot without restarting the qemu process | |
| 01:28:57 | dcapone2004 | was going to iterate through all possible methods before quitting :-) .... get some rest...your assistant has been much appreciated | |
| 01:29:17 | sean-k-mooney | o/ | |
| 03:17:46 | openstackgerrit | chengsheng proposed openstack/nova master: CPU selection with hypervisor consideration https://review.opendev.org/c/openstack/nova/+/762330 | |
| 05:51:48 | openstackgerrit | Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336 | |
| 06:32:57 | brinzhang_ | gibi, dansmith: updated cyborg shelve/unshelve support patch, please review it while you are free https://review.opendev.org/c/openstack/nova/+/729563, thanks | |
| 07:05:11 | openstackgerrit | Xinran WANG proposed openstack/nova-specs master: Smart-nic Support Specification https://review.opendev.org/c/openstack/nova-specs/+/742785 | |
| 08:07:51 | openstackgerrit | Wenping Song proposed openstack/nova master: Nova supports password encrypted VNC https://review.opendev.org/c/openstack/nova/+/622336 | |
| 08:38:19 | bauzas | good morning Nova | |
| 08:47:54 | gibi | good morning bauzas | |
| 08:49:07 | bauzas | :-) | |
| 08:59:07 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Separate out the migration tests https://review.opendev.org/c/openstack/nova/+/765300 | |
| 09:10:47 | elod | good morning :) | |
| 09:11:11 | elod | bauzas: if you will have time can you have another look at this patch? https://review.opendev.org/c/openstack/nova/+/764432 | |
| 09:11:33 | elod | this would unblock the gate on stable/victoria | |
| 09:11:43 | bauzas | elod: for sure, I just want to progress on the routed networks impl, but I can do other urgent stuff | |
| 09:11:56 | bauzas | a-ha, good reason then | |
| 09:12:09 | bauzas | elod: and fwiw, lyarwood is on PTO those 2 days | |
| 09:12:24 | bauzas | damn, those RH folks who are always on vacation... | |
| 09:12:47 | elod | this is lyarwood's commit so it does not really matter ;) | |
| 09:13:46 | elod | actually, only a commit message change happened since your last +1 (and a successful zuul run \o/) | |
| 09:46:49 | elod | bauzas: thx! \o/ (and sorry for the interrupt o:)) | |
| 09:47:21 | bauzas | np | |
| 10:24:23 | openstackgerrit | Lucian Petrut proposed openstack/nova master: hyper-v rbd volume support https://review.opendev.org/c/openstack/nova/+/763550 | |
| 11:05:37 | openstackgerrit | Brin Zhang proposed openstack/nova master: Replace all_tenants with all_projects https://review.opendev.org/c/openstack/nova/+/765311 | |
| 11:27:21 | chengsheng | kashyap: I have updated: https://review.opendev.org/c/openstack/nova/+/762330/ | |
| 11:28:35 | kashyap | chengsheng: Hi; will look. (Side note: I'm juggling various things this and next week, as I'll be off from 14-Dec until 31-Dec) | |
| 11:29:10 | gibi | kashyap: thanks for the heads up, have a nice time off! | |
| 11:29:25 | kashyap | gibi: Thank you; lots of non-computer reading :-) | |
| 11:30:57 | gibi | nice! | |
| 11:47:12 | brinzhang_ | gmann: There is an small issue while I want the replace the list servers's policies, I am not find a good way to decrepate the old policy (https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L1299), I have submited a base patch, hope you can give some suggestions | |
| 11:48:40 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Replace tenants* with projects* in List Servers's policy https://review.opendev.org/c/openstack/nova/+/765315 | |
| 11:48:48 | brinzhang_ | gmann: this is the replace role name patch https://review.opendev.org/c/openstack/nova/+/765315 | |
| 11:48:57 | brinzhang_ | gmann: thanks | |
| 11:52:48 | brinzhang_ | gibi, stephenfin, sean-k-mooney, gmann: the blueprint remove-tenant-id need a microversion, and there are so many nova API need to be changed, so I would like to get a microversion to avoid many conflict, do you have time to review the first patch that adding a microversion 2.88 for this change. links:https://review.opendev.org/c/openstack/nova/+/764292 | |
| 12:00:40 | sean-k-mooney | brinzhang_: im not sure we have many patches tat are changing the api at present, i i would hope there wont be many conflicts | |
| 12:01:17 | sean-k-mooney | but yes ill try to review later today | |
| 12:02:24 | brinzhang_ | sean-k-mooney: thanks, but from the list nova apis in the spec, there are at least 3 APIs need a microversion, I thinks https://specs.openstack.org/openstack/nova-specs/specs/wallaby/approved/remove-tenant-id.html | |
| 12:03:16 | brinzhang_ | whatever, there is a microversion to be bound, it's easy to do ^^ | |
| 12:03:22 | sean-k-mooney | yep but how many of those are close to merging | |
| 12:04:31 | sean-k-mooney | what im not sure about is what to do with the follow up patches | |
| 12:04:41 | brinzhang_ | I thinks this one https://review.opendev.org/c/openstack/nova/+/764292 | |
| 12:04:48 | sean-k-mooney | it kind of feels like you shoudl be doing this in one big patch | |
| 12:05:10 | sean-k-mooney | if its 3 it feels like you need 3 microverions | |
| 12:05:20 | brinzhang_ | no, I wont to do this in one patch | |
| 12:05:53 | brinzhang_ | it's not easy to review, and not easy to manage by me | |
| 12:06:07 | sean-k-mooney | right but since master is ment to be deployable at all times if its 3 patches it strictly speaking should be 3 microverions i think but perhaps we can make an excption here | |
| 12:07:19 | brinzhang_ | sean-k-mooney: i know what you are concern, I try to complete this in Wallaby release | |
| 12:07:41 | sean-k-mooney | i think the best way forward is too have multiple patches but only merge them when all patches are ready | |
| 12:07:56 | brinzhang_ | but might as your concern, may Icannt complete ^^ | |
| 12:08:39 | sean-k-mooney | gibi: gmann any toughts on ^ | |
| 12:09:07 | sean-k-mooney | gibi: gmann the remove-tenant-id changes are really too big to have in one patch | |
| 12:09:19 | brinzhang_ | wan-k-mooney: yeah, it's also good to me, if so, that I should avoid to maintain more microversion keys in all patches | |
| 12:09:44 | sean-k-mooney | gibi: gmann but we also dont want multiple micorverions here | |
| 12:10:49 | sean-k-mooney | brinzhang_: in anycase ill try and review it today | |
| 12:11:39 | brinzhang_ | sean-k-mooney: thanks | |
| 12:12:07 | sean-k-mooney | brinzhang_: are there more patches in that serise by the way or just the 3 your have pushed | |
| 12:12:29 | brinzhang_ | yeah, I just pushed List Servers APIs changes | |
| 12:13:20 | brinzhang_ | If there is need all patches submited then to review, that you all can ignore my asked above ^^ | |
| 12:13:29 | brinzhang_ | That's nothing | |
| 12:13:58 | sean-k-mooney | well it was more if im reviewing it ill try and review all the patches at the same time | |
| 12:14:13 | sean-k-mooney | https://review.opendev.org/q/topic:%22bp%252Fremove-tenant-id%22+(status:open%20OR%20status:merged) so i was wondering if there were more pending or if that was it | |
| 12:14:19 | sean-k-mooney | they dont all need to be there | |
| 12:14:37 | sean-k-mooney | just wanted to make sure that had all the patches that were currently avaiable | |
| 12:15:43 | brinzhang_ | There a two patches are avaliable, except the policy changes patch, that I want to get help from gmann | |
| 12:16:49 | brinzhang_ | after complete the policy changes, the server list apis change is ok for this microversion, IMO, yes | |
| 12:22:08 | gibi | sean-k-mooney, brinzhang_: what if we merge the changes gradually but not expose the new microversion until the last patch? | |
| 12:22:47 | gibi | what happens if we don't do this change until the last patch? https://review.opendev.org/c/openstack/nova/+/764292/5/nova/api/openstack/api_version_request.py#248 | |
| 12:23:40 | sean-k-mooney | gibi: i was wondering about that too i think we did that in the past but if we do we need to diable the new codepaths until the last patch merges | |
| 12:24:59 | brinzhang_ | for example: in the server list apis, I need to remove the tenant_id and all_tenants, and replaced with project_id and all_projects, some places need the version to have a judgement, maybe it's not easy to control all changes if there is not a microversion | |
| 12:25:00 | gibi | sean-k-mooney: why do we need to disable the new codepaths? Not having the microversion 88 published makes those new codepath unreachable | |
| 12:25:12 | brinzhang_ | it's my opinion | |
| 12:25:22 | sean-k-mooney | gibi: oh ok in that case yep that should work | |
| 12:25:33 | gibi | brinzhang_: you do have a microversion it just not available for the client to request it | |
| 12:25:39 | sean-k-mooney | unless a different api change takes the microversion | |
| 12:26:00 | gibi | sean-k-mooney: yeah, another api change can break this | |
| 12:26:05 | gibi | hm hm | |
| 12:26:56 | gibi | so if we want to go this direction then we need to make the api patches serialized | |