| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-10-27 | |||
| 14:25:21 | bauzas | lyarwood: yeah, but that's not the python binding API, right? | |
| 14:26:38 | lyarwood | bauzas: true, we could use better documentation | |
| 14:26:40 | bauzas | totally unrelated, I really would love Gerrit supporing images or memes https://review.opendev.org/#/c/759828/2/specs/wallaby/approved/nova-support-webvnc-with-password-anthentication.rst@175 | |
| 14:26:56 | bauzas | I mean the Gerrit UI | |
| 14:27:19 | bauzas | hyperlinks would stay plain text for gerrit text clients | |
| 14:27:29 | bauzas | but for those which are smart... | |
| 14:28:50 | sean-k-mooney | unicode works | |
| 14:29:02 | sean-k-mooney | although sometimes it can break things | |
| 14:29:51 | bauzas | sean-k-mooney: how so ? | |
| 14:32:01 | sean-k-mooney | using unicode in commit messages has broken things in the past | |
| 14:32:21 | gibi | bauzas: you can try to add a client side script that resolves the links for you locally | |
| 14:32:25 | sean-k-mooney | i think it broke the zuul parser that looks for depend on | |
| 14:32:54 | sean-k-mooney | but ya you can use code injector | |
| 14:32:59 | bauzas | lol | |
| 14:33:20 | bauzas | for gerrit | |
| 14:33:26 | sean-k-mooney | i use code injector to allow me to copy form gerrit commits again | |
| 14:33:30 | sean-k-mooney | *comments | |
| 14:34:07 | sean-k-mooney | you need to set user-select: text to get comment to be selectable again | |
| 14:34:29 | openstackgerrit | Lee Yarwood proposed openstack/os-traits master: Add COMPUTE_EPHEMERAL_ENCRYPTION tratis https://review.opendev.org/759878 | |
| 14:46:59 | gibi | sean-k-mooney: could you paste that code, I could use that too | |
| 14:50:25 | sean-k-mooney | i need to fix it but yes right now i some times need to refresh as it can run too early but before it was quadadic still fast can cleint side i just felt bad | |
| 14:51:05 | sean-k-mooney | http://paste.openstack.org/show/799434/ | |
| 14:55:53 | gibi | thanks | |
| 14:58:59 | sean-k-mooney | the reason it broke is both firefox and chrome change how ineritance works for css | |
| 14:59:35 | sean-k-mooney | so the default value that was inherited chaned | |
| 15:02:32 | sean-k-mooney | gibi: this is basically what i based it on https://www.smashingmagazine.com/2019/04/mutationobserver-api-guide/ | |
| 15:08:59 | sean-k-mooney | gibi: i might just need to add subtree to that list https://www.smashingmagazine.com/2019/04/mutationobserver-api-guide/#childlist-with-subtree | |
| 15:09:48 | gibi | thanks | |
| 15:11:01 | sean-k-mooney | im going to hack on it for 5 mins and see if i can get it back to workign without a refresh | |
| 15:14:24 | sean-k-mooney | gibi: i just need to call it once when the script is loaded and then on mutation http://paste.openstack.org/show/799435/ | |
| 15:14:31 | sean-k-mooney | that should work | |
| 15:16:14 | sean-k-mooney | gibi: also "review\.opendev\.org" is what im using for the site regex/matcher thing for the code injector plugin | |
| 15:16:36 | sean-k-mooney | i have it set to run on page load | |
| 15:37:51 | gibi | sean-k-mooney: works nicely (after an extra refresh) | |
| 15:47:58 | bauzas | gibi: sean-k-mooney: fwiw dev mode on FF or Chrome works fine | |
| 15:48:05 | bauzas | no need for a plugin | |
| 15:48:25 | bauzas | newspapers* | |
| 15:48:42 | sean-k-mooney | bauzas: to add it sure but its kind of annoying to have to keep changing it | |
| 15:48:54 | bauzas | I don't really copy/paste a lot | |
| 15:49:16 | bauzas | what you can also do is just to click on "reply" at a comment | |
| 15:49:30 | sean-k-mooney | ya but that quotes it | |
| 15:49:32 | bauzas | you'll get the text with a "> " prefix | |
| 15:49:34 | bauzas | right | |
| 15:49:39 | bauzas | but easy peasy nope ? | |
| 15:49:42 | sean-k-mooney | its annoying when you providing code examples | |
| 15:50:01 | bauzas | humm, really ? | |
| 15:50:13 | sean-k-mooney | yep why do you think i wrote a script :) | |
| 15:50:20 | sean-k-mooney | i want it to just work | |
| 15:50:28 | bauzas | cut -c1 - ? | |
| 15:50:41 | bauzas | whoops | |
| 15:50:43 | sean-k-mooney | more work the copy paste :P | |
| 15:50:46 | bauzas | cut -c1- | |
| 15:51:19 | bauzas | sean-k-mooney: well, if you're lazy enough to copy/paste some hand-written code, then I can understand your point :p | |
| 15:53:46 | sean-k-mooney | lol i copy paste it but i use my skills to make my job more efficent | |
| 15:53:56 | sean-k-mooney | but speaking of reviewing my code | |
| 15:54:25 | sean-k-mooney | https://review.opendev.org/#/c/751642/7 and https://review.opendev.org/#/c/602432/22 coudl do with some reivew | |
| 15:57:18 | bauzas | sean-k-mooney: ping me those changes next week | |
| 15:57:26 | bauzas | this week, I focused on open specs | |
| 16:22:55 | gibi | bauzas: see you tomorrow o/ | |
| 17:31:04 | openstack | Launchpad bug 1901739 in OpenStack Compute (nova) " libvirt.libvirtError: internal error: missing block job data for disk 'vda'" [Undecided,New] | |
| 17:31:04 | lyarwood | kashyap: https://bugs.launchpad.net/nova/+bug/1901739 - odd LM issue if you have time tomorrow | |
| #openstack-nova - 2020-10-28 | |||
| 00:48:47 | brinzhang | bauzas:hi, yesterday was my wife's brithday, I am sorry replied later | |
| 06:20:26 | openstackgerrit | sean mooney proposed openstack/nova master: enable host shuffeling by default https://review.opendev.org/760055 | |
| 06:39:39 | openstackgerrit | Jorhson Deng proposed openstack/nova master: Reject to attach and detach volume while task_state is not None https://review.opendev.org/758918 | |
| 07:27:34 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication https://review.opendev.org/759828 | |
| 08:00:42 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication https://review.opendev.org/759828 | |
| 08:13:40 | bauzas | brinzhang0: absolutely no worries, priorities go to the family | |
| 08:14:10 | bauzas | good morning Nova | |
| 08:16:00 | brinzhang0 | bauzas: good morning, thanks | |
| 08:31:21 | lyarwood | well the gate is fun at the moment | |
| 08:31:41 | lyarwood | melwitt++ thanks for the ER query and other bug you raised, looks like we have hit *more* issues overnight | |
| 08:33:50 | bauzas | lyarwood: /o\ | |
| 08:35:23 | bauzas | lyarwood: mmmm, the gate looks all good for me | |
| 08:36:47 | lyarwood | https://review.opendev.org/#/c/759831/ check the failures here, a random collection of unrelated failures | |
| 08:37:03 | lyarwood | the gate isn't jammed, jobs are just failing | |
| 08:50:44 | bauzas | lyarwood: I see | |
| 08:50:57 | bauzas | we're just lucky then | |
| 08:57:25 | kashyap | lyarwood: Mornin; will check | |
| 09:01:15 | lyarwood | kashyap: ack, is that streaming somewhere? | |
| 09:01:43 | kashyap | lyarwood: It is per-email-based login; costs $25 | |
| 09:01:52 | kashyap | lyarwood: Yeah, your recollection is right | |
| 09:02:04 | kashyap | BTW, don't worry; the full talks will be available on YouTube soon | |
| 09:02:16 | lyarwood | kk no issues, I'll watch it once it's posted there | |
| 09:02:20 | kashyap | (Even the panel discussion was preprecorded) | |
| 09:04:45 | kashyap | lyarwood: So the test that's failing is live migration _without_ shared storage? | |
| 09:06:17 | frickler | gibi: lyarwood: since https://review.opendev.org/759831 failed once more on unrelated issues, how about force-merging it in order to unblock things? I think we can be pretty sure that the patch itself is working fine by now | |
| 09:06:51 | lyarwood | kashyap: https://opendev.org/openstack/tempest/src/branch/master/tempest/api/compute/admin/test_live_migration.py#L151 | |
| 09:07:12 | lyarwood | frickler: I'd be happy with that if it unblocks everyone, gibi should have the final say as PTL however. | |
| 09:07:39 | lyarwood | I'm going to spend some time this morning going over the other failures and making sure we have bugs / ER queries etc for each | |
| 09:09:21 | lyarwood | kashyap: hmm why is this even listed as live block migration? | |
| 09:09:26 | lyarwood | kashyap: it's just a paused instance | |
| 09:09:51 | kashyap | lyarwood: So it is migrating a paused instance but _with_ storage, isn't it? | |
| 09:10:18 | lyarwood | kashyap: yeah, it's just making assumptions about the env that storage isn't shared | |
| 09:10:37 | kashyap | Aah, so it might well be a shared storage setup, but the test is dubious | |
| 09:10:37 | lyarwood | I guess that's what block_migration_for_live_migration is checking | |
| 09:11:06 | kashyap | I wonder if that's why the NBD copy was cancelled - it must've detected "hey, it's shared storage, no need for copy, hence I'm cancelling it" | |
| 09:11:33 | lyarwood | kashyap: no I don't think the storage is in this job | |
| 09:11:42 | kashyap | So, it is non-shared storage? | |
| 09:11:57 | lyarwood | yeah sorry I'm just confusing the situation | |
| 09:12:16 | kashyap | No prob | |