Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-10-22
09:05:33 gibi s/flutile/futile
09:14:37 gibi which means it is very limited what we can typecheck
09:16:18 gibi List*Fields are complicated as they are coreced from Iterables but not from str or Mapping myobj.list_of_ints = {1, 2, 3}
09:16:36 gibi sorry I wanted to link https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L648
09:17:24 gibi btw myobj.list_of_ints = {'1', '2', '3'} also accepted by ovo as the elements of the iterable is coerced to int
09:27:27 stephenfin gibi: I hadn't considered coercion /o\
09:28:06 stephenfin Hmm, that does sound pretty futile alright. Damn :-\
09:29:49 stephenfin I had been thinking it might make sense to at least define the attributes and simply set their type to Any, so that we'd know you could define e.g. 'InstanceNUMACell.cpu_policy' but not '.cpu_policyyyy'. However, I guess we rely on that to store working data
09:32:48 gibi stephenfin: I can generate the fields with https://github.com/gibizer/ovo-mypy-plugin and map them to Any. I guess non o.vo fields defined via simply assigning value to them in nova code. So those can be typed in nova code and picked up by mypy
09:34:42 stephenfin gibi: I think there's probably value in that. I mean, it sounds like the best we can get unless we wanted to drop the coerce functionality
09:35:08 stephenfin which, tbc, I wouldn't be entirely against either; explicit is better than implicit and all that
09:36:12 gibi stephenfin: I don't know if the generic RPC code depends on coerce or not. But the specific nova usage of o.vo can be converted to not use coerce
09:37:13 gibi or at least to use explicit coerce
09:37:22 gibi instead of implicit during assignment
09:39:16 stephenfin Even if the RPC code did rely on it, type checking doesn't happen at run time so we could require explicit coercion for non-RPC cases
09:39:27 stephenfin i.e. get static type checking working
10:12:56 gibi stephenfin: so then we are back to defining IntegerField as int even though we know that o.vo is more forgiving than that at runtime?
10:41:21 openstackgerrit Merged openstack/nova master: virt: Remove 'post_interrupted_snapshot_cleanup' API https://review.opendev.org/749313
12:32:49 openstackgerrit sean mooney proposed openstack/os-vif stable/victoria: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/759255
12:33:06 sean-k-mooney lyarwood: can you reivew https://review.opendev.org/#/c/756406 and https://review.opendev.org/#/c/759255/
12:33:24 sean-k-mooney they are os-vif stable/victoria backports
12:35:28 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/759256
12:36:43 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/758396
12:40:41 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/758396
12:54:12 lyarwood sean-k-mooney: ack will do
12:57:42 lyarwood sean-k-mooney: done, LGTM.
12:59:11 sean-k-mooney lyarwood:thanks
13:02:53 sean-k-mooney lyarwood: if you fell like doing other reviews https://review.opendev.org/#/q/topic:bug/1895220+(status:open+OR+status:merged) is related to a downstream escalation
13:03:19 sean-k-mooney i have just rechecked them but i would really like to get thos merged sooner rather then later
13:04:10 lyarwood sean-k-mooney: ack queued
13:12:58 openstackgerrit Merged openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949
13:13:06 openstackgerrit Merged openstack/nova master: Remove self.server dependency form _evacuate_server https://review.opendev.org/758209
15:47:57 gibi nova weekly meeting starts in 12 minutes in #openstack-meeting-3
16:07:25 openstackgerrit Merged openstack/nova stable/victoria: libvirt: Increase incremental and max sleep time during device detach https://review.opendev.org/757305
16:32:44 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Kilo database migrations https://review.opendev.org/758396
16:32:45 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Mitaka database migrations https://review.opendev.org/758398
16:32:45 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Liberty database migrations https://review.opendev.org/758397
16:32:46 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Ocata database migrations https://review.opendev.org/759086
16:32:46 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Newton database migrations https://review.opendev.org/759085
16:32:47 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Queens database migrations https://review.opendev.org/759088
16:32:47 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Pike database migrations https://review.opendev.org/759087
16:32:48 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Stein database migrations https://review.opendev.org/759090
16:32:48 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Rocky database migrations https://review.opendev.org/759089
16:32:49 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Train database migrations https://review.opendev.org/759091
16:33:31 openstackgerrit melanie witt proposed openstack/nova master: DNM test https://review.opendev.org/759294
16:39:44 openstackgerrit melanie witt proposed openstack/nova master: DNM test https://review.opendev.org/759294
21:27:42 openstackgerrit melanie witt proposed openstack/nova master: DNM test https://review.opendev.org/759294
#openstack-nova - 2020-10-23
04:09:53 openstackgerrit melanie witt proposed openstack/nova master: WIP Omit resource inventories from placement update if zero https://review.opendev.org/759348
07:42:16 openstackgerrit Jeffrey Zhang proposed openstack/nova master: Support inject-nmi action in watchdog https://review.opendev.org/741072
08:37:20 openstackgerrit Jorhson Deng proposed openstack/nova stable/rocky: optimize the shelve code flow https://review.opendev.org/759373
08:38:25 openstackgerrit Jorhson Deng proposed openstack/nova stable/ussuri: optimize the shelve code flow https://review.opendev.org/759374
08:39:26 openstackgerrit Jorhson Deng proposed openstack/nova stable/train: optimize the shelve code flow https://review.opendev.org/759375
08:39:54 openstackgerrit Jorhson Deng proposed openstack/nova stable/stein: optimize the shelve code flow https://review.opendev.org/759376
08:41:04 openstackgerrit Jorhson Deng proposed openstack/nova stable/queens: optimize the shelve code flow https://review.opendev.org/759377
08:41:34 openstackgerrit Jorhson Deng proposed openstack/nova stable/pike: optimize the shelve code flow https://review.opendev.org/759378
08:41:58 openstackgerrit Jorhson Deng proposed openstack/nova stable/ocata: optimize the shelve code flow https://review.opendev.org/759379
08:44:30 lyarwood ^ needs to start from stable/victoria btw, I've updated the stable/ussuri commit if you could take a look.
08:49:45 deke997 hey guys
08:49:53 deke997 I'm trying to get some updated info on multi-function pci passthrough
08:50:08 deke997 last I checked it was not really supported
08:50:09 deke997 anyone know more on this?
10:13:01 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Liberty database migrations https://review.opendev.org/758397
10:13:02 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Newton database migrations https://review.opendev.org/759085
10:13:02 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Mitaka database migrations https://review.opendev.org/758398
10:13:03 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Pike database migrations https://review.opendev.org/759087
10:13:03 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Ocata database migrations https://review.opendev.org/759086
10:13:04 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Rocky database migrations https://review.opendev.org/759089
10:13:04 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Queens database migrations https://review.opendev.org/759088
10:13:05 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Train database migrations https://review.opendev.org/759091
10:13:05 openstackgerrit Stephen Finucane proposed openstack/nova master: db: Compact Stein database migrations https://review.opendev.org/759090
10:32:56 recyclehero hey guys, I was referred here from my deploment method team OSA
10:33:15 recyclehero there is a problem with cpu allocation ratio
10:34:38 recyclehero at first as OSA was templating xxx_allocation_ratio it was normal that subsequent changes to aloocation ratio via palcement api get discarded
10:34:48 recyclehero but we did this patch
10:35:10 recyclehero https://review.opendev.org/#/c/758029/
10:36:07 recyclehero so we let xxx_allocation_ratios to be None
10:36:44 recyclehero then I have set inital_xxx_allocation_ratio to a floating number and did a clean deploy
10:37:26 recyclehero 1- in horizon I am seeing again the actual PCPU instead of VCPU. some people say this is the way it is and I am okay with that
10:38:13 recyclehero 2- using openstack resource cli I see the allocation ratio for cpu is equal to number tht I have set for initial_cpu_allocation_ratio
10:38:22 recyclehero but the problem is with *total*
10:38:56 recyclehero total is eqaul to 1*PCPU
10:41:14 recyclehero 3-I tried palcement api to put the inventory for the resource provider. its sucsess as I check just after with openstack resource provider inventory show. resource_provider_generation is also ++. then in a minute it gets overwritten and another generation++
10:41:52 recyclehero curl -XPUT -H 'X-Auth-Token: gAAAAABfkgravKJ1xAyjbHjY3hTy4wOMfufVKfafIIb5KUqcJufJ82mEIorUC_FwnOgHWX4uLDr_W22PHc28JouKhIknGkSJyP0dAPYa3DwFNA5dRgugMi9DcycwUPqLYoBQ3h6zv8M-VWCFFEJAuc-9ggV5ZTfkkB_vvXYDdd5dc765WhLZr2s' -H "Content-type: application/json" -d '{"inventories": {"MEMORY_MB": {"allocation_ratio": 2.0,"reserved": 1024,"total": 24014},"VCPU": {"allocation_ratio": 16.0,"reserved":
10:41:58 recyclehero 0,"total": 128}},"resource_provider_generation": 4}' 'http://172.29.236.11:8780/resource_providers/c8ac01e1-0b52-41f0-bd52-484070ea3aa9/inventories'
11:07:58 stephenfin recyclehero: 'cpu_allocation_ratio' applies only to VCPU; you can't overcommit PCPU
11:10:42 stephenfin Assuming you're talking about the different resource classes?
11:11:35 stephenfin To be clear, VCPU and PCPU are resource classes, along with DISK_GB, MEMORY_MB etc. Maybe you meant "total is equal to 1 * host CPUs?"
11:12:55 stephenfin recyclehero: the way that's supposed to work is that 'initial_*_allocation_ratio' will be used to set the initial ratios, allowing a user to overrides them manually using e.g. osc-placement. By comparison, '*_allocation_ratio' (no 'initial_' prefix) will always override whatever the user sets
11:14:35 stephenfin recyclehero: e.g. https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.cpu_allocation_ratio
11:34:43 stephenfin gibi: https://review.opendev.org/#/c/759114/ failed but it doesn't seem related; I guess we're good to remove that?
11:35:11 stephenfin assuming so, could you revisit https://review.opendev.org/#/c/749312/ and we can address the comments in a follow-up?
11:35:15 stephenfin *the follow-up
11:40:19 openstackgerrit Stephen Finucane proposed openstack/nova master: api-ref: Move 'os-agents' API to obsolete section https://review.opendev.org/755729
11:40:55 stephenfin lyarwood: Any chance you could close out the last two xenapi changes? https://review.opendev.org/#/c/749315/ https://review.opendev.org/#/c/755729/
11:41:25 stephenfin There's one more, but I think I've been too eager in removing stuff with it https://review.opendev.org/#/c/749316/
11:42:18 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Liberty database migrations https://review.opendev.org/759399
11:42:19 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Newton database migrations https://review.opendev.org/759401
11:42:19 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Mitaka database migrations https://review.opendev.org/759400
11:42:20 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Pike database migrations https://review.opendev.org/759403
11:42:20 openstackgerrit Stephen Finucane proposed openstack/nova master: apidb: Compact Ocata database migrations https://review.opendev.org/759402

Earlier   Later