| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-10-05 | |||
| 10:55:04 | sean-k-mooney | gibi: i dont think that exists | |
| 10:55:29 | sean-k-mooney | but you could possibley add it via build metadata at least in the source build | |
| 10:56:11 | sean-k-mooney | the base file has https://github.com/openstack/kolla/blob/master/docker/nova/nova-base/Dockerfile.j2#L3 | |
| 10:56:29 | sean-k-mooney | {% block labels %} | |
| 10:56:32 | sean-k-mooney | LABEL maintainer="{{ maintainer }}" name="{{ image_name }}" build-date="{{ build_date }}" | |
| 10:56:33 | sean-k-mooney | {% endblock %} | |
| 10:56:57 | sean-k-mooney | you could add other labels with the nova version | |
| 10:57:14 | gibi | sean-k-mooney: thanks. So the only way to see what changed from nova perspective is to introspect the image | |
| 10:57:24 | sean-k-mooney | yes | |
| 10:58:36 | sean-k-mooney | if its a binary install then you would have to compate the package versions if its a sourc install it will use tarballs by defualt rather then git | |
| 10:59:33 | sean-k-mooney | i think it recoreds which one somewhre but i cant recal off the top of my head | |
| 10:59:34 | jiriprox | @gibi @sean-k-mooney I would expect that stable/train branch should have some documented release updates. | |
| 10:59:47 | sean-k-mooney | oh i t does one sec | |
| 11:00:49 | sean-k-mooney | for soruce builds its https://github.com/openstack/kolla/blob/stable/train/kolla/common/config.py#L306-L865 | |
| 11:01:17 | sean-k-mooney | it uses the last stable release | |
| 11:01:20 | sean-k-mooney | https://github.com/openstack/kolla/blob/stable/train/kolla/common/config.py#L661-L664 | |
| 11:01:24 | sean-k-mooney | is nova ^ | |
| 11:01:33 | sean-k-mooney | so currently 20.4.0 for stable train | |
| 11:02:43 | sean-k-mooney | that only applies for source builds, if its a binary build its whatever the disto was shiping at the time it was built | |
| 11:02:50 | gibi | hm, 20.4.0 was released on 28th of Aug | |
| 11:03:31 | gibi | so on I don't expect any nova changes in kolla stable/train image between 25th and 29th of Sept | |
| 11:03:38 | gibi | jiriprox: ^^ | |
| 11:04:12 | sean-k-mooney | jiriprox: which docker hub image are you using sprecicly | |
| 11:04:31 | sean-k-mooney | ubuntu-source vs centos-binary | |
| 11:05:21 | sean-k-mooney | there are at least 4 copyies of every image, the ubunut/centos source will have the version in that file but ubuntu/centos binary will be different | |
| 11:05:53 | jiriprox | sean-k-mooney centos-source (centos7) from docker.io | |
| 11:06:01 | sean-k-mooney | jiriprox: ok cool | |
| 11:06:05 | sean-k-mooney | looking at https://github.com/openstack/nova/tree/stable/train/nova/pci | |
| 11:06:19 | sean-k-mooney | there has been no change fo 16months | |
| 11:07:10 | sean-k-mooney | looking at the compute managert ther have been more recent updates https://github.com/openstack/nova/commits/stable/train/nova/compute | |
| 11:07:22 | sean-k-mooney | but they are all related to volumes or networking | |
| 11:08:10 | sean-k-mooney | similarly nothing has changed in the conductor | |
| 11:08:26 | sean-k-mooney | so im not seeing an obvious reason to assume its a nova code change | |
| 12:22:39 | openstackgerrit | Takashi Natsume proposed openstack/nova-specs master: Make 'Feature Liaison' optional in test https://review.opendev.org/748591 | |
| 12:23:02 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Add placeholder migrations for Victoria backports https://review.opendev.org/754396 | |
| 12:42:56 | bauzas | good afternoon, folks | |
| 12:44:03 | bauzas | spoiler alert : you can get the video of my recorded talk for my summit session now and not needing to await for the Summit | |
| 12:44:07 | bauzas | ping me if you want :p | |
| 12:45:14 | bauzas | gibi: any urgent queries for me ? | |
| 12:46:58 | gibi | bauzas: hi. Nothing in my mind for Victoria. I've started reading open specs like https://review.opendev.org/#/c/742785/ | |
| 12:47:13 | bauzas | cool, I'll then repropose the routed-networks one | |
| 12:47:31 | bauzas | and I'll start looking at open specs | |
| 12:48:41 | gibi | i've proposed my own spec for W https://review.opendev.org/#/c/755477/ | |
| 12:51:44 | bauzas | my review ratio is super low, looks good a good start for improving my stats :) | |
| 13:04:42 | gibi | :) | |
| 13:06:02 | kashyap | bauzas: quality > quantity, no? :-) | |
| 13:06:46 | bauzas | kashyap: surely yes, but honestly, I still need to review for others | |
| 13:07:01 | kashyap | Sure, quality doesn't exclude reviewing for othres :) | |
| 13:07:18 | bauzas | that's what I'm paid^R^R^R^R expected to do | |
| 13:07:33 | bauzas | :) | |
| 13:08:40 | sean-k-mooney | gibi: oh the qos interface attach | |
| 13:09:10 | sean-k-mooney | gibi: that would be a good one to bring up with neutron in the cross project session | |
| 13:09:29 | sean-k-mooney | gibi: they had a FFE for the ablity to update a qos policy | |
| 13:09:37 | sean-k-mooney | for bandwidth | |
| 13:09:48 | sean-k-mooney | but it had a bunch of unhandeled edgecases | |
| 13:10:05 | sean-k-mooney | it might be workth discussing if there is a more holistic way to hanel it | |
| 13:10:57 | gibi | sean-k-mooney: qos interface attach also has some of the same edge cases | |
| 13:11:17 | gibi | namely that we only allocate bandwidth inplace | |
| 13:11:22 | sean-k-mooney | gibi: ya the main gap they had is if you remove the qos policy they could not add it again | |
| 13:11:27 | gibi | ohh | |
| 13:11:36 | sean-k-mooney | because there was no set of alloctions in the port profile | |
| 13:11:47 | sean-k-mooney | so they could not update placement | |
| 13:12:03 | sean-k-mooney | i was wondering if we coudl always populated it or something | |
| 13:12:58 | gibi | we cannot store zero allocation unfortunately | |
| 13:13:18 | stephenfin | sean-k-mooney: would you be able to sanity check https://review.opendev.org/#/c/746949/ today? | |
| 13:13:36 | stephenfin | I think lyarwood was waiting on you before closing out that SR-IOV functional test series | |
| 13:13:39 | sean-k-mooney | now is as good a time as any before i get bogged down in specs | |
| 13:15:21 | stephenfin | great, thanks :) | |
| 13:16:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add tests for mixed CPU policy https://review.opendev.org/755852 | |
| 13:16:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'InstanceNUMACell.min_threads' https://review.opendev.org/756070 | |
| 13:16:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Fix issue in exception type https://review.opendev.org/756069 | |
| 13:24:36 | sean-k-mooney | stephenfin: +1 on that some nits inline but i dont see any blockers | |
| 13:58:03 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Remove unused arguments from detach_device_with_retry https://review.opendev.org/756079 | |
| 13:58:03 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Increase incremental and max sleep time during device detach https://review.opendev.org/755799 | |
| 14:08:14 | openstackgerrit | Merged openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | |
| 14:21:04 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Stop returning a retry function from detach_device_with_retry https://review.opendev.org/756084 | |
| 14:50:56 | openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Merge nova-evacuate into nova-multinode-live-migration https://review.opendev.org/755309 | |
| 15:04:13 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM: Test Ib9ed7069cef5b73033351f7a78a3fb566753970d on Focal https://review.opendev.org/756097 | |
| 15:11:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add 'InstanceNUMACell.min_threads' https://review.opendev.org/756070 | |
| 15:11:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Check inventory of shared CPUs for 'mixed' policy https://review.opendev.org/756101 | |
| 15:11:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add functional test for #1898272 https://review.opendev.org/756100 | |
| 15:14:18 | stephenfin | artom, sean-k-mooney: There's the fix for that bug I pointed out Friday. Just as easy as I thought, thankfully :) | |
| 15:14:49 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Log exception when unable to import rbd or rados https://review.opendev.org/746873 | |
| 15:15:14 | stephenfin | sean-k-mooney also ^ | |
| 15:22:22 | sean-k-mooney | stephenfin: cool open ill review after meeting | |
| 15:27:36 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Log exception when unable to import rbd or rados https://review.opendev.org/746873 | |
| 15:34:57 | stephenfin | gibi: Easy +W here https://review.opendev.org/#/c/746873/ if you've time | |
| 15:35:53 | gibi | stephenfin: done | |
| 15:35:58 | stephenfin | ta | |
| 15:36:54 | lyarwood | stephenfin: https://review.opendev.org/#/c/755928/ - likewise, an easy one if you have time | |
| 15:37:33 | stephenfin | I thought we'd done that already? | |
| 15:37:58 | stephenfin | Ah, no, started but incomplete https://review.opendev.org/#/c/752073/ | |
| 15:38:17 | lyarwood | ah my bad, missed the conflict | |
| 15:38:32 | lyarwood | came up over the weekend when we tried to switch the py38 jobs over to centos | |
| 15:39:46 | stephenfin | All good | |
| 15:39:59 | lyarwood | bt-- | |
| 15:40:06 | stephenfin | Federico has another related patch here that would be good to get in IMO https://review.opendev.org/#/c/750652/ | |
| 15:41:12 | lyarwood | stephenfin: ack'd | |
| 15:53:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Check inventory of shared CPUs for 'mixed' policy https://review.opendev.org/756101 | |
| 15:53:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add test for #1898272 https://review.opendev.org/756100 | |