| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-21 | |||
| 17:49:54 | sean-k-mooney | yep | |
| 17:49:57 | artom | dansmith, no, that as import nova.monkey_patch # noqa in __init__.py | |
| 17:50:00 | artom | *has | |
| 17:50:13 | sean-k-mooney | also fucntion is still under nova.test | |
| 17:50:17 | sean-k-mooney | which import the objects | |
| 17:50:29 | sean-k-mooney | i would have to be nova.evetlet.tests or soemthign like that | |
| 17:50:57 | dansmith | sean-k-mooney: it's tests/unit/__init not tests/__init | |
| 17:51:08 | sean-k-mooney | oh your right | |
| 17:51:10 | dansmith | but yeah, unless we move that patch out of functional/__init it doesn't matter | |
| 17:51:26 | sean-k-mooney | then ya just tests/ then | |
| 17:51:33 | dansmith | yeah, | |
| 17:51:46 | artom | So it's fine if it gets put in nova/tests | |
| 17:51:46 | dansmith | and then it will be excluded from the regular stest execution anyway, | |
| 17:51:50 | dansmith | which is what we wanted right? | |
| 17:51:52 | sean-k-mooney | drop it at the top level and run it explcitly with tox | |
| 17:51:55 | dansmith | yah | |
| 17:52:29 | sean-k-mooney | ya it is | |
| 17:53:43 | artom | Don't need the env var skip mechanism then, either | |
| 17:53:50 | dansmith | right | |
| 17:55:26 | sean-k-mooney | so this http://paste.openstack.org/show/798162/ | |
| 17:55:57 | sean-k-mooney | actully setp is not needed | |
| 17:56:07 | dansmith | yup | |
| 17:56:34 | dansmith | but it'd be nice to get some other validations in there for the other things if we can | |
| 17:56:54 | sean-k-mooney | ya im not super happy with the self.assertNotIn('.greendns', tb) | |
| 17:56:56 | dansmith | artom: also, my -1 is going to be "change the title of the patch to what it does and not an obscure 'tests for $hash' message" | |
| 17:57:20 | artom | dansmith, fair | |
| 17:57:27 | artom | sean-k-mooney, I'll add comments? | |
| 17:57:29 | dansmith | lots of people do that, but I hate it | |
| 17:57:59 | artom | Tests for hash is what I do on the weekends :D | |
| 17:58:07 | sean-k-mooney | actully it should be greendns.py | |
| 17:58:18 | sean-k-mooney | its not the module path in the trace its the file path | |
| 17:58:19 | dansmith | artom: it's legal here now, so doesn't make you seem cool and edgy like it used to | |
| 17:59:19 | artom | dansmith, but what will I do for personality now? | |
| 18:01:42 | dansmith | dirty jokes? | |
| 18:01:55 | sean-k-mooney | so this works for me now that i moved it http://paste.openstack.org/show/798163/ | |
| 18:03:22 | sean-k-mooney | oh this is what i ran http://paste.openstack.org/show/798164/ | |
| 18:21:26 | openstackgerrit | Merged openstack/nova stable/rocky: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742417 | |
| 18:26:23 | CeeMac | Evening all | |
| 18:27:48 | CeeMac | Anyone ever come across issues with guest operating system corruption following a volume retype operation ? | |
| 18:48:23 | artom | Hrmpf, so it actually would work in nova/tests/functional because that __init__.py imports nova.monkey_patch, which is fine because we set EVENTLET_NO_GREENDNS in there | |
| 18:48:35 | artom | But then we need the env var skip mechanism | |
| 18:48:45 | artom | So perhaps better in nova/tests after all? | |
| 18:48:59 | dansmith | I don't really care either way | |
| 18:49:25 | artom | I guess the latter then, because less code. | |
| 18:49:34 | artom | And I'll explain it all with a proper commit message | |
| 18:49:40 | artom | ... *after* I pick up my kinds | |
| 18:49:42 | artom | *kids | |
| #openstack-nova - 2020-09-22 | |||
| 00:00:13 | brinzhang | gibi: ack, thanks | |
| 00:44:19 | openstackgerrit | Yao wang proposed openstack/nova master: Use VIR_DOMAIN_XML_INACTIVE for detach volume https://review.opendev.org/749489 | |
| 00:57:14 | openstackgerrit | Yingji Sun proposed openstack/nova stable/train: Set different VirtualDevice.key https://review.opendev.org/752843 | |
| 07:19:53 | bauzas | good morning Nova | |
| 08:08:07 | lyarwood | Morning | |
| 08:31:11 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Improve CinderFixtureNewAttachFlow https://review.opendev.org/749228 | |
| 08:31:12 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/749229 | |
| 08:31:13 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/749230 | |
| 08:31:14 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: refactor volume bdm rollback error handling https://review.opendev.org/749231 | |
| 08:31:17 | openstack | bug 1889108 in OpenStack Compute (nova) queens "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | |
| 08:31:17 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Add regression tests for bug #1889108 https://review.opendev.org/749232 | |
| 08:31:18 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749233 | |
| 08:34:44 | lyarwood | https://2733627e1a0348401721-fb543e4b225e8fdb51d174f0fee213a6.ssl.cf1.rackcdn.com/746981/8/check/nova-tox-functional-py38/594be66/testr_results.html - hmm I've never seen this failure before in the gate | |
| 08:35:06 | lyarwood | nova.tests.functional.test_cross_cell_migrate.TestMultiCellMigrate.test_delete_while_in_verify_resize_status oslo_messaging.exceptions.MessagingTimeout: No reply on topic conductor | |
| 08:55:16 | nightmare_unreal | Hi , where can I find logs in a devstack machine. I tried /var/log/ but there was no logs there | |
| 09:01:19 | CeeMac | morning | |
| 09:01:43 | CeeMac | regarding nova's roll in volume retyping an attached volume on a running instance | |
| 09:02:09 | CeeMac | does the quiesce operation rely on the guest agent being available on the instance, or should it be fully transparent to the instance | |
| 09:02:59 | CeeMac | trying to understand an issue with operating system disk corruption on an instance after a volume retype | |
| 09:07:38 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: hardware: fix memory check usage for small/large pages https://review.opendev.org/726867 | |
| 09:07:39 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Fix overcommit for NUMA-based instances https://review.opendev.org/726868 | |
| 09:07:40 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Fix typo https://review.opendev.org/753261 | |
| 09:16:30 | kashyap | stephenfin: --^ That's quick; thanks! | |
| 09:16:35 | frickler | nightmare_unreal: most logs are in the systemd journal, try e.g. "journalctl -u devstack@n-api" | |
| 09:16:49 | kashyap | (Although, I don't need 'em myself, though) | |
| 09:23:15 | nightmare_unreal | thanks frickler | |
| 09:30:07 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981 | |
| 09:30:08 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | |
| 09:30:08 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | |
| 09:30:09 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | |
| 09:30:09 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | |
| 09:30:10 | openstackgerrit | Lee Yarwood proposed openstack/nova master: test_evacuate.sh: Stop using libvirt-bin https://review.opendev.org/753267 | |
| 09:30:10 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | |
| 09:30:56 | lyarwood | CeeMac: I don't think we quiesce during a retype | |
| 09:31:09 | lyarwood | CeeMac: the entire operation should be transparent to the instance | |
| 09:32:01 | lyarwood | CeeMac: which version of nova and libvirt is this? | |
| 09:41:13 | CeeMac | Nova v18.1.1, libvirt 4.0.0 | |
| 09:41:26 | CeeMac | lyarwood: ^ | |
| 09:49:31 | CeeMac | that was my understanding too, but I've had a couple of instance corrupt after retyping the volume and I can't understand why | |
| 10:20:46 | luyao | stephenfin, alex_xu: Hi, there are 2 patches for vpmem enhencement missed the feature freeze, hope you could review them again if you get time. Thanks. https://review.opendev.org/#/q/topic:bp/vpmem-enhancement+(status:open) | |
| 10:30:23 | lyarwood | CeeMac: sorry had to go afk, so with libvirt 4.0.0 we should still be using virDomainBlockRebase | |
| 10:30:42 | lyarwood | CeeMac: I'd be interested in looking at some example logs if you have any tbh | |
| 10:31:06 | lyarwood | CeeMac: if you could use the event list to find the request-id and create a bug for this I can review them | |
| 10:31:18 | lyarwood | CeeMac: openstack server event list $instance | |
| 10:31:37 | lyarwood | CeeMac: that should list a swap_volume event and associated request-id | |
| 10:31:54 | lyarwood | CeeMac: we might also need libvirtd logs from the host if available | |
| 10:32:29 | CeeMac | lyarwood: I'll see what I can find, not sure I'll get the exact logs for the broken instance as we didn't realise until alter in the day it was an issue | |
| 10:40:15 | brinzhang0 | stephenfin: I seem not understand what would you like to say of https://review.opendev.org/#/c/675304/21/openstackclient/compute/v2/server.py@1868 | |
| 10:41:31 | brinzhang0 | and the Line1888, the parsed_args.server can get the server name or id, right? and we have always used it in openstackclient | |
| 10:44:17 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: test_evacuate.sh: Support libvirt-bin and libvirtd systemd services https://review.opendev.org/753280 | |
| 10:45:30 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: test_evacuate.sh: Stop using libvirt-bin https://review.opendev.org/753281 | |
| 10:46:48 | lyarwood | elod: ^ if you have time today, https://review.opendev.org/753281 should unblock the nova-live-migration job on stable/ussuri now it's using the train UCA | |
| 10:46:56 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: Ensure source compute is up when confirming a resize https://review.opendev.org/748369 | |