| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-21 | |||
| 17:38:41 | dansmith | right | |
| 17:38:58 | dansmith | although I moved the import into the test function and I still fail the test | |
| 17:39:27 | dansmith | so, here's the other thing | |
| 17:39:41 | dansmith | stestr forks and runs the worker children outside the main process | |
| 17:39:57 | dansmith | which may not share the environment where the flag is being set | |
| 17:40:09 | artom | Sounds "right" - in the sense that, if we're the *only* ones importing nova.test, and that imports eventlet "properly" (setting EVENTLET_NO_GREENDNS), shouldn't matter when we do the importing | |
| 17:41:04 | dansmith | still happens with bare unittest run | |
| 17:41:27 | sean-k-mooney | http://paste.openstack.org/show/798157/ | |
| 17:42:07 | sean-k-mooney | so it match on the function call | |
| 17:42:24 | artom | *facepalm* | |
| 17:42:49 | sean-k-mooney | test_greendns_is_disabled | |
| 17:42:50 | dansmith | ah hah | |
| 17:43:46 | dansmith | although I'm seeing it for realz: /home/dan/nova/.tox/py37/lib/python3.7/site-packages/eventlet/support/greendns.py | |
| 17:43:47 | artom | Maybe premature though, changing it go 'greendns.py' still fails | |
| 17:44:12 | dansmith | any chance the flag name is wrong, or requires a value different than "yes" ? | |
| 17:44:47 | artom | dansmith, I don't think it's that - remember, the bare python file worked | |
| 17:44:56 | artom | worked == verified the correct behaviour | |
| 17:45:04 | sean-k-mooney | dansmith https://github.com/eventlet/eventlet/blob/af407c77f208ceefe5a35e39aed0cf3fdfc07cb9/eventlet/green/socket.py#L20 | |
| 17:45:11 | sean-k-mooney | if os.environ.get("EVENTLET_NO_GREENDNS", '').lower() != 'yes': | |
| 17:45:44 | dansmith | ack | |
| 17:45:44 | sean-k-mooney | so i think its right | |
| 17:46:32 | sean-k-mooney | so i have a working copy locally | |
| 17:46:40 | sean-k-mooney | just changed it to greendns.py | |
| 17:46:57 | sean-k-mooney | but is that goign to be in the traceback | |
| 17:47:18 | sean-k-mooney | http://paste.openstack.org/show/798159/ | |
| 17:47:29 | dansmith | https://pastebin.com/kY9iCQpu | |
| 17:47:33 | dansmith | this is how I'm getting to eventlet ^ | |
| 17:47:57 | dansmith | unit/__init__.py calls objects.register_all() | |
| 17:47:59 | dansmith | and eventlet is in there | |
| 17:48:10 | sean-k-mooney | ya i was looking at that | |
| 17:48:19 | sean-k-mooney | i didnt see which object it was | |
| 17:48:34 | dansmith | so, like I surmised, something in the test infra is hitting it before we even get to us, but unfortunately it's in our module so it gets imported before we get imported | |
| 17:48:36 | artom | Oh, smart just raising in evenlet itself and examining the trace | |
| 17:48:42 | dansmith | if it wasn't in an __init__ then we'd be safe | |
| 17:48:43 | sean-k-mooney | nova.objects.agent | |
| 17:49:18 | artom | dansmith, so then... if I move it out of tests/unit ? | |
| 17:49:31 | dansmith | artom: yeah I guess.. maybe functional would work by chance? | |
| 17:49:41 | dansmith | lol, | |
| 17:49:44 | sean-k-mooney | no | |
| 17:49:49 | sean-k-mooney | fucntion defietly wont | |
| 17:49:49 | dansmith | functional moneky patches in __init__ ;P | |
| 17:49:54 | sean-k-mooney | yep | |
| 17:49:57 | artom | dansmith, no, that as import nova.monkey_patch # noqa in __init__.py | |
| 17:50:00 | artom | *has | |
| 17:50:13 | sean-k-mooney | also fucntion is still under nova.test | |
| 17:50:17 | sean-k-mooney | which import the objects | |
| 17:50:29 | sean-k-mooney | i would have to be nova.evetlet.tests or soemthign like that | |
| 17:50:57 | dansmith | sean-k-mooney: it's tests/unit/__init not tests/__init | |
| 17:51:08 | sean-k-mooney | oh your right | |
| 17:51:10 | dansmith | but yeah, unless we move that patch out of functional/__init it doesn't matter | |
| 17:51:26 | sean-k-mooney | then ya just tests/ then | |
| 17:51:33 | dansmith | yeah, | |
| 17:51:46 | artom | So it's fine if it gets put in nova/tests | |
| 17:51:46 | dansmith | and then it will be excluded from the regular stest execution anyway, | |
| 17:51:50 | dansmith | which is what we wanted right? | |
| 17:51:52 | sean-k-mooney | drop it at the top level and run it explcitly with tox | |
| 17:51:55 | dansmith | yah | |
| 17:52:29 | sean-k-mooney | ya it is | |
| 17:53:43 | artom | Don't need the env var skip mechanism then, either | |
| 17:53:50 | dansmith | right | |
| 17:55:26 | sean-k-mooney | so this http://paste.openstack.org/show/798162/ | |
| 17:55:57 | sean-k-mooney | actully setp is not needed | |
| 17:56:07 | dansmith | yup | |
| 17:56:34 | dansmith | but it'd be nice to get some other validations in there for the other things if we can | |
| 17:56:54 | sean-k-mooney | ya im not super happy with the self.assertNotIn('.greendns', tb) | |
| 17:56:56 | dansmith | artom: also, my -1 is going to be "change the title of the patch to what it does and not an obscure 'tests for $hash' message" | |
| 17:57:20 | artom | dansmith, fair | |
| 17:57:27 | artom | sean-k-mooney, I'll add comments? | |
| 17:57:29 | dansmith | lots of people do that, but I hate it | |
| 17:57:59 | artom | Tests for hash is what I do on the weekends :D | |
| 17:58:07 | sean-k-mooney | actully it should be greendns.py | |
| 17:58:18 | sean-k-mooney | its not the module path in the trace its the file path | |
| 17:58:19 | dansmith | artom: it's legal here now, so doesn't make you seem cool and edgy like it used to | |
| 17:59:19 | artom | dansmith, but what will I do for personality now? | |
| 18:01:42 | dansmith | dirty jokes? | |
| 18:01:55 | sean-k-mooney | so this works for me now that i moved it http://paste.openstack.org/show/798163/ | |
| 18:03:22 | sean-k-mooney | oh this is what i ran http://paste.openstack.org/show/798164/ | |
| 18:21:26 | openstackgerrit | Merged openstack/nova stable/rocky: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742417 | |
| 18:26:23 | CeeMac | Evening all | |
| 18:27:48 | CeeMac | Anyone ever come across issues with guest operating system corruption following a volume retype operation ? | |
| 18:48:23 | artom | Hrmpf, so it actually would work in nova/tests/functional because that __init__.py imports nova.monkey_patch, which is fine because we set EVENTLET_NO_GREENDNS in there | |
| 18:48:35 | artom | But then we need the env var skip mechanism | |
| 18:48:45 | artom | So perhaps better in nova/tests after all? | |
| 18:48:59 | dansmith | I don't really care either way | |
| 18:49:25 | artom | I guess the latter then, because less code. | |
| 18:49:34 | artom | And I'll explain it all with a proper commit message | |
| 18:49:40 | artom | ... *after* I pick up my kinds | |
| 18:49:42 | artom | *kids | |
| #openstack-nova - 2020-09-22 | |||
| 00:00:13 | brinzhang | gibi: ack, thanks | |
| 00:44:19 | openstackgerrit | Yao wang proposed openstack/nova master: Use VIR_DOMAIN_XML_INACTIVE for detach volume https://review.opendev.org/749489 | |
| 00:57:14 | openstackgerrit | Yingji Sun proposed openstack/nova stable/train: Set different VirtualDevice.key https://review.opendev.org/752843 | |
| 07:19:53 | bauzas | good morning Nova | |
| 08:08:07 | lyarwood | Morning | |
| 08:31:11 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Improve CinderFixtureNewAttachFlow https://review.opendev.org/749228 | |
| 08:31:12 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/749229 | |
| 08:31:13 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/749230 | |
| 08:31:14 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: refactor volume bdm rollback error handling https://review.opendev.org/749231 | |
| 08:31:17 | openstack | bug 1889108 in OpenStack Compute (nova) queens "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | |
| 08:31:17 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Add regression tests for bug #1889108 https://review.opendev.org/749232 | |
| 08:31:18 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749233 | |