| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-16 | |||
| 13:59:16 | bauzas | sean-k-mooney: well, they just kill ironic-api right? | |
| 13:59:33 | bauzas | sean-k-mooney: but both servers GET and INDEX don't require our virt drivers to be up | |
| 13:59:45 | sean-k-mooney | oh i know that | |
| 14:00:16 | bauzas | so I suspect that ironic makes some recalculation on an ironic-api destroy, which borks either the cell DB or the API DB, I do agree | |
| 14:00:24 | bauzas | an inconsistency | |
| 14:01:08 | bauzas | either way, we're missing details | |
| 14:01:15 | sean-k-mooney | ya | |
| 14:01:45 | sean-k-mooney | and i was suggsting that we might try to retrive something in the show that we dont in the list | |
| 14:02:09 | sean-k-mooney | list with out details i think mainly operates on the api db | |
| 14:02:30 | sean-k-mooney | anyway its weird | |
| 14:02:50 | sean-k-mooney | oh did we reenable the experiation bot | |
| 14:03:20 | sean-k-mooney | oh i think launchpad might have https://help.launchpad.net/BugExpiry | |
| 14:05:21 | sean-k-mooney | gibi: bauzas did we recently enable bug expiry. im not against it by the way but im wondering if this now enabled by default | |
| 14:05:49 | bauzas | well, we only do it once | |
| 14:05:56 | bauzas | afaict, this isn't a bot | |
| 14:06:06 | sean-k-mooney | its a launchpad feature | |
| 14:06:11 | sean-k-mooney | we used to have an openstack bot do it | |
| 14:06:31 | bauzas | oh, I see | |
| 14:06:34 | bauzas | you're right | |
| 14:06:38 | gibi | I'm not aware of any recent changes so if that is on then it is on for a while | |
| 14:07:22 | sean-k-mooney | its strange i have teh correct permision to change this on os-vif but i dont see the option. looks like its not running for os-vif | |
| 14:09:39 | sean-k-mooney | ah there is an "Expire "Incomplete" bug reports when they become inactive" option in the configure bugs tab | |
| 14:09:51 | sean-k-mooney | its not unde edit details in the project page | |
| 14:10:09 | openstackgerrit | Rodrigo Barbieri proposed openstack/nova stable/ussuri: Allow tap interface with multiqueue https://review.opendev.org/752245 | |
| 14:10:10 | sean-k-mooney | im going to leave that off for now we dont really get many os-vif bug reports | |
| 14:15:41 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Skip cinder_encryption_key_id check when booting from volume https://review.opendev.org/752090 | |
| 14:15:43 | openstack | bug 1895696 in OpenStack Compute (nova) "unable to boot instance from encrypted volume created from a glance image of an encrypted volume" [Medium,In progress] https://launchpad.net/bugs/1895696 - Assigned to Lee Yarwood (lyarwood) | |
| 14:15:43 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1895696 https://review.opendev.org/752247 | |
| 14:15:47 | lyarwood | stephenfin: ^ I'll review your GlanceFixture stuff shortly if it still needs it as I'm using it in this bugfix | |
| 14:16:19 | stephenfin | lyarwood: sure, if you've time that would be great. I can take a look at that bugfix | |
| 14:38:12 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Introduce nova-multinode-evacuate https://review.opendev.org/744883 | |
| 15:15:41 | gibi | we are under 10 untriaged bugs. I really appreaciate all of your bug triage work! thank you! | |
| 15:43:12 | stephenfin | gibi, bauzas, gmann: https://review.opendev.org/752210 is passing now (the base for the os-server-groups 500 -> 400 change) | |
| 15:45:26 | openstack | Launchpad bug 1775934 in OpenStack Compute (nova) "Cannot run "openstack server list" with instance stuck in scheduling state" [Undecided,New] | |
| 15:45:26 | bauzas | melwitt: based on your last (and old) comment on https://bugs.launchpad.net/nova/+bug/1775934 could we mark the bug as Confirmed ? this is unclear to me whether we need to fix it | |
| 15:45:27 | gmann | stephenfin +2 | |
| 15:45:32 | gibi | +@ | |
| 15:45:41 | gibi | +2+A | |
| 15:45:42 | gibi | ;d | |
| 15:52:03 | melwitt | bauzas: that sounds familiar and I think "probably". I need to look around a bit to find a related/duplicate bug I've seen and add more information | |
| 15:52:31 | bauzas | melwitt: kk, marking it as confirmed for now, but feel free to mark it duplicate if so | |
| 15:52:37 | bauzas | thanks | |
| 15:52:48 | melwitt | sounds good, thanks | |
| 16:03:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Make overcommit check for pinned instance pagesize aware https://review.opendev.org/631053 | |
| 17:07:23 | sean-k-mooney | gibi: bauzas melwitt can i get your input on how backportale someting is quickly | |
| 17:08:47 | sean-k-mooney | basically i want to add a call to unplug_vifs in migrate_disk_and_power_off which is caleed in _resize_instance | |
| 17:09:12 | sean-k-mooney | and ideally remove the call to clean up the souce vifs form resize confirm | |
| 17:09:48 | sean-k-mooney | so when we do resize_instance before we go to resize_verify we would unplug the souce vif | |
| 17:09:58 | openstackgerrit | Merged openstack/nova stable/train: post live migration: don't call Neutron needlessly https://review.opendev.org/750670 | |
| 17:10:05 | sean-k-mooney | basicaly right after we call power off just like we remove the cinder attahcments | |
| 17:10:06 | openstackgerrit | Merged openstack/nova master: docs: Improve 'AggregateImagePropertiesIsolation' docs https://review.opendev.org/752236 | |
| 17:10:14 | openstackgerrit | Merged openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906 | |
| 17:10:23 | openstackgerrit | Merged openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907 | |
| 17:11:24 | openstack | bug 1895220 in OpenStack Compute (nova) "Fail to cold migrate between two hosts have difference VIF type" [Medium,In progress] https://launchpad.net/bugs/1895220 - Assigned to Dat Le (datlq) | |
| 17:11:24 | sean-k-mooney | it would fix bug #1895220 and i also need to do it for https://review.opendev.org/#/c/602432 to adress bug #1734320 | |
| 17:11:25 | openstack | bug 1734320 in neutron "Eavesdropping private traffic" [High,In progress] https://launchpad.net/bugs/1734320 - Assigned to Rodolfo Alonso (rodolfo-alonso-hernandez) | |
| 17:11:52 | openstackgerrit | melanie witt proposed openstack/nova stable/train: Sanity check instance mapping during scheduling https://review.opendev.org/752279 | |
| 17:13:49 | openstackgerrit | melanie witt proposed openstack/nova stable/train: Sanity check instance mapping during scheduling https://review.opendev.org/752279 | |
| 17:16:42 | sean-k-mooney | lyarwood: elod i guess same question to ye since its about backportablity ^ | |
| 17:17:59 | sean-k-mooney | the current behavior rely on libvirt to unplug the vif so to maintain the correct behavior when we deleate that to os-vif we now need to call unplug_vifs explcitly | |
| 17:18:16 | sean-k-mooney | which we should have been doing along really | |
| 17:21:05 | melwitt | sean-k-mooney: is the unplug_vifs functionality in os-vif available in older branches? | |
| 17:22:16 | sean-k-mooney | yes | |
| 17:22:27 | sean-k-mooney | unplug_vifs is a libvirt driver function | |
| 17:22:45 | sean-k-mooney | but the os-vif support is also there in older branches | |
| 17:23:30 | sean-k-mooney | melwitt: it look like im going to either need to make this change to when we do it | |
| 17:23:50 | sean-k-mooney | e.g. from confirm_resize where it is today to resize_instance | |
| 17:24:13 | sean-k-mooney | or im going to have to alter where and if nova waits for vifs in revert | |
| 17:25:01 | sean-k-mooney | or i guess i could have revert call unplug_vifs before it calls plug_vifs but that is slightly more complicated. | |
| 17:26:09 | sean-k-mooney | melwitt: for the CVE fix we have to do a locksetp backport in neutron and nova. | |
| 17:26:28 | sean-k-mooney | its a publci CVE by the way | |
| 17:26:50 | sean-k-mooney | for the other case of cold migrating/resizign between network backends | |
| 17:27:01 | sean-k-mooney | its technically not something tha was offically supported | |
| 17:27:11 | sean-k-mooney | which i noted in the bug | |
| 17:27:18 | sean-k-mooney | but it works in a limited set of cases | |
| 17:27:29 | melwitt | yeah I guess I'm not immediately seeing a backportability issue (but I could be missing something) but I think we'd want to let bake on master for awhile before backporting everywhere, to catch bugs before it's propagated to more branches | |
| 17:27:31 | sean-k-mooney | e.g. ml2/ovs to ml2/ovn | |
| 17:27:59 | sean-k-mooney | melwitt: there is one edge case im not sure how to adress | |
| 17:28:20 | melwitt | maybe it's just me but the fix sounds complicated and something we'd want to see if problems appear once it's running throughout the gate | |
| 17:29:03 | sean-k-mooney | well the first fix is just one addtion fucntion all in resize_instance to unplug_vifs | |
| 17:29:27 | melwitt | is that consistent with what we do with volumes today too? | |
| 17:29:34 | sean-k-mooney | bit that makes it trickin is to fully solve the diffent backend case i need to remove the current call in confirm | |
| 17:29:56 | sean-k-mooney | melwitt: ya for volumes we remove attacments in resize_instance | |
| 17:30:32 | melwitt | ok. it seems like it would make sense to have them be consistent but I don't know the reason vifs are handled differently | |
| 17:30:55 | sean-k-mooney | well technically in migrate_disk_and_poweroff | |
| 17:30:56 | sean-k-mooney | https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L10362 | |
| 17:31:22 | sean-k-mooney | and im suggesting adding self.unplug_vifs here https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L10357 | |
| 17:31:22 | melwitt | yeah, I did see the volume detach there | |
| 17:31:38 | sean-k-mooney | basicly 5 lines up | |
| 17:32:30 | melwitt | yeah, seems to make sense to me | |
| 17:32:48 | sean-k-mooney | melwitt: basically power_off call _destory() not destroy() to delete the domain xml without remving the disk images | |
| 17:32:57 | sean-k-mooney | so we can revert without copying data | |
| 17:33:08 | sean-k-mooney | but _destory() does not call unplug_vifs | |
| 17:33:25 | sean-k-mooney | destroy() does via the call to cleanup() | |
| 17:33:30 | sean-k-mooney | which delete the disk too | |
| 17:33:43 | melwitt | right | |
| 17:34:22 | sean-k-mooney | and today conrim does an rpc from the dest to the source to call unplug_vifs | |
| 17:34:50 | sean-k-mooney | here in cleanup_resize https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L1665 | |
| 17:35:43 | melwitt | yeah I guess I wonder what are the potential issues if the deployment is in the middle of an upgrade | |
| 17:35:50 | sean-k-mooney | for revert we call plug_vifs in create_instace_with_networks here https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L6704 https://github.com/openstack/nova/blob/e0f088c95d05e9cf32d4af4c7cfc20566b17f8e1/nova/virt/libvirt/driver.py#L10681-L10683 | |