| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-04 | |||
| 15:47:37 | sean-k-mooney | no it cant because of limitation in the neutron implemation | |
| 15:47:45 | bauzas | but grrrr, I need to stop working | |
| 15:48:09 | bauzas | parents-teacher meeting at 6pm, since kids are back at school | |
| 15:48:10 | sean-k-mooney | gibi: we could but i think caching it in the VIF is better | |
| 15:48:32 | sean-k-mooney | to avoid needign to call neutron during the prefileter | |
| 15:48:35 | gibi | sean-k-mooney: for move operations I'm OK with that | |
| 15:48:49 | sean-k-mooney | gibi: ya for create since we dont have the vif objects | |
| 15:48:50 | gibi | bauzas: no worries, enjoy your weekend | |
| 15:48:56 | bauzas | thinking out loud, this is unrealistic to merge it before victoria-3 | |
| 15:48:58 | sean-k-mooney | we need to look it up if we are passed a port | |
| 15:49:27 | sean-k-mooney | proably altough viable for early m1 | |
| 15:49:31 | bauzas | so, I'll continue working on it, but let's all agree this will be a Wallaby merge | |
| 15:49:43 | bauzas | yeah, can continue investigating during RC1 | |
| 15:49:55 | bauzas | we're close to the job done, I think | |
| 15:50:02 | gibi | bauzas: OK. let's merge this in W | |
| 15:50:21 | sean-k-mooney | bauzas: for the limited usecases in the spec maybe :) | |
| 15:50:29 | sean-k-mooney | enjoy o/ | |
| 15:51:11 | gibi | bauzas: also if you boot an instance with a network then I think nothing guarantees that every compute host will is attached to one of the segments of that networks. So we still have to filter hosts based on segments even if the instance is booted with network | |
| 15:51:59 | bauzas | gibi: we do it already in my change | |
| 15:52:29 | gibi | bauzas: yes, you just said something about it above and I wanted to make sure this check will not be removed | |
| 15:52:32 | gibi | :) | |
| 15:52:46 | gibi | bauzas: also I read through your patches and I like them | |
| 15:52:59 | gibi | thanks for picking up this feature | |
| 15:53:27 | sean-k-mooney | gibi: ya so bauzas is going to limit to the full set of segment on a network if we boot to a network | |
| 15:53:46 | sean-k-mooney | or just the segment related to the ip if we have a port with an ip | |
| 15:54:11 | gibi | sean-k-mooney: yeah that feels correct | |
| 15:54:13 | sean-k-mooney | gibi: so that will covert the case fo only looking at the subset of host with the correct segment reacblitiy | |
| 15:54:21 | gibi | aagree | |
| 15:56:07 | sean-k-mooney | gibi: did you see https://review.opendev.org/#/c/749175/1 by the way | |
| 15:56:32 | sean-k-mooney | that might fix the PF edgecase i notes while testing your code | |
| 15:56:39 | gibi | no I haven't | |
| 15:56:49 | gibi | I will check that patch on Monday | |
| 15:56:51 | sean-k-mooney | ill try to test that on monday and ill retest your code | |
| 15:56:56 | gibi | cool | |
| 15:57:14 | sean-k-mooney | they are proposing it for a different edgecase | |
| 15:57:31 | sean-k-mooney | where a deivce did not support sriov and after some operation it now does | |
| 15:57:42 | sean-k-mooney | changing it form type-pci to type-PF | |
| 15:58:39 | sean-k-mooney | that only happens if 1 you change the device phsyically, 2 you updated the frimeare to add sriov supprot, 3 you reconfitre the firmware/bios to supprot it by for exampel chanige from datacenter bridging mode to sriov mode | |
| 15:59:03 | sean-k-mooney | so there usecase is rare but the fix i think might fix both | |
| 15:59:30 | sean-k-mooney | although i might also need to be update to hanel the removed vf case | |
| 16:13:52 | openstackgerrit | Merged openstack/nova master: doc: Add IPv6 metadata address https://review.opendev.org/744492 | |
| 16:23:06 | gibi | o/ | |
| 16:23:49 | lyarwood | \o | |
| 16:40:28 | ganso | hi sean-k-mooney. Thanks for the feedback on patch https://review.opendev.org/#/c/748533 ... I pushed an update to it. Please let me know if it is still missing any adjustment | |
| 16:54:08 | stephenfin | sean-k-mooney: I replied on https://review.opendev.org/#/c/748453/. I wasn't able to reproduce the issue | |
| 17:05:33 | artom | me: "trivial: Remove useless comment" | |
| 17:05:40 | artom | zuul: "merge conflict lulz" | |
| 17:05:49 | artom | 😠 | |
| 17:06:29 | sean-k-mooney | :) | |
| 17:06:37 | sean-k-mooney | upstream life | |
| 17:06:46 | sean-k-mooney | at least we are not using svn | |
| 17:07:05 | sean-k-mooney | or a email based patch submission workflow | |
| 17:07:05 | artom | *snerk* | |
| 17:07:29 | artom | YEah | |
| 17:07:36 | artom | sean-k-mooney, oh, I have a whitebox thing for you: https://review.opendev.org/#/c/749797/ | |
| 17:09:23 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: trivial: Remove useless comment https://review.opendev.org/748475 | |
| 17:09:43 | sean-k-mooney | ah yes i saw your comment regaring failed tests | |
| 17:10:15 | sean-k-mooney | so enter stops the service and exit start it | |
| 17:10:21 | artom | sean-k-mooney, yeah | |
| 17:10:35 | artom | Just to make sure we actually start it again in case anything inside the context fails | |
| 17:10:50 | sean-k-mooney | ya that works | |
| 17:10:58 | sean-k-mooney | i see your doing it via a coroutine too | |
| 17:11:11 | sean-k-mooney | instead of implementing it as a class wich works | |
| 17:11:41 | artom | sean-k-mooney, you mean I'm using that context decorator? | |
| 17:11:54 | artom | I mean yeah, I'm not coding a whole class just for that | |
| 17:11:58 | sean-k-mooney | you can create context managers in several ways | |
| 17:12:17 | sean-k-mooney | you are using the automatic convertion of coroutiens to create context managers | |
| 17:12:37 | sean-k-mooney | that was a py3 feature that was backported to py27 | |
| 17:12:43 | sean-k-mooney | but it was notin py26 | |
| 17:14:06 | sean-k-mooney | but ya you are using the decorator | |
| 17:14:09 | sean-k-mooney | https://docs.python.org/2.7/library/contextlib.html#contextlib.contextmanager | |
| 17:15:18 | sean-k-mooney | hum ok atuclly its part of 2.5 i tought it was 3.2 | |
| 17:15:20 | sean-k-mooney | https://www.python.org/dev/peps/pep-0343/ | |
| 17:15:47 | sean-k-mooney | i think contextlib was a not in the stadard lib in 2.5 however | |
| 17:19:52 | artom | Have to drop for a sec, back in a bit | |
| 18:22:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059 | |
| 18:27:52 | lyarwood | gmann: do you know how we control how many threads tempest uses to run tests? | |
| 18:28:20 | openstack | Launchpad bug 1882521 in OpenStack Compute (nova) "Failing device detachments on Focal" [Critical,Confirmed] - Assigned to Lee Yarwood (lyarwood) | |
| 18:28:20 | lyarwood | gmann: re https://bugs.launchpad.net/nova/+bug/1882521 - I can hit this 100% of the time running the full suite but never if I run things in serial | |
| 18:28:55 | lyarwood | gmann: looking at dstat etc I'm pretty sure the host CPU is just maxed out slowing the guestOSs within the instances to the point where they can't detach disks quickly enough | |
| 18:30:52 | lyarwood | --concurrency nvm sorry | |
| 18:44:58 | gmann | lyarwood: yeah, via concurrency. for serial run concurrency is hardcoded to 1 | |
| 19:40:03 | openstackgerrit | Merged openstack/nova stable/stein: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742416 | |
| 19:47:01 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059 | |
| 20:30:25 | openstackgerrit | Merged openstack/nova stable/stein: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747360 | |
| 22:04:06 | openstackgerrit | Merged openstack/nova stable/stein: Improve CinderFixtureNewAttachFlow https://review.opendev.org/748509 | |
| 22:04:12 | openstackgerrit | Merged openstack/nova stable/stein: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/748510 | |
| 22:08:35 | sean-k-mooney | luyao: yes you can set concurrency in the zuul config | |
| 22:08:52 | sean-k-mooney | luyao: sory that was for lyarwood | |
| 22:08:57 | sean-k-mooney | but he is offline | |
| 23:16:04 | openstackgerrit | Merged openstack/nova stable/stein: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/748511 | |
| 23:33:15 | openstackgerrit | Merged openstack/nova stable/stein: compute: refactor volume bdm rollback error handling https://review.opendev.org/748512 | |
| 23:33:23 | openstack | bug 1889108 in OpenStack Compute (nova) stein "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | |
| 23:33:23 | openstackgerrit | Merged openstack/nova stable/stein: Add regression tests for bug #1889108 https://review.opendev.org/748513 | |
| 23:33:28 | openstackgerrit | Merged openstack/nova stable/stein: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748514 | |
| 23:41:11 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059 | |
| 23:41:23 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: [Trivial] Replace ref of policy.json to policy.yaml https://review.opendev.org/749821 | |
| #openstack-nova - 2020-09-05 | |||
| 01:55:01 | openstackgerrit | Merged openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472 | |
| 04:00:02 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | |
| 04:01:49 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757 | |