Posted	Nick	Remark
#openstack-nova - 2020-09-02
20:38:25	openstackgerrit	Artom Lifshitz proposed openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451
20:38:45	artom	sean-k-mooney, lyarwood ^^ if you still have the time/energy
20:56:50	sean-k-mooney	so you just removed raise NotImplemted and moved the stub up
20:57:06	sean-k-mooney	well and update the doc string
20:57:20	artom	sean-k-mooney, I fixed the test logic as well
20:57:54	sean-k-mooney	stubing _notify_about_instance_usage instead of post_live_migration_at_source
20:58:03	sean-k-mooney	this is the delta https://review.opendev.org/#/c/747451/5..6/nova/tests/functional/compute/test_live_migration.py
20:58:05	artom	sean-k-mooney, since your migrate_data.vifs patch hasn't merged yet, we currently call driver.post_live_migration_at_source with a different network_info
20:58:21	artom	So we can't assert anything about it, so I went and mocked the notification helper instead
20:58:32	artom	To assert that we're using the correct network_info
20:58:38	sean-k-mooney	ah ok
20:58:51	sean-k-mooney	its a litle non obvious but i guess that works
20:59:04	artom	sean-k-mooney, I didn't have a better idea :/
20:59:12	artom	Maybe I should add a note?
20:59:32	sean-k-mooney	neither do i so i +1d it
20:59:43	sean-k-mooney	well other then merge my patches
20:59:44	artom	Cheers!
20:59:55	artom	I need to review that
21:00:04	sean-k-mooney	sure https://review.opendev.org/#/q/topic:bug/1888395+(status:open+OR+status:merged)
21:01:21	sean-k-mooney	also im so shocked a test fixture that does not behave liek reality :P
21:01:47	sean-k-mooney	the sad thing is it proably did at one point and our assumetion and precondition have been broken in neturon
21:02:12	sean-k-mooney	but its equally likely it was broken form the start just doiong the minium we needed
21:03:06	sean-k-mooney	oh cool my devstack patch merged :) https://review.opendev.org/#/c/749295/ i can now stack and unstack without having to delete pyc file the whole time
21:04:56	artom	sean-k-mooney, no the fixture's actually fine
21:05:06	artom	We just clobber what it gives us with migrate_data.vifs
21:05:46	artom	Which makes the test pointless, because that never contains `migrating_to` in the peofile
21:35:52	openstackgerrit	Rodrigo Barbieri proposed openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533
21:43:38	openstackgerrit	Merged openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958
21:44:00	openstackgerrit	Merged openstack/nova master: Describe '[glance]/enable_rbd_download' https://review.opendev.org/749437
23:29:50	gmann	stephenfin: replied on https://review.opendev.org/#/c/749505/. I remember we discussed this as one of the possible API clean during train cycle but dropped it as there are lot of API changes needed. But as this is API change we definitely need spec first.
#openstack-nova - 2020-09-03
00:00:19	brinzhang	alex_xu: ack.
00:00:34	brinzhang	luyao: please review this patch https://review.opendev.org/#/c/749472/
00:01:49	brinzhang	luyao: we should be have maintained document consistency
00:22:13	openstack	bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
00:22:13	openstackgerrit	Merged openstack/nova stable/train: Add regression tests for bug #1889108 https://review.opendev.org/748494
00:25:05	openstackgerrit	melanie witt proposed openstack/nova stable/ussuri: Removed the host FQDN from the exception message https://review.opendev.org/749607
00:28:23	openstackgerrit	melanie witt proposed openstack/nova stable/train: Removed the host FQDN from the exception message https://review.opendev.org/749609
00:29:19	openstackgerrit	melanie witt proposed openstack/nova stable/stein: Removed the host FQDN from the exception message https://review.opendev.org/749610
00:31:39	openstackgerrit	melanie witt proposed openstack/nova stable/rocky: Removed the host FQDN from the exception message https://review.opendev.org/749612
00:32:29	openstackgerrit	melanie witt proposed openstack/nova stable/queens: Removed the host FQDN from the exception message https://review.opendev.org/749613
00:36:06	prometheanfire	fatfingering, causing me to spend hours beating head against the wall
01:20:58	openstackgerrit	Brin Zhang proposed openstack/nova master: Refactor check and exception https://review.opendev.org/749052
01:27:09	openstackgerrit	Merged openstack/nova stable/train: compute: refactor volume bdm rollback error handling https://review.opendev.org/748495
01:27:20	openstackgerrit	Merged openstack/nova stable/train: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748496
01:59:24	openstackgerrit	Merged openstack/nova master: Remove support for Intel CMT events https://review.opendev.org/740922
01:59:33	openstackgerrit	Merged openstack/nova master: Update image_base_image_ref during rebuild. https://review.opendev.org/749205
02:50:05	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472
02:51:49	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472
02:55:27	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472
03:15:30	openstackgerrit	Brin Zhang proposed openstack/nova master: Add note and daxio version to the vPMEM document https://review.opendev.org/749628
03:42:35	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Unified virtual persistent memory restrictions https://review.opendev.org/749472
03:50:06	openstackgerrit	Akhil Gudise proposed openstack/nova master: Introduced a service UP check for host to the Rebuild path https://review.opendev.org/749531
07:38:46	gibi	sean-k-mooney: is there anything we are still waiting to land in os-vif or I can approve the propoesd release?
07:44:24	bauzas	good morning
07:46:21	gibi	good morning
07:47:40	suryasingh	Good Morning gibi bauzas
07:50:42	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Remove no-op fake calls from network_info tests https://review.opendev.org/749661
07:58:58	gibi	sean-k-mooney: I'm building on the existing libvirt sriov functional test but not depending on stephenfin's cleanup series for that. I'm willing to rebase and resolve conflicts when the cleanup merge
07:59:41	openstackgerrit	Lee Yarwood proposed openstack/nova master: func: Remove references to attachment_id when volume_id is used https://review.opendev.org/749664
08:13:04	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/ussuri: resolve ResourceProviderSyncFailed issue https://review.opendev.org/749668
08:15:07	brinzhang0	alex_xu, gibi: luyao has checked the change of vPMEM dependencies, please review https://review.opendev.org/#/q/topic:bug/1894022+(status:open+OR+status:merged)
08:43:18	openstackgerrit	Lee Yarwood proposed openstack/nova master: zuul: Add devstack-plugin-ceph-compute-local-eph to the experimental queue https://review.opendev.org/743220
08:45:49	openstackgerrit	Lee Yarwood proposed openstack/nova master: zuul: Add devstack-plugin-ceph-compute-local-ephemeral to experimental https://review.opendev.org/743220
08:50:38	jkulik	stephenfin, may I ask you something? How small/large should I make the changes for the oslo.vmware SOAP library switch. Downstream, I keep commits small and let them only do one thing, but I'm not sure posting 7 patches for review upstream is the best way, if some of them only contain ~3 line changes to a new attribute.
08:51:09	stephenfin	jkulik: Small changes are fine
08:51:19	stephenfin	Probably better, in fact. They're easier to review
08:51:28	jkulik	ok then, thank you
08:55:48	openstackgerrit	Stephen Finucane proposed openstack/nova master: Move confirm resize under semaphore https://review.opendev.org/747745
08:55:56	openstackgerrit	Stephen Finucane proposed openstack/nova master: Move revert resize under semaphore https://review.opendev.org/747746
08:56:03	openstackgerrit	Stephen Finucane proposed openstack/nova master: Cleanup 'drop_move_claim' and '_drop_move_claim' https://review.opendev.org/747747
08:56:09	openstackgerrit	Stephen Finucane proposed openstack/nova master: manager: Address TODO https://review.opendev.org/747748
08:56:17	openstackgerrit	Stephen Finucane proposed openstack/nova master: manager: Move context manager up one level https://review.opendev.org/745674
08:56:31	openstackgerrit	Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341
08:56:39	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675
09:04:38	openstackgerrit	Merged openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748560
09:04:45	openstackgerrit	Merged openstack/nova master: Add note and daxio version to the vPMEM document https://review.opendev.org/749628
09:04:59	openstackgerrit	Merged openstack/nova master: Remove no-op fake calls from network_info tests https://review.opendev.org/749661
09:05:43	openstackgerrit	Brin Zhang proposed openstack/nova stable/ussuri: Add note and daxio version to the vPMEM document https://review.opendev.org/749681
09:07:07	openstackgerrit	Johannes Kulik proposed openstack/nova master: vmware: Use cookiejar from oslo.vmware client directly https://review.opendev.org/749682
09:14:37	openstackgerrit	Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673
09:33:16	gibi	dansmith: hi! can we finalize documentation for the multistore spec? https://review.opendev.org/#/c/731577/
09:33:57	gibi	dansmith: I would like to mention that feature in the cycle highlights and link to the documentation
09:46:13	gibi	stephenfin: could you hit this doc patch about rdb export https://review.opendev.org/#/c/728411 ?
09:46:28	stephenfin	sure
09:46:42	gibi	thanks
09:47:44	lyarwood	gibi: that needs to be updated
09:48:15	stephenfin	lyarwood: I'd say I've pointed out why?
09:48:22	stephenfin	(wrong section for conf options)
09:50:54	stephenfin	lyarwood: Got time to do the respin quickly while we're looking at it? I can do so if not
09:51:48	lyarwood	stephenfin: yeah I can
09:52:46	gibi	thanks ^^
10:00:25	openstackgerrit	Brin Zhang proposed openstack/nova stable/ussuri: Reject resize operation for accelerator https://review.opendev.org/749698
10:02:11	lyarwood	stephenfin: stupid question, but how would you list user defined things like rbd_user etc
10:02:27	lyarwood	stephenfin: rbd_user=$rbd_user or rbd_user=foo etc?
10:02:33	stephenfin	can you rephrase that?
10:02:34	stephenfin	oh
10:02:53	stephenfin	really up to you. I prefer dummy values that somewhat resemble reality
10:03:09	stephenfin	http://example.com for URLs, 1.2.3.4 for IP addresses etc.
10:03:10	lyarwood	meh I was thinking that could confuse people tbh
10:03:14	lyarwood	kk

Earlier   Later