Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-28
13:18:17 aarents know
13:21:15 sean-k-mooney yes but i dont think it clears +2
13:21:23 sean-k-mooney i do think it clears +w
13:21:49 sean-k-mooney assuming you only edit the comit and not the code
13:22:24 sean-k-mooney its treated like a rebase in that way
13:40:25 aarents sean-k-mooney: it seems in my case to have drop +2, NVM
13:48:49 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943
13:48:50 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945
13:48:50 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944
13:48:51 openstackgerrit Stephen Finucane proposed openstack/nova master: conductor: Don't use setattr https://review.opendev.org/746947
13:48:51 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add resize tests for PCI servers https://review.opendev.org/746946
13:48:52 openstackgerrit Stephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949
13:48:52 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports https://review.opendev.org/746948
13:48:53 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/746950
13:50:45 gmann stephenfin: done
14:08:53 stephenfin aarents: Could I get the comment here and I can fast approve, seeing as gibi was +2 before? https://review.opendev.org/#/c/747957/
14:14:43 openstackgerrit Merged openstack/nova master: vmware: Handle exception in destroy with attached volumes https://review.opendev.org/738416
14:15:33 stephenfin_ hurrah, my znc instance is alive again \o/
14:27:00 aarents stephenfin_: done thks
14:34:56 stephenfin_ aarents: Sorry, I meant can I get a comment in the code? :D
14:36:05 stephenfin_ aarents: Basically so some poor sucker isn't looking at this in 5 years time saying "why on earth did Alexandre add that call?" :P
14:36:34 aarents stephenfin_: sure.. friday..
14:40:11 stephenfin gibi: Could you weigh in on https://review.opendev.org/#/c/748411/ ? I think it's a fair request, but in fairness it's not what the BP stated so maybe I'm being unfair
14:41:07 gibi 12:14 < gibi> so as far as I see artom and stephen on the side of a new config. I have no
14:41:07 gibi I did so on IRC but I can put that in the patch too
14:41:10 gibi hard oppionon on either side so I will fall in line with the rest and
14:41:13 gibi support the new config then
14:41:49 stephenfin ah, sorry. Had ZNC issues so I missed any discussion this morning /o\
14:41:51 stephenfin Thanks
14:41:59 gibi doen
14:42:01 gibi done
14:42:09 gibi no worries
14:48:20 artom gibi, yeah, I don't really have strong opinions one way or the other
14:48:46 artom gibi, conceptually the new clean options seems cleaner
14:48:59 artom But maybe there are practical considerations for reviving the old one
14:49:25 stephenfin gibi: Also, in the context of https://review.opendev.org/#/c/748453/, have you seen https://review.opendev.org/#/c/746950/ ?
14:49:55 stephenfin In theory it _should_ be reproducible there, so I can put together a test for that early next week
14:52:17 gibi stephenfin: sounds cool.
14:52:32 gibi stephenfin: I wasn't eager to try to create a functional reproduce for that
14:52:49 gibi stephenfin: as that bug is a bit tangential to the sriov attach work I do righ now
14:53:40 openstackgerrit Lucas Alvares Gomes proposed openstack/nova master: DO NOT REVIEW: Test OVN devstack module https://review.opendev.org/748226
14:57:44 openstackgerrit Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957
15:07:45 stephenfin aarents++ Thanks
16:23:33 sean-k-mooney stephenfin: just spoke to radolfo about a few thing one of them being the os-vif chanage for the defualt backend
16:23:55 sean-k-mooney im going to fix the patch by lazy loadign the connect to ovs via a property
16:24:05 sean-k-mooney can you take a look at the patch on monday
16:55:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995
16:55:27 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make PCI claim NUMA aware during live migration https://review.opendev.org/748453
16:55:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use UUID as vif an network_id in vif tests https://review.opendev.org/748722
16:55:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: tracing the PCI allocation code path https://review.opendev.org/748454
16:56:39 openstackgerrit sean mooney proposed openstack/os-vif master: deprecate ovs-vsctl driver and make native the default https://review.opendev.org/744816
17:29:54 openstackgerrit Dan Smith proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547
18:35:10 openstackgerrit Merged openstack/nova stable/ussuri: Removes the delta file once image is extracted https://review.opendev.org/748034
21:30:41 openstackgerrit Lucas Alvares Gomes proposed openstack/nova master: DO NOT REVIEW: Test OVN devstack module https://review.opendev.org/748226
#openstack-nova - 2020-08-29
00:31:01 openstack bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to sean mooney (sean-k-mooney)
00:31:01 openstackgerrit sean mooney proposed openstack/nova master: add functional regression test for bug #1888395 https://review.opendev.org/747454
00:31:37 openstackgerrit sean mooney proposed openstack/nova master: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/742180
01:41:03 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326
01:51:29 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
03:28:53 openstackgerrit melanie witt proposed openstack/nova master: Default user_id when not specified in check_num_instances_quota https://review.opendev.org/748550
03:28:55 openstack bug 1893284 in OpenStack Compute (nova) "Per-user quotas not scoped correctly when creating a server" [Low,In progress] https://launchpad.net/bugs/1893284 - Assigned to melanie witt (melwitt)
03:28:55 openstackgerrit melanie witt proposed openstack/nova master: Add regression test for bug 1893284 https://review.opendev.org/748779
06:16:35 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326
08:25:05 openstackgerrit Wenping Song proposed openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748560
08:27:43 openstackgerrit Wenping Song proposed openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748560
09:38:43 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326
10:56:27 openstackgerrit Elod Illes proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
#openstack-nova - 2020-08-30
12:45:02 openstackgerrit Merged openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957
12:55:43 openstackgerrit Merged openstack/nova master: QEMU/KVM: accept vmxnet3 NIC https://review.opendev.org/738695
#openstack-nova - 2020-08-31
01:18:36 openstackgerrit Keigo Noha proposed openstack/nova stable/ussuri: Change default num_retries for glance to 3 https://review.opendev.org/748936
02:20:01 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Coding style and test cases improvment https://review.opendev.org/748939
02:22:22 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Coding style and test cases improvement https://review.opendev.org/748939
07:21:43 swp20 gibi: hi gibi, morning.
07:23:34 swp20 I have a question: As we donnot delete allocations when evacuate, so this case `nova.tests.functional.wsgi.test_services.TestServicesAPI.test_evacuate_then_delete_compute_service` is not reasonable, right?
07:35:59 gibi swp20: the source host allocation is not deleted during evacuation. It is left for the source host to delete it when it is recovered. If the source host is never recovered but deleted instead then we might need to delete the source side of the allocation of successfull evacuations
07:40:08 gibi swp20: alternatively we can reject the service delete if there is allocations against the RP due to finished evacuations
07:41:34 gibi and ask the admin to clean that up manually before delete the service
07:41:44 swp20 so how can we process the exception when we delete rp failed? we cannot raise the exception.
07:42:19 swp20 please see the patch: https://review.opendev.org/#/c/748339/
07:42:48 bauzas good morning
07:43:30 gibi swp20: I will check
07:43:34 gibi bauzas: good morning
07:43:59 swp20 gibi: thanks
07:54:38 suryasingh @gibi hi... Sorry to address directly. Do you know if graceful shutdown of nova-compute is supported from nova side (For ex: like SIGTERM send to nova-compute to stopped in the middle of instance boot operation)
07:59:44 gibi suryasingh: hi! good questions. I'm not sure.
08:01:45 gibi suryasingh: looking at the nova.service.Service impl, I don't see specific implementtin
08:02:22 gibi nova.service.Service.stop just stops the RPC service and then calls manager.clean_up
08:03:06 gibi we do cancel ongoing live migration though
08:03:16 gibi via nova.compute.manager.ComputeManager._cleanup_live_migrations_in_pool
08:03:27 gibi but I don't see any more gracefullness
08:05:51 suryasingh I see gibi, Thanks for response though.
08:09:25 gibi suryasingh: if you would need more gracefullness the I suggest to describe you use case in a mail on the mailing list or in a nova specification
08:11:56 suryasingh gibi: thanks for info. I will do once feel require to mail.
08:12:14 bauzas gibi: suryasingh: we just hook the SIGHUP signal
08:12:22 bauzas hook up*
08:12:38 bauzas we don't indeed have any other signal for a graceful restart
08:13:04 bauzas but operators just disable the service before they restart
08:13:17 bauzas so they don't need to wait
08:23:53 bauzas gibi: IIRC, oslo.service also waits gracefully
08:24:02 brinzhang gibi, stephenfin: Fixed stephenfin's comments inline in Cyborg evacuate patch, hope you can review again https://review.opendev.org/#/c/715326/

Earlier   Later