| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-19 | |||
| 16:43:04 | gmann | rescue does not add admin-only fields. you mean rebuild? | |
| 16:43:15 | stephenfin | Sorry, I mean in the response | |
| 16:43:38 | stephenfin | actually, never mind | |
| 16:43:46 | gmann | yeah in response rescue return empty dict or admin_password | |
| 16:44:15 | stephenfin | this is what I was referring to https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/test_rescue.py#L94 | |
| 16:44:23 | stephenfin | but that's only for internal validation purposes | |
| 16:44:36 | stephenfin | that sample response doesn't need admin-fields in it | |
| 16:46:03 | gmann | stephenfin: ohk i got now. yes we can keep that with non-admin. if sample is not complete then yes keep testing that with non-admin. | |
| 16:47:51 | gmann | stephenfin: even such test can just check state from response explicitly instead of comparing it with sample file response. | |
| 17:19:13 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Drop '_api' suffix from placement fixture https://review.opendev.org/745905 | |
| 17:19:13 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Move single-use function to its caller https://review.opendev.org/745904 | |
| 17:19:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907 | |
| 17:19:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906 | |
| 17:19:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908 | |
| 17:19:27 | stephenfin | gmann: ^ | |
| 17:19:49 | stephenfin | I might have missed one or two tests (there were 109 failures, after all) but that should be pretty correct now :) | |
| 17:21:08 | gmann | stephenfin: ok, waiting for gate result | |
| 17:31:50 | stephenfin | dansmith: melwitt: Can you folks look at https://review.opendev.org/#/c/744958/ again today? | |
| 17:32:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675 | |
| 17:32:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | |
| 17:55:25 | artom | stephenfin, lyarwood, did any of you start backporting Stephen's func tests refactors to train? Or did we want to socialize that a bit first? | |
| 17:56:51 | artom | Nothing that I can find in gerrit, at any rate. Shall I start? | |
| 17:58:52 | lyarwood | artom: I've not had a chance to get back to it so feel free to start | |
| 17:59:45 | lyarwood | elod: https://review.opendev.org/#/c/746529/ - that reminds me can you take a look at this series from artom when you have time please | |
| 18:01:13 | dansmith | artom: I think stephenfin did what you asked here, so can you throw your +1 back on it? https://review.opendev.org/#/c/744950/4 | |
| 18:01:13 | artom | lyarwood, yep, thanks for poking elod for me | |
| 18:01:21 | dansmith | er, s/back// | |
| 18:06:45 | lyarwood | melwitt: https://review.opendev.org/#/c/745512/ - trivial test cleanup if you have time today btw | |
| 18:20:39 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 18:20:39 | openstackgerrit | Lee Yarwood proposed openstack/nova master: rbd: Move rbd_utils out of libvirt driver under nova.storage https://review.opendev.org/746904 | |
| 18:23:42 | melwitt | lyarwood: took too long to find what I was looking for, but commented on your patch that there's a fixture for doing that | |
| 18:25:52 | dansmith | so that would only work with eventlet, | |
| 18:25:53 | dansmith | which seems like an odd thing to favor | |
| 18:26:08 | openstack | Launchpad bug 1864020 in OpenStack Compute (nova) "libvirt.libvirtError: Requested operation is not valid: format of backing image %s of image %s was not specified in the image metadata (See https://libvirt.org/kbase/backing_chains.html for troubleshooting)" [Undecided,Fix committed] - Assigned to Lee Yarwood (lyarwood) | |
| 18:26:08 | yankcrime | hey folks, i think i'm hitting this bug with an instance that was created circa rocky, but now a user has stopped and is attempting to start it again for this first time under ussuri: https://bugs.launchpad.net/nova/+bug/1864020 | |
| 18:26:34 | yankcrime | if i'm reading right, it's related to libvirt 6.0 and that fix only applies to new instances that are created with this vesion of libvirt | |
| 18:30:34 | lyarwood | yankcrime: yeah I thought libvirt then relaxed this in a later release? | |
| 18:31:27 | melwitt | dansmith: yeah I guess loopingcall uses eventlet for its looping https://github.com/openstack/oslo.service/blob/master/oslo_service/loopingcall.py | |
| 18:32:56 | lyarwood | yankcrime: sorry need to drop for the day now but if this isn't resolved by a later release of libvirt then you might need to convert the disks in place to include the format details of the backing file | |
| 18:33:05 | dansmith | yeah that seems weird to me -- if we were to convert some of our stuff to real threads as we've discussed before, that'd be a problem | |
| 18:34:16 | yankcrime | lyarwood: yeah that's the conclusion i'm coming to, wanted to make sure i wasn't missing anything | |
| 18:34:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982 | |
| 18:34:38 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984 | |
| 18:34:38 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983 | |
| 18:34:39 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986 | |
| 18:34:39 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985 | |
| 18:34:58 | lyarwood | yankcrime: yup sorry, I was sure the libvirt folks backed down after we complained about this but I can't seem to find the change | |
| 18:35:14 | lyarwood | yankcrime: kashyap is the person to speak to about this, I'll follow up with him in the morning | |
| 18:35:19 | yankcrime | lyarwood: damn, fwiw i'm on 6.0.0-0ubuntu8.1~cloud0 | |
| 18:35:24 | yankcrime | lyarwood: thanks! | |
| 18:36:54 | melwitt | dansmith: yeah, if we convert then we'd have to add support to loopingcall or stop using loopingcall I guess | |
| 19:32:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: compute: Add more type hints for resize functions https://review.opendev.org/745675 | |
| 19:32:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | |
| 19:32:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: manager: Move context manager up one level https://review.opendev.org/745674 | |
| 19:32:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958 | |
| 19:32:52 | openstack | bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | |
| 19:32:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1879878 https://review.opendev.org/744950 | |
| 19:33:00 | stephenfin | dansmith: Addressed your comments ^ If you could take the third one in that series too, that'd be great (split out per your request) | |
| 20:16:58 | openstackgerrit | Merged openstack/nova master: libvirt: Mock LoopingCallBase._sleep in rbd tests https://review.opendev.org/745512 | |
| 20:26:05 | mnaser | fyi, ceph jobs are breaking often and i tracked it down to https://review.opendev.org/747030 | |
| 20:26:10 | mnaser | hoping to land that when we can :) | |
| 20:33:00 | melwitt | thanks mnaser. looks like cinder core are core on devstack-plugin-ceph | |
| 21:21:56 | openstackgerrit | Merged openstack/python-novaclient master: zuul functional job: drop the custom playbooks https://review.opendev.org/746649 | |
| 22:50:17 | gmann | stephenfin: commented about server tag test failing with non-admin even this API is admin-or-owner. that is because of different project_id of server in SingleCellSimple and OSAPIFixture - https://review.opendev.org/#/c/745906/2/nova/tests/functional/api_sample_tests/test_server_tags.py@22 | |
| 22:51:46 | gmann | also there are few tests does not need ADMIN_API=true which were passing with non-admin also in previous PS | |
| #openstack-nova - 2020-08-20 | |||
| 00:13:45 | openstackgerrit | Keigo Noha proposed openstack/nova master: Change default num_retries for glance to 3 https://review.opendev.org/740389 | |
| 00:52:52 | sean-k-mooney | artom: did your "fix" for the cleanup merge | |
| 00:53:00 | sean-k-mooney | the one that depend on the multiple port bindings | |
| 00:53:09 | sean-k-mooney | we need to revert it if it did | |
| 00:53:19 | sean-k-mooney | or fix it before the relese | |
| 00:53:57 | sean-k-mooney | we cant assume multiple prot bindigns is supported by neutron | |
| 00:54:47 | sean-k-mooney | apparently neutron is not filtering it properly for ml2 drivers on older releases | |
| 00:55:17 | sean-k-mooney | also core plugins e.g. where you dont use ml2 may or may not support it | |
| 00:55:24 | sean-k-mooney | contrail does not currently | |
| 01:05:46 | sean-k-mooney | artom: so ya https://review.opendev.org/#/c/729763/ | |
| 01:06:12 | sean-k-mooney | we cant assume multiple port bindings is used | |
| 01:06:20 | sean-k-mooney | so that fix is not valid | |
| 01:08:09 | melwitt | sean-k-mooney: pls -1 the backport so reviewers know | |
| 01:08:26 | sean-k-mooney | just did | |
| 01:09:33 | sean-k-mooney | melwitt: i have been diging into https://review.opendev.org/#/c/742180/4/nova/objects/migrate_data.py@97 | |
| 01:10:12 | sean-k-mooney | for the last cople of days which seam to be cause by port-bindings being reported as supported when its not | |
| 01:10:37 | sean-k-mooney | the contrial core plugin does not support multipel port bidnigns so we have at least one concreate case | |
| 01:11:17 | sean-k-mooney | there are some ml2 driver that also dont in cluding the alternitive way to integrate vrouter/contrial via an ml2 driver | |
| 01:12:03 | sean-k-mooney | ovn also did not support it until recently. not sure if they added support or just removed it form the list. | |
| 01:12:31 | sean-k-mooney | but it broke 16 and they had to fix it quickly before the 16.0 release | |
| 01:12:57 | sean-k-mooney | so i dont know if they still have the quick fix or actully impemented support | |
| 04:58:49 | openstackgerrit | Merged openstack/nova master: trivial: Remove unused attributes https://review.opendev.org/743284 | |
| 04:59:00 | openstackgerrit | Merged openstack/nova master: Remove warning filters for legacy Python version https://review.opendev.org/743285 | |
| 04:59:12 | openstackgerrit | Merged openstack/nova master: libvirt: Remove MIN_LIBVIRT_ETHERNET_SCRIPT_PATH_NONE https://review.opendev.org/730865 | |
| 07:58:51 | stephenfin | gmann++ Thanks or the pointer | |
| 07:59:05 | stephenfin | *for | |
| 07:59:07 | stephenfin | and the reviews | |
| 08:02:55 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: windows: Add missing return https://review.opendev.org/746870 | |
| 08:02:56 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Add type annotations https://review.opendev.org/745162 | |
| 08:02:57 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop' https://review.opendev.org/745163 | |
| 08:11:41 | lyarwood | kashyap: https://review.opendev.org/#/c/694821/ - Morning, do you recall why you picked NEXT_MIN_LIBVIRT_VERSION v5.0.0 and NEXT_MIN_QEMU_VERSION 4.0.0 in U? | |
| 08:12:26 | lyarwood | kashyap: https://review.opendev.org/#/c/746981/ - I started bumping things yesterday and noticed that as we don't use UCA anymore it's impossible for us to move to these until we move to focal | |
| 08:12:34 | kashyap | lyarwood: Hi, will answer in a bit. | |
| 08:14:36 | kashyap | lyarwood: On the first 'why', I always add the rationale - it was the common version available across the distros we care | |
| 08:15:54 | kashyap | lyarwood: Reasons documented here: http://lists.openstack.org/pipermail/openstack-discuss/2019-November/010907.html | |