| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-19 | |||
| 12:32:38 | sean-k-mooney | oh :) | |
| 12:32:38 | lyarwood | sean-k-mooney: not whatever you're talking about now | |
| 12:32:40 | lyarwood | :D | |
| 12:32:43 | sean-k-mooney | ok ignore me then | |
| 12:32:51 | stephenfin | we always do 0:) | |
| 12:33:20 | lyarwood | oh look it's princess eugenie | |
| 12:33:52 | sean-k-mooney | stephenfin: anyway _check_can_migrate_pci is the only check we do and thats in the conductor | |
| 12:34:05 | lyarwood | https://i.pinimg.com/originals/c6/42/73/c64273010126b4ca904a776dc7a079e7.jpg <- context sorry that was a very British joke | |
| 12:34:28 | stephenfin | heh | |
| 12:34:37 | sean-k-mooney | silly hats are silly | |
| 12:35:06 | sean-k-mooney | stephenfin: you could add a check for pci aliase safely in the api | |
| 12:36:28 | sean-k-mooney | stephenfin: we currently do the check in this loop after schduling https://github.com/openstack/nova/blob/cff7382fb3de4eef7aeddc34b6ae3409cbe50ea0/nova/conductor/tasks/live_migrate.py#L523-L567 | |
| 12:36:50 | sean-k-mooney | which eliminates all the hosts and results in a no valid hosts i guess | |
| 12:38:45 | sean-k-mooney | eventually _check_not_over_max_retries fires a MaxRetriesExceeded exception which gets translated to no valid host | |
| 13:21:15 | openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | |
| 13:24:20 | gmann | lyarwood: Bionic will not be tested by default any more so we can say it is not tested so might work or might not. devstack drop the support (remove from supported distro list ) in next cycle from when we upgrade the distro so W cycle will be to drop the Bionic support in devstack. | |
| 13:28:31 | sean-k-mooney | for vitoria we need it since we need it for grenade? | |
| 13:28:43 | lyarwood | gmann: kk, so for Nova we'd only bump our MIN_LIBVIRT_VERSION to the focal version in W | |
| 13:28:49 | sean-k-mooney | but form W on it will be 20.04 on both sides right | |
| 13:29:38 | sean-k-mooney | lyarwood: i think kasyap has a workflow for this. when ever i have tried to change it i have got shouted at but apparently he is blessed | |
| 13:30:01 | sean-k-mooney | lyarwood: are you thinkihng of bumping the min version to 6 | |
| 13:30:02 | gmann | sean-k-mooney: yes, in V it will be Bionic->bionic upgrade testing and in W Focal->Focal | |
| 13:30:51 | sean-k-mooney | gmann: yep because we dont do distro upgrades in grenade so we need to support bionic for one release longer | |
| 13:31:15 | gmann | lyarwood: if no compatible issue then it is fine to bump in W which give upgrade compatibility also | |
| 13:31:27 | sean-k-mooney | by the way that is not a suggestion to start doing disto upgrade in grenade :) | |
| 13:34:56 | lyarwood | sean-k-mooney: yeah, would be nice to move to >= 6.0.0 etc in W | |
| 13:35:24 | lyarwood | gmann: yeah there shouldn't be any issues moving to 6.0.0 in W assuming we also drop support for el7 distros | |
| 13:35:51 | gmann | ok | |
| 13:35:56 | sean-k-mooney | i think we need to bump https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L228 so to 6 | |
| 13:36:18 | aarents | Hi there, lyarwood FYI, I resummit with the missing tempest config : https://review.opendev.org/#/c/743708/ thks! | |
| 13:36:45 | sean-k-mooney | lyarwood: sorry https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L235 | |
| 13:38:01 | lyarwood | aarents: looking | |
| 13:38:35 | sean-k-mooney | https://github.com/openstack/nova/commit/1b76c0f72ee1c1175a089b83a41e4ada94570820 | |
| 13:38:51 | sean-k-mooney | so we should be moving to 5.0.0 in v ithink based on this | |
| 13:39:16 | sean-k-mooney | we bumped NEXT_MIN_LIBVIRT_VERSION in ussuri | |
| 13:39:18 | sean-k-mooney | to 5.0.0 | |
| 13:39:38 | sean-k-mooney | lyarwood: we need a similar patch in V for W | |
| 13:42:04 | sean-k-mooney | looking at https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix and https://repology.org/project/libvirt/versions | |
| 13:42:15 | sean-k-mooney | 6.0.0 should be ok for W | |
| 13:43:48 | sean-k-mooney | the only really concern i see would be debian buster(10) has 5.0.0 but bullseye(11) has 6.0.0 | |
| 13:52:06 | lyarwood | sean-k-mooney: yeah doesn't look like bullseye actually has a confirmed release date | |
| 13:52:23 | lyarwood | sean-k-mooney: still raising NEXT_MIN_LIBVIRT_VERSION in V is still correct | |
| 13:52:41 | sean-k-mooney | lyarwood: yes raising next min is correct | |
| 13:52:55 | sean-k-mooney | you can also technicaly bump the min version to 5.0.0 | |
| 13:53:34 | sean-k-mooney | we have 5.4 from ubuntu cloud archive on bionic | |
| 13:54:34 | sean-k-mooney | lyarwood: actully we have 6.0.0 | |
| 13:54:45 | sean-k-mooney | in the ussuri repos | |
| 13:54:48 | sean-k-mooney | http://ubuntu-cloud.archive.canonical.com/ubuntu/dists/bionic-proposed/ussuri/main/binary-amd64/Packages | |
| 13:54:50 | lyarwood | we do? | |
| 13:54:52 | lyarwood | ah | |
| 13:54:54 | sean-k-mooney | yep | |
| 13:55:48 | sean-k-mooney | its in both proposed and updates repos | |
| 13:55:51 | sean-k-mooney | http://ubuntu-cloud.archive.canonical.com/ubuntu/dists/bionic-updates/ussuri/main/binary-amd64/Packages | |
| 14:36:42 | lyarwood | stupid o.vo question if anyone has time, LibvirtLiveMigrateData is starting to gather fields that we no longer use, can we bump and remove these or do they need to stay forever? | |
| 14:37:55 | lyarwood | ah just noticed notes about dropping things when we do a major version bump | |
| 14:42:01 | stephenfin | lyarwood: FYI I went and updated the wiki a while back in preparation for version bump patches. Never did the actual bump though | |
| 14:42:06 | stephenfin | so that might be helpful | |
| 14:42:37 | stephenfin | also, yeah, we can drop but it needs a major version bump. I don't think we've done one of those since the Instance 2.0 object so that'll be interesting to see :) | |
| 14:47:27 | mandre | hi, anyone knows if nova AZs are case sensitive? can we create distinct AZs named MyAZ and myaz? | |
| 14:49:02 | dansmith | lyarwood: you need a bridge release where you can speak both versions, just like RPC | |
| 14:49:29 | dansmith | so it probably needs to be a need (to drop something) vs want (to clean up some things) to make it feel worthwhile :) | |
| 14:50:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943 | |
| 14:50:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Provide default 'host_info' for '_get_connection' https://review.opendev.org/746942 | |
| 14:50:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945 | |
| 14:50:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944 | |
| 14:50:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conductor: Don't use setattr https://review.opendev.org/746947 | |
| 14:50:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add resize tests for PCI, SR-IOV servers https://review.opendev.org/746946 | |
| 14:50:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949 | |
| 14:50:03 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports https://review.opendev.org/746948 | |
| 14:50:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/746950 | |
| 14:50:09 | stephenfin | sean-k-mooney: Ta-da ^ | |
| 14:50:21 | lyarwood | dansmith: yeah understood thanks | |
| 14:50:37 | stephenfin | If you can think of ways I can improve those live migration tests to highlight bugs, lemme know | |
| 14:51:09 | stephenfin | tbh I was expecting the resize test to fail because I thought you'd said that was broken, but clearly not. Maybe I'm thinking of another move operation | |
| 14:52:14 | sean-k-mooney | stephenfin: nice | |
| 14:52:30 | sean-k-mooney | ill start working my way through them | |
| 14:52:51 | stephenfin | as for why I was seeing the HTTP 500 for NoValidHost, it's the use of the CastAsCall fixture | |
| 14:52:54 | sean-k-mooney | gibi_pto_24th: wehn your back ^ will be of interest | |
| 14:53:34 | sean-k-mooney | stephenfin: resize is broken if it does a retry i think | |
| 14:54:14 | sean-k-mooney | stephenfin: tere are edgecases that fail for all move operations except live_migration with vnic_type=direct | |
| 14:54:29 | stephenfin | sean-k-mooney: Feel free to stick in comments. I'm happy to keep bulking out these tests | |
| 14:54:47 | stephenfin | given the hardwork is done now, I think | |
| 14:54:55 | sean-k-mooney | so i think it will be nice to assert the correct behavior of gibis attach/detach feature | |
| 14:55:41 | sean-k-mooney | stephenfin: but ya i have a list in the downstream emial i sent | |
| 14:56:24 | sean-k-mooney | stephenfin: one example of something that is broke is we do not update the neutron port mac address for pf migration | |
| 14:56:52 | stephenfin | Cool. I can assert that kind of stuff in the test | |
| 14:56:54 | sean-k-mooney | that is broken for both cold and live migration | |
| 14:57:15 | sean-k-mooney | detach on livem migation with PFs is also broken | |
| 14:57:39 | stephenfin | can you attach PFs via neutron? | |
| 14:57:47 | sean-k-mooney | not after the vm is booted | |
| 14:57:49 | sean-k-mooney | but on boot yes | |
| 14:57:57 | sean-k-mooney | vnic_type=direct-phsyical | |
| 14:58:28 | sean-k-mooney | no it was rammed through as a feature without accounting form a bunch of basic edgecease | |
| 14:58:44 | sean-k-mooney | and broke backwards compatiablei of the pci alias | |
| 14:59:06 | stephenfin | sounds like CPU pinning and PCI in general | |
| 15:01:40 | sean-k-mooney | not really | |
| 15:14:38 | iurygregory | sean-k-mooney, hey I did the changes directly to the node (in setup time) and at least all non uefi/multinode jobs are green =) | |
| 15:23:05 | sean-k-mooney | cool | |
| 16:05:32 | stephenfin | gmann: suuuuper dumb question. I'm attempting to enable policy by default in all tests but seeing policy failures https://review.opendev.org/#/c/745906/ | |
| 16:06:13 | stephenfin | gmann: some of the rules are using PROJECT_MEMBER_OR_SYSTEM_ADMIN but I'm seeing requests using the non-admin user rejected | |