| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-19 | |||
| 09:56:17 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop' https://review.opendev.org/745163 | |
| 09:56:18 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: windows: Add missing return https://review.opendev.org/746870 | |
| 10:05:55 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Log exception when unable to import rbd https://review.opendev.org/746873 | |
| 10:08:55 | stephenfin | lyarwood: https://review.opendev.org/#/c/734734/ might be of interest | |
| 10:19:15 | lyarwood | stephenfin: reviewed, issue with the test but agree with blocking that in the API | |
| 10:33:13 | lyarwood | stephenfin: https://review.opendev.org/#/c/574301/ - Can you take a look at my notes/question in this, tl;dr we end up relying on [libvirt] specific configurables within nova.image.glance *if* the default ceph config doesn't provide access to the RBD pool hosting glance images. | |
| 10:33:53 | lyarwood | stephenfin: I'm fine addressing that in FUPs in the future by introducing [glance] specific configurables for this | |
| 10:34:03 | stephenfin | sure | |
| 10:34:11 | lyarwood | stephenfin: but wanted other cores to agree with that approach before merging this | |
| 10:34:21 | lyarwood | stephenfin: kk thanks | |
| 10:36:36 | lyarwood | ah right cinder volumes | |
| 10:38:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM zuul: Enable [glance]/allowed_direct_url_schemes within nova-ceph-multistore https://review.opendev.org/743220 | |
| 10:47:47 | stephenfin | lyarwood: yup, agreed with not using libvirt-specific stuff in a generic place. Left my comments on the patch | |
| 11:12:47 | sean-k-mooney | stephenfin: wehn you write c/c++ do you put the { on a new line after the funtion signiture followed by another new line before starting the body | |
| 11:13:34 | stephenfin | Python isn't C | |
| 11:13:43 | stephenfin | and I haven't written a lot of C in quite some time :( | |
| 11:15:27 | sean-k-mooney | i know but you are formating things like peopel that do that. i have all been in the void myfunc(int arg) { camp or "auto myfunc(int arg) -> void {" where the code base is following almost always auto | |
| 11:15:43 | tosky | sean-k-mooney: if you change existing code, follow that style; there are different styles around | |
| 11:16:16 | sean-k-mooney | tosky: yes i do | |
| 11:16:20 | tosky | tl;dr there is no correct answer :) | |
| 11:16:49 | sean-k-mooney | well stephenfin is pushing to change the styple of every function in os-vif to a new one which i dislike | |
| 11:16:55 | sean-k-mooney | but im still thinking about it | |
| 11:17:14 | sean-k-mooney | it just reminds me of a c codeing style i always hateded | |
| 11:17:51 | stephenfin | I'll win you over eventually :P | |
| 11:17:56 | sean-k-mooney | i was just wondering if that was the style stephenfin was familar with | |
| 11:18:04 | stephenfin | In other news, I got the live migration with SR-IOV test working \o/ | |
| 11:18:05 | sean-k-mooney | which woudl explain his perfernce | |
| 11:18:14 | sean-k-mooney | stephenfin: awsome | |
| 11:18:36 | sean-k-mooney | i tought we had some limited functional test before but maybe that was numa | |
| 11:18:46 | stephenfin | NUMA, yeah | |
| 11:18:51 | stephenfin | artom wrote them | |
| 11:18:59 | sean-k-mooney | cool | |
| 11:19:05 | stephenfin | but no other live migration in nova.tests.functional.libvirt | |
| 11:19:32 | sean-k-mooney | ya there were a few gaps which i guess you have not finished | |
| 11:19:51 | sean-k-mooney | in the neutron fixture as well as pci code? | |
| 11:20:20 | stephenfin | the gaps were in mocking | |
| 11:20:21 | sean-k-mooney | althoguh i think we more or less had covered the pci stuff with numa | |
| 11:20:25 | sean-k-mooney | yes | |
| 11:20:30 | sean-k-mooney | that is what i ment | |
| 11:20:32 | stephenfin | with the neutron fixture mostly, yeah | |
| 11:20:41 | stephenfin | we had no SR-IOV with neutron coverage | |
| 11:20:46 | sean-k-mooney | correct | |
| 11:20:59 | sean-k-mooney | that is why i did not add the functional tests in the first plance | |
| 11:21:27 | sean-k-mooney | it was trying to get it laned befor m3 and it then got pushed to early train | |
| 11:21:56 | sean-k-mooney | anyway got a link i can review | |
| 11:24:57 | stephenfin | just touching up the last few bits, making sure stuff passes | |
| 11:25:45 | sean-k-mooney | we dont have a good way to simultate different config right i know i did an example that everyone hated | |
| 11:26:01 | sean-k-mooney | but can we easily simulate different hardware toplogies on idfferent nodes | |
| 11:26:13 | sean-k-mooney | we would just need different pci info objects right | |
| 11:26:22 | stephenfin | yup, exactly | |
| 11:27:46 | sean-k-mooney | i was wondering how easy it would be to create a repoducer for https://review.opendev.org/#/c/738432/3 | |
| 11:29:00 | sean-k-mooney | i feel like it will be a little tricky as i dont think we mock the eth device lookup but it also might be simipale if that all i have to mock | |
| 11:29:30 | sean-k-mooney | we just need the netdev names to be different on each host which i think we can do with mocks | |
| 11:30:11 | stephenfin | that's the main reason for doing these tests | |
| 11:30:22 | stephenfin | I haven't got a test case for that yet though | |
| 11:30:25 | stephenfin | baby steps and all that | |
| 11:30:52 | sean-k-mooney | i know how that bug happens i repoduced it on my local setup and the v1 patch fixed it | |
| 11:30:59 | sean-k-mooney | i should proably test v3 | |
| 12:09:49 | openstackgerrit | Merged openstack/os-vif master: update tox envs and support pdf docs https://review.opendev.org/728037 | |
| 12:21:52 | openstackgerrit | Lee Yarwood proposed openstack/nova master: rbd: Move rbd_utils out of libvirt driver under nova.storage https://review.opendev.org/746904 | |
| 12:21:52 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 12:28:51 | stephenfin | lyarwood: I know you've started that already, but does this rbd direct download scheme make sense for other virt drivers? | |
| 12:29:05 | stephenfin | i.e. did you give thought to my suggestion on making this virt driver-configurable? | |
| 12:29:42 | stephenfin | sean-k-mooney: what's the expected behavior rn if you try to live migrate an instance with PCI devices attached? | |
| 12:30:01 | sean-k-mooney | via an alias | |
| 12:30:05 | stephenfin | yes | |
| 12:30:09 | sean-k-mooney | it should be rejected in the conductor | |
| 12:30:16 | openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | |
| 12:30:35 | stephenfin | Hmm, I'm seeing the request request fail with NoValidHost | |
| 12:30:44 | sean-k-mooney | yep | |
| 12:30:50 | sean-k-mooney | well let me check | |
| 12:30:54 | stephenfin | oh, so it's not validated at the API layer | |
| 12:30:55 | stephenfin | ? | |
| 12:30:55 | sean-k-mooney | i think that could happen | |
| 12:31:08 | sean-k-mooney | i dont think so | |
| 12:31:27 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/conductor/tasks/live_migrate.py#L229-L264 | |
| 12:31:39 | lyarwood | stephenfin: yeah it is possible to do this in other virt drivers | |
| 12:31:47 | sean-k-mooney | we dont know at the api if the hosts are new enough | |
| 12:31:53 | sean-k-mooney | lyarwood: actully its not | |
| 12:31:58 | lyarwood | yeah it is | |
| 12:32:02 | sean-k-mooney | lyarwood: it would be possible to do it in other deivers | |
| 12:32:11 | sean-k-mooney | but you cant live migrate with pci device period | |
| 12:32:28 | lyarwood | sean-k-mooney: I'm replying to stephenfin from earlier about rbd imports | |
| 12:32:36 | sean-k-mooney | the pci-sig sriov spec does not provide a fasicalty for it | |
| 12:32:38 | sean-k-mooney | oh :) | |
| 12:32:38 | lyarwood | sean-k-mooney: not whatever you're talking about now | |
| 12:32:40 | lyarwood | :D | |
| 12:32:43 | sean-k-mooney | ok ignore me then | |
| 12:32:51 | stephenfin | we always do 0:) | |
| 12:33:20 | lyarwood | oh look it's princess eugenie | |
| 12:33:52 | sean-k-mooney | stephenfin: anyway _check_can_migrate_pci is the only check we do and thats in the conductor | |
| 12:34:05 | lyarwood | https://i.pinimg.com/originals/c6/42/73/c64273010126b4ca904a776dc7a079e7.jpg <- context sorry that was a very British joke | |
| 12:34:28 | stephenfin | heh | |
| 12:34:37 | sean-k-mooney | silly hats are silly | |
| 12:35:06 | sean-k-mooney | stephenfin: you could add a check for pci aliase safely in the api | |
| 12:36:28 | sean-k-mooney | stephenfin: we currently do the check in this loop after schduling https://github.com/openstack/nova/blob/cff7382fb3de4eef7aeddc34b6ae3409cbe50ea0/nova/conductor/tasks/live_migrate.py#L523-L567 | |
| 12:36:50 | sean-k-mooney | which eliminates all the hosts and results in a no valid hosts i guess | |
| 12:38:45 | sean-k-mooney | eventually _check_not_over_max_retries fires a MaxRetriesExceeded exception which gets translated to no valid host | |
| 13:21:15 | openstackgerrit | Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734 | |
| 13:24:20 | gmann | lyarwood: Bionic will not be tested by default any more so we can say it is not tested so might work or might not. devstack drop the support (remove from supported distro list ) in next cycle from when we upgrade the distro so W cycle will be to drop the Bionic support in devstack. | |